gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-10 02:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hoist per-call allocations out of the mock metric role path

Browse Source 
A live heap profile of the demo (9.5 days uptime) showed 76TB of
cumulative allocations, with inferMetricRole accounting for 12% of the
total: the classifier table and its keyword slices were rebuilt on every
call, and normalizeMetricRoleTokens constructed a fresh strings.Replacer
per token, paying the lazy trie build each time. Both run per resource
per 2-second mock tick, so the demo spent a measurable share of its
single vCPU feeding the garbage collector.

Both structures are static; make them package-level.

Contract-Neutral: mock allocation hoists: behavior-identical, no contract delta
This commit is contained in:
rcourtman
2026-08-05 13:35:08 +01:00
parent 563a3aa06c
commit 7815d6bf4c
1 changed files with 28 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/mock/metric_personas.go
+28 -18
View File
@@ -168,27 +168,32 @@ func buildMetricRoleRegistry(graph FixtureGraph) map[string]string {
return registry
}
// metricRoleClassifiers is package-level state: inferMetricRole runs per
// resource per mock tick, and rebuilding this table (and its keyword slices)
// on every call dominated the demo's allocation profile.
var metricRoleClassifiers = []struct {
role string
keywords []string
}{
{metricRoleDatabase, []string{"postgres", "mysql", "mariadb", "mongodb", "database", "db", "sql", "pg", "influxdb"}},
{metricRoleCache, []string{"redis", "memcached", "cache", "valkey"}},
{metricRoleMonitoring, []string{"prometheus", "grafana", "loki", "monitoring", "metrics", "telemetry", "alertmanager", "jaeger"}},
{metricRoleBackup, []string{"backup", "pbs", "archive", "snapshot", "replica", "replication", "offsite", "borg", "restic"}},
{metricRoleStorage, []string{"storage", "datastore", "dataset", "pool", "zfs", "nfs", "smb", "ceph", "nas", "minio"}},
{metricRoleIngress, []string{"nginx", "traefik", "haproxy", "envoy", "proxy", "ingress", "loadbalancer", "load-balancer"}},
{metricRoleSecurity, []string{"bitwarden", "vaultwarden", "wireguard", "openvpn", "firewall", "pihole", "cloudflare", "auth", "vpn"}},
{metricRoleMedia, []string{"jellyfin", "plex", "sonarr", "radarr", "transmission", "deluge", "sabnzbd", "media", "stream"}},
{metricRoleCI, []string{"jenkins", "gitlab", "runner", "build", "ci"}},
{metricRoleQueue, []string{"queue", "worker", "rabbitmq", "kafka", "broker"}},
{metricRoleAPI, []string{"api", "backend", "service", "worker-api"}},
{metricRoleWeb, []string{"web", "frontend", "portal", "site", "ui", "dashboard", "nextcloud", "seafile", "owncloud", "gitea"}},
}
func inferMetricRole(resourceClass, resourceID string, hints ...string) string {
classKey := normalizeMetricClass(resourceClass)
tokens := normalizeMetricRoleTokens(append([]string{resourceID, classKey}, hints...)...)
for _, classifier := range []struct {
role string
keywords []string
}{
{metricRoleDatabase, []string{"postgres", "mysql", "mariadb", "mongodb", "database", "db", "sql", "pg", "influxdb"}},
{metricRoleCache, []string{"redis", "memcached", "cache", "valkey"}},
{metricRoleMonitoring, []string{"prometheus", "grafana", "loki", "monitoring", "metrics", "telemetry", "alertmanager", "jaeger"}},
{metricRoleBackup, []string{"backup", "pbs", "archive", "snapshot", "replica", "replication", "offsite", "borg", "restic"}},
{metricRoleStorage, []string{"storage", "datastore", "dataset", "pool", "zfs", "nfs", "smb", "ceph", "nas", "minio"}},
{metricRoleIngress, []string{"nginx", "traefik", "haproxy", "envoy", "proxy", "ingress", "loadbalancer", "load-balancer"}},
{metricRoleSecurity, []string{"bitwarden", "vaultwarden", "wireguard", "openvpn", "firewall", "pihole", "cloudflare", "auth", "vpn"}},
{metricRoleMedia, []string{"jellyfin", "plex", "sonarr", "radarr", "transmission", "deluge", "sabnzbd", "media", "stream"}},
{metricRoleCI, []string{"jenkins", "gitlab", "runner", "build", "ci"}},
{metricRoleQueue, []string{"queue", "worker", "rabbitmq", "kafka", "broker"}},
{metricRoleAPI, []string{"api", "backend", "service", "worker-api"}},
{metricRoleWeb, []string{"web", "frontend", "portal", "site", "ui", "dashboard", "nextcloud", "seafile", "owncloud", "gitea"}},
} {
for _, classifier := range metricRoleClassifiers {
for _, keyword := range classifier.keywords {
if keyword != "" && strings.Contains(tokens, keyword) {
return classifier.role
@@ -253,6 +258,11 @@ func stableMetricRoleChoice(seed string, roles []weightedMetricRole) string {
return roles[0].role
}
// metricRoleTokenReplacer is package-level state: a strings.Replacer builds
// its lookup structure lazily on first use, so constructing one per call paid
// that build cost for every normalized token.
var metricRoleTokenReplacer = strings.NewReplacer("-", " ", "_", " ", "/", " ", ":", " ")
func normalizeMetricRoleTokens(values ...string) string {
var builder strings.Builder
for _, value := range values {
@@ -260,7 +270,7 @@ func normalizeMetricRoleTokens(values ...string) string {
if normalized == "" {
continue
}
normalized = strings.NewReplacer("-", " ", "_", " ", "/", " ", ":", " ").Replace(normalized)
normalized = metricRoleTokenReplacer.Replace(normalized)
if builder.Len() > 0 {
builder.WriteByte(' ')
}