gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-26 21:47:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Align malformed filesystem guidance with uncertainty admission

Browse Source 
Malformed command replies retain completion-unverified with no recovery guidance. Extend the collector/log control to prove a fresh diagnostic client cannot queue another command while completion remains uncertain.

Contract-Neutral: Tests exercise the committed successful-reply admission contract; no further runtime or API delta.
Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-10-06 06:57:39 +01:00
parent caceb1d266
commit 780f5333ce
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/monitoring/monitor_pve_guest_lxc_test.go
+11 -1
View File
@@ -617,7 +617,7 @@ func TestGuestFilesystemFailureGuidanceUsesObservedEvidence(t *testing.T) {
{"unauthorised-quotes-stopped", "API error 500: QEMU guest agent is not running", "permission-denied", "Guest filesystem query was not authorised", 401, true},
{"bad-request-quotes-permission", "API error 403: permission denied", "agent-error", "Guest filesystem query failed", 400, true},
{"empty", `{"data":{"result":[]}}`, "no-filesystems", "Guest agent returned no filesystem readings", 200, true},
{"malformed", `{"data":`, "agent-error", "Guest filesystem query failed", 200, true},
{"malformed", `{"data":`, "agent-completion-unverified", "", 200, false},
{"server-uncertain", "provider-private-detail", "agent-completion-unverified", "", 500, false},
{"gateway-quotes-stopped", "QEMU guest agent is not running", "agent-completion-unverified", "", 502, false},
}
@@ -665,6 +665,16 @@ func TestGuestFilesystemFailureGuidanceUsesObservedEvidence(t *testing.T) {
if calls.Load() != 1 {
t.Errorf("wire guest commands = %d, want one even with retries configured", calls.Load())
}
if guestAgentDiskDeferred(tc.reason) {
diagnostic, err := proxmox.NewClient(proxmox.ClientConfig{Host: server.URL, TokenName: "fixture@pve!pulse", TokenValue: "fixture", Timeout: time.Second})
if err != nil {
t.Fatal(err)
}
_, err = diagnostic.GetVMAgentInfo(context.Background(), res.Node, res.VMID)
if proxmox.GuestAgentDeferredReason(err) != "agent-cooldown" || calls.Load() != 1 {
t.Errorf("filesystem uncertainty let a fresh diagnostic queue another command: %v calls=%d", err, calls.Load())
}
}
guidance := 0
for _, line := range bytes.Split(bytes.TrimSpace(output.Bytes()), []byte("\n")) {
if len(line) == 0 {