gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-22 11:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove script output from logs to prevent credential leaks

Browse Source 
Script outputs from change-password and remove-password operations could
potentially contain sensitive information. Removed output logging while
keeping error logging for debugging.
This commit is contained in:
Pulse Monitor
2025-08-14 12:37:20 +00:00
parent 3388198b6c
commit 75b2fad471
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/router.go
+3 -3
View File
@@ -994,7 +994,7 @@ func (r *Router) handleChangePassword(w http.ResponseWriter, req *http.Request)
cmd := exec.Command("sudo", scriptPath, hashedPassword)
output, err := cmd.CombinedOutput()
if err != nil {
log.Error().Err(err).Str("output", string(output)).Msg("Failed to change password via script")
log.Error().Err(err).Msg("Failed to change password via script")
writeErrorResponse(w, http.StatusInternalServerError, "config_error",
"Failed to save new password", nil)
return
@@ -1087,9 +1087,9 @@ func (r *Router) handleRemovePassword(w http.ResponseWriter, req *http.Request)
if _, err := os.Stat(scriptPath); err == nil {
cmd := exec.Command("sudo", "-n", scriptPath)
if output, err := cmd.CombinedOutput(); err != nil {
log.Warn().Err(err).Str("output", string(output)).Msg("Could not run remove-password script with sudo")
log.Warn().Err(err).Msg("Could not run remove-password script with sudo")
} else {
log.Info().Str("output", string(output)).Msg("Successfully removed password from systemd")
log.Info().Msg("Successfully removed password from systemd")
}
}