gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-22 11:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure API clients are properly reloaded after configuration save

Browse Source 
- Make runDiscoveryCycle globally accessible for config reload
- Use global API clients in discovery and metrics cycles
- Trigger discovery cycle after configuration reload
- Fix issue where metrics cycle couldn't find reloaded API clients

This ensures the server properly initializes and starts collecting data after saving configuration through the web interface.
This commit is contained in:
courtmanr@gmail.com
2025-05-30 11:45:08 +01:00
parent d44a0f04d8
commit 647cdaa625
2 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/configApi.js
+11
View File
@@ -331,6 +331,17 @@ class ConfigApi {
global.lastReloadTime = Date.now();
}
// Trigger a discovery cycle if we have endpoints configured
if (endpoints.length > 0) {
console.log('Triggering discovery cycle after configuration reload...');
// Import and call runDiscoveryCycle if available
if (global.runDiscoveryCycle && typeof global.runDiscoveryCycle === 'function') {
setTimeout(() => {
global.runDiscoveryCycle();
}, 1000); // Give a moment for everything to settle
}
}
console.log('Configuration reloaded successfully');
return true;
} catch (error) {
server/index.js
+13 -4
View File
@@ -727,12 +727,16 @@ async function runDiscoveryCycle() {
let errors = [];
try {
if (Object.keys(apiClients).length === 0 && Object.keys(pbsApiClients).length === 0) {
// Use global API clients if local ones aren't set
const currentApiClients = global.pulseApiClients ? global.pulseApiClients.apiClients : apiClients;
const currentPbsApiClients = global.pulseApiClients ? global.pulseApiClients.pbsApiClients : pbsApiClients;
if (Object.keys(currentApiClients).length === 0 && Object.keys(currentPbsApiClients).length === 0) {
console.warn("[Discovery Cycle] API clients not initialized yet, skipping run.");
return;
}
// Use imported fetchDiscoveryData
const discoveryData = await fetchDiscoveryData(apiClients, pbsApiClients);
const discoveryData = await fetchDiscoveryData(currentApiClients, currentPbsApiClients);
const duration = Date.now() - startTime;
@@ -772,7 +776,10 @@ async function runMetricCycle() {
let errors = [];
try {
if (Object.keys(apiClients).length === 0) {
// Use global API clients if local ones aren't set
const currentApiClients = global.pulseApiClients ? global.pulseApiClients.apiClients : apiClients;
if (Object.keys(currentApiClients).length === 0) {
console.warn("[Metrics Cycle] PVE API clients not initialized yet, skipping run.");
return;
}
@@ -783,7 +790,7 @@ async function runMetricCycle() {
if (runningVms.length > 0 || runningContainers.length > 0) {
// Use imported fetchMetricsData
const fetchedMetrics = await fetchMetricsData(runningVms, runningContainers, apiClients);
const fetchedMetrics = await fetchMetricsData(runningVms, runningContainers, currentApiClients);
const duration = Date.now() - startTime;
@@ -990,6 +997,7 @@ async function startServer() {
// Store globally for config reload
global.pulseApiClients = { apiClients, pbsApiClients };
global.runDiscoveryCycle = runDiscoveryCycle;
console.log("INFO: All API clients initialized.");
} catch (initError) {
@@ -1004,6 +1012,7 @@ async function startServer() {
apiClients = {};
pbsApiClients = {};
global.pulseApiClients = { apiClients, pbsApiClients };
global.runDiscoveryCycle = runDiscoveryCycle;
}
server.listen(PORT, () => {