mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-03 20:53:09 +00:00
Drop duplicate intros on Assistant & Patrol and Remote Access
Same anti-pattern as the Infrastructure settings card: each page rendered its own header (from SETTINGS_HEADER_META) and then SettingsPanel rendered the SAME title and description directly beneath. The user read the same sentence twice on the same screen. Drop the duplicate description from both AISettings and RelaySettingsPanel. Card titles stay so the user has a section anchor; the page-level description carries the detail without repeating it inline.
This commit is contained in:
@@ -10,7 +10,6 @@ import SettingsPanel from '@/components/shared/SettingsPanel';
|
||||
import { Toggle } from '@/components/shared/Toggle';
|
||||
import { PATROL_PATH } from '@/routing/resourceLinks';
|
||||
import {
|
||||
AI_SETTINGS_PANEL_DESCRIPTION,
|
||||
AI_SETTINGS_PANEL_TITLE,
|
||||
getAISettingsLoadingState,
|
||||
getAISettingsLoadErrorMessage,
|
||||
@@ -25,7 +24,6 @@ export const AISettings: Component = () => {
|
||||
<>
|
||||
<SettingsPanel
|
||||
title={AI_SETTINGS_PANEL_TITLE}
|
||||
description={AI_SETTINGS_PANEL_DESCRIPTION}
|
||||
action={(() => {
|
||||
return (
|
||||
<Toggle
|
||||
|
||||
@@ -18,7 +18,6 @@ import {
|
||||
RELAY_PRIMARY_BUTTON_CLASS,
|
||||
RELAY_PRIMARY_LINK_CLASS,
|
||||
RELAY_READONLY_NOTICE_CLASS,
|
||||
RELAY_SETTINGS_DESCRIPTION,
|
||||
} from '@/utils/relayPresentation';
|
||||
import { RelayPairingSection } from './RelayPairingSection';
|
||||
import {
|
||||
@@ -32,7 +31,7 @@ export const RelaySettingsPanel: Component<RelaySettingsPanelProps> = (props) =>
|
||||
// Relay feature gate
|
||||
if (!state.relayEnabled()) {
|
||||
return (
|
||||
<SettingsPanel title="Remote Access" description={RELAY_SETTINGS_DESCRIPTION}>
|
||||
<SettingsPanel title="Remote Access">
|
||||
<Show when={!state.loading()} fallback={<div class="text-sm ">Loading...</div>}>
|
||||
<Card tone="info" padding="md">
|
||||
<div class="flex flex-col sm:flex-row items-center gap-4">
|
||||
@@ -61,7 +60,7 @@ export const RelaySettingsPanel: Component<RelaySettingsPanelProps> = (props) =>
|
||||
}
|
||||
|
||||
return (
|
||||
<SettingsPanel title="Remote Access" description={RELAY_SETTINGS_DESCRIPTION}>
|
||||
<SettingsPanel title="Remote Access">
|
||||
<Show
|
||||
when={!state.loading()}
|
||||
fallback={<div class="text-sm ">{getSettingsConfigurationLoadingState().text}</div>}
|
||||
|
||||
Reference in New Issue
Block a user