gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-11 14:00:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify the 24h alert overview stat label

Browse Source 
The Acknowledged / Last 24 Hours / Workload Overrides stat row on
/alerts had an ambiguous middle card: "Last 24 Hours" with a bare
number doesn't say what is being counted. Rename the label to
"Triggered (24h)" so the metric (alerts that fired in the window)
is readable at a glance. The underlying total24h calculation is
unchanged.
This commit is contained in:
rcourtman
2026-05-09 18:39:42 +01:00
parent 2adbb96836
commit 3ddfd224aa
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend-modern/src/features/alerts/__tests__/OverviewTab.total24h.test.tsx
+5 -5
View File
@@ -75,7 +75,7 @@ describe('OverviewTab Last 24 Hours stat', () => {
render(() => <OverviewTab {...defaultProps({ activeAlerts })} />);
const label = screen.getByText('Last 24 Hours');
const label = screen.getByText('Triggered (24h)');
const statValue = label.parentElement?.querySelector('.text-lg, .text-2xl, [class*="text-lg"]');
expect(statValue?.textContent).toBe('1');
});
@@ -91,7 +91,7 @@ describe('OverviewTab Last 24 Hours stat', () => {
render(() => <OverviewTab {...defaultProps({ activeAlerts })} />);
const label = screen.getByText('Last 24 Hours');
const label = screen.getByText('Triggered (24h)');
const statValue = label.parentElement?.querySelector('.text-lg, .text-2xl, [class*="text-lg"]');
expect(statValue?.textContent).toBe('0');
});
@@ -108,7 +108,7 @@ describe('OverviewTab Last 24 Hours stat', () => {
render(() => <OverviewTab {...defaultProps({ activeAlerts })} />);
const label = screen.getByText('Last 24 Hours');
const label = screen.getByText('Triggered (24h)');
const statValue = label.parentElement?.querySelector('.text-lg, .text-2xl, [class*="text-lg"]');
expect(statValue?.textContent).toBe('3');
});
@@ -122,7 +122,7 @@ describe('OverviewTab Last 24 Hours stat', () => {
render(() => <OverviewTab {...defaultProps({ activeAlerts })} />);
const label = screen.getByText('Last 24 Hours');
const label = screen.getByText('Triggered (24h)');
const statValue = label.parentElement?.querySelector('.text-lg, .text-2xl, [class*="text-lg"]');
expect(statValue?.textContent).toBe('0');
});
@@ -137,7 +137,7 @@ describe('OverviewTab Last 24 Hours stat', () => {
render(() => <OverviewTab {...defaultProps({ activeAlerts })} />);
const label = screen.getByText('Last 24 Hours');
const label = screen.getByText('Triggered (24h)');
const statValue = label.parentElement?.querySelector('.text-lg, .text-2xl, [class*="text-lg"]');
expect(statValue?.textContent).toBe('1');
frontend-modern/src/utils/__tests__/alertOverviewPresentation.test.ts
+1 -1
View File
@@ -57,7 +57,7 @@ describe('alertOverviewPresentation', () => {
it('returns canonical alert overview stat labels', () => {
expect(ALERT_OVERVIEW_ACKNOWLEDGED_LABEL).toBe('Acknowledged');
expect(ALERT_OVERVIEW_LAST_24_HOURS_LABEL).toBe('Last 24 Hours');
expect(ALERT_OVERVIEW_LAST_24_HOURS_LABEL).toBe('Triggered (24h)');
expect(ALERT_OVERVIEW_WORKLOAD_OVERRIDES_LABEL).toBe('Workload Overrides');
});
frontend-modern/src/utils/alertOverviewPresentation.ts
+1 -1
View File
@@ -15,7 +15,7 @@ export const ALERT_BUCKET_EMPTY_LABEL = 'No alerts';
export const ALERT_HISTORY_LOADING_STATE = 'Loading alert history...';
export const ALERT_HISTORY_ALL_TIME_FILTER_LABEL = getAllFilterOptionLabel('time');
export const ALERT_OVERVIEW_ACKNOWLEDGED_LABEL = 'Acknowledged';
export const ALERT_OVERVIEW_LAST_24_HOURS_LABEL = 'Last 24 Hours';
export const ALERT_OVERVIEW_LAST_24_HOURS_LABEL = 'Triggered (24h)';
export const ALERT_OVERVIEW_WORKLOAD_OVERRIDES_LABEL = 'Workload Overrides';
export const ALERTS_PAGE_DEFAULT_TITLE = 'Alerts';
export const ALERTS_PAGE_OVERVIEW_TITLE = 'Alerts Overview';