Govern alert resource table presentation helper

This commit is contained in:
rcourtman
2026-03-24 11:23:57 +00:00
parent f5f8eb75d8
commit 2fb264929c
2 changed files with 24 additions and 5 deletions
@@ -27,10 +27,11 @@ operator-facing alert routing behavior for live runtime alerts.
5. `internal/alerts/unified_incidents.go`
6. `frontend-modern/src/components/Alerts/RecentAlertsPanel.tsx`
7. `frontend-modern/src/utils/alertOverviewPresentation.ts`
8. `frontend-modern/src/utils/alertDestinationsPresentation.ts`
9. `frontend-modern/src/utils/alertIncidentPresentation.ts`
10. `frontend-modern/src/utils/alertSchedulePresentation.ts`
11. `frontend-modern/src/utils/alertWebhookPresentation.ts`
8. `frontend-modern/src/utils/alertResourceTablePresentation.ts`
9. `frontend-modern/src/utils/alertDestinationsPresentation.ts`
10. `frontend-modern/src/utils/alertIncidentPresentation.ts`
11. `frontend-modern/src/utils/alertSchedulePresentation.ts`
12. `frontend-modern/src/utils/alertWebhookPresentation.ts`
## Shared Boundaries
@@ -223,7 +224,11 @@ card ownership lives in
desktop row ownership lives in
`frontend-modern/src/components/Alerts/AlertResourceTableRow.tsx`, and selection
state, delay-row toggling, and inline metric-input focus live in
`frontend-modern/src/components/Alerts/useAlertResourceTableState.ts`.
`frontend-modern/src/components/Alerts/useAlertResourceTableState.ts`. Shared
resource-table empty states, badge labels, offline-state wording, note
placeholders, and metric input titles now route through
`frontend-modern/src/utils/alertResourceTablePresentation.ts` instead of
remaining duplicated across the desktop and mobile thresholds surfaces.
`frontend-modern/src/components/Alerts/ResourceTable.tsx` is now limited to the
shell boundary for breakpoint selection and bulk-edit composition. Future
resource-table threshold semantics should land in those owners instead of
@@ -914,6 +914,7 @@
"frontend-modern/src/utils/alertDestinationsPresentation.ts",
"frontend-modern/src/utils/alertIncidentPresentation.ts",
"frontend-modern/src/utils/alertOverviewPresentation.ts",
"frontend-modern/src/utils/alertResourceTablePresentation.ts",
"frontend-modern/src/utils/alertSchedulePresentation.ts",
"frontend-modern/src/utils/alertWebhookPresentation.ts"
],
@@ -996,6 +997,19 @@
"frontend-modern/src/utils/__tests__/alertOverviewPresentation.test.ts"
]
},
{
"id": "alert-resource-table-presentation-helper",
"label": "alert resource table presentation helper proof",
"match_prefixes": [],
"match_files": [
"frontend-modern/src/utils/alertResourceTablePresentation.ts"
],
"allow_same_subsystem_tests": false,
"test_prefixes": [],
"exact_files": [
"frontend-modern/src/utils/__tests__/alertResourceTablePresentation.test.ts"
]
},
{
"id": "alert-destinations-presentation-helper",
"label": "alert destinations presentation helper proof",