gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-23 20:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Preserve sending-row crash recovery in the occurrence fixture

Browse Source 
Assert surviving row status before restart, then expect the existing sending-to-pending crash recovery after reopening the queue. The initial source-dtamnmrn fixture failure is retained; runtime source and delivery policy are unchanged.

Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-10-03 01:20:39 +01:00
parent 8f42497b8f
commit 2c57a54ec4
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/notifications/queue_occurrence_cancellation_test.go
+11 -2
View File
@@ -61,6 +61,9 @@ func TestQueueOccurrenceCancellationPreservesRecurrenceAcrossRestart(t *testing.
if err != nil || count != wantCount {
t.Fatalf("cancel count = %d, %v, want %d", count, err, wantCount)
}
if row := loadQuietReplay(t, q, "mixed"); row.Status != status || len(row.Alerts) != 2 {
t.Fatalf("cancellation changed surviving row status: %+v", row)
}
if err := q.Stop(); err != nil {
t.Fatal(err)
}
@@ -68,14 +71,20 @@ func TestQueueOccurrenceCancellationPreservesRecurrenceAcrossRestart(t *testing.
if err != nil {
t.Fatal(err)
}
reopenStatus := status
if status == QueueStatusSending {
// Existing crash recovery requeues interrupted sends. Exact
// cancellation must preserve that behaviour for survivors.
reopenStatus = QueueStatusPending
}
oldRow, mixed := loadQuietReplay(t, q, "old"), loadQuietReplay(t, q, "mixed")
if oldRow.Status != QueueStatusCancelled || mixed.Status != status || len(mixed.Alerts) != 2 ||
if oldRow.Status != QueueStatusCancelled || mixed.Status != reopenStatus || len(mixed.Alerts) != 2 ||
!mixed.Alerts[0].StartTime.Equal(current.StartTime) || mixed.Alerts[1].ID != peer.ID || len(mixed.Links) != 2 ||
mixed.Links[0].OperationalRecordID != current.OperationalRecord.ID || mixed.Links[1].OperationalRecordID != peer.OperationalRecord.ID {
t.Fatalf("wrong retained rows/links: old=%+v mixed=%+v", oldRow, mixed)
}
for _, id := range []string{"new", "recovery", "unknown"} {
if row := loadQuietReplay(t, q, id); row.Status != status || len(row.Alerts) != 1 {
if row := loadQuietReplay(t, q, id); row.Status != reopenStatus || len(row.Alerts) != 1 {
t.Fatalf("unrelated row %s changed: %+v", id, row)
}
}