Match safety fixtures to private responses and native platforms

PR2472 build run 37239183545 extracts no wrapped TrueNAS recipes; exercise all three current blocks and retain synthetic HTTP response bodies only in private files, including 201 save and error controls. Native run 37239183481 expects a Linux QGA capability on macOS and Windows; assert non-Linux agents do not advertise it and scope the connected PVE fixture to its actual Linux runtime. Production safety and documentation remain unchanged.

Contract-Neutral: Test-only reconciliation of already-reviewed private-response recipes and existing Linux-only guest-execution capability; no product contract change.
Change-source: pulse-maintainer

internal/hostagent/guest_exec_discovery_integration_test.go

@@ -6,6 +6,7 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"os/exec"
+	"runtime"
 	"strings"
 	"sync/atomic"
 	"testing"
@@ -39,6 +40,16 @@ func (e guestSafetyDiscoveryExecutor) IsAgentConnected(id string) bool {
 // Real server/session/registration/agent/Discovery paths, with a fake non-QGA
 // config reader and fake provider process. This is NOT native PVE acceptance.
 func testGuestExecRealServerAgentDiscoveryAdmission(t *testing.T) {
+	if runtime.GOOS != "linux" {
+		// This connected fixture models a Linux PVE host. Non-Linux agents
+		// must not advertise the production QGA guard, even with injected
+		// readers; pretending their registration is Linux would weaken that
+		// contract. The native suites retain their other command controls.
+		if c := new(CommandClient); c.guestExecGuardVersion() != 0 {
+			t.Fatal("non-Linux agent advertised Linux guest-execution safety")
+		}
+		t.Skip("connected PVE guest-execution fixture requires a Linux agent runtime")
+	}
 	s := agentexec.NewServer(func(token, agent, host string) bool {
 		return token == "fixture" && agent == "node-agent" && host == "node"
 	})

scripts/tests/test_truenas_docs.py

@@ -27,10 +27,12 @@ PAYLOAD = {"name": "test-nas", "host": "https://nas.example.invalid",
 
 
 def commands():
-    blocks = re.findall(r"```bash\n(.*?)```", DOC.read_text(), re.DOTALL)
-    preparation = next(block for block in blocks if "umask 077" in block)
-    requests = [block for block in blocks if block.startswith("curl ")]
-    return preparation, requests
+    section = DOC.read_text().split("### Testing and adding a connection (API)\n", 1)[1]
+    section = section.split("\n## Troubleshooting", 1)[0]
+    blocks = re.findall(r"```bash\n(.*?)```", section, re.DOTALL)
+    if len(blocks) != 3:
+        raise AssertionError("expected separate preparation, test and save recipes")
+    return blocks[0], blocks[1:]
 
 
 @contextmanager
@@ -41,7 +43,7 @@ def server(status=200):
         def do_POST(self):
             body = self.rfile.read(int(self.headers["Content-Length"]))
             requests.append((self.path, dict(self.headers), json.loads(body)))
-            self.send_response(status)
+            self.send_response(status if status != 200 or self.path.endswith("/test") else 201)
             self.end_headers()
             self.wfile.write(b'{"fixture":true}\n')
 
@@ -192,6 +194,11 @@ class TrueNASDocsTest(unittest.TestCase):
         for secret in (TOKEN, NAS_KEY):
             self.assertNotIn(secret, " ".join(argv))
             self.assertNotIn(secret.encode(), result.stdout + result.stderr)
+        output = Path(argv[argv.index("--output") + 1])
+        self.assertEqual(output.parent, private)
+        self.assertEqual(stat.S_IMODE(output.stat().st_mode), 0o600)
+        self.assertEqual(output.read_bytes(), b'{"fixture":true}\n')
+        self.assertNotIn(b'{"fixture":true}', result.stdout + result.stderr)
         return result
 
     def test_test_and_save_send_header_and_json_from_private_files(self):
@@ -215,7 +222,7 @@ class TrueNASDocsTest(unittest.TestCase):
                     with server(status) as (port, _):
                         result = self.request(Path(temporary), command, port)
                         self.assertEqual(result.returncode, 22, result.stderr.decode())
-                        self.assertIn(b'{"fixture":true}', result.stdout)
+                        self.assertNotIn(b'{"fixture":true}', result.stdout + result.stderr)
 
 
 if __name__ == "__main__":