mirror of
https://github.com/projectsend/projectsend.git
synced 2026-09-17 17:15:08 +00:00
ignacionelson
bab90c0ad8
Every upload now starts as "being checked" and is not served to anyone until a scanner has looked at it. Infected files are quarantined: kept on disk, unreachable, waiting for an administrator. The scanner is ClamAV, reached over a socket, streaming the file wherever it is stored — no temporary copy for an S3 or GCS disk. What the scanner answers is a fact; what it means for the file is this installation's setting, so ClamAvScanner knows nothing about settings and ScanPolicy knows nothing about sockets. Three of clamd's own alert options are what make a file it could not open come back as an answer rather than as "OK"; the client maps those to "too large" and "encrypted" instead of to a threat. Both policies default to letting files through, marked "not scanned", which is the product owner's decision: a scanner that cannot answer must not stop people working. Every such file is logged, and the screens that say so come with the rest of this work. Withholding is two rules. A file that is not available drops out of the scopes that answer "what may this person see" — recipients and the public listings, never the uploader's own copy. And every route that puts bytes on the wire asks FileAvailability first: download, thumbnail, preview, share link, the four public routes and both ends of a zip build. A share link minted before the scan finishes says the file is still being checked rather than 404ing. Not yet here, and coming next: the quarantine screen and its permission, the notifications, the settings screen, the hourly retry, the backfill for existing libraries, and the Docker service.
48 lines
1.4 KiB
PHP
48 lines
1.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Modules\Files\Scanning;
|
|
|
|
use Illuminate\Support\Carbon;
|
|
|
|
/**
|
|
* What the scanner said about itself — for the Test button, the dashboard
|
|
* warning and `projectsend:status`.
|
|
*/
|
|
final class ScannerStatus
|
|
{
|
|
public function __construct(
|
|
public readonly bool $reachable,
|
|
/** e.g. "ClamAV 1.4.1", or null when unreachable. */
|
|
public readonly ?string $engine = null,
|
|
/** The signature database number, when the scanner reports one. */
|
|
public readonly ?int $definitionsVersion = null,
|
|
public readonly ?Carbon $definitionsDate = null,
|
|
/** Why it could not be reached, for a person to act on. */
|
|
public readonly ?string $error = null,
|
|
) {}
|
|
|
|
public static function unreachable(string $error): self
|
|
{
|
|
return new self(false, error: $error);
|
|
}
|
|
|
|
/**
|
|
* How old the definitions are, in hours. Null when the scanner does
|
|
* not say — absent and zero are different answers, and a caller
|
|
* warning on "older than three days" must not treat "did not say" as
|
|
* "brand new".
|
|
*/
|
|
public function definitionsAgeHours(): ?int
|
|
{
|
|
if ($this->definitionsDate === null) {
|
|
return null;
|
|
}
|
|
|
|
// diffInHours() answers with a float; whole hours is what the
|
|
// warning threshold and the status document both speak in.
|
|
return (int) $this->definitionsDate->diffInHours(now());
|
|
}
|
|
}
|