mirror of
https://github.com/projectsend/projectsend.git
synced 2026-09-17 00:55:07 +00:00
ignacionelson
6e47d76ba6
Client file sharing, rebuilt from the ground up: a private area per client, resumable uploads, folders, groups and categories, sharing with expiry dates and download limits, comments, file versions, an activity log, a REST API, and sixteen languages. This repository begins here. ProjectSend 2 was developed privately, and that development history is not published — the previous generation remains available, with its own history, at projectsend/legacy. Free software under the GNU General Public License v2, or (at your option) any later version.
106 lines
4.6 KiB
PHP
106 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\User;
|
|
use App\Modules\Files\Models\File;
|
|
use App\Modules\Files\Models\Folder;
|
|
use App\Modules\Groups\Models\Group;
|
|
use App\Modules\Notifications\InAppNotification;
|
|
use Illuminate\Database\Eloquent\Collection;
|
|
use Illuminate\Support\Facades\Storage;
|
|
|
|
beforeEach(function () {
|
|
Storage::fake('files');
|
|
$this->admin = User::factory()->create();
|
|
});
|
|
|
|
function sharedNotificationsFor(User $client): Collection
|
|
{
|
|
return InAppNotification::query()
|
|
->where('user_id', $client->id)
|
|
->where('type', 'file_shared')
|
|
->get();
|
|
}
|
|
|
|
test('sharing a file with a client notifies them', function () {
|
|
$file = File::factory()->create(['name' => 'Report']);
|
|
$client = User::factory()->client()->create();
|
|
|
|
$this->actingAs($this->admin)->post("/files/{$file->id}/assignments", ['type' => 'client', 'id' => $client->id]);
|
|
|
|
$notifications = sharedNotificationsFor($client);
|
|
|
|
expect($notifications)->toHaveCount(1)
|
|
->and($notifications->first()->data['itemName'])->toBe('Report')
|
|
->and($notifications->first()->subject_id)->toBe($file->id);
|
|
});
|
|
|
|
// Folder shares used to send nothing at all: FolderAssignmentsController had
|
|
// no Notifier, so a client was granted live access to a whole subtree without
|
|
// being told. The registered type's own label — "A file or folder was shared
|
|
// with you" — shows folders were always meant to be covered.
|
|
test('sharing a folder with a client notifies them too', function () {
|
|
$folder = Folder::query()->create(['name' => 'Brand Kit', 'path' => '/']);
|
|
$client = User::factory()->client()->create();
|
|
|
|
$this->actingAs($this->admin)->post("/folders/{$folder->id}/assignments", ['type' => 'client', 'id' => $client->id]);
|
|
|
|
$notifications = sharedNotificationsFor($client);
|
|
|
|
expect($notifications)->toHaveCount(1)
|
|
->and($notifications->first()->data['itemName'])->toBe('Brand Kit')
|
|
->and($notifications->first()->subject_id)->toBe($folder->id)
|
|
->and($notifications->first()->subject_type)->toBe($folder->getMorphClass());
|
|
});
|
|
|
|
test('sharing with a group notifies every member, for both subjects', function (string $type) {
|
|
$group = Group::query()->create(['name' => 'Design Team']);
|
|
$first = User::factory()->client()->create();
|
|
$second = User::factory()->client()->create();
|
|
$group->members()->sync([$first->id, $second->id]);
|
|
|
|
$subject = $type === 'files'
|
|
? File::factory()->create(['name' => 'Report'])
|
|
: Folder::query()->create(['name' => 'Brand Kit', 'path' => '/']);
|
|
|
|
$this->actingAs($this->admin)->post("/{$type}/{$subject->id}/assignments", ['type' => 'group', 'id' => $group->id]);
|
|
|
|
expect(sharedNotificationsFor($first))->toHaveCount(1)
|
|
->and(sharedNotificationsFor($second))->toHaveCount(1);
|
|
})->with(['files', 'folders']);
|
|
|
|
// firstOrCreate makes re-posting an existing assignment a no-op on the row,
|
|
// but the notification is sent outside that check, so a repeat share notifies
|
|
// again. That is long-standing behaviour on the file side; what this pins is
|
|
// that folders now do exactly the same thing. If the repeat notification is
|
|
// ever judged wrong, it should stop being sent for both at once — which is
|
|
// the point of them sharing one implementation.
|
|
test('a repeat share notifies again, identically for files and folders', function () {
|
|
$file = File::factory()->create(['name' => 'Report']);
|
|
$folder = Folder::query()->create(['name' => 'Brand Kit', 'path' => '/']);
|
|
$fileClient = User::factory()->client()->create();
|
|
$folderClient = User::factory()->client()->create();
|
|
|
|
foreach ([1, 2] as $ignored) {
|
|
$this->actingAs($this->admin)->post("/files/{$file->id}/assignments", ['type' => 'client', 'id' => $fileClient->id]);
|
|
$this->actingAs($this->admin)->post("/folders/{$folder->id}/assignments", ['type' => 'client', 'id' => $folderClient->id]);
|
|
}
|
|
|
|
expect(sharedNotificationsFor($fileClient)->count())
|
|
->toBe(sharedNotificationsFor($folderClient)->count())
|
|
->and(sharedNotificationsFor($fileClient))->toHaveCount(2);
|
|
});
|
|
|
|
test('unsharing does not notify', function (string $type) {
|
|
$subject = $type === 'files'
|
|
? File::factory()->create(['name' => 'Report'])
|
|
: Folder::query()->create(['name' => 'Brand Kit', 'path' => '/']);
|
|
$client = User::factory()->client()->create();
|
|
|
|
$this->actingAs($this->admin)->post("/{$type}/{$subject->id}/assignments", ['type' => 'client', 'id' => $client->id]);
|
|
$this->actingAs($this->admin)->delete("/{$type}/{$subject->id}/assignments", ['type' => 'client', 'id' => $client->id]);
|
|
|
|
expect(sharedNotificationsFor($client))->toHaveCount(1);
|
|
})->with(['files', 'folders']);
|