gsadmin/projectsend
1
0
Fork 0
mirror of https://github.com/projectsend/projectsend.git synced 2026-09-22 19:43:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the duplicate custom-pr-sign-comment that broke the CLA workflow

Browse Source 
c9a4b552 added custom-pr-sign-comment to close a hole that was not
there: the key was already set further down the same block, with the
same value, and has been since 2.0.0. The action was already comparing
the whole comment, so a comment wrapping the phrase in other text was
never recorded as a signature, and loosening the job filter in
0a7330d5 opened nothing. The second copy made the file invalid, and
GitHub stopped running the CLA check at all.

This removes the copy and says at the original why it is set, since it
repeats the action's default phrase and looks removable.
This commit is contained in:
ignacionelson
2026-09-21 18:26:43 -03:00
parent c9a4b5520d
commit 86edbc640d
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/cla.yml
+6 -8
View File
@@ -69,14 +69,6 @@ jobs:
allowlist: dependabot[bot],renovate[bot],*[bot]
# Set to the action's own default phrase, and it matters that it
# is set. Without it the action searches the comment for the
# phrase, so "I LIE, I have read the CLA Document and I hereby sign
# the CLA. I do not sign it" on one line was recorded as a
# signature. With it, the comment -- trimmed and lowercased --
# must be the phrase and nothing else.
custom-pr-sign-comment: 'I have read the CLA Document and I hereby sign the CLA'
custom-notsigned-prcomment: |
Thanks for the pull request!
@@ -89,6 +81,12 @@ jobs:
Please read the **[CLA]($pathToCLADocument)**, then post exactly this as a comment
on this pull request:
# Not decoration, although it repeats the action's default phrase.
# Set, it makes the action compare the whole comment, trimmed and
# lowercased, against it. Unset, the action searches the comment
# for the phrase instead, and "I LIE, I have read the CLA Document
# and I hereby sign the CLA. I do not sign it" on one line would
# be recorded as a signature.
custom-pr-sign-comment: 'I have read the CLA Document and I hereby sign the CLA'
custom-allsigned-prcomment: 'CLA signed — thanks. A maintainer will review this shortly.'
lock-pullrequest-aftermerge: false