11 Commits

Author	SHA1	Message	Date
xarmian	0fd5d0cdfb	fix: green up Go (PostgreSQL) CI (BUG-842) (#275) ... * fix(store): swap plainto_tsquery → websearch_to_tsquery for PG FTS (BUG-842) `TestListItems_FTS_HyphenatedSearchTerm/task-five` has been failing on every Go (PostgreSQL) CI run because `plainto_tsquery('english', 'task-five')` doesn't match the asciihword lexeme(s) the english parser produces for an indexed `task-five-distinctive`. The result is that every PG full-text search for hyphenated terms returns zero rows. `websearch_to_tsquery` (Postgres 11+) is purpose-built for arbitrary user input and tokenizes hyphenated terms the same way `to_tsvector` does for the indexed document, so the query intersects the index correctly. Swapped in three spots in the postgres dialect — FTSMatch, FTSSnippet, FTSRank — and updated the caller-side comments that referenced plainto_tsquery. SQLite path is unchanged: it goes through items_fts MATCH with sanitizeFTSQuery, never through these methods. * fix(server): drain background goroutines on Stop() (BUG-842) `TestAdminBillingStats_SidecarSidecarError_DegradesToLocalOnly` (and other server tests) have been flaking on the Go (PostgreSQL) CI runner with `TempDir RemoveAll cleanup: directory not empty`. Root cause: several request handlers spawned bare `go func() { ... }()` goroutines that touched the SQLite WAL DB after the test function returned. testServer's t.Cleanup closed the store but had no way to drain those goroutines first, so a fire-and-forget WAL write could re-create the `-wal`/`-shm` files between Close() and t.TempDir's RemoveAll. Add a Server.bg sync.WaitGroup, a Server.goAsync helper that wraps a WaitGroup-tracked goroutine, and a Server.Stop() that blocks until every goAsync closure has finished. Convert the four known fire-and-forget sites to goAsync: - middleware_auth.go (TouchUserActivity) - handlers_auth.go (password reset email) - handlers_cloud.go (stripe_processed_events pruning) - handlers_members.go (workspace invitation email) Wire `srv.Stop()` into both testServer (server_test.go) and newMetricsTestServer (metrics_auth_test.go) so cleanup order is Stop → Close → TempDir RemoveAll. Add TestServer_Stop_DrainsBackgroundGoroutines to pin the contract: a goAsync goroutine must block Stop until it returns. * fix(store): correct PG FTS hyphenation via OR-combined plainto_tsquery (BUG-842) The previous attempt swapped plainto_tsquery → websearch_to_tsquery, which was wrong: websearch_to_tsquery treats `-` as a NEGATION operator (Google-style), so `task-five` becomes `task & !five` and the search returns 0 rows for the same reason as before. This commit reverts the swap and applies the actual fix. PG's english parser indexes `task-five-distinctive` as `{task-five-distinct, task, five, distinct}` — the asciihword AND its parts. plainto_tsquery applied to the partial query `task-five` produces `task-fiv & task & five`: the stemmed asciihword for the PARTIAL query (`task-fiv`) is NOT in the vector, so the AND fails. Replacing the hyphen with a space makes plainto emit `task & five`, which DOES match — but doing that unconditionally breaks `BUG-842`- style queries: PG indexes the `-842` suffix as a negative-number lexeme, so `plainto_tsquery('BUG-842')` matches via `-842`, while `plainto_tsquery('BUG 842')` searches for `842` and misses. The fix ORs the two query variants together so the search vector is matched against either the raw user query OR its hyphen-as-space form. Both `task-five` (against `task-five-distinctive`) and `BUG-842` (against `BUG-842 fix the cleanup race`) hit. Verified locally against postgres:17-alpine via PAD_TEST_POSTGRES_URL — both 10x stress and race-detector runs are green. Surfaces: - dialect.go: FTSMatch / FTSSnippet / FTSRank now consume TWO placeholders each in the PG dialect. - items.go: listItemsFTS PG branch + SearchItems PG branch update args to pass (raw, sanitized) for every PG `?` placeholder. - search.go: SearchItems main / count / facets PG branches updated likewise. New sanitizePGFTSQuery helper alongside sanitizeFTSQuery. - documents.go: ListDocuments PG branch updated. Tests: - TestListItems_FTS_HyphenatedSearchTerm extended with a `BUG-842` case to pin the OR-combined logic — naive hyphen-stripping would silently regress this. - New TestSanitizePGFTSQuery unit test. * chore: gofmt 11 files with import-order issues (BUG-842 PR cleanup) The Go (SQLite) CI job has been failing on `main` (and every PR built against it) because golangci-lint flags 11 files whose third-party imports are intermixed with internal imports — the import-grouping rule that gofmt enforces. None of these were introduced by the BUG-842 PR; they're pre-existing on main. The PR can't go green without this cleanup, though, so it's bundled here. Pure mechanical change — `gofmt -w <files>` only re-orders import groups; no logic changes. Files touched: cmd/pad/configure.go cmd/pad/main.go internal/cli/format.go internal/server/handlers_admin_invitations.go internal/server/handlers_admin_users.go internal/server/handlers_grants.go internal/server/handlers_share_links.go internal/server/handlers_stars.go internal/server/middleware_auth.go internal/store/store.go internal/store/store_test.go After this commit `gofmt -l ./cmd ./internal` returns clean.	2026-04-28 16:21:43 -04:00
xarmian	7cda0d7896	feat: rebrand to Perpetual Software + new tagline (IDEA-832) (#273) ... Migrates from xarmian/pad to PerpetualSoftware/pad across the entire repo and updates the product subtitle to "Collaborate with your AI agents". Go module rename - go.mod: github.com/xarmian/pad → github.com/PerpetualSoftware/pad - All Go imports updated across cmd/pad, internal/{cli,server,store, models,collections,items,events,metrics,webhooks} (~130 files) - Test fixtures with the literal repo slug ("xarmian/pad" in JSON shapes, SSH/HTTPS git URL strings, workspace_context fixtures) also updated, including the secondary repo entry (xarmian/pad-web → PerpetualSoftware/pad-web — pad-web was also moved to the org per branch context) Docs / config - README badges, install instructions, brew tap, Docker image, source build path, sponsor link (sponsor link kept as personal @xarmian) - Subtitle: "Project management for developers and AI agents." → "Collaborate with your AI agents." (README, manifests, web layout meta, .goreleaser homebrew description) - CONTRIBUTING.md, SECURITY.md, skills/INSTALL.md - .goreleaser.yaml: homebrew_casks owner, GHCR image, release github owner, cosign cert-identity regex, comments - .github/workflows/release.yml: tap/release comments - deploy/k8s/deployment.yaml: container image - docs/deployment.md: clone URL - web/static/{site.webmanifest,manifest.json}: description - web/src/routes/+layout.svelte: meta description + og:description Brew tap path is PerpetualSoftware/tap/pad (CamelCase, matches GitHub user case). GHCR image is ghcr.io/perpetualsoftware/pad (lowercased per GHCR's URL normalization). CODEOWNERS @xarmian and FUNDING.yml github: xarmian intentionally retained — those are the personal maintainer / sponsor account, separate from the org repo. Verification: go build ./..., go test ./... (all pkgs pass), web build, and make install all clean (TASK-844, TASK-845).	2026-04-28 12:26:39 -04:00
xarmian	bf5ab5b366	chore: clear staticcheck SA + U1000 findings on main (TASK-764) (#249) ... * chore: clear cosmetic staticcheck findings (TASK-764) Apply zero-behavior-change fixes for 8 staticcheck findings on main: - SA4023 cmd/pad/main.go:431 — drop always-true `if eventBus != nil` guard. eventBus is wrapped in metrics.NewInstrumentedBus a few lines above, which returns a concrete *InstrumentedBus that is never nil. - SA1019 cmd/pad/main.go:3926 — replace deprecated strings.Title with golang.org/x/text/cases.Title(language.English).String. golang.org/x/text was already an indirect dep; now promoted to direct. - SA4031 internal/server/handlers_changes.go:130 — delete dead `if updatedItems == nil { ... }` block. make([]T, n) always returns non-nil; the JSON marshalling already produced [] not null. - SA9003 cmd/pad/init.go:351 — delete empty if branch and fold its intent into the surrounding comment. - SA9003 internal/server/handlers_dashboard.go:125 — replace empty `if err == nil { ... }` branch with `_ = json.Unmarshal(...)` to match the sibling settings parse and document the best-effort intent. - SA4006 internal/cli/format.go:153 — drop the dead initial `titlePart := item.Title` (overwritten in both branches below); declare titlePart with `var` instead. - SA4006 internal/store/workspaces.go:70 — drop the dead first call to s.uniqueSlug; only the workspace-specific uniqueWorkspaceSlug is meaningful (workspace slugs are globally unique, not workspace- scoped like collection/item slugs). - SA4000 internal/store/store_test.go:99 — remove always-true outer `if idx := len(connStr) - len(connStr); idx >= 0` and unindent the inner '?' query-string split. go.mod side effects from `go mod tidy` under Go 1.26: golang.org/x/text moves to direct (used directly now); pquerna/otp, prometheus/client_* and trustelem/zxcvbn move from indirect to direct (they were already used directly — Go 1.26's tidy correctly classifies them). Verified: - `go build ./...` clean - `go vet ./...` clean - `go test ./...` all pass (including the replaceDBName test path) - `staticcheck -checks "SA1019,SA4000,SA4006,SA4023,SA4031,SA9003"` clean except for handlers_dashboard.go:221 (SA4006, dashboard visibility- filter dead block — handled in TASK-765) Parent: PLAN-644. * fix: clear SA5011 nil-deref in buildReconcileFindings (TASK-764) extractItemStatus(item.Fields) on the first line of the function would have panicked on a nil item before the `if item != nil && item.CodeContext == nil` guard could fire. Staticcheck SA5011 flagged the inconsistency. Drop the (item != nil) half of the guard — the function now documents its non-nil contract in the doc comment. All callers (reconcile.go:204 plus three sites in cmd/pad/reconcile_test.go) already pass non-nil, so this is documentation, not behaviour change. Verified: - `go build ./...` clean - `go test ./cmd/pad/...` passes (the existing reconcile tests cover the contract) - `staticcheck -checks SA5011 ./...` clean Parent: PLAN-644. * chore: silence SA4017 false positive in watchCmd SSE loop (TASK-764) cmd/pad/main.go SSE keepalive branch: if strings.HasPrefix(line, ":") { continue } Staticcheck SA4017 reports "HasPrefix doesn't have side effects and its return value is ignored" — but the return value IS used as the if condition. Two sibling strings.HasPrefix calls earlier in the same for-loop body (matching "event: " and "data: " prefixes) are not flagged, which strongly suggests an SSA-analysis quirk specific to this branch rather than a real defect. Suppress the finding with a //lint:ignore directive that explains the false positive in-place. Rewriting to a different form (extract to a bool var, comma-OK on a synthetic value, etc.) would be uglier than the suppression comment. Verified: - `staticcheck -checks SA4017 ./...` clean - `go build ./...` clean Parent: PLAN-644. * chore: delete dead code flagged by U1000 (TASK-764) Pre-launch (no external contributors yet) — no consumer fork can be relying on these unreferenced symbols, so we delete them rather than carry the maintenance burden into v1. ## Helpers (14 functions, 1 type) cmd/pad/main.go - progressBar — never called internal/cli/format.go - stripHTMLTags — never called internal/server/handlers_dashboard_test.go - updateItem (test helper) — never called from any test internal/server/handlers_items.go - publishItemEvent — wrapper over publishItemEventWithName; all 5 call sites use the *WithName variant directly. - resolveRelationFields — never called. - resolveRelationFieldFiltersForWorkspace, resolveRelationFieldFilters, relationFilterKeys, resolveRelationFilterValue — closed loop of dead helpers (each one only called by another dead one in the family). - extractStatus — never called (cmd/pad/reconcile.go has its own copy). internal/server/handlers_versions.go - handleGetDiff (HTTP handler) — never wired into setupRouter. - diffsToChanges, diffChange (type) — only used by handleGetDiff above. - Removes now-unused imports `strconv` and `dmp` (sergi/go-diff). internal/server/middleware_ratelimit.go - writeTooManyRequests — never called; the live ratelimit middleware uses a dedicated 429 path with Retry-After-Bucket headers. internal/server/server.go - guestVisibleItemIDs — never called. handlers_events.go had a comment cross-reference; updated to drop the reference. ## Constants internal/events/redis_bus.go - reconnectDelay — never read. internal/store/api_tokens.go - defaultTokenExpiryDays — never read. ## Out of scope The 5 unwired handlers in internal/server/handlers_documents.go are left alone: they are the subject of TASK-769 (a product decision — wire up vs. delete — that may want different treatment per handler). The two SA4006/SA4010 findings on internal/server/handlers_dashboard.go visibility-filter block are similarly left for TASK-765. ## Verified - `go build ./...` clean - `go vet ./...` clean - `go test ./...` all pass - `staticcheck -checks "SA*,U1000" ./...` clean except the two TASK- 765 / TASK-769 follow-ups noted above. Parent: PLAN-644. * docs: correct caller name in buildReconcileFindings doc (TASK-764) Codex round 1 caught: the doc comment named the caller `reconcileSingle` but the actual function is `reconcileItem` (cmd/pad/reconcile.go:204). Fix the contract comment so it doesn't go stale on the first git blame.	2026-04-25 11:53:31 -04:00
xarmian	157ca4e88f	chore: bump Go toolchain to 1.26 (TASK-763) (#247) ... * chore: bump Go toolchain to 1.26 (TASK-763) Bump Go from 1.25 to 1.26 across all toolchain pins: - go.mod — go 1.25.0 → go 1.26.0 - Dockerfile — golang:1.25-alpine → golang:1.26-alpine - .github/workflows/ci.yml — three setup-go steps (Go, Go-Postgres, E2E jobs) - .github/workflows/release.yml — release pipeline No `toolchain` directive: the repo is pre-launch with no external contributors yet, so we set the floor where we want it (hard requirement). Verified locally before commit: - golangci-lint v2.11.4 builds and runs under Go 1.26.2 (pinned in CI) - golang:1.26-alpine and 1.26.2-alpine images present on Docker Hub - go build ./... clean - go vet ./... clean - go test ./... all pass Parent: PLAN-644 (OSS Repo Hygiene and Launch Polish). * chore: gofmt -w under Go 1.26 (TASK-763) Apply Go 1.26's gofmt to the codebase. ~41 files reformatted, all struct-tag whitespace realignment — no semantic changes. Verified: - gofmt -l ./cmd ./internal returns empty after - go build ./... still clean - go test ./... still passes (run before commit) Bundling the gofmt diff with the toolchain bump in the same PR because the formatting drift is a direct consequence of moving from 1.25 to 1.26; splitting them creates a mandatory two-PR ordering for no value. Parent: PLAN-644. * docs: bump documented Go floor to 1.26 (TASK-763) Match go.mod's hard 1.26.0 requirement in the source-build instructions. Caught by Codex review round 1 on PR #247. - README.md:158 — "Go 1.25+" → "Go 1.26+" - CONTRIBUTING.md:9 — "Go 1.25+" → "Go 1.26+"	2026-04-25 11:35:19 -04:00
xarmian	bde15d45ca	Rename Phases to Plans, clean up deprecated aliases (#71) ... * Rename "Phases" to "Plans" and clean up deprecated phase aliases Renames the default "Phases" collection to "Plans" across the full stack: - DB migration renames existing collections in-place (name, slug, prefix PLAN, icon 🗺️) - Removes all deprecated Phase* backward-compat aliases from models and store - Removes --phase CLI flag (use --parent instead) - Updates convention triggers: on-phase-start/complete → on-plan-start/complete - Updates dashboard API: active_phases → active_plans, /phases-progress → /plans-progress - Updates all frontend components, types, and documentation Closes IDEA-124 * Fix CSRF cookie not being cleared on logout The SessionAuth middleware was re-issuing a CSRF cookie before the logout handler could clear it, resulting in two Set-Cookie headers. Skip CSRF re-issue for /api/v1/auth/ paths since auth endpoints manage their own CSRF cookies (login sets, logout clears). * Fix migration issues found in Codex review - P1: Move doc_type UPDATE from migration 024 into 025, which recreates the table with the new CHECK constraint first (SQLite enforces CHECK on UPDATE, so the old constraint would reject 'plan') - P1: Add PostgreSQL migration 005 for the collection rename (phases → plans) — previously only existed on the SQLite path - P2: Recreate FTS triggers, indexes, and rebuild FTS after the table swap in migration 025 (DROP TABLE drops associated objects in SQLite) * Fix parent filter field name and sync .agents skill copy Codex review round 2 findings: - P1: Parent filter compared against `parent_id` (wrong) instead of `parent_link_id` — plan filtering in collection view was broken - P1: .agents/skills/pad/SKILL.md still had old --phase flags and "Phases" references — synced from the updated .claude copy - P2: Accept legacy 'phase' filter key for backward compat with existing saved views that serialized the old key name * Fix PG migration JSONB casting and add slug collision guards Codex PR review bot findings: - P1: PostgreSQL REPLACE/LIKE don't work on JSONB columns — cast schema::text and fields::text before string ops, then back to ::jsonb - P1: If a workspace already has a custom 'plans' collection, the rename hits UNIQUE(workspace_id, slug) — added NOT EXISTS guard to both SQLite and PostgreSQL migrations	2026-04-07 14:55:23 -04:00
xarmian	063ff92d00	feat: generalized parent/child items with progress tracking (#70) ... * feat: generalize parent/child items — any item can have children with progress tracking Replaces the phases-only task widget with a generalized parent/child system. Any item (Phase, Idea, Doc, Task, etc.) can now be a parent of child items, getting automatic progress bars, burndown charts, status grouping, drag-drop reordering, and recursive expand/collapse up to 3 levels deep. DB: migrate link_type 'phase' → 'parent' (migration 023) Store: generalized methods (GetChildItems, GetItemProgress, SetParentLink with cycle detection), drop collection filters, per-child terminal status API: new /items/{slug}/children and /items/{slug}/progress endpoints Frontend: ChildItems, ChildChart, NestedChildren components replace PhaseTasks CLI: --parent flag (--phase kept as hidden alias), list/show/changelog updated Docs: CLAUDE.md, SKILL.md, pad-web updated for parent/child model Full backward compatibility: old 'phase' link_type, --phase flags, phase_id/ phase_ref JSON fields all still work as deprecated aliases. Closes PHASE-16 (9 tasks). * fix: update collection list page to use item_id from phasesProgress response The TS client return type changed from phase_id to item_id but the collection list page still referenced p.phase_id, causing svelte-check type errors in CI. * fix: address Codex review findings — PG migration, terminal statuses, metrics, CSRF resilience - Add PostgreSQL migration 003 to rename 'phase' links to 'parent' - Use schema-defined terminal statuses in GetAllItemProgress instead of hardcoded defaults - Pass computed terminal statuses from page to ChildItems component - Only special-case 'parent' field key when not defined in collection schema - Move MetricsMiddleware before Recoverer so panics are counted - Always mount ChildItems for SSE subscriptions even with 0 children - Exclude soft-deleted children from has_children enrichment query - Re-issue CSRF cookie when session is valid but cookie is missing - Show actual API error messages in create-item toasts	2026-04-07 09:52:31 -04:00
xarmian	be576d9e24	feat: agent roles — role-based (user, role) assignment for items (#58) ... * feat: agent roles — role-based (user, role) assignment for items (#PHASE-9) Introduce agent roles as a first-class concept for human-agent work assignment. Roles describe capability specializations (Planner, Implementer, Reviewer, etc.) and items can be assigned to a (user, role) pair, enabling natural handoff workflows between different AI tools. Migration: - New `agent_roles` table (workspace-scoped, slug-unique) - `assigned_user_id` + `agent_role_id` columns on `items` with FKs - Removed legacy `assignee` text field from Tasks schema Backend: - AgentRole model + full CRUD store/API - All item queries updated with LEFT JOINs to resolve assignment - Item list filtering by assigned_user_id and agent_role_id - Role transitions tracked in activity feed metadata CLI: - `pad role list/create/delete` commands - `--role` and `--assign` flags on item create/update/list - Assignment displayed in `pad item show` output Web: - TypeScript types + API client for agent roles - Role badge on item cards in list/board views - Assignment display on item detail page * fix: enforce workspace-scoped assignments and fail fast on unresolved --assign filter Addresses code review feedback from PR #58: P1: Add validateAssignmentScope() to the store layer, called by both CreateItem and UpdateItem. Verifies that assigned_user_id belongs to the workspace (via IsWorkspaceMember) and agent_role_id exists in the workspace (via GetAgentRole) before writing. Prevents cross-workspace assignment leaks. P2: The CLI `pad item list --assign <name>` now errors instead of silently returning unfiltered results when the member lookup fails or no workspace member matches the provided name.	2026-04-03 21:16:38 -04:00
xarmian	a219f81633	fix: CLI and skill file now use issue IDs (TASK-5) instead of slugs (#15) ... Agents were using verbose slugs because: 1. The skill file (SKILL.md) taught them to use `<slug>` in every example 2. CLI output showed slugs in parentheses rather than issue IDs 3. CLI usage strings said `<slug>` not `<ref>` 4. JSON output lacked a `ref` field, so agents parsing JSON only saw slugs Changes: - Add computed `ref` field to Item model (e.g. "TASK-5") in JSON output - CLI create/update/delete/edit output now prominently shows issue IDs - All CLI usage strings changed from `<slug>` to `<ref>` - Issue IDs displayed in bold cyan (not dim) in list/show/grouped views - Skill file rewritten to use issue IDs in all examples and instructions - Dashboard API includes `item_ref`/`ref` in attention, suggestions, phases - Search results now include item_number and collection_prefix for refs - CLAUDE.md updated to document issue ID usage	2026-03-28 16:14:32 -04:00
xarmian	823afe615c	feat: Add terminal colors and improved CLI formatting ... Add fatih/color dependency for terminal color output. Status colors (green=done, yellow=in-progress, blue=open, red=cancelled), priority colors, item reference numbers in all list output, and colorized status icons throughout the CLI.	2026-03-28 13:54:41 +00:00
xarmian	7ba69abb88	Misc improvements: CLI field summaries, editor enhancements, CI and UI polish ... Show field summary after create/update CLI commands. Make svelte-check blocking in CI. Improve editor block handling, field editor layout, conventions page, and minor UI consistency fixes across pages.	2026-03-27 01:13:07 +00:00
xarmian	81579847c6	Initial release ... Pad — project management for developers and AI agents. Single Go binary with embedded SvelteKit web UI, SQLite storage, CLI, and Claude Code /pad skill integration. https://getpad.dev	2026-03-26 01:52:36 +00:00