Philipp Krüger
32467e4567
## Description Fixes an underflow panic on decrementing `active_connections` in the noq endpoint state. This occurred when the API was used in this order: 1. client connects to server 2. server calls `Endpoint::accept` and captures the `Incoming` 3. server endpoint closes using `Endpoint::close` 4. server side calls `Incoming::accept` on the captured incoming 5. (EndpointDriver will panic) The reason for this was that incrementing and decrementing the `active_connections` was asymmetrical. We would increment `active_connections` only if the endpoint wasn't closed yet. However, we would decrement unconditionally, eventually underflowing. This PR removes the condition for incrementing. This preserves the behavior of being able to accept `Incoming`s after calling `Endpoint::close`. This is somewhat unlike what the iroh API expects (because in iroh you can't do anything with the endpoint *after* `Endpoint::close`), but noq's API is just different. This also adds a regression test that fails without the fix. That needs a `PanicPropagatingRuntime` implementation and some test helpers to allow for configuring that though... ## Breaking Changes None ## Notes & open questions Disclosure: Heavily assisted with GLM 5.2. ## Change checklist - [x] Self-review. - [x] Tests if relevant. - [x] All breaking changes documented.
noq
General purpose implementation of the QUIC transport
protocol in pure
Rust. Noq is built as an async-friendly API in the noq crate on top
of a sans-io protocol library in noq-proto.
Noq started out as a fork of the excellent Quinn project. The main focus of development has been towards adding support for more QUIC (draft) extensions:
Features
- Easy to use futures-based async API.
- Client and server server functionality.
- 0-RTT and 0.5-RTT data support.
- Ordered and unordered stream reads.
- Custom and zero-length connection identifiers.
- Fully pluggable crypto API with a Rustls implementation using ring or aws-lc-rs provided by default for convenience.
- Broad platform support, including Linux, Windows, macOS, android, iOS and wasm.
Standards
The noq library aims to be correct implementation of various QUIC standards:
- Supports the core QUIC specifications:
- The standardised QUIC extensions:
- Draft extensions:
- qlog: Structured Logging for Network Protocols.
- QUIC Multipath.
- With experimental qlog support.
- QUIC Address Discovery (QAD).
- Using QUIC to traverse NATs (QNT).
Getting started
Examples at https://github.com/n0-computer/noq/blob/main/noq/examples
$ cargo run --example server ./
$ cargo run --example client https://localhost:4433/Cargo.toml
This launches an HTTP 0.9 server over the QUIC transport on the loopback address serving the current working directory, with the client fetching ./Cargo.toml. By default, the server generates a self-signed certificate and stores it to disk, where the client will automatically find and trust it.
License
Copyright 2025 The quinn developers Copyright 2025 N0, INC.
This project is licensed under either of
- Apache License, Version 2.0, (LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0)
- MIT license (LICENSE-MIT or http://opensource.org/licenses/MIT)
at your option.
Contribution
Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in this project by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any additional terms or conditions.