Commit Graph

2291 Commits

Author SHA1 Message Date
Benjamin Saunders 47dad2292e Bundle retry token payload into a struct 2020-05-25 06:22:35 +02:00
Benjamin Saunders ca689d33d6 Update version numbers for draft 28 2020-05-25 06:22:35 +02:00
Benjamin Saunders 075fbb2ab9 Don't reset PTO backoff when our address need not be validated 2020-05-25 06:22:35 +02:00
Benjamin Saunders 8c81bb7c6e Remove dead state 2020-05-25 06:22:35 +02:00
Benjamin Saunders 7f7717ba46 Correct errors on illegal stream limits 2020-05-25 06:22:35 +02:00
Benjamin Saunders 5329a047ab Discard spurious version negotiation packets 2020-05-25 06:22:35 +02:00
Benjamin Saunders f9ef94f155 Discard Retry packets after successfully decrypting anything else 2020-05-25 06:22:35 +02:00
Benjamin Saunders b5021d46dd Don't leak application close details during handshake 2020-05-25 06:22:35 +02:00
Benjamin Saunders f5d4ab5624 Capture connection ID from preferred address TP
Previously, that slot in the active connection ID limit would be
leaked.
2020-05-25 06:22:35 +02:00
Benjamin Saunders 1d7a32f70f Simplify sending of initial close packets 2020-05-25 06:22:35 +02:00
Benjamin Saunders 085236b2f4 Fix inverted 0-RTT transport parameter validation 2020-05-25 06:22:35 +02:00
Benjamin Saunders e15b2be713 Rename Connection.params to peer_params for clarity 2020-05-25 06:22:35 +02:00
Benjamin Saunders b4ae98b0b3 Move retry token logic into a dedicated module 2020-05-25 06:22:35 +02:00
Benjamin Saunders 0422deada1 Draft 28 transport parameters 2020-05-25 06:22:35 +02:00
Benjamin Saunders 9085f457e8 Update rustls for interop fixes 2020-05-24 11:03:11 -07:00
Benjamin Saunders d92a567034 Return UnknownStream from Connection::reset for closed/reset streams
Improves consistency with other stream interfaces. H3 logic was
updated to ignore errors to preserve existing behavior, but future
work might want to insert some unwraps there if static correctness
guarantees are available.
2020-05-23 19:08:46 +02:00
Benjamin Saunders cd63774c0b Don't reference a hidden interface in documentation 2020-05-23 19:08:46 +02:00
Dirkjan Ochtman de5dc88782 Move DecodeHeaders into data module 2020-05-22 15:21:36 +02:00
Dirkjan Ochtman 7117e01929 Move WriteFrame into data module 2020-05-22 15:21:36 +02:00
Dirkjan Ochtman aa1ebbab76 H3: simplify ownership of SendStream (fixes #768) 2020-05-22 15:21:36 +02:00
Jean-Christophe BEGUE 68b866bc63 H3: Ignore unknown incoming uni stream 2020-05-21 10:42:26 +02:00
Jean-Christophe BEGUE 5f5be440dc H3: ignore unknown frames 2020-05-21 10:42:26 +02:00
Jean-Christophe BEGUE 061733dc1e H3: send get requests with FakeRequest helpers 2020-05-21 10:42:26 +02:00
Jean-Christophe BEGUE 77aeb5544b H3: enable tracing by default in tests 2020-05-21 10:42:26 +02:00
Benjamin Saunders 7a05701e05 Simplify stream stop logic 2020-05-21 09:28:42 +02:00
Benjamin Saunders d4b7a8f73e Additional stream testing 2020-05-21 09:28:42 +02:00
Benjamin Saunders eea76d2a90 Proactively discard data on stopped streams
Previously, flow control credit would not be issued for data received
on stopped streams unless the application continued reading them
indefinitely. This produced a flow control leak in the high level API,
causing applications which dropped streams with unread data to
eventually grind to a halt.

Discarding data immediately should also improve performance when data
is being received on stopped streams, and allows us to discard stream
state earlier.
2020-05-21 09:28:42 +02:00
Benjamin Saunders 959227566e Reject connections on ALPN failure 2020-05-21 09:22:59 +02:00
Benjamin Saunders 7053c6a802 Wake connection driver on read to issue flow control credit 2020-05-20 12:52:34 +02:00
Benjamin Saunders a58b712e46 Don't double-count acknowledgement of reset stream data 2020-05-20 12:52:34 +02:00
Benjamin Saunders 0e24d2224e Ignore redundant reset frames
This could cause excess connection-level flow control credit to be
issued.
2020-05-20 12:52:34 +02:00
Benjamin Saunders 9cf8652deb Fix empty stream frames not raising stream watermark 2020-05-20 12:52:34 +02:00
Benjamin Saunders 36a040bcf9 Ignore redundant stream reset calls
Prevents corruption of internal state on API misuse.
2020-05-20 12:52:34 +02:00
Benjamin Saunders 6e9f7e8063 Clarify variable name 2020-05-13 06:46:44 +02:00
Benjamin Saunders 275c9ca782 Apply padding in populate_packet 2020-05-13 06:46:44 +02:00
Benjamin Saunders f946bad7b8 More distinct test name 2020-05-13 06:46:44 +02:00
Benjamin Saunders d9311309af Bundle populate_packet return values into a struct 2020-05-13 06:46:44 +02:00
Benjamin Saunders 790546a6d8 Factor out congestion controller into a trait object 2020-05-12 22:43:19 +02:00
Benjamin Saunders 17d97888fc Clarify benefits of read_unordered 2020-05-12 20:59:13 +02:00
Benjamin Saunders 54f0ab1b14 Clarifying comments 2020-05-12 20:59:13 +02:00
Benjamin Saunders ba78cbc680 Move received range tracking into Assembler 2020-05-12 20:59:13 +02:00
Benjamin Saunders f068d497e3 Move Recv::bytes_read into Assembler 2020-05-12 20:59:13 +02:00
Benjamin Saunders 77185c8676 Move unordered read tracking into Assembler 2020-05-12 20:59:13 +02:00
Benjamin Saunders 6786b8a1bb Include ReadError in ReadToEndError::Read display
By treating the read error as a component of, rather than an
incidental ancestor to, the enclosing error we reduce the odds of
unhelpful diagnostics.
2020-05-11 13:53:23 -07:00
Benjamin Saunders 30b42c5bcf Don't use a larger receive buffer than necessary 2020-05-11 22:29:36 +02:00
Benjamin Saunders 8ba2a820d0 Move UDP payload limit to EndpointConfig
Makes it straightforward to share a smaller recieve buffer between
many connections.
2020-05-11 22:29:36 +02:00
Benjamin Saunders 30ac99895d Delete duplicate comments 2020-05-11 22:29:36 +02:00
Benjamin Saunders 9889a4cd56 Fix max UDP payload size not being sent to the peer 2020-05-11 22:29:36 +02:00
Benjamin Saunders 2833009dca Update naming and adjust default for UDP payload size limit 2020-05-11 22:29:36 +02:00
Benjamin Saunders 0247c7d644 Improve endpoint construction docs 2020-05-11 15:40:32 +02:00