mirror of
https://github.com/n0-computer/noq.git
synced 2026-09-21 18:53:27 +00:00
Log GSO halt on info
It is common to set up automated error reporting based on `ERROR` and potentially also `WARN` logs. Whilst GSO being unsupported is certainly something worthwhile logging, the `ERROR` log level seems a bit excessive and leads to unactionable errors reports. The system can still operate with `max_gso_segments == 1`. As such, this codepath "merely" indicates a state change in the system but not a fatal error. As such, logging this on INFO level seems more appropriate.
This commit is contained in:
committed by
Benjamin Saunders
parent
f8b8c5032e
commit
a16dcd27de
@@ -322,7 +322,9 @@ fn send(
|
||||
// Prevent new transmits from being scheduled using GSO. Existing GSO transmits
|
||||
// may already be in the pipeline, so we need to tolerate additional failures.
|
||||
if state.max_gso_segments() > 1 {
|
||||
crate::log::error!("got transmit error, halting segmentation offload");
|
||||
crate::log::info!(
|
||||
"`libc::sendmsg` failed with {e}; halting segmentation offload"
|
||||
);
|
||||
state
|
||||
.max_gso_segments
|
||||
.store(1, std::sync::atomic::Ordering::Relaxed);
|
||||
|
||||
Reference in New Issue
Block a user