🐛(frontend) prevent Crisp crash when superuser has no email

Fix crash when switching from admin session to app with superuser account
that lacks email field. Add null check to prevent Crisp initialization
errors.

src/backend/core/services/lobby.py

@@ -212,7 +212,7 @@ class LobbyService:
 
         try:
             utils.notify_participants(
-                room_name=str(room_id),
+                room_name=room_id,
                 notification_data={
                     "type": settings.LOBBY_NOTIFICATION_TYPE,
                 },

src/backend/core/tests/services/test_lobby.py

@@ -442,7 +442,7 @@ def test_enter_success(
         timeout=settings.LOBBY_WAITING_TIMEOUT,
     )
     mock_notify.assert_called_once_with(
-        room_name=str(room.id), notification_data={"type": "participantWaiting"}
+        room_name=room.id, notification_data={"type": "participantWaiting"}
     )
 
 

src/backend/pyproject.toml

@@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "meet"
-version = "0.1.30"
+version = "0.1.29"
 authors = [{ "name" = "DINUM", "email" = "dev@mail.numerique.gouv.fr" }]
 classifiers = [
     "Development Status :: 5 - Production/Stable",

src/frontend/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "meet",
-  "version": "0.1.30",
+  "version": "0.1.29",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "meet",
-      "version": "0.1.30",
+      "version": "0.1.29",
       "dependencies": {
         "@livekit/components-react": "2.9.13",
         "@livekit/components-styles": "1.1.6",

src/frontend/package.json

@@ -1,7 +1,7 @@
 {
   "name": "meet",
   "private": true,
-  "version": "0.1.30",
+  "version": "0.1.29",
   "type": "module",
   "scripts": {
     "dev": "panda codegen && vite",

src/frontend/src/features/settings/components/SettingsDialog.tsx

@@ -10,6 +10,10 @@ export const SettingsDialog = (props: SettingsDialogProps) => {
   const { t, i18n } = useTranslation('settings')
   const { user, isLoggedIn, logout } = useUser()
   const { languagesList, currentLanguage } = useLanguageLabels()
+  const userDisplay =
+    user?.full_name && user?.email
+      ? `${user.full_name} (${user.email})`
+      : user?.email
   return (
     <Dialog title={t('dialog.heading')} {...props}>
       <H lvl={2}>{t('account.heading')}</H>
@@ -18,7 +22,7 @@ export const SettingsDialog = (props: SettingsDialogProps) => {
           <P>
             <Trans
               i18nKey="settings:account.currentlyLoggedAs"
-              values={{ user: user?.full_name ?? user?.email }}
+              values={{ user: userDisplay }}
               components={[<Badge />]}
             />
           </P>

src/frontend/src/features/settings/components/tabs/AccountTab.tsx

@@ -18,6 +18,10 @@ export const AccountTab = ({ id, onOpenChange }: AccountTabProps) => {
   const room = useRoomContext()
   const { user, isLoggedIn, logout } = useUser()
   const [name, setName] = useState(room?.localParticipant.name ?? '')
+  const userDisplay =
+    user?.full_name && user?.email
+      ? `${user.full_name} (${user.email})`
+      : user?.email
 
   const handleOnSubmit = () => {
     if (room) room.localParticipant.setName(name)
@@ -37,7 +41,7 @@ export const AccountTab = ({ id, onOpenChange }: AccountTabProps) => {
         value={name}
         onChange={setName}
         validate={(value) => {
-          return !value ? <p>{'Votre Nom ne peut pas être vide'}</p> : null
+          return !value ? <p>{t('account.nameError')}</p> : null
         }}
       />
       <H lvl={2}>{t('account.authentication')}</H>
@@ -46,7 +50,7 @@ export const AccountTab = ({ id, onOpenChange }: AccountTabProps) => {
           <P>
             <Trans
               i18nKey="settings:account.currentlyLoggedAs"
-              values={{ user: user?.full_name || user?.email }}
+              values={{ user: userDisplay }}
               components={[<Badge />]}
             />
           </P>

src/frontend/src/features/support/hooks/useSupport.tsx

@@ -7,7 +7,7 @@ export const initializeSupportSession = (user: ApiUser) => {
   if (!Crisp.isCrispInjected()) return
   const { id, email } = user
   Crisp.setTokenId(`meet-${id}`)
-  Crisp.user.setEmail(email)
+  if (email) Crisp.user.setEmail(email)
 }
 
 export const terminateSupportSession = () => {

src/frontend/src/locales/de/settings.json

@@ -4,7 +4,8 @@
     "heading": "Konto",
     "youAreNotLoggedIn": "Sie sind nicht angemeldet.",
     "nameLabel": "Ihr Name",
-    "authentication": "Authentifizierung"
+    "authentication": "Authentifizierung",
+    "nameError": "Ihr Name darf nicht leer sein"
   },
   "audio": {
     "microphone": {

src/frontend/src/locales/en/settings.json

@@ -4,7 +4,8 @@
     "heading": "Account",
     "youAreNotLoggedIn": "You are not logged in.",
     "nameLabel": "Your Name",
-    "authentication": "Authentication"
+    "authentication": "Authentication",
+    "nameError": "Your name cannot be empty"
   },
   "audio": {
     "microphone": {

src/frontend/src/locales/fr/settings.json

@@ -4,7 +4,8 @@
     "heading": "Compte",
     "youAreNotLoggedIn": "Vous n'êtes pas connecté.",
     "nameLabel": "Votre Nom",
-    "authentication": "Authentification"
+    "authentication": "Authentification",
+    "nameError": "Votre Nom ne peut pas être vide"
   },
   "audio": {
     "microphone": {

src/frontend/src/locales/nl/settings.json

@@ -4,7 +4,8 @@
     "heading": "Account",
     "youAreNotLoggedIn": "U bent niet ingelogd.",
     "nameLabel": "Uw naam",
-    "authentication": "Authenticatie"
+    "authentication": "Authenticatie",
+    "nameError": "Uw naam mag niet leeg zijn"
   },
   "audio": {
     "microphone": {

src/mail/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "mail_mjml",
-  "version": "0.1.30",
+  "version": "0.1.29",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "mail_mjml",
-      "version": "0.1.30",
+      "version": "0.1.29",
       "license": "MIT",
       "dependencies": {
         "@html-to/text-cli": "0.5.4",

src/mail/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mail_mjml",
-  "version": "0.1.30",
+  "version": "0.1.29",
   "description": "An util to generate html and text django's templates from mjml templates",
   "type": "module",
   "dependencies": {

src/sdk/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "sdk",
-  "version": "0.1.30",
+  "version": "0.1.29",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "sdk",
-      "version": "0.1.30",
+      "version": "0.1.29",
       "license": "ISC",
       "workspaces": [
         "./library",

src/sdk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sdk",
-  "version": "0.1.30",
+  "version": "0.1.29",
   "author": "",
   "license": "ISC",
   "description": "",

src/summary/pyproject.toml

@@ -1,7 +1,7 @@
 
 [project]
 name = "summary"
-version = "0.1.30"
+version = "0.1.29"
 dependencies = [
     "fastapi[standard]>=0.105.0",
     "uvicorn>=0.24.0",

src/summary/summary/core/analytics.py

@@ -107,13 +107,12 @@ class MetadataManager:
             "retries": 0,
         }
 
-        _required_args_count = 7
+        _required_args_count = 4
         if len(task_args) != _required_args_count:
             logger.error("Invalid number of arguments.")
             return
 
-        filename, email, _, received_at, *_ = task_args
-
+        filename, email, _, received_at = task_args
         initial_metadata = {
             **initial_metadata,
             "filename": filename,

src/summary/summary/core/celery_config.py

@@ -1,9 +1,8 @@
-"""Celery Config."""
 
 # https://github.com/danihodovic/celery-exporter
 # Enable task events for Prometheus monitoring via celery-exporter.
 
-# worker_send_task_events: Sends task lifecycle events (e.g., started, succeeded),
+# worker_send_task_events: Sends task lifecycle events (e.g., started, succeeded, failed),
 # allowing the exporter to track task execution metrics and durations.
 worker_send_task_events = True
 

src/summary/summary/core/celery_worker.py

@@ -37,7 +37,7 @@ celery = Celery(
     broker_connection_retry_on_startup=True,
 )
 
-celery.config_from_object("summary.core.celery_config")
+celery.config_from_object('summary.core.celery_config')
 
 if settings.sentry_dsn and settings.sentry_is_enabled: