Compare commits

..

10 Commits

Author SHA1 Message Date
Florent Chehab 53a139fe58 📝(changelog) document summary privacy improvements
Record signed URL protection, secret-aware validation errors and safer
logging and Sentry capture under Unreleased.

Document the retention of redacted frame locals and application DEBUG
diagnostics.
2026-10-27 14:39:05 +01:00
Florent Chehab e1cc318d07 🔒️(summary) scrub Sentry events and breadcrumbs
Redact signed URLs and remove untrusted exception messages, request
bodies and breadcrumb payloads from Sentry events and transactions.

Preserve stack-frame locals after the existing content scrubber runs.
Cover real HTTP failures, chained exceptions and DEBUG breadcrumbs.
2026-10-27 14:39:05 +01:00
Florent Chehab fdc9f6ec9e 🔒️(summary) hide sensitive Celery task details
Publish redacted task argument representations and filter task results
and exception details from INFO-and-above Celery trace logs.

Keep task identity and DEBUG diagnostics available.
2026-10-27 14:39:05 +01:00
Florent Chehab 8b06e0d2f9 🔒️(summary) sanitize analytics client failures
Avoid chaining raw analytics client errors or logging feature-flag
exception messages. Preserve event metadata and feature-flag fallback
behavior.
2026-10-27 14:39:05 +01:00
Florent Chehab 84459eac35 🔒️(summary) sanitize LLM failures and summary progress logs
Raise safe LLM errors for upstream failures and invalid structured
responses without retaining the original exception chain.

Keep generated section titles out of INFO progress logs and preserve
the existing DEBUG diagnostics.
2026-10-27 14:39:05 +01:00
Florent Chehab 20469913ab 🔒️(summary) sanitize upstream HTTP failures
Replace raw download, transcription, webhook and Docs exceptions with
safe messages while preserving retryable exception categories.

Retain document IDs and DEBUG responses. Give webhook regression tests
their own tenant settings instead of relying on development tenants.
2026-10-27 14:29:04 +01:00
Florent Chehab 4ce6c96085 🔒️(summary) clean validation errors at application boundaries
Use cleaned validation errors for task execution, prerun signals,
transcription responses and API results. Share the same cleanup with
FastAPI validation responses while retaining ordinary input values.

Verify secret masking, preserved diagnostics and summary retries.
2026-10-27 14:29:04 +01:00
Florent Chehab 59aecb550f 🔒️(summary) protect signed URL model fields with SecretStr
Validate signed URLs as secrets and reveal them explicitly for file
access, Celery messages, webhook delivery and authorized API responses.

Cover model representations, nested broker payloads and URL consumers.
2026-10-27 14:29:04 +01:00
Florent Chehab a2c13cec46 🔒️(summary) add secret-aware validation errors
Preserve Pydantic error categories and diagnostics while masking nested
SecretStr inputs and avoiding retained validator exception objects.

Support custom error codes and safe pickling for Celery.
2026-10-27 14:29:04 +01:00
Florent Chehab 2a9c99003c 🔒️(summary) redact signed URLs in source logs and analytics
Strip URL credentials, query strings and fragments from file-service
logs and analytics source metadata using one shared helper.

Cover malformed URLs, non-string inputs and signed source URLs.
2026-10-27 13:54:32 +01:00
110 changed files with 1572 additions and 1791 deletions
+8 -11
View File
@@ -2,22 +2,19 @@
# Review regularly and remove entries once Debian ships a fix.
# util-linux
CVE-2026-76642 exp:2026-12-05
CVE-2026-78408 exp:2026-12-05
CVE-2026-78409 exp:2026-12-05
CVE-2026-78410 exp:2026-12-05
CVE-2026-76642
CVE-2026-78408
CVE-2026-78409
CVE-2026-78410
# acl
CVE-2026-54369 exp:2026-12-05
CVE-2026-54369
# ncurses
CVE-2025-69720 exp:2026-12-05
CVE-2025-69720
# systemd
CVE-2026-16742 exp:2026-12-05
CVE-2026-16742
# perl-base (fix deferred by Debian)
CVE-2026-9538 exp:2026-12-05
# libsqlite3-0 (fixed in sid 3.54.1-1; trixie marked no-dsa / minor)
CVE-2026-119373 exp:2026-12-05
CVE-2026-9538
+7 -23
View File
@@ -8,32 +8,16 @@ and this project adheres to
## [Unreleased]
### Added
- ✨(frontend) add jittered exponential backoff to LiveKit reconnections
- ✨(frontend) tell participants when a recording is interrupted
### Changed
- ⬆️(frontend) upgrade livekit-client to 2.23.0
- ✨(backend) expose LiveKit reconnection settings in the config
- ✨(backend) keep recordings cut short by LiveKit egress
- ⬆️(dev) upgrade LiveKit server to v1.13.11 and egress to v1.15.0
### Fixed
- 🐛(frontend) show a page when the connection ends unexpectedly
- 🐛(frontend) show the transcript mic hint when every mic is muted
## [1.37.0] - 2026-11-01
### Changed
- ⬆️(summary) update ffmpeg to 8.1.3-r0
- ✨(frontend) replace the Crisp chat with the La Suite support form
- 🔒️(frontend) keep rooms out of search engine and AI indexes
- ⬆️(backend) upgrade django-lasuite to v1.0.0
- ⚡️(docker) build frontend assets natively for arm64 images
### Fixed
- 🔒️(summary) protect signed URLs in models, source logs and analytics metadata
- 🔒️(summary) mask secret validation inputs and sanitize upstream and task errors
- 🔒️(summary) scrub sensitive Sentry event and breadcrumb content while retaining
redacted frame locals and application DEBUG diagnostics
## [1.36.3] - 2026-10-23
-24
View File
@@ -16,30 +16,6 @@ the following command inside your docker container:
## [Unreleased]
## v1.37.0
### Crisp support chat replaced by the La Suite support form
The Crisp chat is gone, the support button, now open the La Suite support form. They are hidden unless these `FRONTEND_SUPPORT` keys are all set.
The former help links for recording/transcription are now redirecting to the adhoc page in the official documentation
### Pages hidden from search engines
Every page except `/` now carries a `noindex` tag and, with the provided nginx configurations, an `X-Robots-Tag` header to stay out of search indexes.
A new `robots.txt` also blocks the main AI crawlers. If you maintain your own nginx configuration, copy the `location = /` and `location = /home.html` blocks from `src/frontend/default.conf`, and the `X-Robots-Tag` header from its `location /`.
### LiveKit server v1.13.11 and egress v1.15.0
The development stack now runs LiveKit server v1.13.11 and LiveKit Egress v1.15.0. When upgrading your own deployment:
- Deploy this release of Meet first, then upgrade egress, then the server. Older Meet releases discard the partial recordings described below.
- Transcripts no longer go through Chrome. Since egress v1.13, audio-only recordings always use the egress SDK pipeline.
- A transcript now waits for actual audio: it stays "starting", and participants are asked to turn on their microphone, while every microphone is muted.
- Recordings cut short are now kept. Since egress v1.14, a transcript that lost the room, or any recording drained because its egress host ran out of CPU, still uploads what it recorded, even though egress may report it as failed. Meet saves and processes it as usual, and tells participants the recording was interrupted. A screen recording that loses the room is still reported as complete, and saved without a warning.
- Telephony: since server v1.13.8, a call that matches no dispatch rule, for example while no room is active, is rejected with a SIP 404 instead of being silently dropped.
## [v1.35.0]
### Purging deleted rooms
Deleting a room now only soft deletes it: it is hidden but keeps its slug and PIN code. The `purge_inactive_rooms` command also permanently deletes soft-deleted rooms. See [the room purge documentation](docs/features/room-purge.md).
+2 -2
View File
@@ -218,7 +218,7 @@ services:
- kc_postgresql
livekit:
image: livekit/livekit-server:v1.13.11
image: livekit/livekit-server:v1.13.6
entrypoint: /livekit-server --dev --bind 0.0.0.0 --config ./config.yaml
ports:
- "7880:7880"
@@ -233,7 +233,7 @@ services:
- livekit-egress
livekit-egress:
image: livekit/egress:v1.15.0
image: livekit/egress:v1.11.0
environment:
EGRESS_CONFIG_FILE: ./livekit-egress.yaml
volumes:
-12
View File
@@ -38,17 +38,6 @@ server {
add_header Cache-Control "public, max-age=2592000";
}
location = / {
try_files /home.html /index.html;
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache";
add_header Expires 0;
}
location = /home.html {
internal;
}
# Serve static files
location / {
try_files $uri $uri/ /index.html;
@@ -56,7 +45,6 @@ server {
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache"; # HTTP 1.0 header for backward compatibility
add_header Expires 0;
add_header X-Robots-Tag "noindex, nofollow" always;
}
# Optionally, handle 404 errors by redirecting to index.html
+3 -4
View File
@@ -1,5 +1,5 @@
# ---- Front-end image ----
FROM --platform=$BUILDPLATFORM node:22.23.4-alpine AS frontend-deps
FROM node:22.23.4-alpine AS frontend-deps
RUN apk upgrade --no-cache ca-certificates
@@ -41,7 +41,7 @@ COPY ./docker/dinum-frontend/fonts/ \
./dist/assets/fonts/
# ---- Addons builder image ----
FROM --platform=$BUILDPLATFORM node:22.23.4-alpine AS addons-builder
FROM node:22.23.4-alpine AS addons-builder
RUN apk upgrade --no-cache ca-certificates
@@ -65,8 +65,7 @@ RUN apk upgrade --no-cache libexpat && \
apk add --no-cache --upgrade 'pcre2>=10.49-r0' 'tiff>=4.7.2-r0' \
'libx11>=1.8.14-r0' 'ca-certificates>=20261020-r0' \
'brotli-libs>=1.2.1-r0' && \
apk del curl && \
rm -f /usr/share/nginx/html/50x.html
apk del curl
USER nginx
USER nginx
-13
View File
@@ -43,7 +43,6 @@ server {
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache" always;
add_header Expires 0 always;
add_header X-Robots-Tag "noindex, nofollow" always;
set $ms_domains "https://*.live.com https://*.office.com https://*.microsoft.com https://*.office365.com https://*.sharepoint.com";
@@ -77,17 +76,6 @@ server {
add_header Cache-Control "public, max-age=2592000";
}
location = / {
try_files /home.html /index.html;
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache";
add_header Expires 0;
}
location = /home.html {
internal;
}
# Serve static files
location / {
try_files $uri $uri/ /index.html;
@@ -95,7 +83,6 @@ server {
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache"; # HTTP 1.0 header for backward compatibility
add_header Expires 0;
add_header X-Robots-Tag "noindex, nofollow" always;
}
# Optionally, handle 404 errors by redirecting to index.html
+1 -1
View File
@@ -1,4 +1,4 @@
FROM livekit/livekit-server:v1.13.11
FROM livekit/livekit-server:v1.13.6
# We inject the nip.io certificate manually because the livekit chart doesn't support volume mounting
COPY rootCA.pem /etc/ssl/certs/
+1 -2
View File
@@ -1,5 +1,4 @@
logging:
level: debug
log_level: debug
api_key: devkey
api_secret: secret
ws_url: "ws://livekit:7880"
+1 -1
View File
@@ -37,7 +37,7 @@ $ make help
---
## Need Help?
If you need any assistance or have questions while getting started, feel free to reach out to @lebaudantoine anytime! Antoine is available to help you onboard and guide you through the process. Chat with him @antoine.lebaud:matrix.org, or by email at [support-visio@numerique.gouv.fr](mailto:support-visio@numerique.gouv.fr).
If you need any assistance or have questions while getting started, feel free to reach out to @lebaudantoine anytime! Antoine is available to help you onboard and guide you through the process. Chat with him @antoine.lebaud:matrix.org, or from the [support hotline](https://go.crisp.chat/chat/embed/?website_id=58ea6697-8eba-4492-bc59-ad6562585041).
---
+4 -13
View File
@@ -11,23 +11,14 @@ We do not cover internal signaling behavior. For full reference, see the [LiveKi
> [!IMPORTANT]
> The WebSocket is the backbone of LiveKit signaling. All signaling messages rely on it, and without it, ICE candidate exchange and peer connection setup cannot occur. If the WebSocket connection is lost, the client automatically attempts to resume the RTC session once connectivity is restored.
## Reconnection
When the WebSocket drops, for instance after a LiveKit node crash or during a Redis outage, every client in every room loses it at the same time. To keep them from all reconnecting at once, each client waits a random delay before every attempt. The first delay is at most `LIVEKIT_RECONNECT_BASE_DELAY_MS`. That ceiling then doubles after each failed attempt, capped at `LIVEKIT_RECONNECT_MAX_DELAY_MS`, and each later delay falls between half the ceiling and the ceiling. The first attempt always starts within 5 seconds of the drop.
A client gives up once its reconnection has lasted longer than `LIVEKIT_RECONNECT_GIVE_UP_AFTER_MS`, and then shows a "connection lost" page. While only signaling is down and its media still flows, it keeps trying instead. A client that loses the connection again less than `LIVEKIT_RECONNECT_BACKOFF_RESET_MS` after reconnecting resumes the backoff one step above where it stopped.
## Environment Variables
| Variable | Type | Default | Purpose |
| ----------------------------------------- | ------- | -------- | --------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `LIVEKIT_FORCE_WSS_PROTOCOL` | Boolean | `False` | Forces the WebSocket URL to use `wss://`. Required for legacy browsers (Firefox <124, Chrome <125, Edge <125) where HTTPS URLs in `WebSocket()` may fail. |
| `LIVEKIT_ENABLE_FIREFOX_PROXY_WORKAROUND` | Boolean | `False` | Workaround for Firefox clients behind proxies that fail to establish WebSocket connections. Pre-establishes a dummy connection to “prime” the WebSocket. |
| `LIVEKIT_RECONNECT_BACKOFF_ENABLED` | Boolean | `True` | Enables the reconnection backoff described above. When `False`, clients use LiveKit's default reconnection policy. |
| `LIVEKIT_RECONNECT_BASE_DELAY_MS` | Integer | `1000` | Longest wait before the first reconnection attempt, in milliseconds. It doubles after each failed attempt. Must be greater than 0. |
| `LIVEKIT_RECONNECT_MAX_DELAY_MS` | Integer | `10000` | Longest wait between two reconnection attempts, in milliseconds. Must be greater than 0. |
| `LIVEKIT_RECONNECT_GIVE_UP_AFTER_MS` | Integer | `180000` | How long a client keeps trying to reconnect, in milliseconds. Not applied while its media still flows. Must be greater than 0. |
| `LIVEKIT_RECONNECT_BACKOFF_RESET_MS` | Integer | `120000` | How long a connection must stay up, in milliseconds, for the next reconnection to start from the shortest delay again. With `0`, every reconnection does. |
| Variable | Type | Default | Purpose |
| ----------------------------------------- | ------- | ------- | --------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `LIVEKIT_FORCE_WSS_PROTOCOL` | Boolean | `True` | Forces the WebSocket URL to use `wss://`. Required for legacy browsers (Firefox <124, Chrome <125, Edge <125) where HTTPS URLs in `WebSocket()` may fail. |
| `LIVEKIT_ENABLE_FIREFOX_PROXY_WORKAROUND` | Boolean | `True` | Workaround for Firefox clients behind proxies that fail to establish WebSocket connections. Pre-establishes a dummy connection to “prime” the WebSocket. |
> [!NOTE]
> Questions? Open an issue on [GitHub](https://github.com/suitenumerique/meet/issues/new?assignees=&labels=bug&template=Bug_report.md) or join our [Matrix community](https://matrix.to/#/#meet-official:matrix.org).
+1 -6
View File
@@ -348,7 +348,7 @@ These are the environmental options available on meet backend.
| CSRF_TRUSTED_ORIGINS | CSRF trusted origins list | [] |
| FRONTEND_CUSTOM_CSS_URL | URL of an additional CSS file to load in the frontend app. If set, a `<link>` tag with this URL as href is added to the `<head>` of the frontend app | |
| FRONTEND_ANALYTICS | Analytics information | {} |
| FRONTEND_SUPPORT | La Suite support form (`widget_script_url`, `widget_api_url`, `widget_channel`) and help articles (`help_article_*`) | {} |
| FRONTEND_SUPPORT | Crisp frontend support configuration, also you can pass help articles, with `help_article_transcript`, `help_article_recording`, `help_article_more_tools` | {} |
| FRONTEND_MANIFEST_LINK | Link to the "Learn more" button on the homepage | {} |
| FRONTEND_SILENCE_LIVEKIT_DEBUG | Silence LiveKit debug logs | false |
| FRONTEND_IS_SILENT_LOGIN_ENABLED | Enable silent login feature | true |
@@ -413,11 +413,6 @@ These are the environmental options available on meet backend.
| LIVEKIT_API_TIMEOUT_SECONDS | Seconds before a call to the LiveKit API gives up | 10 |
| LIVEKIT_FORCE_WSS_PROTOCOL | Enables WSS protocol conversion for legacy browser compatibility (Firefox <124, Chrome <125, Edge <125) where HTTPS URLs fail in WebSocket() constructor. | false |
| LIVEKIT_ENABLE_FIREFOX_PROXY_WORKAROUND | Firefox-only connection warmup: pre-calls WebSocket endpoint (expecting 401) to initialize cache, resolving proxy/network connectivity issues. | false |
| LIVEKIT_RECONNECT_BACKOFF_ENABLED | Spread client reconnections with a random exponential backoff. When false, clients use LiveKit's default reconnection policy | true |
| LIVEKIT_RECONNECT_BASE_DELAY_MS | Longest wait before the first reconnection attempt, in milliseconds. It doubles after each failed attempt. Must be greater than 0 | 1000 |
| LIVEKIT_RECONNECT_MAX_DELAY_MS | Longest wait between two reconnection attempts, in milliseconds. Must be greater than 0 | 10000 |
| LIVEKIT_RECONNECT_GIVE_UP_AFTER_MS | How long a client keeps trying to reconnect, in milliseconds. Not applied while its media still flows. Must be greater than 0 | 180000 |
| LIVEKIT_RECONNECT_BACKOFF_RESET_MS | How long a connection must stay up, in milliseconds, for the next reconnection to start from the shortest delay again. With 0, every reconnection does | 120000 |
| RESOURCE_DEFAULT_ACCESS_LEVEL | Default resource access level for rooms | public |
| ALLOW_UNREGISTERED_ROOMS | Allow usage of unregistered rooms | true |
| ROOM_INACTIVITY_DELETION_DAYS | Days without being started after which a room is purged. Unset to never purge | |
@@ -2,7 +2,6 @@
<html lang="fr">
<head>
<meta charset="UTF-8" />
<meta name="robots" content="noindex, nofollow" />
<title data-app-name></title>
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
<script nonce="NONCE_PLACEHOLDER" src="https://appsforoffice.microsoft.com/lib/1/hosted/office.js"></script>
@@ -4,7 +4,6 @@
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="robots" content="noindex, nofollow" />
<title data-app-name></title>
<link rel="stylesheet" href="../styles/spinner.css" />
<script nonce="NONCE_PLACEHOLDER" src="/addons/outlook/config.js"></script>
@@ -4,7 +4,6 @@
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="robots" content="noindex, nofollow" />
<title data-app-name></title>
<link rel="stylesheet" href="taskpane.css" />
<script nonce="NONCE_PLACEHOLDER" src="/addons/outlook/config.js"></script>
@@ -4,7 +4,6 @@
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="robots" content="noindex, nofollow" />
<title data-app-name></title>
<link rel="stylesheet" href="../styles/spinner.css" />
<script nonce="NONCE_PLACEHOLDER" src="/addons/outlook/config.js"></script>
+1 -1
View File
@@ -1,7 +1,7 @@
[project]
name = "agents"
version = "1.37.0"
version = "1.36.3"
requires-python = ">=3.12"
dependencies = [
"livekit-agents==1.7.0",
+1 -1
View File
@@ -9,7 +9,7 @@ resolution-markers = [
[[package]]
name = "agents"
version = "1.37.0"
version = "1.36.3"
source = { virtual = "." }
dependencies = [
{ name = "boto3" },
-7
View File
@@ -86,13 +86,6 @@ def get_frontend_configuration(request):
"enable_firefox_proxy_workaround": settings.LIVEKIT_ENABLE_FIREFOX_PROXY_WORKAROUND,
"default_sources": settings.LIVEKIT_DEFAULT_SOURCES,
"default_video_codec": settings.LIVEKIT_DEFAULT_VIDEO_CODEC,
"reconnect": {
"backoff_enabled": settings.LIVEKIT_RECONNECT_BACKOFF_ENABLED,
"base_delay_ms": settings.LIVEKIT_RECONNECT_BASE_DELAY_MS,
"max_delay_ms": settings.LIVEKIT_RECONNECT_MAX_DELAY_MS,
"give_up_after_ms": settings.LIVEKIT_RECONNECT_GIVE_UP_AFTER_MS,
"backoff_reset_ms": settings.LIVEKIT_RECONNECT_BACKOFF_RESET_MS,
},
},
"allow_unregistered_rooms": settings.ALLOW_UNREGISTERED_ROOMS,
"authenticated_users_can_edit_display_name": (
-4
View File
@@ -27,9 +27,6 @@ class RecordingWorkerEvent(Enum):
COMPLETED = "completed"
# The recording ended on its configured limit, its media file is available.
LIMIT_REACHED = "limit reached"
# The recording ended early without being stopped, its partial media file
# is available.
INTERRUPTED = "interrupted"
# The worker stopped before it ever started recording, there is no media file.
ABORTED = "aborted"
# The worker hit a runtime error once recording had started; its media file
@@ -47,7 +44,6 @@ SUCCESSFUL_EVENTS = frozenset(
{
RecordingWorkerEvent.COMPLETED,
RecordingWorkerEvent.LIMIT_REACHED,
RecordingWorkerEvent.INTERRUPTED,
}
)
@@ -33,7 +33,6 @@ NOTIFICATION_PREFIXES = {
}
NOTIFICATION_SUFFIXES = {
RecordingWorkerEvent.LIMIT_REACHED: "LimitReached",
RecordingWorkerEvent.INTERRUPTED: "Interrupted",
RecordingWorkerEvent.FAILED: "Failed",
RecordingWorkerEvent.ABORTED: "Aborted",
}
@@ -62,29 +61,24 @@ class RecordingEventsService:
"""
@staticmethod
def log_worker_error(recording, event, error=None, error_code=None, details=None):
"""Log FAILED at error level, INTERRUPTED at warning level and expected
ABORTED outcomes at info level."""
def log_worker_error(recording, event, error=None, error_code=None):
"""Log FAILED at error level and expected ABORTED outcomes at info level."""
if event == RecordingWorkerEvent.FAILED:
log = logger.error
elif event == RecordingWorkerEvent.INTERRUPTED:
log = logger.warning
elif event == RecordingWorkerEvent.ABORTED:
log = logger.info
else:
return
log(
"Recording worker reported %s for recording %s (room=%s, mode=%s): %s "
"(error_code=%s, details=%s)",
"Recording worker reported %s for recording %s (room=%s, mode=%s): %s (error_code=%s)",
event.value,
recording.id,
recording.room.id,
recording.mode,
error or "no error reported",
error_code or "no error_code reported",
details or "no details reported",
)
@staticmethod
@@ -202,13 +196,6 @@ class RecordingEventsService:
):
self._apply_outcome(recording, event, self._handle_limit_reached)
# Interrupted
if (
event == RecordingWorkerEvent.INTERRUPTED
and recording.status == models.RecordingStatusChoices.ACTIVE
):
self._apply_outcome(recording, event, self._handle_interrupted)
try:
self._handle_successful(recording)
except RecordingNotSavableError:
@@ -237,20 +224,6 @@ class RecordingEventsService:
cls._notify_participants(recording, RecordingWorkerEvent.LIMIT_REACHED)
@classmethod
def _handle_interrupted(cls, recording: Recording):
"""Stop recording and notify participants that only part of it is saved.
INTERRUPTED: used when the worker ended the recording early on its own
because it lost the room or ran out of resources but kept what it had
recorded so far
"""
recording.status = models.RecordingStatusChoices.STOPPED
recording.save()
cls._notify_participants(recording, RecordingWorkerEvent.INTERRUPTED)
@classmethod
def _handle_failed(cls, recording: Recording):
"""Set recording status to failed, matching the worker event, and notify participants.
+1 -33
View File
@@ -96,9 +96,6 @@ EGRESS_STATUS_TO_RECORDING_EVENT = {
api.EgressStatus.EGRESS_FAILED: RecordingWorkerEvent.FAILED,
}
EGRESS_ROOM_CONNECTION_FAILED_ERROR = "recording ended early: connection to room failed"
EGRESS_CPU_EXHAUSTED_DETAILS = "End reason: CPU exhausted"
def to_recording_event(egress_status):
"""Translate a LiveKit egress status into a recording worker event."""
@@ -112,34 +109,6 @@ def to_recording_event(egress_status):
return event
def to_ended_recording_event(egress_info):
"""Translate an ended LiveKit egress into a recording worker event.
This handles partial media file upload where an egress was interrupted
which can happen when:
- an transcription egress that lost its room connection uploads an audio file, then ends
FAILED with the EGRESS_ROOM_CONNECTION_FAILED_ERROR
- an egress drained because its host ran out of CPU which can transition to COMPLETE state
with EGRESS_CPU_EXHAUSTED_DETAILS or FAILED state if the drain outlasted its grace period
and the egress got killed, possibly before the upload.
"""
status = egress_info.status
is_cut_short = (
egress_info.error == EGRESS_ROOM_CONNECTION_FAILED_ERROR
or egress_info.details == EGRESS_CPU_EXHAUSTED_DETAILS
)
has_uploaded_file = any(file.location for file in egress_info.file_results)
if is_cut_short and (
status == api.EgressStatus.EGRESS_COMPLETE
or (status == api.EgressStatus.EGRESS_FAILED and has_uploaded_file)
):
return RecordingWorkerEvent.INTERRUPTED
return to_recording_event(status)
class LiveKitEventsService:
"""Service for processing and handling LiveKit webhook events and notifications."""
@@ -252,7 +221,7 @@ class LiveKitEventsService:
f"Recording with worker ID {data.egress_info.egress_id} does not exist"
) from err
event = to_ended_recording_event(data.egress_info)
event = to_recording_event(data.egress_info.status)
self._audit_recording_end(recording, event, data.egress_info.error_code)
# Log if/why the recording failed
@@ -261,7 +230,6 @@ class LiveKitEventsService:
event,
error=data.egress_info.error,
error_code=data.egress_info.error_code,
details=data.egress_info.details,
)
# Update room
@@ -50,26 +50,6 @@ def test_handle_limit_reached_success(mock_notify, mode, notification_type, serv
)
@pytest.mark.parametrize(
("mode", "notification_type"),
(
("screen_recording", "screenRecordingInterrupted"),
("transcript", "transcriptionInterrupted"),
),
)
@mock.patch("core.utils.notify_participants")
def test_handle_interrupted_success(mock_notify, mode, notification_type, service):
"""Test _handle_interrupted stops recording and notifies participants."""
recording = RecordingFactory(status="active", mode=mode)
service._handle_interrupted(recording)
assert recording.status == "stopped"
mock_notify.assert_called_once_with(
room_name=str(recording.room.id), notification_data={"type": notification_type}
)
@pytest.mark.parametrize(
("mode", "notification_type"),
(
@@ -242,7 +222,6 @@ def test_handle_update_syncs_room_metadata(
RecordingWorkerEvent.STARTING,
RecordingWorkerEvent.COMPLETED,
RecordingWorkerEvent.LIMIT_REACHED,
RecordingWorkerEvent.INTERRUPTED,
RecordingWorkerEvent.ABORTED,
RecordingWorkerEvent.FAILED,
),
@@ -265,10 +244,6 @@ def test_handle_update_ignores_events_without_a_metadata_status(
(RecordingWorkerEvent.LIMIT_REACHED, "active", "saved", "LimitReached"),
(RecordingWorkerEvent.LIMIT_REACHED, "stopped", "saved", None),
(RecordingWorkerEvent.LIMIT_REACHED, "saved", "saved", None),
(RecordingWorkerEvent.INTERRUPTED, "active", "saved", "Interrupted"),
(RecordingWorkerEvent.INTERRUPTED, "stopped", "saved", None),
(RecordingWorkerEvent.INTERRUPTED, "saved", "saved", None),
(RecordingWorkerEvent.INTERRUPTED, "failed_to_stop", "failed_to_stop", None),
(RecordingWorkerEvent.ABORTED, "active", "aborted", "Aborted"),
(RecordingWorkerEvent.ABORTED, "failed_to_stop", "failed_to_stop", None),
(RecordingWorkerEvent.FAILED, "active", "failed", "Failed"),
@@ -346,7 +321,6 @@ def test_handle_terminal_event_ignores_non_terminal_events(
("event", "expected_status"),
(
(RecordingWorkerEvent.LIMIT_REACHED, "saved"),
(RecordingWorkerEvent.INTERRUPTED, "saved"),
(RecordingWorkerEvent.ABORTED, "aborted"),
(RecordingWorkerEvent.FAILED, "failed"),
),
@@ -433,7 +407,6 @@ def test_handle_update_survives_a_metadata_failure(
("event", "expected_level"),
(
(RecordingWorkerEvent.ABORTED, logging.INFO),
(RecordingWorkerEvent.INTERRUPTED, logging.WARNING),
(RecordingWorkerEvent.FAILED, logging.ERROR),
),
)
@@ -446,11 +419,7 @@ def test_log_worker_error_reports_an_unsuccessful_event(
with caplog.at_level(logging.INFO):
service.log_worker_error(
recording,
event,
error="could not connect to the room",
error_code=500,
details="End reason: Failure",
recording, event, error="could not connect to the room", error_code=500
)
assert (
@@ -459,7 +428,6 @@ def test_log_worker_error_reports_an_unsuccessful_event(
)
assert "could not connect to the room" in caplog.text
assert "error_code=500" in caplog.text
assert "details=End reason: Failure" in caplog.text
worker_logs = [
record
for record in caplog.records
@@ -480,7 +448,7 @@ def test_log_worker_error_reports_an_unsuccessful_event(
),
)
def test_log_worker_error_stays_quiet_on_anything_else(event, service, caplog):
"""Test log_worker_error ignores events other than FAILED, INTERRUPTED and ABORTED."""
"""Test log_worker_error ignores events other than FAILED and ABORTED."""
recording = RecordingFactory(status="active")
@@ -8,12 +8,9 @@ import hashlib
import json
from unittest import mock
from django.utils import timezone
import pytest
from livekit import api
from ...factories import RecordingFactory
from ...services.livekit_events import ActionFailedError, LiveKitEventsService
@@ -187,75 +184,3 @@ def test_action_error(client, mock_livekit_config):
content_type="application/json",
HTTP_AUTHORIZATION=auth_token,
)
@pytest.mark.django_db
@mock.patch(
"core.recording.services.recording_events.notification_service."
"notify_external_services",
return_value=False,
)
@mock.patch("core.utils.notify_participants")
@mock.patch("core.services.room_management.RoomManagement.update_metadata")
def test_egress_ended_keeps_a_partial_transcript(
mock_update_metadata,
mock_notify,
mock_notify_external_services,
client,
mock_livekit_config,
):
"""Should save a transcript whose egress lost the room but uploaded its file.
LiveKit Egress v1.14 reports it as failed. The payload mirrors the one it
sends, including a field unknown to the pinned livekit-protocol, which
must be ignored rather than rejected.
"""
recording = RecordingFactory(
worker_id="EG_hycBMAjmt6Ub", mode="transcript", status="active"
)
event_data = json.dumps(
{
"event": "egress_ended",
"egressInfo": {
"egressId": "EG_hycBMAjmt6Ub",
"roomId": "RM_hycBMAjmt6Ub",
"roomName": str(recording.room.id),
"status": "EGRESS_FAILED",
"error": "recording ended early: connection to room failed",
"errorCode": 503,
"details": "End reason: Source closed",
"fileResults": [
{
"filename": f"recordings/{recording.id}.ogg",
"location": f"https://s3.example.com/recordings/{recording.id}.ogg",
"size": "123456",
}
],
},
"id": "EV_eugWmGhovZmm",
"createdAt": str(int(timezone.now().timestamp())),
}
)
hash64 = base64.b64encode(hashlib.sha256(event_data.encode()).digest()).decode()
token = api.AccessToken(
mock_livekit_config["api_key"], mock_livekit_config["api_secret"]
)
token.claims.sha256 = hash64
response = client.post(
"/api/v1.0/rooms/webhooks-livekit/",
data=event_data,
content_type="application/json",
HTTP_AUTHORIZATION=token.to_jwt(),
)
assert response.status_code == 200
mock_notify.assert_called_once_with(
room_name=str(recording.room.id),
notification_data={"type": "transcriptionInterrupted"},
)
mock_notify_external_services.assert_called_once_with(recording)
recording.refresh_from_db()
assert recording.status == "saved"
@@ -1,7 +1,7 @@
"""
Test LiveKitEvents service.
"""
# pylint: disable=W0621,W0613, W0212, E0611, E1101, C0302
# pylint: disable=W0621,W0613, W0212, E0611, C0302
import logging
import uuid
@@ -11,7 +11,6 @@ from unittest import mock
from django.utils import timezone
import pytest
from faker import Faker
from livekit.api import EgressStatus
from core.audit.testing import find_events
@@ -20,15 +19,12 @@ from core.models import Room
from core.recording.enums import RecordingWorkerEvent
from core.recording.services.recording_events import RecordingEventsService
from core.services.livekit_events import (
EGRESS_CPU_EXHAUSTED_DETAILS,
EGRESS_ROOM_CONNECTION_FAILED_ERROR,
EGRESS_STATUS_TO_RECORDING_EVENT,
ActionFailedError,
AuthenticationError,
InvalidPayloadError,
LiveKitEventsService,
api,
to_ended_recording_event,
to_recording_event,
)
from core.services.lobby import LobbyService
@@ -43,7 +39,6 @@ from core.services.sip_management import (
from core.utils import NotificationError
pytestmark = pytest.mark.django_db
fake = Faker()
@pytest.fixture
@@ -499,228 +494,6 @@ def test_to_recording_event_returns_none_on_unmapped_status(caplog):
assert "Unmapped LiveKit egress status" in caplog.text
recording_filename = f"recordings/{fake.file_name(extension='ogg')}"
UPLOADED_FILE = api.FileInfo(
filename=recording_filename,
location=f"https://storage.example.com/{recording_filename}",
size=1048576,
)
NOT_UPLOADED_FILE = api.FileInfo(filename=recording_filename)
ROOM_CONNECTION_FAILED = {
"status": EgressStatus.EGRESS_FAILED,
"error": EGRESS_ROOM_CONNECTION_FAILED_ERROR,
"error_code": 503,
"details": "End reason: Source closed",
}
CPU_EXHAUSTED_DRAINED = {
"status": EgressStatus.EGRESS_COMPLETE,
"details": EGRESS_CPU_EXHAUSTED_DETAILS,
}
CPU_EXHAUSTED_KILLED = {
"status": EgressStatus.EGRESS_FAILED,
"error": "CPU exhausted: 8.5 cores used",
"error_code": 403,
"details": EGRESS_CPU_EXHAUSTED_DETAILS,
}
@pytest.mark.parametrize(
("egress_info", "expected_event"),
(
(
api.EgressInfo(**ROOM_CONNECTION_FAILED, file_results=[UPLOADED_FILE]),
RecordingWorkerEvent.INTERRUPTED,
),
(
api.EgressInfo(**ROOM_CONNECTION_FAILED, file_results=[NOT_UPLOADED_FILE]),
RecordingWorkerEvent.FAILED,
),
(
api.EgressInfo(**CPU_EXHAUSTED_DRAINED, file_results=[UPLOADED_FILE]),
RecordingWorkerEvent.INTERRUPTED,
),
(
api.EgressInfo(**CPU_EXHAUSTED_KILLED, file_results=[UPLOADED_FILE]),
RecordingWorkerEvent.INTERRUPTED,
),
(
api.EgressInfo(**CPU_EXHAUSTED_KILLED, file_results=[NOT_UPLOADED_FILE]),
RecordingWorkerEvent.FAILED,
),
# Other failures stay failures, even with an uploaded file.
(
api.EgressInfo(
status=EgressStatus.EGRESS_FAILED,
error="pipeline frozen",
error_code=500,
details="End reason: Source closed",
file_results=[UPLOADED_FILE],
),
RecordingWorkerEvent.FAILED,
),
(
api.EgressInfo(
status=EgressStatus.EGRESS_COMPLETE,
details="End reason: StopEgress API",
file_results=[UPLOADED_FILE],
),
RecordingWorkerEvent.COMPLETED,
),
(
api.EgressInfo(
status=EgressStatus.EGRESS_ABORTED,
error="Stop called before pipeline could start",
error_code=412,
details="End reason: StopEgress API",
),
RecordingWorkerEvent.ABORTED,
),
(
api.EgressInfo(
status=EgressStatus.EGRESS_LIMIT_REACHED,
error="Session limit reached",
error_code=413,
details="End reason: Session limit reached",
file_results=[UPLOADED_FILE],
),
RecordingWorkerEvent.LIMIT_REACHED,
),
),
)
def test_to_ended_recording_event_translates_egress_info(egress_info, expected_event):
"""Should tell an egress cut short with a partial file apart from the others."""
assert to_ended_recording_event(egress_info) == expected_event
@pytest.mark.parametrize(
("mode", "egress_info_kwargs", "notification_type"),
(
("transcript", ROOM_CONNECTION_FAILED, "transcriptionInterrupted"),
("transcript", CPU_EXHAUSTED_DRAINED, "transcriptionInterrupted"),
("screen_recording", CPU_EXHAUSTED_DRAINED, "screenRecordingInterrupted"),
("screen_recording", CPU_EXHAUSTED_KILLED, "screenRecordingInterrupted"),
),
)
@mock.patch(
"core.recording.services.recording_events.notification_service."
"notify_external_services"
)
@mock.patch("core.utils.notify_participants")
@mock.patch("core.services.room_management.RoomManagement.update_metadata")
def test_handle_egress_ended_interrupted_saves_partial_recording( # noqa: PLR0913, PLR0917
mock_update_metadata,
mock_notify,
mock_notify_external_services,
mode,
egress_info_kwargs,
notification_type,
service,
caplog,
): # pylint: disable=too-many-arguments,too-many-positional-arguments
"""Should save an interrupted recording and tell participants it is partial."""
mock_notify_external_services.return_value = True
recording = RecordingFactory(worker_id="worker-1", mode=mode, status="active")
data = api.WebhookEvent(
event="egress_ended",
egress_info=api.EgressInfo(
egress_id=recording.worker_id,
file_results=[UPLOADED_FILE],
**egress_info_kwargs,
),
)
with caplog.at_level(logging.WARNING):
service._handle_egress_ended(data)
mock_notify.assert_called_once_with(
room_name=str(recording.room.id), notification_data={"type": notification_type}
)
mock_notify_external_services.assert_called_once_with(recording)
mock_update_metadata.assert_called_once_with(
str(recording.room.id), remove_keys=["recording_mode", "recording_status"]
)
assert (
f"Recording worker reported interrupted for recording {recording.id}"
in caplog.text
)
recording.refresh_from_db()
assert recording.status == "notification_succeeded"
@mock.patch(
"core.recording.services.recording_events.notification_service."
"notify_external_services"
)
@mock.patch("core.utils.notify_participants")
@mock.patch("core.services.room_management.RoomManagement.update_metadata")
def test_handle_egress_ended_interrupted_after_stop_does_not_notify_participants(
mock_update_metadata, mock_notify, mock_notify_external_services, service
):
"""Shouldn't notify participants about a recording they already stopped."""
mock_notify_external_services.return_value = False
recording = RecordingFactory(worker_id="worker-1", status="stopped")
data = api.WebhookEvent(
event="egress_ended",
egress_info=api.EgressInfo(
egress_id=recording.worker_id,
file_results=[UPLOADED_FILE],
**CPU_EXHAUSTED_DRAINED,
),
)
service._handle_egress_ended(data)
mock_notify.assert_not_called()
mock_notify_external_services.assert_called_once_with(recording)
recording.refresh_from_db()
assert recording.status == "saved"
@mock.patch("core.utils.notify_participants")
@mock.patch("core.services.room_management.RoomManagement.update_metadata")
def test_handle_egress_ended_failed_on_another_error_discards_recording(
mock_update_metadata, mock_notify, service
):
"""Should still flag as failed an egress that failed for another reason."""
recording = RecordingFactory(
worker_id="worker-1", mode="transcript", status="active"
)
data = api.WebhookEvent(
event="egress_ended",
egress_info=api.EgressInfo(
egress_id=recording.worker_id,
status=EgressStatus.EGRESS_FAILED,
error="pipeline frozen",
error_code=500,
details="End reason: Source closed",
file_results=[UPLOADED_FILE],
),
)
service._handle_egress_ended(data)
mock_notify.assert_called_once_with(
room_name=str(recording.room.id),
notification_data={"type": "transcriptionFailed"},
)
recording.refresh_from_db()
assert recording.status == "failed"
@mock.patch("core.services.room_management.RoomManagement.update_metadata")
def test_handle_egress_updated_ignores_unmapped_status(mock_update_metadata, service):
"""Shouldn't touch the room's metadata when the egress status is unknown."""
@@ -1,40 +0,0 @@
"""Test the LiveKit reconnection settings exposed by the config endpoint."""
import pytest
from rest_framework.test import APIClient
pytestmark = pytest.mark.django_db
def test_api_config_retrieve_livekit_reconnect_defaults():
"""Without any override, the frontend gets the default backoff."""
response = APIClient().get("/api/v1.0/config/")
assert response.status_code == 200
assert response.json()["livekit"]["reconnect"] == {
"backoff_enabled": True,
"base_delay_ms": 1000,
"max_delay_ms": 10000,
"give_up_after_ms": 180000,
"backoff_reset_ms": 120000,
}
def test_api_config_retrieve_livekit_reconnect_settings(settings):
"""Each reconnection setting reaches the frontend unchanged."""
settings.LIVEKIT_RECONNECT_BACKOFF_ENABLED = False
settings.LIVEKIT_RECONNECT_BASE_DELAY_MS = 500
settings.LIVEKIT_RECONNECT_MAX_DELAY_MS = 30000
settings.LIVEKIT_RECONNECT_GIVE_UP_AFTER_MS = 600000
settings.LIVEKIT_RECONNECT_BACKOFF_RESET_MS = 60000
response = APIClient().get("/api/v1.0/config/")
assert response.status_code == 200
assert response.json()["livekit"]["reconnect"] == {
"backoff_enabled": False,
"base_delay_ms": 500,
"max_delay_ms": 30000,
"give_up_after_ms": 600000,
"backoff_reset_ms": 60000,
}
@@ -184,7 +184,7 @@ def test_api_rooms_list_with_application_disabled(mock_rs_authenticate, settings
@responses.activate
def test_api_rooms_list_with_invalid_rs_token(settings):
"""Listing rooms with invalid resource server token should return 401."""
"""Listing rooms with invalid resource server token should return 400."""
settings.OIDC_OP_INTROSPECTION_ENDPOINT = "https://oidc.example.com/introspect"
settings.OIDC_OP_URL = "https://oidc.example.com"
@@ -202,8 +202,9 @@ def test_api_rooms_list_with_invalid_rs_token(settings):
client.credentials(HTTP_AUTHORIZATION="Bearer invalid-token-123")
response = client.get("/external-api/v1.0/rooms/")
assert response.status_code == 401
assert "introspected user is not active" in str(response.data).lower()
# Return 400 instead of 401 because ResourceServerAuthentication raises
# SuspiciousOperation when the introspected user is not active
assert response.status_code == 400
def test_api_rooms_list_missing_scope():
@@ -421,7 +422,7 @@ def test_api_rooms_retrieve_with_expired_token(settings):
@responses.activate
def test_api_rooms_retrieve_with_invalid_rs_token(settings):
"""Retrieving rooms with invalid resource server token should return 401."""
"""Retrieving rooms with invalid resource server token should return 400."""
settings.OIDC_OP_INTROSPECTION_ENDPOINT = "https://oidc.example.com/introspect"
settings.OIDC_OP_URL = "https://oidc.example.com"
@@ -442,8 +443,9 @@ def test_api_rooms_retrieve_with_invalid_rs_token(settings):
client.credentials(HTTP_AUTHORIZATION="Bearer invalid-token-123")
response = client.get(f"/external-api/v1.0/rooms/{room.id}/")
assert response.status_code == 401
assert "introspected user is not active" in str(response.data).lower()
# Return 400 instead of 401 because ResourceServerAuthentication raises
# SuspiciousOperation when the introspected user is not active
assert response.status_code == 400
def test_api_rooms_retrieve_requires_scope():
@@ -645,7 +647,7 @@ def test_api_rooms_create_with_expired_token(settings):
@responses.activate
def test_api_rooms_create_with_invalid_rs_token(settings):
"""Creating rooms with invalid resource server token should return 401."""
"""Creating rooms with invalid resource server token should return 400."""
settings.OIDC_OP_INTROSPECTION_ENDPOINT = "https://oidc.example.com/introspect"
settings.OIDC_OP_URL = "https://oidc.example.com"
@@ -663,8 +665,9 @@ def test_api_rooms_create_with_invalid_rs_token(settings):
client.credentials(HTTP_AUTHORIZATION="Bearer invalid-token-123")
response = client.post("/external-api/v1.0/rooms/")
assert response.status_code == 401
assert "introspected user is not active" in str(response.data).lower()
# Return 400 instead of 401 because ResourceServerAuthentication raises
# SuspiciousOperation when the introspected user is not active
assert response.status_code == 400
def test_api_rooms_create_inactive_user():
@@ -2968,36 +2971,6 @@ def test_api_rooms_missing_token_is_audited_as_denial(audit_events):
assert event["url"]["path"] == "/external-api/v1.0/rooms/"
@responses.activate
def test_api_rooms_invalid_rs_token_is_audited_as_denial(audit_events, settings):
"""A token refused by the identity provider is recorded as a denial."""
settings.OIDC_OP_INTROSPECTION_ENDPOINT = "https://oidc.example.com/introspect"
settings.OIDC_OP_URL = "https://oidc.example.com"
responses.add(
responses.POST,
"https://oidc.example.com/introspect",
json={"iss": "https://oidc.example.com", "active": False},
)
client = APIClient()
client.credentials(HTTP_AUTHORIZATION="Bearer invalid-token-123")
response = client.get("/external-api/v1.0/rooms/")
assert response.status_code == 401
assert response.headers["WWW-Authenticate"] == "Bearer"
responses.assert_call_count("https://oidc.example.com/introspect", 1)
[event] = find_events(audit_events, "room.list")
assert event["event"]["category"] == ["api", "authentication"]
assert event["event"]["reason"] == "authentication_failed"
assert event["lasuite"]["outcome"] == "denied"
assert event["lasuite"]["actor"] == {"type": "anonymous"}
assert event["http"]["response"] == {"status_code": 401}
assert event["error"]["message"] == response.json()["detail"]
def test_api_rooms_missing_scope_is_audited_as_denial(audit_events):
"""A token without the required scope is a permission denial by the application."""
user = UserFactory()
@@ -1,24 +0,0 @@
"""Unit tests for the value of the LiveKit reconnection delay settings."""
import pytest
from meet.settings import StrictlyPositiveIntegerValue
@pytest.mark.parametrize("raw,expected", [("1", 1), (" 15000 ", 15000)])
def test_strictly_positive_integer_value_parses(raw, expected):
"""A delay above 0 is read as an integer."""
assert StrictlyPositiveIntegerValue(environ=False).to_python(raw) == expected
def test_strictly_positive_integer_value_rejects_zero():
"""0 stops the settings module loading, unlike with PositiveIntegerValue."""
with pytest.raises(ValueError, match="greater than 0"):
StrictlyPositiveIntegerValue(environ=False).to_python("0")
@pytest.mark.parametrize("raw", ["-1", "1e3", "1000ms", ""])
def test_strictly_positive_integer_value_rejects_invalid(raw):
"""A negative or non-integer value stops the settings module loading."""
with pytest.raises(ValueError):
StrictlyPositiveIntegerValue(environ=False).to_python(raw)
-33
View File
@@ -68,17 +68,6 @@ class VideoCodecValue(values.Value):
return codec
class StrictlyPositiveIntegerValue(values.PositiveIntegerValue):
"""An integer greater than 0"""
def to_python(self, value):
"""Ensure the integer is greater than 0."""
int_value = super().to_python(value)
if int_value == 0:
raise ValueError(f"Expected an integer greater than 0, got {value!r}.")
return int_value
class ResolutionSpec(BaseModel):
"""An value of RECORDING_ENCODING_AVAILABLE_RESOLUTIONS."""
@@ -798,28 +787,6 @@ class Base(Configuration):
LIVEKIT_DEFAULT_VIDEO_CODEC = VideoCodecValue(
"vp9", environ_name="LIVEKIT_DEFAULT_VIDEO_CODEC", environ_prefix=None
)
# Livekit websocket reconnection exponential backoff config sent to the frontend.
# Before its first reconnection attempt, a client waits a random delay up to the base
# delay. That ceiling doubles after every failed attempt, capped at the max delay, and
# later delays fall between half the ceiling and the ceiling.
# It gives up after the give-up delay unless the media still flows.
# After a successful reconnection, a new disconnection starting sooner than the reset
# delay after the last one resumes the backoff one step above where that one stopped.
LIVEKIT_RECONNECT_BACKOFF_ENABLED = values.BooleanValue(
True, environ_name="LIVEKIT_RECONNECT_BACKOFF_ENABLED", environ_prefix=None
)
LIVEKIT_RECONNECT_BASE_DELAY_MS = StrictlyPositiveIntegerValue(
1000, environ_name="LIVEKIT_RECONNECT_BASE_DELAY_MS", environ_prefix=None
)
LIVEKIT_RECONNECT_MAX_DELAY_MS = StrictlyPositiveIntegerValue(
10000, environ_name="LIVEKIT_RECONNECT_MAX_DELAY_MS", environ_prefix=None
)
LIVEKIT_RECONNECT_GIVE_UP_AFTER_MS = StrictlyPositiveIntegerValue(
180000, environ_name="LIVEKIT_RECONNECT_GIVE_UP_AFTER_MS", environ_prefix=None
)
LIVEKIT_RECONNECT_BACKOFF_RESET_MS = values.PositiveIntegerValue(
120000, environ_name="LIVEKIT_RECONNECT_BACKOFF_RESET_MS", environ_prefix=None
)
CONNECTION_TEST_ENABLED = values.BooleanValue(
environ_name="CONNECTION_TEST_ENABLED",
environ_prefix=None,
+2 -2
View File
@@ -7,7 +7,7 @@ build-backend = "uv_build"
[project]
name = "meet"
version = "1.37.0"
version = "1.36.3"
authors = [{ "name" = "DINUM", "email" = "dev@mail.numerique.gouv.fr" }]
classifiers = [
"Development Status :: 5 - Production/Stable",
@@ -33,7 +33,7 @@ dependencies = [
"django-cors-headers==4.9.0",
"django-countries==9.0.0",
"django-filter==26.1",
"django-lasuite[all]==1.0.0",
"django-lasuite[all]==0.0.29",
"django-parler==2.4",
"redis==5.2.1",
"django-redis==7.0.0",
+11 -22
View File
@@ -837,28 +837,26 @@ wheels = [
[[package]]
name = "django-lasuite"
version = "1.0.0"
version = "0.0.29"
source = { registry = "https://pypi.org/simple" }
dependencies = [
{ name = "django" },
{ name = "djangorestframework" },
{ name = "joserfc" },
{ name = "mozilla-django-oidc" },
{ name = "pyjwt" },
{ name = "requests" },
{ name = "requests-toolbelt" },
]
sdist = { url = "https://files.pythonhosted.org/packages/0f/cc/35335b826b039c43da68a0e624e154f60c3ac6c83f01f9b4ad6ce91faf03/django_lasuite-1.0.0.tar.gz", hash = "sha256:8921aaba5a78f1f9728cee2cc4596755478108f17146d4a2fccb393c043a05a3", size = 45815, upload-time = "2026-10-30T14:57:31.764Z" }
sdist = { url = "https://files.pythonhosted.org/packages/f4/ab/72a79b7133fb2d17835bef40f45f7e6d2b4343469c37fd00386122e9068d/django_lasuite-0.0.29.tar.gz", hash = "sha256:831cb859e45e33963c9d89168c2de14f9844e805000b0f0d1512ffd0b9731a39", size = 35248, upload-time = "2026-08-25T13:03:43.597Z" }
wheels = [
{ url = "https://files.pythonhosted.org/packages/a4/6f/d1df3f2881cda711e569b8e685ad3a846ca9c71226340597cee1c09beae0/django_lasuite-1.0.0-py3-none-any.whl", hash = "sha256:23d589be9496b1f484772b49f3c4c4a81e70affd537e3c50abf15303c84d7cb0", size = 68529, upload-time = "2026-10-30T14:57:30.416Z" },
{ url = "https://files.pythonhosted.org/packages/a1/cf/86648643221816f18ebd5a3e59b6d2a85ee85b38b19c7abe939f798a2845/django_lasuite-0.0.29-py3-none-any.whl", hash = "sha256:33bcff90ced2709190ef01241badb17ceed08a32725b9cdd3105650b36da303b", size = 54899, upload-time = "2026-08-25T13:03:42.212Z" },
]
[package.optional-dependencies]
all = [
{ name = "celery" },
{ name = "cryptography" },
{ name = "django-configurations" },
{ name = "djangorestframework" },
{ name = "joserfc" },
{ name = "mozilla-django-oidc" },
{ name = "pyjwt" },
{ name = "python-icap" },
{ name = "requests" },
{ name = "requests-toolbelt" },
]
[[package]]
@@ -1360,7 +1358,7 @@ wheels = [
[[package]]
name = "meet"
version = "1.37.0"
version = "1.36.3"
source = { editable = "." }
dependencies = [
{ name = "aiohttp" },
@@ -1442,7 +1440,7 @@ requires-dist = [
{ name = "django-cors-headers", specifier = "==4.9.0" },
{ name = "django-countries", specifier = "==9.0.0" },
{ name = "django-filter", specifier = "==26.1" },
{ name = "django-lasuite", extras = ["all"], specifier = "==1.0.0" },
{ name = "django-lasuite", extras = ["all"], specifier = "==0.0.29" },
{ name = "django-parler", specifier = "==2.4" },
{ name = "django-pydantic-field", specifier = "==0.5.4" },
{ name = "django-redis", specifier = "==7.0.0" },
@@ -2260,15 +2258,6 @@ wheels = [
{ url = "https://files.pythonhosted.org/packages/a6/a3/17c284b4f4d8ad50f0f9ba70ad8fcc35c777aeafcdbbffdd91bbdc5ab379/python_frontmatter-1.3.0-py3-none-any.whl", hash = "sha256:9f7dd9260bec99044219159a329f64f039087f9d1a2124c9442556f2fe6f82ec", size = 10562, upload-time = "2026-05-20T19:21:43.323Z" },
]
[[package]]
name = "python-icap"
version = "0.2.0"
source = { registry = "https://pypi.org/simple" }
sdist = { url = "https://files.pythonhosted.org/packages/5c/0a/123c30f4041eabb94c587d35fb64aa9498435d028a8577340a4e5adc5224/python_icap-0.2.0.tar.gz", hash = "sha256:627869ac29119074542de6ae95370914854fdb35ee0a13c8ae4c55847cfcb80e", size = 684516, upload-time = "2026-07-08T22:21:58.842Z" }
wheels = [
{ url = "https://files.pythonhosted.org/packages/d8/f2/b437a5e08b94dfc4cd8505cfc3e63922247e9ce3957707550ab08c514560/python_icap-0.2.0-py3-none-any.whl", hash = "sha256:b648d55b68abe387849a124d1b4a443801342a566afd2141f4515953ed4bd738", size = 70680, upload-time = "2026-07-08T22:21:57.307Z" },
]
[[package]]
name = "python-magic"
version = "0.4.27"
+2 -3
View File
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM node:22.23.4-alpine AS frontend-deps
FROM node:22.23.4-alpine AS frontend-deps
RUN apk upgrade --no-cache ca-certificates
@@ -54,8 +54,7 @@ RUN apk upgrade --no-cache libexpat && \
apk add --no-cache --upgrade 'pcre2>=10.49-r0' 'tiff>=4.7.2-r0' \
'libx11>=1.8.14-r0' 'ca-certificates>=20261020-r0' \
'brotli-libs>=1.2.1-r0' && \
apk del curl && \
rm -f /usr/share/nginx/html/50x.html
apk del curl
USER nginx
# Un-privileged user running the application
-12
View File
@@ -16,17 +16,6 @@ server {
add_header Cache-Control "public, max-age=2592000";
}
location = / {
try_files /home.html /index.html;
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache";
add_header Expires 0;
}
location = /home.html {
internal;
}
# Serve static files
location / {
try_files $uri $uri/ /index.html;
@@ -34,7 +23,6 @@ server {
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache"; # HTTP 1.0 header for backward compatibility
add_header Expires 0;
add_header X-Robots-Tag "noindex, nofollow" always;
}
# Optionally, handle 404 errors by redirecting to index.html
-1
View File
@@ -7,7 +7,6 @@
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
<link rel="manifest" href="/site.webmanifest">
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="robots" content="noindex, nofollow" />
<title>%VITE_APP_TITLE%</title>
</head>
<body>
+17 -20
View File
@@ -1,12 +1,12 @@
{
"name": "meet",
"version": "1.37.0",
"version": "1.36.3",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "meet",
"version": "1.37.0",
"version": "1.36.3",
"dependencies": {
"@fontsource-variable/atkinson-hyperlegible-next": "5.3.0",
"@fontsource-variable/lexend": "5.3.0",
@@ -21,13 +21,14 @@
"@remixicon/react": "4.9.0",
"@tanstack/react-query": "5.101.4",
"@timephy/rnnoise-wasm": "1.0.0",
"crisp-sdk-web": "1.1.2",
"hoofd": "1.7.3",
"humanize-duration": "3.34.1",
"i18next": "26.3.6",
"i18next-browser-languagedetector": "8.2.1",
"i18next-parser": "9.4.0",
"i18next-resources-to-backend": "1.2.3",
"livekit-client": "2.23.0",
"livekit-client": "2.21.0",
"posthog-js": "1.418.10",
"react": "18.3.1",
"react-aria": "3.51.0",
@@ -1027,9 +1028,9 @@
"license": "Apache-2.0"
},
"node_modules/@livekit/protocol": {
"version": "1.52.1",
"resolved": "https://registry.npmjs.org/@livekit/protocol/-/protocol-1.52.1.tgz",
"integrity": "sha512-X8DxKlNbzk6Lh+v630+mjdFHSotdAFwIyzxSRSUql2DbTxCnlpa7JsvFGc6Na3mXiex2OFh0iiQtWwOBP0rIYA==",
"version": "1.50.4",
"resolved": "https://registry.npmjs.org/@livekit/protocol/-/protocol-1.50.4.tgz",
"integrity": "sha512-L1uggNQAqyY21smQY8AllyOYbcv9Me9TaxwuLytL1R8ck9nbYPmQLNwEDi3pOFGAMa5F8I2nUi2Jc59W5awxlA==",
"license": "Apache-2.0",
"dependencies": {
"@bufbuild/protobuf": "^1.10.0"
@@ -4562,6 +4563,12 @@
}
}
},
"node_modules/crisp-sdk-web": {
"version": "1.1.2",
"resolved": "https://registry.npmjs.org/crisp-sdk-web/-/crisp-sdk-web-1.1.2.tgz",
"integrity": "sha512-qxSpiT4EGHnVEO6J/t1UURY6fg1ojgquLU0IIr7RNjZxXZs1R2e6AhAiFqxiGZ13Vb4o5VoUpATFU2TzX/ppOQ==",
"license": "MIT"
},
"node_modules/cross-spawn": {
"version": "7.0.6",
"resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.6.tgz",
@@ -8228,17 +8235,16 @@
"license": "MIT"
},
"node_modules/livekit-client": {
"version": "2.23.0",
"resolved": "https://registry.npmjs.org/livekit-client/-/livekit-client-2.23.0.tgz",
"integrity": "sha512-j9Kg86nJjBjNFUD+ukp2jwMCGa0k+YD5gU//RzAM+ZY3pbG631QCte7fQjwqWMmtBzhDJL9nKYuOLMv/9IbAxg==",
"version": "2.21.0",
"resolved": "https://registry.npmjs.org/livekit-client/-/livekit-client-2.21.0.tgz",
"integrity": "sha512-RBUhPkV/sl1nzl8lokVlK5uATPwn0AlsudCBZXissw/kDl9yz8ac4pNJ43iPpMVoHOeBYH/BZ3vUC1adqa/zFQ==",
"license": "Apache-2.0",
"dependencies": {
"@livekit/mutex": "1.1.1",
"@livekit/protocol": "1.52.1",
"@livekit/protocol": "1.50.4",
"events": "^3.3.0",
"jose": "^6.1.0",
"loglevel": "^1.9.2",
"machina": "^7.0.0",
"sdp-transform": "^2.15.0",
"tslib": "2.8.1",
"typed-emitter": "^2.1.0",
@@ -8347,15 +8353,6 @@
"yallist": "^3.0.2"
}
},
"node_modules/machina": {
"version": "7.0.1",
"resolved": "https://registry.npmjs.org/machina/-/machina-7.0.1.tgz",
"integrity": "sha512-0Xkgs8NeBvO2hW6bjJT8ewLWrMfh1haMPstaghpASWjXkLjRhtDiaJG1Kb7mslaOHxZYxpH7PIjpmirRVYbMMA==",
"license": "MIT",
"engines": {
"node": ">=22.22"
}
},
"node_modules/magic-string": {
"version": "0.30.21",
"resolved": "https://registry.npmjs.org/magic-string/-/magic-string-0.30.21.tgz",
+3 -2
View File
@@ -1,7 +1,7 @@
{
"name": "meet",
"private": true,
"version": "1.37.0",
"version": "1.36.3",
"type": "module",
"scripts": {
"dev": "panda codegen && vite",
@@ -29,13 +29,14 @@
"@remixicon/react": "4.9.0",
"@tanstack/react-query": "5.101.4",
"@timephy/rnnoise-wasm": "1.0.0",
"crisp-sdk-web": "1.1.2",
"hoofd": "1.7.3",
"humanize-duration": "3.34.1",
"i18next": "26.3.6",
"i18next-browser-languagedetector": "8.2.1",
"i18next-parser": "9.4.0",
"i18next-resources-to-backend": "1.2.3",
"livekit-client": "2.23.0",
"livekit-client": "2.21.0",
"posthog-js": "1.418.10",
"react": "18.3.1",
"react-aria": "3.51.0",
-18
View File
@@ -1,18 +0,0 @@
User-agent: GPTBot
User-agent: OAI-SearchBot
User-agent: ChatGPT-User
User-agent: ClaudeBot
User-agent: Claude-SearchBot
User-agent: Claude-User
User-agent: PerplexityBot
User-agent: Perplexity-User
User-agent: Google-Extended
User-agent: Applebot-Extended
User-agent: CCBot
User-agent: Meta-ExternalAgent
User-agent: Amazonbot
User-agent: Bytespider
Disallow: /
User-agent: *
Allow: /
+1 -10
View File
@@ -13,9 +13,7 @@ export interface ApiConfig {
flags_api_host?: string
}
support?: {
widget_script_url?: string
widget_api_url?: string
widget_channel?: string
id: string
help_article_transcript: string
help_article_recording: string
help_article_more_tools: string
@@ -75,13 +73,6 @@ export interface ApiConfig {
enable_firefox_proxy_workaround: boolean
default_sources: Source[]
default_video_codec: VideoCodec
reconnect?: {
backoff_enabled: boolean
base_delay_ms: number
max_delay_ms: number
give_up_after_ms: number
backoff_reset_ms: number
}
}
transcription_destination?: string
max_participants_for_sound: number
@@ -1,5 +1,6 @@
import { useConfig } from '@/api/useConfig'
import { useAnalytics } from '@/features/analytics/hooks/useAnalytics'
import { useSupport } from '@/features/support/hooks/useSupport'
import { useSyncUserPreferencesWithBackend } from '@/features/auth/api/useSyncUserPreferencesWithBackend'
import { useEffect } from 'react'
@@ -7,9 +8,10 @@ export const AppInitialization = () => {
const { data } = useConfig()
useSyncUserPreferencesWithBackend()
const { analytics = {}, custom_css_url = '' } = data ?? {}
const { analytics = {}, support = {}, custom_css_url = '' } = data ?? {}
useAnalytics(analytics)
useSupport(support)
useEffect(() => {
if (custom_css_url) {
@@ -2,6 +2,12 @@ import type { CaptureResult } from 'posthog-js'
const IGNORED_EXCEPTION_PATTERNS = [
/ResizeObserver loop (completed with undelivered notifications|limit exceeded)/,
// livekit-client leaks the raw WebSocket error Event as an unhandled
// rejection when the signal ws errors after connect (Firefox-heavy,
// coincides with signal reconnects). Carries zero diagnostic content —
// the close reason is already logged by the SDK.
// See: https://github.com/livekit/client-sdk-js/issues/2062
/^Event captured as exception with keys: isTrusted$/,
]
const shouldIgnoreException = (value: unknown): boolean =>
@@ -32,7 +32,6 @@ export type LogCode =
| 'fullscreen_failure'
| 'publish_sources_failure'
| 'disconnect_failure'
| 'support_widget_failure'
| 'generic_failure'
export const reportError = (
@@ -1,4 +1,5 @@
import { apiUrl } from '@/api/apiUrl'
import { terminateSupportSession } from '@/features/support/hooks/useSupport'
import { terminateAnalyticsSession } from '@/features/analytics/hooks/useAnalytics'
const logoutUrl = () => {
@@ -7,5 +8,6 @@ const logoutUrl = () => {
export const logout = async () => {
await terminateAnalyticsSession()
terminateSupportSession()
window.location.href = logoutUrl()
}
@@ -96,8 +96,6 @@ export const MainNotificationToast = () => {
case NotificationType.ScreenRecordingStopped:
case NotificationType.TranscriptionLimitReached:
case NotificationType.ScreenRecordingLimitReached:
case NotificationType.TranscriptionInterrupted:
case NotificationType.ScreenRecordingInterrupted:
case NotificationType.TranscriptionFailed:
case NotificationType.ScreenRecordingFailed:
case NotificationType.TranscriptionAborted:
@@ -10,7 +10,6 @@ export enum NotificationType {
TranscriptionStarted = 'transcriptionStarted',
TranscriptionStopped = 'transcriptionStopped',
TranscriptionLimitReached = 'transcriptionLimitReached',
TranscriptionInterrupted = 'transcriptionInterrupted',
TranscriptionFailed = 'transcriptionFailed',
TranscriptionAborted = 'transcriptionAborted',
TranscriptionRequested = 'transcriptionRequested',
@@ -18,7 +17,6 @@ export enum NotificationType {
ScreenRecordingStopped = 'screenRecordingStopped',
ScreenRecordingRequested = 'screenRecordingRequested',
ScreenRecordingLimitReached = 'screenRecordingLimitReached',
ScreenRecordingInterrupted = 'screenRecordingInterrupted',
ScreenRecordingFailed = 'screenRecordingFailed',
ScreenRecordingAborted = 'screenRecordingAborted',
RecordingSaving = 'recordingSaving',
@@ -22,8 +22,6 @@ export function ToastAnyRecording({ state, ...props }: Readonly<ToastProps>) {
return 'transcript.stopped'
case NotificationType.TranscriptionLimitReached:
return 'transcript.limitReached'
case NotificationType.TranscriptionInterrupted:
return 'transcript.interrupted'
case NotificationType.TranscriptionFailed:
return 'transcript.failed'
case NotificationType.TranscriptionAborted:
@@ -34,8 +32,6 @@ export function ToastAnyRecording({ state, ...props }: Readonly<ToastProps>) {
return 'screenRecording.stopped'
case NotificationType.ScreenRecordingLimitReached:
return 'screenRecording.limitReached'
case NotificationType.ScreenRecordingInterrupted:
return 'screenRecording.interrupted'
case NotificationType.ScreenRecordingFailed:
return 'screenRecording.failed'
case NotificationType.ScreenRecordingAborted:
@@ -58,8 +58,6 @@ const renderToast = (
case NotificationType.ScreenRecordingStarted:
case NotificationType.ScreenRecordingStopped:
case NotificationType.ScreenRecordingLimitReached:
case NotificationType.TranscriptionInterrupted:
case NotificationType.ScreenRecordingInterrupted:
case NotificationType.TranscriptionFailed:
case NotificationType.ScreenRecordingFailed:
case NotificationType.TranscriptionAborted:
@@ -12,10 +12,6 @@ export const useRecordingWaitingForTracks = (mode: RecordingMode) => {
mode === RecordingMode.Transcript ? [Track.Source.Microphone] : undefined,
{ onlySubscribed: false }
)
const hasTracks =
mode === RecordingMode.Transcript
? tracks.some((track) => !track.publication.isMuted)
: tracks.length > 0
const [delayElapsed, setDelayElapsed] = useState(false)
useEffect(() => {
@@ -29,5 +25,5 @@ export const useRecordingWaitingForTracks = (mode: RecordingMode) => {
return () => window.clearTimeout(timeout)
}, [isStarting, mode])
return isStarting && delayElapsed && !hasTracks
return isStarting && delayElapsed && tracks.length === 0
}
@@ -10,6 +10,7 @@ import {
ConnectionErrorReason,
DisconnectReason,
MediaDeviceFailure,
Room,
type RoomOptions,
VideoPresets,
} from 'livekit-client'
@@ -45,26 +46,6 @@ import { WatchMediaDeviceErrors } from './WatchMediaDeviceErrors'
import { MeetDevtools } from '@/features/devtools'
import { VOICE_AUDIO_CONSTRAINTS } from '@/features/rooms/livekit/utils/constants'
import { resolveAudioOutputDeviceId } from '@/features/rooms/utils/resolveAudioOutputDeviceId'
import { ConnectionEndReason } from '@/features/rooms/utils/connectionEndReason'
import { createLiveKitRoom } from '@/features/rooms/livekit/utils/reconnectPolicy'
const handleError = (e: Error) => {
const failure = getMediaDeviceFailure(e)
if (failure && failure !== MediaDeviceFailure.Other) return
// connect() was aborted by a disconnect() before the join completed
if (
e instanceof ConnectionError &&
e.reason === ConnectionErrorReason.Cancelled
) {
void captureEvent('connection-cancelled')
return
}
reportError('livekit_room_error', e, {
path: 'connect_publish',
})
}
export const Conference = ({
roomId,
@@ -155,11 +136,7 @@ export const Conference = ({
apiConfig?.livekit.default_video_codec,
])
const reconnect = apiConfig?.livekit.reconnect
const room = useMemo(
() => createLiveKitRoom(roomOptions, reconnect),
[roomOptions, reconnect]
)
const room = useMemo(() => new Room(roomOptions), [roomOptions])
useEffect(() => {
/**
@@ -209,7 +186,6 @@ export const Conference = ({
const isMobile = useIsMobile()
const hasAutoMutedRef = useRef(false)
const hasConnectedRef = useRef(false)
/*
* Ensure stable WebSocket connection URL. This is critical for legacy browser compatibility
@@ -272,9 +248,24 @@ export const Conference = ({
className={css({
backgroundColor: 'primaryDark.50 !important',
})}
onError={handleError}
onError={(e) => {
const failure = getMediaDeviceFailure(e)
if (failure && failure !== MediaDeviceFailure.Other) return
// connect() was aborted by a disconnect() before the join completed
if (
e instanceof ConnectionError &&
e.reason === ConnectionErrorReason.Cancelled
) {
void captureEvent('connection-cancelled')
return
}
reportError('livekit_room_error', e, {
path: 'connect_publish',
})
}}
onConnected={async () => {
hasConnectedRef.current = true
if (!apiConfig) return
if (
userPreferencesSnap.is_auto_mute_large_room_enabled &&
@@ -316,20 +307,6 @@ export const Conference = ({
}
)
return
default:
// Reconnecting gave up, or the join itself failed
navigateTo(
'feedback',
{},
{
state: {
reason: hasConnectedRef.current
? ConnectionEndReason.Lost
: ConnectionEndReason.Failed,
...metadata,
},
}
)
}
}}
>
@@ -1,29 +1,17 @@
import { useConfig } from '@/api/useConfig'
import { useIsAnalyticsEnabled } from '@/features/analytics/hooks/useIsAnalyticsEnabled'
import {
useConnectionState,
useRemoteParticipants,
useRoomContext,
} from '@livekit/components-react'
import { useEffect, useRef } from 'react'
import { useSnapshot } from 'valtio'
import {
ConnectionState,
DisconnectReason,
type Room,
RoomEvent,
} from 'livekit-client'
import { DisconnectReason, RoomEvent } from 'livekit-client'
import { userPreferencesStore } from '@/stores/userPreferences'
import { captureEvent, captureMediaEvent } from '@/features/analytics/telemetry'
import { connectionObserverStore } from '@/stores/connectionObserver'
import { BackoffReconnectPolicy } from '@/features/rooms/livekit/utils/reconnectPolicy'
const getBackoffPolicy = (room: Room) => {
const policy = room.options.reconnectPolicy
return policy instanceof BackoffReconnectPolicy ? policy : undefined
}
export const ConnectionObserver = () => {
const room = useRoomContext()
@@ -43,7 +31,6 @@ export const ConnectionObserver = () => {
RoomEvent.ParticipantDisconnected,
],
})
const connectionState = useConnectionState(room)
useEffect(() => {
// Always clear existing timer on dependency change
@@ -61,10 +48,6 @@ export const ConnectionObserver = () => {
return
}
// A full reconnection removes every remote participant until it
// succeeds: being alone then doesn't mean being idle
if (connectionState !== ConnectionState.Connected) return
if (remoteParticipants.length === 0) {
idleDisconnectModalTimeoutRef.current = setTimeout(() => {
connectionObserverStore.isIdleDisconnectModalOpen = true
@@ -81,7 +64,6 @@ export const ConnectionObserver = () => {
}
}, [
remoteParticipants.length,
connectionState,
data?.idle_disconnect_warning_delay,
userPreferencesSnap.is_idle_disconnect_modal_enabled,
])
@@ -107,13 +89,11 @@ export const ConnectionObserver = () => {
}
const handleReconnected = async () => {
const durationMs = getBackoffPolicy(room)?.lastReconnectionDurationMs
const participantSid = room.localParticipant.sid
const roomSid = await room.getSid().catch(() => undefined)
captureEvent('reconnected-event', {
livekit_room_sid: roomSid,
livekit_participant_sid: participantSid,
durationMs,
})
}
@@ -136,12 +116,9 @@ export const ConnectionObserver = () => {
sessionDuration: connectionStartTimeRef.current
? connectionEndTime - connectionStartTimeRef.current
: -1,
// LiveKit reports no reason when the reconnect policy gives up
reason: getBackoffPolicy(room)?.gaveUp
? 'RECONNECT_GAVE_UP'
: disconnectReason
? DisconnectReason[disconnectReason]
: 'UNKNOWN',
reason: disconnectReason
? DisconnectReason[disconnectReason]
: 'UNKNOWN',
})
}
@@ -2,18 +2,23 @@ import { RiQuestionLine } from '@remixicon/react'
import { MenuItem } from 'react-aria-components'
import { useTranslation } from 'react-i18next'
import { menuRecipe } from '@/primitives/menuRecipe'
import { useSupportWidget } from '@/features/support/hooks/useSupportWidget'
import {
useIsSupportEnabled,
openSupportChat,
} from '@/features/support/hooks/useSupport'
export const SupportMenuItem = () => {
const { t } = useTranslation('rooms', { keyPrefix: 'options.items' })
const { isEnabled, open } = useSupportWidget()
const isSupportEnabled = useIsSupportEnabled()
if (!isEnabled) return
if (!isSupportEnabled) {
return
}
return (
<MenuItem
className={menuRecipe({ icon: true, variant: 'dark' }).item}
onAction={open}
onAction={openSupportChat}
>
<RiQuestionLine size={20} />
{t('support')}
@@ -1,273 +0,0 @@
import { ConnectionState, RoomEvent, type Room } from 'livekit-client'
import { afterEach, describe, expect, it, vi } from 'vitest'
import {
BackoffReconnectPolicy,
createLiveKitRoom,
MAX_FIRST_DELAY_MS,
} from './reconnectPolicy'
const CONFIG = {
backoff_enabled: true,
base_delay_ms: 1_000,
max_delay_ms: 15_000,
give_up_after_ms: 300_000,
backoff_reset_ms: 120_000,
}
const createRoom = () => {
const listeners = new Map<RoomEvent, Array<(...args: unknown[]) => void>>()
const room = {
on(event: RoomEvent, listener: (...args: unknown[]) => void) {
listeners.set(event, [...(listeners.get(event) ?? []), listener])
return room
},
emit(event: RoomEvent, ...args: unknown[]) {
listeners.get(event)?.forEach((listener) => listener(...args))
},
setState(state: ConnectionState, event?: RoomEvent) {
room.emit(RoomEvent.ConnectionStateChanged, state)
if (event) room.emit(event)
},
}
return room
}
const setup = ({ config = CONFIG, random = 0.5 } = {}) => {
const clock = { now: 0 }
vi.spyOn(Math, 'random').mockReturnValue(random)
vi.spyOn(performance, 'now').mockImplementation(() => clock.now)
const room = createRoom()
const policy = new BackoffReconnectPolicy(config)
policy.attach(room as unknown as Room)
const delay = (retryCount: number, elapsedMs = 0) =>
policy.nextRetryDelayInMs({ retryCount, elapsedMs })
return { clock, room, policy, delay }
}
afterEach(() => {
vi.restoreAllMocks()
})
describe('BackoffReconnectPolicy', () => {
it('doubles the delay ceiling after each failed attempt, up to the cap', () => {
const { delay } = setup()
expect([0, 1, 2, 3, 4, 10].map((retryCount) => delay(retryCount))).toEqual([
500, 1_500, 3_000, 6_000, 11_250, 11_250,
])
})
it('draws the first delay anywhere below its ceiling (check two extremes)', () => {
expect(setup({ random: 0 }).delay(0)).toBe(0)
expect(setup({ random: 0.9999 }).delay(0)).toBe(999)
})
it('draws the next delays between half their ceiling and their ceiling (check two extremes)', () => {
expect(setup({ random: 0 }).delay(3)).toBe(4_000)
expect(setup({ random: 0.9999 }).delay(3)).toBe(7_999)
})
it('keeps the first delay of a reconnection under 5 s', () => {
const config = { ...CONFIG, base_delay_ms: 8_000 }
const { delay } = setup({ config, random: 0.9999 })
expect(delay(0)).toBeLessThan(MAX_FIRST_DELAY_MS)
expect(delay(1)).toBe(14_999)
})
it('starts the first attempt within 5 s of the drop', () => {
const config = { ...CONFIG, base_delay_ms: 8_000 }
const { clock, delay } = setup({ config })
expect(delay(0)).toBe(2_500)
clock.now = 4_000
expect(delay(0)).toBe(500)
clock.now = 6_000
expect(delay(0)).toBe(0)
})
it('never steps the backoff down within a reconnection', () => {
const { delay } = setup()
expect(delay(3)).toBe(6_000)
expect(delay(0)).toBe(6_000)
})
it('ignores the elapsed time reported by LiveKit', () => {
const { delay } = setup()
expect(delay(1, Date.now())).toBe(1_500)
})
it('picks up the backoff of a reconnection that ended shortly before', () => {
const { clock, room, delay } = setup()
delay(0)
delay(1)
delay(2)
room.emit(RoomEvent.Reconnected)
clock.now += 60_000
// One step above where the last reconnection ended (capped)
expect(delay(0)).toBe(2_500)
expect(delay(1)).toBe(11_250)
})
it('starts the backoff over once the connection held for the reset delay', () => {
const { clock, room, delay } = setup()
delay(0)
delay(1)
delay(2)
room.emit(RoomEvent.Reconnected)
clock.now += 120_000
expect(delay(0)).toBe(500)
})
it('gives up once the reconnection lasts longer than the give-up delay', () => {
const { clock, room, policy, delay } = setup()
delay(0)
room.setState(ConnectionState.Reconnecting, RoomEvent.Reconnecting)
clock.now = 299_999
expect(delay(20)).toBe(11_250)
expect(policy.gaveUp).toBe(false)
clock.now = 300_000
expect(delay(21)).toBeNull()
expect(policy.gaveUp).toBe(true)
})
it('keeps trying while only signaling is down', () => {
const { clock, room, policy, delay } = setup()
delay(0)
room.setState(
ConnectionState.SignalReconnecting,
RoomEvent.SignalReconnecting
)
clock.now = 600_000
expect(delay(40)).toBe(11_250)
expect(policy.gaveUp).toBe(false)
// The media connection failed as well
room.setState(ConnectionState.Reconnecting, RoomEvent.Reconnecting)
expect(delay(41)).toBeNull()
expect(policy.gaveUp).toBe(true)
})
it('gives up once the media connection failed, even back to resuming', () => {
const { clock, room, policy, delay } = setup()
delay(0)
room.setState(
ConnectionState.SignalReconnecting,
RoomEvent.SignalReconnecting
)
delay(1)
// The peer connections fail, then LiveKit tries to resume again
clock.now = 30_000
room.setState(ConnectionState.Reconnecting, RoomEvent.Reconnecting)
room.setState(
ConnectionState.SignalReconnecting,
RoomEvent.SignalReconnecting
)
clock.now = 299_999
expect(delay(20)).toBe(11_250)
expect(policy.gaveUp).toBe(false)
clock.now = 300_000
expect(delay(21)).toBeNull()
expect(policy.gaveUp).toBe(true)
})
it('starts a new reconnection once the room connects again', () => {
const { clock, room, policy, delay } = setup()
delay(0)
room.setState(ConnectionState.Reconnecting, RoomEvent.Reconnecting)
clock.now = 300_000
expect(delay(21)).toBeNull()
room.setState(ConnectionState.Disconnected, RoomEvent.Disconnected)
expect(policy.gaveUp).toBe(true)
room.setState(ConnectionState.Connecting)
room.setState(ConnectionState.Connected, RoomEvent.Connected)
expect(policy.gaveUp).toBe(false)
clock.now += 600_000
expect(delay(0)).toBe(500)
// The media connection of the previous reconnection is not lost anymore
room.setState(
ConnectionState.SignalReconnecting,
RoomEvent.SignalReconnecting
)
clock.now += 300_000
expect(delay(20)).toBe(11_250)
})
it('starts over when a new join replaces the reconnection', () => {
const { clock, room, policy, delay } = setup()
delay(0)
delay(3)
room.setState(ConnectionState.Reconnecting, RoomEvent.Reconnecting)
// LiveKitRoom calls room.connect() again in the middle of the reconnection
clock.now = 400_000
room.setState(ConnectionState.Connecting)
expect(delay(0)).toBe(500)
expect(policy.gaveUp).toBe(false)
})
it('reports how long a reconnection lasted, once', () => {
const { clock, room, policy, delay } = setup()
clock.now = 1_000
delay(0)
clock.now = 4_000
room.emit(RoomEvent.Reconnected)
expect(policy.lastReconnectionDurationMs).toBe(3_000)
// LiveKit can emit Reconnected several times for one recovery
room.emit(RoomEvent.Reconnected)
expect(policy.lastReconnectionDurationMs).toBeUndefined()
})
})
describe('createLiveKitRoom', () => {
it('builds the policy from the config endpoint values', () => {
vi.spyOn(Math, 'random').mockReturnValue(0.5)
const { reconnectPolicy } = createLiveKitRoom({}, CONFIG).options
expect(reconnectPolicy).toBeInstanceOf(BackoffReconnectPolicy)
expect(
reconnectPolicy.nextRetryDelayInMs({ retryCount: 2, elapsedMs: 0 })
).toBe(3_000)
})
it('keeps the default policy when the backoff is missing or disabled', () => {
for (const config of [undefined, { ...CONFIG, backoff_enabled: false }]) {
expect(
createLiveKitRoom({}, config).options.reconnectPolicy
).not.toBeInstanceOf(BackoffReconnectPolicy)
}
})
})
@@ -1,146 +0,0 @@
import {
ConnectionState,
Room,
RoomEvent,
type ReconnectContext,
type ReconnectPolicy,
type RoomOptions,
} from 'livekit-client'
import type { ApiConfig } from '@/api/useConfig'
/**
* Until the first attempt of a reconnection starts, the room still reports
* Connected and LiveKit keeps checking its transport for a while.
* Around 10s after the initial drop, it will try a full websocket reconnection.
* Hence, the first attempt should start well before that.
*/
export const MAX_FIRST_DELAY_MS = 5_000
type ReconnectConfig = NonNullable<ApiConfig['livekit']['reconnect']>
type Reconnection = {
startedAt: number
// Higher than 0 when the previous reconnection ended shortly before
firstStep: number
failedAttempts: number
isMediaLost: boolean
gaveUp: boolean
}
/**
* When a LiveKit node crashes or Redis stalls, every client loses its signal
* connection at the same time. This policy implements an exponential backoff
* with some randomness to spread the reconnections out.
*
* The policy keeps its own clock since LiveKit calls the policy again on every
* new disconnection trigger
*/
export class BackoffReconnectPolicy implements ReconnectPolicy {
lastReconnectionDurationMs: number | undefined
private readonly config: ReconnectConfig
private reconnection: Reconnection | undefined
private lastRecovery: { at: number; step: number } | undefined
constructor(config: ReconnectConfig) {
this.config = config
}
attach(room: Room) {
room.on(RoomEvent.Connected, this.handleRecovery)
room.on(RoomEvent.Reconnected, this.handleRecovery)
room.on(RoomEvent.Reconnecting, this.handleMediaLost)
room.on(RoomEvent.ConnectionStateChanged, this.handleStateChange)
}
get gaveUp() {
return this.reconnection?.gaveUp ?? false
}
nextRetryDelayInMs({ retryCount }: ReconnectContext): number | null {
const now = performance.now()
this.reconnection ??= this.startReconnection(now)
const reconnection = this.reconnection
reconnection.failedAttempts = Math.max(
reconnection.failedAttempts,
retryCount
)
if (
now - reconnection.startedAt >= this.config.give_up_after_ms &&
reconnection.isMediaLost
) {
reconnection.gaveUp = true
return null
}
const ceiling = Math.min(
this.config.max_delay_ms,
this.config.base_delay_ms *
2 ** (reconnection.firstStep + reconnection.failedAttempts)
)
if (reconnection.failedAttempts === 0) {
// LiveKit re-arms its timer on each trigger: count from the first drop
const timeLeft = reconnection.startedAt + MAX_FIRST_DELAY_MS - now
return Math.floor(
Math.random() * Math.min(ceiling, Math.max(timeLeft, 0))
)
}
return Math.floor((ceiling / 2) * (1 + Math.random()))
}
private startReconnection(now: number): Reconnection {
const recovery = this.lastRecovery
const isLastDisconnectionRecent =
recovery !== undefined && now - recovery.at < this.config.backoff_reset_ms
return {
startedAt: now,
firstStep: isLastDisconnectionRecent ? recovery.step + 1 : 0,
failedAttempts: 0,
isMediaLost: false,
gaveUp: false,
}
}
private handleMediaLost = () => {
this.reconnection ??= this.startReconnection(performance.now())
this.reconnection.isMediaLost = true
}
private handleStateChange = (state: ConnectionState) => {
if (state === ConnectionState.Connecting) this.reconnection = undefined
}
private handleRecovery = () => {
const now = performance.now()
if (this.reconnection) {
const { startedAt, firstStep, failedAttempts } = this.reconnection
this.lastRecovery = { at: now, step: firstStep + failedAttempts }
this.lastReconnectionDurationMs = now - startedAt
this.reconnection = undefined
} else {
// LiveKit can emit Reconnected several times for a full reconnection
// We want to avoid duplicating the reconnection duration in PostHog
this.lastReconnectionDurationMs = undefined
}
}
}
/**
* Build a room with the reconnection policy from the config endpoint.
* Without it, the room keeps the LiveKit default policy
*/
export const createLiveKitRoom = (
options: RoomOptions,
config?: ReconnectConfig
): Room => {
if (!config?.backoff_enabled) return new Room(options)
const reconnectPolicy = new BackoffReconnectPolicy(config)
const room = new Room({ ...options, reconnectPolicy })
reconnectPolicy.attach(room)
return room
}
@@ -7,7 +7,6 @@ import { Rating } from '@/features/rooms/components/Rating.tsx'
import { useLocation } from 'wouter'
import { useMemo } from 'react'
import { DisconnectReason } from 'livekit-client'
import { ConnectionEndReason } from '@/features/rooms/utils/connectionEndReason'
// fixme - duplicated with home, refactor in a proper style
const Heading = styled('h1', {
@@ -33,8 +32,6 @@ enum DisconnectReasonKey {
DuplicateIdentity = 'duplicateIdentity',
ParticipantRemoved = 'participantRemoved',
RoomDeleted = 'roomDeleted',
ConnectionLost = 'connectionLost',
ConnectionFailed = 'connectionFailed',
}
const FeedbackRoute = () => {
@@ -52,10 +49,6 @@ const FeedbackRoute = () => {
return DisconnectReasonKey.ParticipantRemoved
case DisconnectReason.ROOM_DELETED:
return DisconnectReasonKey.RoomDeleted
case ConnectionEndReason.Lost:
return DisconnectReasonKey.ConnectionLost
case ConnectionEndReason.Failed:
return DisconnectReasonKey.ConnectionFailed
}
}, [])
@@ -98,9 +91,7 @@ const FeedbackRoute = () => {
{t('feedback.home')}
</Button>
</Stack>
{reasonKey !== DisconnectReasonKey.ConnectionFailed && (
<Rating metadata={metadata} />
)}
<Rating metadata={metadata} />
</VStack>
</Center>
</Screen>
@@ -1,7 +0,0 @@
/**
* Why a room ended when no more specific reason applies
*/
export enum ConnectionEndReason {
Failed = 'connectionFailed',
Lost = 'connectionLost',
}
@@ -1,25 +0,0 @@
import { useTranslation } from 'react-i18next'
import { RiQuestionLine } from '@remixicon/react'
import { Button } from '@/primitives'
import { Spinner } from '@/primitives/Spinner'
import { useSupportWidget } from '../hooks/useSupportWidget'
export const SupportButton = () => {
const { t } = useTranslation('global', { keyPrefix: 'support' })
const { isEnabled, isPending, open } = useSupportWidget()
if (!isEnabled) return null
return (
<Button
square
variant="secondaryText"
aria-label={t('buttonLabel')}
tooltip={t('buttonLabel')}
isPending={isPending}
onPress={open}
>
{isPending ? <Spinner size={24} /> : <RiQuestionLine />}
</Button>
)
}
@@ -1,73 +0,0 @@
import { useEffect } from 'react'
import { useTranslation } from 'react-i18next'
import { useSnapshot } from 'valtio'
import { useLocation } from 'wouter'
import { RiCheckboxCircleFill, RiCloseLine } from '@remixicon/react'
import { css } from '@/styled-system/css'
import { Button, Text } from '@/primitives'
import { announceToScreenReader } from '@/stores/screenReaderAnnouncer'
import { supportStore } from '@/stores/support'
import { subscribeToSupportWidget } from '../utils/supportWidget'
import { ToastDuration } from '@/features/notifications/NotificationDuration'
import { StyledToast } from '@/features/notifications/components/StyledToast'
import { StyledToastContainer } from '@/features/notifications/components/StyledToastContainer'
const hide = () => {
supportStore.showSentConfirmation = false
}
export const SupportWidget = () => {
const { t } = useTranslation('global', { keyPrefix: 'support.sent' })
const { showSentConfirmation } = useSnapshot(supportStore)
const [location] = useLocation()
useEffect(() => subscribeToSupportWidget(), [])
useEffect(hide, [location])
useEffect(() => {
if (!showSentConfirmation) return
announceToScreenReader(`${t('title')}. ${t('body')}`)
const timeout = window.setTimeout(hide, ToastDuration.EXTRA_LONG)
return () => window.clearTimeout(timeout)
}, [showSentConfirmation, t])
if (!showSentConfirmation) return null
return (
<div
className={css({
position: 'fixed',
top: '5rem',
left: '50%',
transform: 'translateX(-50%)',
zIndex: 1000,
})}
>
<StyledToastContainer>
<StyledToast>
<RiCheckboxCircleFill
size={24}
aria-hidden="true"
className={css({ color: 'success.300', flexShrink: 0 })}
/>
<div>
<Text margin={false} bold>
{t('title')}
</Text>
<Text margin={false}>{t('body')}</Text>
</div>
<Button
square
size="sm"
invisible
aria-label={t('close')}
onPress={hide}
>
<RiCloseLine color="white" />
</Button>
</StyledToast>
</StyledToastContainer>
</div>
)
}
@@ -0,0 +1,125 @@
import { useEffect, useState } from 'react'
import { type ApiUser } from '@/features/auth/api/ApiUser'
import { useUser } from '@/features/auth/api/useUser'
import { useConfig } from '@/api/useConfig'
type CrispSdk = (typeof import('crisp-sdk-web'))['Crisp']
let crisp: CrispSdk | undefined
let crispPromise: Promise<CrispSdk> | undefined
const loadCrisp = (): Promise<CrispSdk> => {
crispPromise ??= import('crisp-sdk-web')
.then((module) => {
crisp = module.Crisp
return module.Crisp
})
.catch((error) => {
crispPromise = undefined
throw error
})
return crispPromise
}
export const openSupportChat = () => {
if (!crisp?.isCrispInjected()) return
crisp.chat.open()
}
export const initializeSupportSession = (user: ApiUser) => {
if (!crisp?.isCrispInjected()) return
const { id, email } = user
crisp.setTokenId(`meet-${id}`)
if (email) crisp.user.setEmail(email)
}
export const terminateSupportSession = () => {
if (!crisp?.isCrispInjected()) return
crisp.setTokenId()
crisp.session.reset()
}
export type useSupportProps = {
id?: string
isDisabled?: boolean
}
const IDLE_TIMEOUT_MS = 10_000
const scheduleWhenIdle = (callback: () => void): (() => void) => {
if (typeof window.requestIdleCallback === 'function') {
const handle = window.requestIdleCallback(callback, {
timeout: IDLE_TIMEOUT_MS,
})
return () => window.cancelIdleCallback(handle)
}
const handle = window.setTimeout(callback, 1)
return () => window.clearTimeout(handle)
}
export const useSupport = ({ id, isDisabled }: useSupportProps) => {
const { user } = useUser()
const [isInjected, setIsInjected] = useState(
() => crisp?.isCrispInjected() ?? false
)
useEffect(() => {
if (!id || isDisabled) return
if (crisp?.isCrispInjected()) {
setIsInjected(true)
return
}
let cancelled = false
const cancelIdle = scheduleWhenIdle(() => {
void loadCrisp()
.then((sdk) => {
if (cancelled) return
if (!sdk.isCrispInjected()) {
sdk.configure(id)
sdk.setHideOnMobile(true)
}
setIsInjected(true)
})
.catch((error) => {
if (!cancelled) {
console.error('Failed to initialize support chat', error)
}
})
})
return () => {
cancelled = true
cancelIdle()
}
}, [id, isDisabled])
useEffect(() => {
if (!user || !isInjected || isDisabled) return
initializeSupportSession(user)
}, [user, isInjected, isDisabled])
return null
}
// Some users block the chat widget, so check its availability safely.
const isCrispAvailable = () => {
try {
return !!window?.$crisp?.is
} catch {
return false
}
}
export const useIsSupportEnabled = () => {
const { data } = useConfig()
return !!data?.support?.id && isCrispAvailable()
}
@@ -1,42 +0,0 @@
import { useTranslation } from 'react-i18next'
import { useSnapshot } from 'valtio'
import { useConfig } from '@/api/useConfig'
import { useUser } from '@/features/auth/api/useUser'
import { reportError } from '@/features/analytics/telemetry'
import { announceToScreenReader } from '@/stores/screenReaderAnnouncer'
import { supportStore } from '@/stores/support'
import { openSupportWidget } from '../utils/supportWidget'
export const useSupportWidget = () => {
const { t, i18n } = useTranslation('global', { keyPrefix: 'support' })
const { data } = useConfig()
const { user } = useUser()
const { status } = useSnapshot(supportStore)
const {
widget_script_url: scriptUrl,
widget_api_url: api,
widget_channel: channel,
} = data?.support ?? {}
const isEnabled = !!(scriptUrl && api && channel)
const open = () => {
if (!isEnabled) return
openSupportWidget(scriptUrl, {
api,
channel,
locale: i18n.language,
email: user?.email,
}).catch((error) => {
reportError('support_widget_failure', error)
announceToScreenReader(t('openError'), 'assertive')
})
}
return {
isEnabled,
isPending: status === 'pending',
open,
}
}
@@ -1,147 +0,0 @@
import { supportStore } from '@/stores/support'
declare global {
interface Window {
_lasuite_widget?: unknown[]
}
}
type WidgetOptions = {
api: string
channel: string
locale: string
email?: string
}
const ROOT_ID = 'lasuite-widget-support-root'
const OPENED_EVENT = 'lasuite-widget-support-opened'
const SUCCESS_EVENT = 'lasuite-widget-support-success'
const CLOSED_EVENT = 'lasuite-widget-support-closed'
const TIMEOUT_MS = 10_000
const WIDGET_CSS = `@media (min-width: 48em) {
[role='dialog'] {
top: 50%;
right: auto;
bottom: auto;
left: 50%;
transform: translate(-50%, -50%);
}
}
[role='status'] {
display: none;
}`
const styleWidget = () => {
const shadowRoot = document.getElementById(ROOT_ID)?.shadowRoot
if (!shadowRoot) return
const style = document.createElement('style')
style.textContent = WIDGET_CSS
shadowRoot.appendChild(style)
}
let returnFocusTo: HTMLElement | null = null
// The widget removes the form without moving focus, which drops it on <body>.
const restoreFocus = () => {
const activeEl = document.activeElement
const isFocusLost = activeEl === document.body || activeEl?.id === ROOT_ID
if (isFocusLost && returnFocusTo?.isConnected) {
returnFocusTo.focus({ preventScroll: true })
}
}
export const subscribeToSupportWidget = () => {
const onOpened = () => {
styleWidget()
supportStore.status = 'open'
}
const onSuccess = () => {
supportStore.showSentConfirmation = true
restoreFocus()
}
const onClosed = () => {
supportStore.status = 'closed'
restoreFocus()
returnFocusTo = null
}
document.addEventListener(OPENED_EVENT, onOpened)
document.addEventListener(SUCCESS_EVENT, onSuccess)
document.addEventListener(CLOSED_EVENT, onClosed)
return () => {
document.removeEventListener(OPENED_EVENT, onOpened)
document.removeEventListener(SUCCESS_EVENT, onSuccess)
document.removeEventListener(CLOSED_EVENT, onClosed)
}
}
const resolveTrigger = () => {
const activeEl = document.activeElement as HTMLElement | null
if (activeEl?.getAttribute('role') === 'menuitem') {
return document.querySelector<HTMLElement>('#room-options-trigger')
}
return activeEl
}
let scriptPromise: Promise<void> | undefined
const loadScript = (src: string): Promise<void> => {
scriptPromise ??= new Promise<void>((resolve, reject) => {
const script = document.createElement('script')
const timeout = window.setTimeout(
() => fail(new Error(`Timed out loading ${src}`)),
TIMEOUT_MS
)
const fail = (error: Error) => {
window.clearTimeout(timeout)
script.remove()
scriptPromise = undefined
reject(error)
}
script.src = src
script.async = true
script.onload = () => {
window.clearTimeout(timeout)
resolve()
}
script.onerror = () => fail(new Error(`Failed to load ${src}`))
document.body.appendChild(script)
})
return scriptPromise
}
const initWidget = (options: WidgetOptions): Promise<void> =>
new Promise<void>((resolve, reject) => {
const onOpened = () => {
window.clearTimeout(timeout)
resolve()
}
const timeout = window.setTimeout(() => {
document.removeEventListener(OPENED_EVENT, onOpened)
reject(new Error('Support widget did not open'))
}, TIMEOUT_MS)
document.addEventListener(OPENED_EVENT, onOpened, { once: true })
window._lasuite_widget?.push(['support', 'init', options])
})
export const openSupportWidget = async (
scriptUrl: string,
options: WidgetOptions
) => {
if (supportStore.status !== 'closed') return
supportStore.status = 'pending'
returnFocusTo = resolveTrigger()
try {
await loadScript(scriptUrl)
await initWidget(options)
} catch (error) {
supportStore.status = 'closed'
returnFocusTo = null
throw error
}
}
-2
View File
@@ -4,7 +4,6 @@ import { HStack, Stack } from '@/styled-system/jsx'
import { useTranslation } from 'react-i18next'
import { Button, Text } from '@/primitives'
import { SettingsButton } from '@/features/settings'
import { SupportButton } from '@/features/support/components/SupportButton'
import { useUser } from '@/features/auth/api/useUser'
import { useMatchesRoute } from '@/navigation/useMatchesRoute'
import { FeedbackBanner } from '@/components/FeedbackBanner'
@@ -154,7 +153,6 @@ export const Header = () => {
</header>
<nav>
<Stack gap={1} direction="row" align="center">
<SupportButton />
{isLoggedIn === false &&
!isHome &&
!isLegalTerms &&
-2
View File
@@ -6,7 +6,6 @@ import { useSnapshot } from 'valtio'
import { Footer } from '@/layout/Footer'
import { ScreenReaderAnnouncer } from '@/primitives'
import { SkipLink, MAIN_CONTENT_ID } from './SkipLink'
import { SupportWidget } from '@/features/support/components/SupportWidget'
export type Layout = 'fullpage' | 'centered'
@@ -47,7 +46,6 @@ export const Layout = ({ children }: { children: ReactNode }) => {
})}
>
<ScreenReaderAnnouncer />
<SupportWidget />
{children}
</main>
</div>
-9
View File
@@ -27,15 +27,6 @@
},
"selected": "ausgewählt",
"submit": "OK",
"support": {
"buttonLabel": "Support kontaktieren",
"openError": "Das Kontaktformular konnte nicht geöffnet werden. Bitte versuchen Sie es später erneut.",
"sent": {
"title": "Nachricht gesendet",
"body": "Das Support-Team hat Ihre Nachricht erhalten.",
"close": "Schließen"
}
},
"footer": {
"links": {
"legifrance": "legifrance.gouv.fr",
@@ -37,7 +37,6 @@
"started": "{{name}} hat die Meeting-Transkription gestartet.",
"stopped": "{{name}} hat die Meeting-Transkription gestoppt.",
"limitReached": "Die Transkription hat die maximal zulässige Dauer überschritten und wird automatisch gespeichert.",
"interrupted": "Die Transkription wurde unerwartet beendet, der bereits aufgezeichnete Teil wird gespeichert.",
"failed": "Die Transkription wurde unerwartet beendet und konnte nicht gespeichert werden.",
"aborted": "Die Transkription konnte nicht gestartet werden.",
"requested": "{{name}} möchte die Meeting-Transkription starten."
@@ -47,7 +46,6 @@
"started": "{{name}} hat die Meeting-Aufzeichnung gestartet.",
"stopped": "{{name}} hat die Meeting-Aufzeichnung gestoppt.",
"limitReached": "Die Aufzeichnung hat die maximal zulässige Dauer überschritten und wird automatisch gespeichert.",
"interrupted": "Die Aufzeichnung wurde unerwartet beendet, der bereits aufgezeichnete Teil wird gespeichert.",
"failed": "Die Aufzeichnung wurde unerwartet beendet und konnte nicht gespeichert werden.",
"aborted": "Die Aufzeichnung konnte nicht gestartet werden.",
"requested": "{{name}} möchte die Meeting-Aufzeichnung starten."
+1 -3
View File
@@ -4,9 +4,7 @@
"normal": "Du hast das Meeting verlassen",
"duplicateIdentity": "Du bist dem Meeting von einem anderen Gerät aus beigetreten",
"participantRemoved": "Du wurdest vom Host aus dem Meeting entfernt",
"roomDeleted": "Dieses Meeting wurde gelöscht",
"connectionLost": "Die Verbindung zum Meeting wurde unterbrochen",
"connectionFailed": "Beitritt zum Meeting nicht möglich"
"roomDeleted": "Dieses Meeting wurde gelöscht"
},
"home": "Zur Startseite zurückkehren",
"back": "Dem Meeting erneut beitreten"
-9
View File
@@ -27,15 +27,6 @@
},
"selected": "selected",
"submit": "OK",
"support": {
"buttonLabel": "Contact support",
"openError": "The contact form could not be opened. Please try again later.",
"sent": {
"title": "Message sent",
"body": "The support team has received your message.",
"close": "Close"
}
},
"footer": {
"links": {
"legifrance": "legifrance.gouv.fr",
@@ -37,7 +37,6 @@
"started": "{{name}} started the meeting transcription.",
"stopped": "{{name}} stopped the meeting transcription.",
"limitReached": "The transcription has exceeded the maximum allowed duration and will be automatically saved.",
"interrupted": "The transcription stopped unexpectedly, the part already recorded will be saved.",
"failed": "The transcription stopped unexpectedly and could not be saved.",
"aborted": "The transcription could not be started.",
"requested": "{{name}} wants to start the meeting transcription."
@@ -47,7 +46,6 @@
"started": "{{name}} started the meeting recording.",
"stopped": "{{name}} stopped the meeting recording.",
"limitReached": "The recording has exceeded the maximum allowed duration and will be automatically saved.",
"interrupted": "The recording stopped unexpectedly, the part already recorded will be saved.",
"failed": "The recording stopped unexpectedly and could not be saved.",
"aborted": "The recording could not be started.",
"requested": "{{name}} wants to start the meeting recording."
+1 -3
View File
@@ -4,9 +4,7 @@
"normal": "You have left the meeting",
"duplicateIdentity": "You have joined the meeting from another device",
"participantRemoved": "You have been removed from the meeting by a host",
"roomDeleted": "This meeting has been deleted",
"connectionLost": "The connection to the meeting was lost",
"connectionFailed": "Unable to join the meeting"
"roomDeleted": "This meeting has been deleted"
},
"home": "Return to home",
"back": "Rejoin the meeting"
-9
View File
@@ -27,15 +27,6 @@
},
"selected": "seleccionado",
"submit": "Aceptar",
"support": {
"buttonLabel": "Contactar con el soporte",
"openError": "No se ha podido abrir el formulario de contacto. Inténtelo de nuevo más tarde.",
"sent": {
"title": "Mensaje enviado",
"body": "El equipo de soporte ha recibido su mensaje.",
"close": "Cerrar"
}
},
"footer": {
"links": {
"legifrance": "legifrance.gouv.fr",
@@ -37,7 +37,6 @@
"started": "{{name}} ha iniciado la transcripción de la reunión.",
"stopped": "{{name}} ha detenido la transcripción de la reunión.",
"limitReached": "La transcripción ha superado la duración máxima permitida, se va a guardar automáticamente.",
"interrupted": "La transcripción se ha interrumpido de forma inesperada, se va a guardar la parte ya grabada.",
"failed": "La transcripción se ha interrumpido de forma inesperada y no se ha podido guardar.",
"aborted": "No se ha podido iniciar la transcripción.",
"requested": "{{name}} ha solicitado iniciar la transcripción."
@@ -47,7 +46,6 @@
"started": "{{name}} ha iniciado la grabación de la reunión.",
"stopped": "{{name}} ha detenido la grabación de la reunión.",
"limitReached": "La grabación ha superado la duración máxima permitida, se va a guardar automáticamente.",
"interrupted": "La grabación se ha interrumpido de forma inesperada, se va a guardar la parte ya grabada.",
"failed": "La grabación se ha interrumpido de forma inesperada y no se ha podido guardar.",
"aborted": "No se ha podido iniciar la grabación.",
"requested": "{{name}} ha solicitado iniciar la grabación."
+1 -3
View File
@@ -4,9 +4,7 @@
"normal": "Has salido de la reunión",
"duplicateIdentity": "Te has unido a la reunión desde otro dispositivo",
"participantRemoved": "Un administrador te ha expulsado de la llamada",
"roomDeleted": "Esta reunión ha sido eliminada",
"connectionLost": "Se ha perdido la conexión con la reunión",
"connectionFailed": "No se ha podido acceder a la reunión"
"roomDeleted": "Esta reunión ha sido eliminada"
},
"home": "Volver al inicio",
"back": "Volver a la reunión"
-9
View File
@@ -27,15 +27,6 @@
},
"selected": "sélectionné",
"submit": "OK",
"support": {
"buttonLabel": "Contacter l'aide",
"openError": "Impossible d'ouvrir le formulaire de contact. Réessayez plus tard.",
"sent": {
"title": "Message envoyé",
"body": "L'équipe support a bien reçu votre message.",
"close": "Fermer"
}
},
"footer": {
"links": {
"legifrance": "legifrance.gouv.fr",
@@ -37,7 +37,6 @@
"started": "{{name}} a démarré la transcription de la réunion.",
"stopped": "{{name}} a arrêté la transcription de la réunion.",
"limitReached": "La transcription a dépassé la durée maximale autorisée, elle va être automatiquement sauvegardée.",
"interrupted": "La transcription s'est interrompue de façon inattendue, la partie déjà enregistrée va être sauvegardée.",
"failed": "La transcription s'est interrompue de façon inattendue et n'a pas pu être sauvegardée.",
"aborted": "La transcription n'a pas pu être démarrée.",
"requested": "{{name}} a demandé à démarrer la transcription."
@@ -47,7 +46,6 @@
"started": "{{name}} a démarré l'enregistrement de la réunion.",
"stopped": "{{name}} a arrêté l'enregistrement de la réunion.",
"limitReached": "L'enregistrement a dépassé la durée maximale autorisée, il va être automatiquement sauvegardé.",
"interrupted": "L'enregistrement s'est interrompu de façon inattendue, la partie déjà enregistrée va être sauvegardée.",
"failed": "L'enregistrement s'est interrompu de façon inattendue et n'a pas pu être sauvegardé.",
"aborted": "L'enregistrement n'a pas pu être démarré.",
"requested": "{{name}} a demandé à démarrer l'enregistrement."
+1 -3
View File
@@ -4,9 +4,7 @@
"normal": "Vous avez quitté la réunion",
"duplicateIdentity": "Vous avez rejoint la réunion depuis un autre appareil",
"participantRemoved": "Vous avez été exclu de l'appel par un administrateur",
"roomDeleted": "Cette réunion a été supprimée",
"connectionLost": "La connexion à la réunion a été perdue",
"connectionFailed": "Impossible de rejoindre la réunion"
"roomDeleted": "Cette réunion a été supprimée"
},
"home": "Retourner à l'accueil",
"back": "Réintégrer la réunion"
-9
View File
@@ -26,15 +26,6 @@
},
"selected": "geselecteerd",
"submit": "OK",
"support": {
"buttonLabel": "Contact ondersteuning",
"openError": "Het contactformulier kon niet worden geopend. Probeer het later opnieuw.",
"sent": {
"title": "Bericht verzonden",
"body": "Het supportteam heeft je bericht ontvangen.",
"close": "Sluiten"
}
},
"footer": {
"links": {
"legifrance": "legifrance.gouv.fr",
@@ -37,7 +37,6 @@
"started": "{{name}} is de transcriptie van de vergadering gestart.",
"stopped": "{{name}} heeft de transcriptie van de vergadering gestopt.",
"limitReached": "De transcriptie heeft de maximaal toegestane duur overschreden en wordt automatisch opgeslagen.",
"interrupted": "De transcriptie is onverwacht gestopt, het al opgenomen deel wordt opgeslagen.",
"failed": "De transcriptie is onverwacht gestopt en kon niet worden opgeslagen.",
"aborted": "De transcriptie kon niet worden gestart.",
"requested": "{{name}} wil graag de transcriptie starten."
@@ -47,7 +46,6 @@
"started": "{{name}} is begonnen met het opnemen van de vergadering.",
"stopped": "{{name}} is gestopt met het opnemen van de vergadering.",
"limitReached": "De opname heeft de maximaal toegestane duur overschreden en wordt automatisch opgeslagen.",
"interrupted": "De opname is onverwacht gestopt, het al opgenomen deel wordt opgeslagen.",
"failed": "De opname is onverwacht gestopt en kon niet worden opgeslagen.",
"aborted": "De opname kon niet worden gestart.",
"requested": "{{name}} wil graag de opname starten."
+1 -3
View File
@@ -4,9 +4,7 @@
"normal": "Je hebt de vergadering verlaten",
"duplicateIdentity": "U heeft de vergadering via een ander apparaat geopend",
"participantRemoved": "U bent door een beheerder uit het gesprek verwijderd",
"roomDeleted": "Deze vergadering is verwijderd",
"connectionLost": "De verbinding met de vergadering is verbroken",
"connectionFailed": "Deelnemen aan de vergadering is niet gelukt"
"roomDeleted": "Deze vergadering is verwijderd"
},
"home": "Keer terug naar het hoofdscherm",
"back": "Sluit weer bij de vergadering aan"
-13
View File
@@ -1,13 +0,0 @@
import { proxy } from 'valtio'
export type SupportWidgetStatus = 'closed' | 'pending' | 'open'
type State = {
status: SupportWidgetStatus
showSentConfirmation: boolean
}
export const supportStore = proxy<State>({
status: 'closed',
showSentConfirmation: false,
})
+8
View File
@@ -72,6 +72,14 @@ main#main-content :is(h1, h2, h3)[tabindex='-1']:focus {
}
}
body:has(.lk-video-conference) #crisp-chatbox-button {
display: none !important;
}
body:has(.lk-video-conference) #crisp-chatbox > * > div[role='button'] {
display: none !important;
}
html:has(.lk-video-conference) {
scrollbar-gutter: auto !important;
}
+2 -21
View File
@@ -1,6 +1,5 @@
import { readFileSync, writeFileSync } from 'node:fs'
import { join } from 'node:path'
import { defineConfig, loadEnv, type Plugin } from 'vite'
import { readFileSync } from 'node:fs'
import { defineConfig, loadEnv } from 'vite'
import react from '@vitejs/plugin-react'
import { visualizer } from 'rollup-plugin-visualizer'
import svgr from 'vite-plugin-svgr'
@@ -26,23 +25,6 @@ if (mediapipeVersion !== livekitMediapipeVersion) {
)
}
const NOINDEX_TAG = '<meta name="robots" content="noindex, nofollow" />'
const homePage = (): Plugin => ({
name: 'home-page',
apply: 'build',
writeBundle({ dir = 'dist' }) {
const html = readFileSync(join(dir, 'index.html'), 'utf-8')
if (!html.includes(NOINDEX_TAG)) {
throw new Error(
`${dir}/index.html does not contain ${NOINDEX_TAG}, so home.html ` +
`cannot be generated from it. The two must stay in sync.`
)
}
writeFileSync(join(dir, 'home.html'), html.replace(NOINDEX_TAG, ''))
},
})
// https://vitejs.dev/config/
export default defineConfig(({ mode }) => {
const env = loadEnv(mode, process.cwd())
@@ -84,7 +66,6 @@ export default defineConfig(({ mode }) => {
},
],
}),
homePage(),
env.VITE_ANALYZE === 'true' &&
visualizer({
open: true,
+1 -1
View File
@@ -163,7 +163,7 @@ backend:
LIVEKIT_DEFAULT_VIDEO_CODEC: vp9
FRONTEND_IDLE_DISCONNECT_WARNING_DELAY: 9000
FRONTEND_SILENCE_LIVEKIT_DEBUG: False
FRONTEND_SUPPORT: "{'help_article_transcript': 'https://docs.numerique.gouv.fr/docs/ba213749-2379-421c-b2ea-e4bd0840ea9b', 'help_article_recording': 'https://docs.numerique.gouv.fr/docs/a4e12e41-2974-472c-84a9-c00d12c10769', 'help_article_more_tools': 'https://docs.numerique.gouv.fr/docs/75fa98c7-5af1-433e-a611-e38143db26d0'}"
FRONTEND_SUPPORT: "{'id': '58ea6697-8eba-4492-bc59-ad6562585041', 'help_article_transcript': 'https://lasuite.crisp.help/fr/article/visio-transcript-1sjq43x', 'help_article_recording': 'https://lasuite.crisp.help/fr/article/visio-enregistrement-wgc8o0', 'help_article_more_tools': 'https://lasuite.crisp.help/fr/article/visio-tools-bvxj23'}"
FRONTEND_FEEDBACK: "{'url': 'https://grist.numerique.gouv.fr/o/docs/cbMv4G7pLY3Z/USER-RESEARCH-or-LA-SUITE/f/26'}"
FRONTEND_DOCUMENTATION_URL: "https://docs.numerique.gouv.fr/docs/7c5bd65d-3c21-486f-bce1-26e0a921d642/"
FRONTEND_TECHNICAL_DOCUMENTATION_URL: "https://docs.numerique.gouv.fr/docs/f2baa1b9-f29e-4d58-959d-65d4376fc6b8/"
@@ -1,12 +1,8 @@
replicaCount: 1
terminationGracePeriodSeconds: 18000
image:
tag: v1.15.0
egress:
logging:
level: debug
log_level: debug
ws_url: ws://livekit-livekit-server:80
insecure: true
enable_chrome_sandbox: true
@@ -2,11 +2,10 @@ replicaCount: 1
terminationGracePeriodSeconds: 18000
image:
tag: v1.15.0
tag: v1.11.0
egress:
logging:
level: debug
log_level: debug
ws_url: ws://livekit-livekit-server:80
insecure: true
enable_chrome_sandbox: true
@@ -51,7 +51,6 @@ data:
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache" always;
add_header Expires 0 always;
add_header X-Robots-Tag "noindex, nofollow" always;
set $ms_domains "https://*.live.com https://*.office.com https://*.microsoft.com https://*.office365.com https://*.sharepoint.com";
@@ -85,17 +84,6 @@ data:
add_header Cache-Control "public, max-age=2592000";
}
location = / {
try_files /home.html /index.html;
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache";
add_header Expires 0;
}
location = /home.html {
internal;
}
# Serve static files
location / {
try_files $uri $uri/ /index.html;
@@ -103,7 +91,6 @@ data:
add_header Cache-Control "no-cache, no-store, must-revalidate";
add_header Pragma "no-cache"; # HTTP 1.0 header for backward compatibility
add_header Expires 0;
add_header X-Robots-Tag "noindex, nofollow" always;
}
# Optionally, handle 404 errors by redirecting to index.html
+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "mail_mjml",
"version": "1.37.0",
"version": "1.36.3",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "mail_mjml",
"version": "1.37.0",
"version": "1.36.3",
"license": "MIT",
"dependencies": {
"@html-to/text-cli": "0.6.1",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "mail_mjml",
"version": "1.37.0",
"version": "1.36.3",
"description": "An util to generate html and text django's templates from mjml templates",
"type": "module",
"dependencies": {
+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "sdk",
"version": "1.37.0",
"version": "1.36.3",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "sdk",
"version": "1.37.0",
"version": "1.36.3",
"license": "ISC",
"workspaces": [
"./library",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "sdk",
"version": "1.37.0",
"version": "1.36.3",
"author": "",
"license": "ISC",
"description": "",
+1 -1
View File
@@ -1,7 +1,7 @@
[project]
name = "summary"
version = "1.37.0"
version = "1.36.3"
requires-python = ">=3.13"
dependencies = [
"certifi>=2026.10.19",
+14 -3
View File
@@ -5,6 +5,7 @@ from datetime import datetime, timezone
from celery.result import AsyncResult
from fastapi import APIRouter, Depends, HTTPException, Request, status
from pydantic import ValidationError
from summary.core.analytics import get_analytics
from summary.core.celery_worker import (
@@ -13,7 +14,9 @@ from summary.core.celery_worker import (
summarize_v2_task,
)
from summary.core.config import AuthorizedTenant, get_settings
from summary.core.exceptions import CleanedValidationError
from summary.core.models import SummarizeTaskApiRequest, TranscribeTaskApiRequest
from summary.core.privacy import dump_for_transport
from summary.core.security import verify_tenant_api_key_v2
from summary.core.shared_models import (
SummarizeWebhookFailurePayload,
@@ -52,7 +55,7 @@ async def create_transcribe_task_v2(
task = process_audio_transcribe_v2_task.apply_async(
args=[
{
**request.model_dump(),
**dump_for_transport(request),
"tenant_id": request_tenant.id,
"received_at": datetime.now(timezone.utc),
}
@@ -125,7 +128,11 @@ async def get_transcribe_job_status(
if task.status == "SUCCESS":
result = task.result
return TranscribeWebhookSuccessPayload.model_validate(result).model_dump()
try:
payload = TranscribeWebhookSuccessPayload.model_validate(result)
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
return dump_for_transport(payload)
if task.status == "FAILURE":
return TranscribeWebhookFailurePayload(
@@ -155,7 +162,11 @@ async def get_summarize_job_status(
if task.status == "SUCCESS":
result = task.result
return SummarizeWebhookSuccessPayload.model_validate(result).model_dump()
try:
payload = SummarizeWebhookSuccessPayload.model_validate(result)
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
return dump_for_transport(payload)
if task.status == "FAILURE":
return SummarizeWebhookFailurePayload(
+6 -7
View File
@@ -5,7 +5,6 @@ import socket
import time
from collections import Counter
from functools import cached_property, lru_cache
from urllib.parse import urlsplit, urlunsplit
import redis
from celery.utils.log import get_task_logger
@@ -13,6 +12,7 @@ from posthog import Posthog
from summary.core.config import get_settings
from summary.core.models import SummarizeTaskJob, TranscribeTaskJob
from summary.core.privacy import redact_url
logger = get_task_logger(__name__)
settings = get_settings()
@@ -54,8 +54,8 @@ class Analytics:
self._client.capture(
event_name, distinct_id=distinct_id, properties=properties
)
except Exception as e:
raise AnalyticsException("Failed to capture analytics event") from e
except Exception:
raise AnalyticsException("Failed to capture analytics event") from None
def is_feature_enabled(self, feature_name: str, distinct_id: str = None) -> bool:
"""Check if a feature flag is enabled for a user."""
@@ -64,8 +64,8 @@ class Analytics:
try:
return self._client.feature_enabled(feature_name, distinct_id)
except Exception as e:
logger.error("Error checking feature flag %s: %s", feature_name, e)
except Exception:
logger.error("Error checking feature flag %s", feature_name)
return False
@@ -133,8 +133,7 @@ class MetadataManager:
}
if isinstance(task_payload, TranscribeTaskJob):
parts = urlsplit(task_payload.cloud_storage_url)
clean_url = urlunsplit((parts.scheme, parts.netloc, parts.path, "", ""))
clean_url = redact_url(task_payload.cloud_storage_url.get_secret_value())
initial_metadata["source_url"] = clean_url
initial_metadata["asr_model"] = settings.whisperx_asr_model
elif isinstance(task_payload, SummarizeTaskJob):
+105 -40
View File
@@ -3,20 +3,23 @@
# ruff: noqa: PLR0913
import json
import logging
import time
from datetime import datetime, timezone
from typing import Any
from urllib.parse import urljoin
import requests
from celery import Celery, signals
from celery import Celery, Task, signals
from celery.utils.log import get_task_logger
from openai.types.audio import Transcription
from pydantic import SecretStr, ValidationError
from requests import exceptions
from summary.core.analytics import MetadataManager, get_analytics
from summary.core.config import get_settings
from summary.core.docs_service import create_document_in_lasuite_docs
from summary.core.exceptions import CleanedValidationError
from summary.core.file_service import (
CorruptedAudioFile,
FileService,
@@ -31,6 +34,7 @@ from summary.core.models import (
SummarizeTaskJob,
TranscribeTaskJob,
)
from summary.core.privacy import dump_for_transport, redact_url
from summary.core.prompt import (
FORMAT_NEXT_STEPS,
FORMAT_PLAN,
@@ -63,8 +67,24 @@ metadata_manager = MetadataManager()
logger = get_task_logger(__name__)
def _reveal(secret: SecretStr | None) -> str | None:
"""Return the underlying value of an optional secret."""
return secret.get_secret_value() if secret is not None else None
class PrivateTask(Task):
"""Hide task arguments in Celery logs and monitoring events."""
def apply_async(self, args=None, kwargs=None, **options):
"""Publish with redacted display representations."""
options.update(argsrepr="[Filtered]", kwargsrepr="[Filtered]")
return super().apply_async(args=args, kwargs=kwargs, **options)
celery = Celery(
__name__,
task_cls=PrivateTask,
broker=settings.celery_broker_url,
backend=settings.celery_result_backend,
broker_connection_retry_on_startup=True,
@@ -76,10 +96,28 @@ celery = Celery(
celery.config_from_object("summary.core.celery_config")
class CeleryLogPrivacyFilter(logging.Filter):
"""Prevent Celery trace logs from serializing task results or exceptions."""
def filter(self, record):
"""Keep task identity and state without upstream values."""
if record.levelno < logging.INFO:
return True
data = getattr(record, "data", None)
if isinstance(data, dict):
record.msg = "Task %s[%s] finished or retried (details omitted)"
record.args = (data.get("name", "unknown"), data.get("id", "unknown"))
record.data = {}
record.exc_info = None
record.exc_text = None
return True
@signals.celeryd_init.connect
def init_celery_sentry(**_kwargs):
"""Initialize Sentry in the Celery worker."""
init_sentry()
logging.getLogger("celery.app.trace").addFilter(CeleryLogPrivacyFilter())
file_service = FileService()
@@ -162,9 +200,9 @@ def transcribe_audio(
try:
res.raise_for_status()
except requests.exceptions.HTTPError:
logger.exception("WhisperX transcription failed")
logger.error("WhisperX transcription failed")
# We reraise the error so that it can be retried by celery
raise
raise requests.exceptions.HTTPError("WhisperX request failed") from None
transcription_json: dict[str, Any] = res.json()
# We remove the "usage" key from the transcription_json dictionary
@@ -175,13 +213,16 @@ def transcribe_audio(
# We force the use of the Transcription model here
# to avoid changing too much code for now.
# Note that it should be WhisperXResponse instead.
transcription = Transcription.model_validate(
# We add a dummy "text" to make the model validate,
# Some API responses lack the "text" key.
{"text": "", **transcription_json},
extra="allow",
strict=False,
)
try:
transcription = Transcription.model_validate(
# We add a dummy "text" to make the model validate,
# Some API responses lack the "text" key.
{"text": "", **transcription_json},
extra="allow",
strict=False,
)
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
# Logging
transcription_duration = round(time.time() - transcription_start_time, 2)
@@ -199,9 +240,9 @@ def transcribe_audio(
if raises:
raise e
redacted_cloud_storage_url = (
cloud_storage_url.split("?", 1)[0] if cloud_storage_url else None
redact_url(cloud_storage_url) if cloud_storage_url else None
)
logger.exception(
logger.error(
("Unexpected error while preparing file %s "),
redacted_cloud_storage_url,
)
@@ -230,7 +271,7 @@ def resolve_speaker_identities_and_apply_to(
logger.debug("Running resolve_speaker_identities")
try:
metadata = file_service.read_cloud_storage_json(
recording_metadata.cloud_storage_url
recording_metadata.cloud_storage_url.get_secret_value()
)
speaker_mapping = resolve_speaker_identities(
metadata,
@@ -241,21 +282,18 @@ def resolve_speaker_identities_and_apply_to(
new_transcription = speaker_mapping.apply_to(transcription.model_dump())
return WhisperXResponse.model_validate(new_transcription)
except FileServiceException as exc:
except FileServiceException:
logger.error(
"Error reading metadata for task %s; skipping speaker assignment."
" Error: %s",
"Error reading metadata for task %s; skipping speaker assignment.",
task_id,
exc,
)
return transcription
except Exception as exc:
logger.exception(
except Exception:
logger.error(
"resolve_speaker_identities failed for task %s; skipping"
" speaker assignment. Error: %s",
" speaker assignment.",
task_id,
exc,
)
return transcription
@@ -302,6 +340,17 @@ def format_actions(llm_output: dict) -> str:
return ""
def parse_llm_json(value: str) -> dict:
"""Parse an LLM response without exposing it in decoding errors."""
try:
result = json.loads(value)
if not isinstance(result, dict):
raise ValueError
return result
except (TypeError, ValueError):
raise LLMException("Invalid LLM response") from None
def summarize_transcription_internals(
*, distinct_id: str, transcript: str, session_id: str
) -> str:
@@ -342,13 +391,13 @@ def summarize_transcription_internals(
)
logger.info("Plan generated")
res = json.loads(parts)
res = parse_llm_json(parts)
parts = res.get("titles", [])
logger.info("Parts to summarize: %s", parts)
logger.info("Parts to summarize: %s", len(parts))
parts_summarized = []
for part in parts:
for i, part in enumerate(parts):
prompt_user_part = PROMPT_USER_PART.format(part=part, transcript=transcript)
logger.info("Summarizing part: %s", part)
logger.info("Summarizing part %s", i + 1)
parts_summarized.append(
llm_service.call(PROMPT_SYSTEM_PART, prompt_user_part, name="part")
)
@@ -364,7 +413,7 @@ def summarize_transcription_internals(
response_format=FORMAT_NEXT_STEPS,
)
next_steps = format_actions(json.loads(next_steps))
next_steps = format_actions(parse_llm_json(next_steps))
logger.info("Next steps generated")
@@ -437,9 +486,11 @@ def call_webhook_v2_task(
tenant_id: str,
):
"""Calls a webhook asynchrously (retry handled by celery)."""
call_webhook_v2(
payload=webhook_payload_adapter.validate_python(payload), tenant_id=tenant_id
)
try:
validated_payload = webhook_payload_adapter.validate_python(payload)
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
call_webhook_v2(payload=validated_payload, tenant_id=tenant_id)
@celery.task(
@@ -465,7 +516,10 @@ def process_audio_transcribe_v2_task(
self: Celery task instance (passed on with bind=True)
payload: Serialized dictionary of TranscribeSummarizeTaskCreationV2
"""
payload = TranscribeTaskJob.model_validate(payload)
try:
payload = TranscribeTaskJob.model_validate(payload)
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
logger.info(
"Transcribing for object received | Owner: %s",
payload.user_sub,
@@ -477,7 +531,7 @@ def process_audio_transcribe_v2_task(
transcription_res = WhisperXResponse(
**transcribe_audio( # type: ignore
task_id=job_id,
cloud_storage_url=payload.cloud_storage_url,
cloud_storage_url=payload.cloud_storage_url.get_secret_value(),
language=payload.language,
raises=True,
).model_dump()
@@ -514,8 +568,8 @@ def process_audio_transcribe_v2_task(
transcription_res.model_dump(),
payload.context_language,
payload.language,
payload.push_to_docs_config.download_link,
payload.push_to_docs_config.form_link,
_reveal(payload.push_to_docs_config.download_link),
_reveal(payload.push_to_docs_config.form_link),
)
create_document_in_lasuite_docs(
@@ -556,18 +610,22 @@ def process_audio_transcribe_v2_task(
transcription_data_url=file_service.get_transcript_signed_url(job_id),
)
call_webhook_v2_task.apply_async(
args=[success_payload.model_dump(), payload.tenant_id]
args=[dump_for_transport(success_payload), payload.tenant_id]
)
metadata_manager.capture(job_id, settings.posthog_transcript_success)
return success_payload.model_dump()
return dump_for_transport(success_payload)
@signals.task_prerun.connect(sender=process_audio_transcribe_v2_task)
def task_started_transcript(task_id=None, task=None, args=None, **kwargs):
"""Signal handler called before task execution begins."""
if args:
metadata_manager.create(task_id, TranscribeTaskJob.model_validate(args[0]))
try:
payload = TranscribeTaskJob.model_validate(args[0])
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
metadata_manager.create(task_id, payload)
@signals.task_retry.connect(sender=process_audio_transcribe_v2_task)
@@ -627,7 +685,10 @@ def summarize_v2_task(
1. Run summary internals
2. Sends the final summary via webhook.
"""
payload = SummarizeTaskJob.model_validate(payload)
try:
payload = SummarizeTaskJob.model_validate(payload)
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
summary = summarize_transcription_internals(
distinct_id=payload.user_sub,
transcript=payload.content,
@@ -652,18 +713,22 @@ def summarize_v2_task(
summary_data_url=file_service.get_summary_signed_url(job_id),
)
call_webhook_v2_task.apply_async(
args=[success_payload.model_dump(), payload.tenant_id]
args=[dump_for_transport(success_payload), payload.tenant_id]
)
metadata_manager.capture(job_id, settings.posthog_summary_success)
return success_payload.model_dump()
return dump_for_transport(success_payload)
@signals.task_prerun.connect(sender=summarize_v2_task)
def task_started_summary(task_id=None, task=None, args=None, **kwargs):
"""Signal handler called before task execution begins."""
if args:
metadata_manager.create(task_id, SummarizeTaskJob.model_validate(args[0]))
try:
payload = SummarizeTaskJob.model_validate(args[0])
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
metadata_manager.create(task_id, payload)
@signals.task_retry.connect(sender=summarize_v2_task)
+3 -1
View File
@@ -4,7 +4,7 @@ import json
import logging
from urllib.parse import urljoin
from requests import Session
from requests import RequestException, Session
from requests.adapters import HTTPAdapter
from urllib3.util import Retry
@@ -43,6 +43,8 @@ def _post_with_retries(*, url, data, api_key: str | None = None):
response = session.post(url, json=data, timeout=(20, 3 * 60))
response.raise_for_status()
return response
except RequestException:
raise RequestException("Docs delivery failed") from None
finally:
session.close()
+62
View File
@@ -0,0 +1,62 @@
"""Validation errors suitable for logging and transport."""
from typing import get_args
from pydantic import SecretStr, ValidationError
from pydantic_core import ErrorType, PydanticCustomError
_BUILTIN_ERROR_TYPES = frozenset(get_args(ErrorType))
def clean_validation_errors(errors: list[dict]) -> list[dict]:
"""Mask SecretStr values, including those nested in validation input."""
def clean(value):
if isinstance(value, SecretStr):
return "[redacted]"
if isinstance(value, Exception):
# Do not retain validator exception objects, whose args may hold secrets.
return str(value)
if isinstance(value, dict):
return {key: clean(item) for key, item in value.items()}
if isinstance(value, list):
return [clean(item) for item in value]
if isinstance(value, tuple):
return tuple(clean(item) for item in value)
return value
return clean(errors)
class CleanedValidationError(ValidationError):
"""A new Pydantic exception with secret inputs replaced by a marker."""
def __init__(self, error, *args, secret_input=False, **kwargs):
"""State is initialized by Pydantic during __new__."""
def __new__(cls, error, *args, secret_input=False, **kwargs):
"""Accept an original error, or Pydantic's native construction arguments."""
if not isinstance(error, ValidationError):
# Pydantic uses this path when constructing or unpickling the error.
return super().__new__(cls, error, *args, **kwargs)
details = clean_validation_errors(error.errors(include_url=False))
for detail in details:
if secret_input:
# An adapter may have received the unwrapped value of a SecretStr.
detail["input"] = "[redacted]"
return cls._from_details(error.title, details)
@classmethod
def _from_details(cls, title, details):
"""Reconstruct builtin and custom Pydantic error codes."""
for detail in details:
if detail["type"] not in _BUILTIN_ERROR_TYPES:
detail["type"] = PydanticCustomError(
detail["type"], detail["msg"], detail.get("ctx")
)
return cls.from_exception_data(title, details, hide_input=True)
def __reduce__(self):
"""Preserve custom error codes when Celery pickles the exception."""
return self._from_details, (self.title, self.errors(include_url=False))
+5 -4
View File
@@ -17,6 +17,7 @@ import requests
from botocore.config import Config
from summary.core.config import get_settings
from summary.core.privacy import redact_url
from summary.core.shared_models import WhisperXResponse
settings = get_settings()
@@ -314,7 +315,7 @@ class FileService:
"""Download file from a cloud storage URL to local temporary file."""
logger.info(
"Download recording from URL | cloud_storage_url: %s",
cloud_storage_url,
redact_url(cloud_storage_url),
)
if not cloud_storage_url:
@@ -352,10 +353,10 @@ class FileService:
logger.debug("Recording local file path: %s", local_path)
return local_path
except requests.RequestException as e:
except requests.RequestException:
raise FileServiceException(
"Unexpected error while downloading object from cloud_storage_url."
) from e
) from None
def _validate_duration(self, duration_seconds: float) -> None:
"""Validate audio file duration against configured maximum."""
@@ -376,7 +377,7 @@ class FileService:
def read_cloud_storage_json(self, cloud_storage_url: str) -> dict:
"""Read and parse a JSON file from a url."""
logger.info("Reading JSON: %s", cloud_storage_url)
logger.info("Reading JSON: %s", redact_url(cloud_storage_url))
res = requests.get(cloud_storage_url, timeout=(10, 100))
res.raise_for_status()
return res.json()
+3 -3
View File
@@ -140,6 +140,6 @@ class LLMService:
response = self._client.chat.completions.create(**params)
return response.choices[0].message.content
except Exception as e:
logger.exception("LLM call failed: %s", e)
raise LLMException(f"LLM call failed: {e}") from e
except Exception:
logger.error("LLM call failed")
raise LLMException("LLM call failed") from None
+19 -6
View File
@@ -2,10 +2,17 @@
from datetime import datetime
from pydantic import AwareDatetime, BaseModel, EmailStr, Field, field_validator
from pydantic import (
AwareDatetime,
BaseModel,
ConfigDict,
EmailStr,
Field,
field_validator,
)
from summary.core.config import get_settings
from summary.core.types import Url
from summary.core.types import SecretUrl
settings = get_settings()
@@ -13,6 +20,8 @@ settings = get_settings()
class SharedV2TaskCreation(BaseModel):
"""Model that holds basic information for task creation."""
model_config = ConfigDict(hide_input_in_errors=True)
user_sub: str = Field(title="User Sub", description="The user's sub.")
user_email: EmailStr | None = Field(
default=None,
@@ -24,7 +33,9 @@ class SharedV2TaskCreation(BaseModel):
class RecordingMetadata(BaseModel):
"""Model for recording metadata."""
cloud_storage_url: Url = Field(
model_config = ConfigDict(hide_input_in_errors=True)
cloud_storage_url: SecretUrl = Field(
title="Cloud Storage URL",
description="The URL of the metadata file for speaker assignment.",
)
@@ -35,6 +46,8 @@ class RecordingMetadata(BaseModel):
class PushToDocsBaseConfig(BaseModel):
"""Model containing information for pushing transcript and summaries to docs."""
model_config = ConfigDict(hide_input_in_errors=True)
user_email: EmailStr = Field(
title="User Email", description="The user's email, future owner of the docs."
)
@@ -44,12 +57,12 @@ class PushToDocsBaseConfig(BaseModel):
class PushToDocsTranscriptConfig(PushToDocsBaseConfig):
"""Model for push to docs information for transcripts."""
download_link: Url | None = Field(
download_link: SecretUrl | None = Field(
default=None,
title="Download Link",
description="The link to download the recording.",
)
form_link: Url | None = Field(
form_link: SecretUrl | None = Field(
default=None,
title="Form Link",
description="The link to fill out a form for the recording.",
@@ -69,7 +82,7 @@ class PushToDocsSummaryConfig(PushToDocsBaseConfig):
class TranscribeTaskApiRequest(SharedV2TaskCreation):
"""Model for creating a transcribe task (used for API request)."""
cloud_storage_url: Url = Field(
cloud_storage_url: SecretUrl = Field(
title="Cloud storage URL",
description="The URL of the audio file to transcribe.",
)
+36
View File
@@ -0,0 +1,36 @@
"""Privacy helpers for observability."""
from urllib.parse import urlsplit, urlunsplit
from pydantic import BaseModel, SecretStr
def dump_for_transport(model: BaseModel) -> dict:
"""Reveal secrets explicitly for task messages, HTTP bodies and API responses."""
def reveal(value):
if isinstance(value, SecretStr):
return value.get_secret_value()
if isinstance(value, dict):
return {key: reveal(item) for key, item in value.items()}
if isinstance(value, list):
return [reveal(item) for item in value]
return value
return reveal(model.model_dump())
def redact_url(url):
"""Keep the source identifiable without logging query or user credentials."""
if not isinstance(url, str):
return "[redacted]"
# Remove query and fragment before parsing, including for malformed URLs.
base, has_query, _ = url.partition("?")
base = base.partition("#")[0]
try:
parts = urlsplit(base)
except ValueError:
return "[redacted]"
authority = parts.netloc.rsplit("@", 1)[-1]
redacted = urlunsplit(parts._replace(netloc=authority))
return redacted + ("?[redacted]" if has_query else "")
+43
View File
@@ -1,9 +1,12 @@
"""Sentry configuration."""
import re
import sentry_sdk
from sentry_sdk.scrubber import DEFAULT_DENYLIST, DEFAULT_PII_DENYLIST, EventScrubber
from summary.core.config import get_settings
from summary.core.privacy import redact_url
# Exact names (case-insensitive) of variables and dict keys to redact.
SENSITIVE_DATA_DENYLIST = [
@@ -90,5 +93,45 @@ def init_sentry() -> None:
# Task creation requests carry the content to summarize.
max_request_body_size="never",
include_local_variables=True,
before_send=before_send,
before_send_transaction=before_send,
before_breadcrumb=before_breadcrumb,
event_scrubber=build_event_scrubber(),
)
def _scrub_strings(value):
"""Remove URL credentials, queries and fragments throughout an event."""
if isinstance(value, str):
return re.sub(
r"https?://[^\s\"'<>]+",
lambda m: redact_url(m.group()),
value,
flags=re.IGNORECASE,
)
if isinstance(value, dict):
return {key: _scrub_strings(item) for key, item in value.items()}
if isinstance(value, list):
return [_scrub_strings(item) for item in value]
return value
def before_send(event, hint):
"""Keep exception types and stacks, but discard untrusted message text."""
del hint
event.pop("message", None)
event.pop("logentry", None)
request = event.get("request", {})
request.pop("data", None)
request.pop("query_string", None)
for exception in event.get("exception", {}).get("values", []):
exception["value"] = "[Filtered]"
return _scrub_strings(event)
def before_breadcrumb(crumb, hint):
"""Drop arbitrary breadcrumb text and scrub URLs in structured data."""
del hint
crumb.pop("message", None)
crumb.pop("data", None)
return _scrub_strings(crumb)
+7 -3
View File
@@ -2,7 +2,9 @@
from typing import Annotated, Literal, Union
from pydantic import BaseModel, Field, TypeAdapter
from pydantic import BaseModel, ConfigDict, Field, TypeAdapter
from summary.core.types import SecretUrl
class WordSegment(BaseModel):
@@ -65,6 +67,8 @@ class WhisperXResponse(BaseModel):
class BaseWebhook(BaseModel):
"""Base webhook payload."""
model_config = ConfigDict(hide_input_in_errors=True)
job_id: str = Field(
title="Job ID",
description="The ID of the job document in the receiver system.",
@@ -76,7 +80,7 @@ class TranscribeWebhookSuccessPayload(BaseWebhook):
type: Literal["transcript"] = Field(default="transcript")
status: Literal["success"] = Field(default="success")
transcription_data_url: str = Field(
transcription_data_url: SecretUrl = Field(
title="Transcript", description="URL to the raw transcription data."
)
@@ -121,7 +125,7 @@ class SummarizeWebhookSuccessPayload(BaseWebhook):
type: Literal["summary"] = Field(default="summary")
status: Literal["success"] = Field(default="success")
summary_data_url: str = Field(
summary_data_url: SecretUrl = Field(
title="Summary", description="URL to the raw summary data."
)
+23 -1
View File
@@ -2,9 +2,31 @@
from typing import Annotated
from pydantic import BeforeValidator, HttpUrl, TypeAdapter
from pydantic import (
AfterValidator,
BeforeValidator,
HttpUrl,
SecretStr,
TypeAdapter,
ValidationError,
)
from summary.core.exceptions import CleanedValidationError
http_url_adapter = TypeAdapter(HttpUrl)
Url = Annotated[
str, BeforeValidator(lambda value: str(http_url_adapter.validate_python(value)))
]
def _validate_secret_url(value: SecretStr) -> SecretStr:
"""Validate and normalize a URL without echoing it in validator messages."""
try:
return SecretStr(
str(http_url_adapter.validate_python(value.get_secret_value()))
)
except ValidationError as exc:
raise CleanedValidationError(exc, secret_input=True) from None
SecretUrl = Annotated[SecretStr, AfterValidator(_validate_secret_url)]

Some files were not shown because too many files have changed in this diff Show More