gsadmin/libredesk
1
0
Fork 0
mirror of https://github.com/abhinavxd/libredesk.git synced 2026-09-11 13:28:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

allow contact updates in create conversation API for callers with contacts:write

Browse Source
This commit is contained in:
Abhinav Raut
2026-08-11 11:53:01 +05:30
parent a097ca8536
commit bb4fecca67
1 changed files with 23 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/conversation.go
+23 -12
View File
@@ -816,23 +816,34 @@ func handleCreateConversation(r *fastglue.Request) error {
ExternalUserID: null.NewString(req.ExternalUserID, req.ExternalUserID != ""),
CustomAttributes: json.RawMessage(`{}`),
}
// Reuse an existing contact as-is; this endpoint is gated only on conversations:write and must never rename a contact.
// Match by external_user_id when provided - one email can map to multiple external IDs.
var existing umodels.User
if req.ExternalUserID != "" {
existing, err = app.user.GetByExternalID(req.ExternalUserID)
} else {
existing, err = app.user.GetContactByEmail(email)
}
// Callers with contacts:write may update the contact's name/email via the CreateContact upsert;
// others only reuse the existing contact as-is.
canWriteContacts, err := app.authz.Enforce(user, "contacts", "write")
if err != nil {
if envErr, ok := err.(envelope.Error); !ok || envErr.ErrorType != envelope.NotFoundError {
return sendErrorEnvelope(r, err)
}
return sendErrorEnvelope(r, envelope.NewError(envelope.GeneralError, app.i18n.T("globals.messages.somethingWentWrong"), nil))
}
if canWriteContacts {
if err := app.user.CreateContact(&contact); err != nil {
return sendErrorEnvelope(r, envelope.NewError(envelope.GeneralError, app.i18n.T("globals.messages.somethingWentWrong"), nil))
}
} else {
contact.ID = existing.ID
// Match by external_user_id when provided - one email can map to multiple external IDs.
var existing umodels.User
if req.ExternalUserID != "" {
existing, err = app.user.GetByExternalID(req.ExternalUserID)
} else {
existing, err = app.user.GetContactByEmail(email)
}
if err != nil {
if envErr, ok := err.(envelope.Error); !ok || envErr.ErrorType != envelope.NotFoundError {
return sendErrorEnvelope(r, err)
}
if err := app.user.CreateContact(&contact); err != nil {
return sendErrorEnvelope(r, envelope.NewError(envelope.GeneralError, app.i18n.T("globals.messages.somethingWentWrong"), nil))
}
} else {
contact.ID = existing.ID
}
}
// Create conversation first.