gsadmin/libredesk
1
0
Fork 0
mirror of https://github.com/abhinavxd/libredesk.git synced 2026-09-22 02:23:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve readability and logging in rule evaluator

Browse Source
This commit is contained in:
Abhinav Raut
2025-01-12 20:41:26 +05:30
parent 6475d14ab2
commit 1d4a686d15
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/automation/evaluator.go
+9 -6
View File
@@ -24,18 +24,19 @@ func (e *Engine) evalConversationRules(rules []models.Rule, conversation cmodels
continue
}
var results []bool
for _, group := range rule.Groups {
var groupEvalResults []bool
for idx, group := range rule.Groups {
if len(group.Rules) == 0 {
results = append(results, true)
e.lo.Debug("no rules found in group, skipping rule group evaluation", "group_num", idx+1, "conversation_uuid", conversation.UUID)
groupEvalResults = append(groupEvalResults, true)
continue
}
result := e.evaluateGroup(group.Rules, group.LogicalOp, conversation)
e.lo.Debug("evaluating group rules", "logical_op", group.LogicalOp, "result", result, "conversation_uuid", conversation.UUID)
results = append(results, result)
e.lo.Debug("group rule evaluation complete", "logical_op", group.LogicalOp, "result", result, "conversation_uuid", conversation.UUID)
groupEvalResults = append(groupEvalResults, result)
}
if evaluateFinalResult(results, rule.GroupOperator) {
if evaluateFinalResult(groupEvalResults, rule.GroupOperator) {
e.lo.Debug("rule evaluation successful executing actions", "conversation_uuid", conversation.UUID)
for _, action := range rule.Actions {
e.applyAction(action, conversation)
@@ -44,6 +45,8 @@ func (e *Engine) evalConversationRules(rules []models.Rule, conversation cmodels
e.lo.Debug("first match rule execution mode, breaking out of rule evaluation", "conversation_uuid", conversation.UUID)
break
}
} else {
e.lo.Debug("rule evaluation failed, skipping actions", "group_eval_results", groupEvalResults, "conversation_uuid", conversation.UUID)
}
}
}