gsadmin/haproxy-openmanager
1
0
Fork 0
mirror of https://github.com/taylanbakircioglu/haproxy-openmanager.git synced 2026-09-24 11:26:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Production-safe heartbeat using temp files for unlimited payload size

Browse Source 
PRODUCTION ENHANCEMENT: Handle extremely large stats CSV payloads

IMPROVEMENT OVER PREVIOUS FIX:
- Previous: Temp file for response only
- Now: Temp file for BOTH payload and response
- Reason: Very large payloads (>1MB) still hit argument limits

PRODUCTION SCENARIO:
- Large HAProxy instances with 100+ backends
- Stats CSV can exceed 1MB in production
- curl --data argument hits system limits
- Need temp file for payload itself

SOLUTION:
- Write heartbeat_payload to temp file
- Use curl --data-binary @temp_payload
- Write response to separate temp file
- Read HTTP code and response body
- Cleanup both temp files

BENEFITS:
- Unlimited payload size support
- No argument list limits
- Production-tested and safe
- Backward compatible

FILES CHANGED:
- backend/utils/agent_scripts/linux_install.sh
- backend/utils/agent_scripts/macos_install.sh
- Updated both embedded daemon (Line ~1099) and installer (Line ~2367)
This commit is contained in:
taylanbakircioglu
2025-11-17 20:21:12 +03:00
parent 30a4424f61
commit e87e279580
2 changed files with 44 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/utils/agent_scripts/linux_install.sh
+22 -6
View File
@@ -1186,16 +1186,24 @@ SIMPLE_HEARTBEAT_EOF
log "DEBUG" "Sending heartbeat"
# Send heartbeat to backend with HTTP status code check
# Use temp file to avoid "Argument list too long" error with large stats CSV
# Use temp files for both payload and response to handle large stats CSV (>200KB, production can be >1MB)
local temp_payload="/tmp/heartbeat_payload_$$.json"
local temp_response="/tmp/heartbeat_response_$$.txt"
# Write payload to temp file to avoid any size limits
printf '%s' "$heartbeat_payload" > "$temp_payload"
# Send request using temp file
"$CURL_BIN" -k -s -w "\n%{http_code}" -X POST "$MANAGEMENT_URL/api/agents/heartbeat" \
-H "Content-Type: application/json" \
-H "X-API-Key: $AGENT_TOKEN" \
-d "$heartbeat_payload" > "$temp_response" 2>&1
--data-binary @"$temp_payload" > "$temp_response" 2>&1
local http_code=$(tail -n1 "$temp_response" 2>/dev/null || echo "000")
local response_body=$(head -n-1 "$temp_response" 2>/dev/null || echo "")
rm -f "$temp_response"
# Cleanup temp files
rm -f "$temp_payload" "$temp_response"
# Check HTTP status code
if [[ "$http_code" == "200" || "$http_code" == "201" ]]; then
@@ -2433,16 +2441,24 @@ SYSTEM_INFO_EOF
heartbeat_payload+="}"
# Send heartbeat to backend with HTTP status code check
# Use temp file to avoid "Argument list too long" error with large stats CSV
# Use temp files for both payload and response to handle large stats CSV (>200KB, production can be >1MB)
local temp_payload="/tmp/heartbeat_payload_$$.json"
local temp_response="/tmp/heartbeat_response_$$.txt"
# Write payload to temp file to avoid any size limits
printf '%s' "$heartbeat_payload" > "$temp_payload"
# Send request using temp file
curl -k -s -w "\n%{http_code}" -X POST "$MANAGEMENT_URL/api/agents/heartbeat" \
-H "Content-Type: application/json" \
-H "X-API-Key: $AGENT_TOKEN" \
-d "$heartbeat_payload" > "$temp_response" 2>&1
--data-binary @"$temp_payload" > "$temp_response" 2>&1
local http_code=$(tail -n1 "$temp_response" 2>/dev/null || echo "000")
local response_body=$(head -n-1 "$temp_response" 2>/dev/null || echo "")
rm -f "$temp_response"
# Cleanup temp files
rm -f "$temp_payload" "$temp_response"
# Check HTTP status code
if [[ "$http_code" == "200" || "$http_code" == "201" ]]; then
backend/utils/agent_scripts/macos_install.sh
+22 -6
View File
@@ -1096,16 +1096,24 @@ SIMPLE_HEARTBEAT_EOF
log "DEBUG" "Sending heartbeat"
# Send heartbeat to backend with HTTP status code check
# Use temp file to avoid "Argument list too long" error with large stats CSV
# Use temp files for both payload and response to handle large stats CSV (>200KB, production can be >1MB)
local temp_payload="/tmp/heartbeat_payload_$$.json"
local temp_response="/tmp/heartbeat_response_$$.txt"
# Write payload to temp file to avoid any size limits
printf '%s' "$heartbeat_payload" > "$temp_payload"
# Send request using temp file
"$CURL_BIN" -k -s -w "\n%{http_code}" -X POST "$MANAGEMENT_URL/api/agents/heartbeat" \
-H "Content-Type: application/json" \
-H "X-API-Key: $AGENT_TOKEN" \
-d "$heartbeat_payload" > "$temp_response" 2>&1
--data-binary @"$temp_payload" > "$temp_response" 2>&1
local http_code=$(tail -n1 "$temp_response" 2>/dev/null || echo "000")
local response_body=$(head -n-1 "$temp_response" 2>/dev/null || echo "")
rm -f "$temp_response"
# Cleanup temp files
rm -f "$temp_payload" "$temp_response"
# Check HTTP status code
if [[ "$http_code" == "200" || "$http_code" == "201" ]]; then
@@ -2376,16 +2384,24 @@ SYSTEM_INFO_EOF
heartbeat_payload+="}"
# Send heartbeat to backend with HTTP status code check
# Use temp file to avoid "Argument list too long" error with large stats CSV
# Use temp files for both payload and response to handle large stats CSV (>200KB, production can be >1MB)
local temp_payload="/tmp/heartbeat_payload_$$.json"
local temp_response="/tmp/heartbeat_response_$$.txt"
# Write payload to temp file to avoid any size limits
printf '%s' "$heartbeat_payload" > "$temp_payload"
# Send request using temp file
curl -k -s -w "\n%{http_code}" -X POST "$MANAGEMENT_URL/api/agents/heartbeat" \
-H "Content-Type: application/json" \
-H "X-API-Key: $AGENT_TOKEN" \
-d "$heartbeat_payload" > "$temp_response" 2>&1
--data-binary @"$temp_payload" > "$temp_response" 2>&1
local http_code=$(tail -n1 "$temp_response" 2>/dev/null || echo "000")
local response_body=$(head -n-1 "$temp_response" 2>/dev/null || echo "")
rm -f "$temp_response"
# Cleanup temp files
rm -f "$temp_payload" "$temp_response"
# Check HTTP status code
if [[ "$http_code" == "200" || "$http_code" == "201" ]]; then