gsadmin/gitbook
1
0
Fork 0
mirror of https://github.com/GitbookIO/gitbook.git synced 2026-09-16 23:55:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix an issue where search and Ask AI triggers unnecessary renders when in a Visitor Authenticated site. (#2738)

Browse Source
This commit is contained in:
Steven H
2025-01-13 21:31:40 +00:00
committed by GitHub
parent 8f046a9cd6
commit dbba50cea4
2 changed files with 28 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/nice-spoons-double.md
+5
View File
@@ -0,0 +1,5 @@
---
'gitbook': minor
---
Fix an issue where search and Ask AI triggers unnecessary renders when in a Visitor Authenticated site.
packages/gitbook/src/middleware.ts
+23 -11
View File
@@ -97,6 +97,7 @@ export type LookupResult = PublishedContentWithCache & {
*/
export async function middleware(request: NextRequest) {
const { url, mode } = getInputURL(request);
const isServerAction = request.headers.has('Next-Action');
setTag('url', url.toString());
setContext('request', {
@@ -284,7 +285,10 @@ export async function middleware(request: NextRequest) {
headers,
},
}),
resolved.cookies,
// A long-standing bug in Nextjs causes modifying cookies in Server Actions to refresh the page and cause root rerenders.
// https://github.com/vercel/next.js/issues/50163
// We don't set the cookies if we're in a server action.
isServerAction ? undefined : resolved.cookies,
);
// Add method so Cloudflare can use it for caching
@@ -299,17 +303,25 @@ export async function middleware(request: NextRequest) {
setMiddlewareHeader(response, 'referrer-policy', 'no-referrer-when-downgrade');
setMiddlewareHeader(response, 'x-content-type-options', 'nosniff');
if (
typeof resolved.cacheMaxAge === 'number' &&
// When the request is authenticated, we don't want to cache the response on the server
!resolved.visitorToken
) {
// For server-actions, we don't want to cache the response on the server
const cacheControl =
request.method === 'POST'
? 'no-store'
: `public, max-age=0, s-maxage=${resolved.cacheMaxAge}, stale-if-error=0`;
const cacheControl = (() => {
// For Server Actions, we don't want to cache the response on the server.
// We don't want to store responses either.
if (isServerAction) {
return 'no-cache, no-store';
}
// When the request is authenticated, we don't want to cache the response on the server.
// Allow storing so that revalidation still happens with server.
if (!resolved.visitorToken) {
return 'no-cache';
}
if (typeof resolved.cacheMaxAge === 'number') {
return `public, max-age=0, s-maxage=${resolved.cacheMaxAge}, stale-if-error=0`;
}
})();
if (cacheControl) {
if (process.env.GITBOOK_OUTPUT_CACHE === 'true' && process.env.NODE_ENV !== 'development') {
setMiddlewareHeader(response, 'cache-control', cacheControl);
setMiddlewareHeader(response, 'Cloudflare-CDN-Cache-Control', cacheControl);