gsadmin/gitbook
1
0
Fork 0
mirror of https://github.com/GitbookIO/gitbook.git synced 2026-09-16 15:45:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

testing using ref for timeout

Browse Source
This commit is contained in:
Claire Chabas
2025-01-13 12:10:22 +01:00
parent 6ba70e649f
commit d4289c387c
1 changed files with 23 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/gitbook/src/components/Search/SearchResults.tsx
+23 -7
View File
@@ -66,6 +66,8 @@ export const SearchResults = React.forwardRef(function SearchResults(
const suggestedQuestionsRef = React.useRef<null | ResultType[]>(null);
const getCtx = useEventCallback(() => ctx);
const timeoutRef = React.useRef<Timer | null>(null);
React.useEffect(() => {
if (!query) {
if (!withAsk) {
@@ -114,7 +116,8 @@ export const SearchResults = React.forwardRef(function SearchResults(
setResultsState((prev) => ({ results: prev.results, fetching: true }));
let cancelled = false;
const timeout = setTimeout(async () => {
timeoutRef.current = setTimeout(async () => {
// const timeout = setTimeout(async () => {
const results = await (global
? searchAllSiteContent(getCtx(), query, pointer)
: searchSiteSpaceContent(getCtx(), query, pointer, revisionId));
@@ -130,11 +133,19 @@ export const SearchResults = React.forwardRef(function SearchResults(
),
{ extra: { results } },
);
setResultsState({ results: [], fetching: false });
// setResultsState({ results: [], fetching: false });
setResultsState((prev) => {
if (prev.results.length === 0 && !prev.fetching) return prev;
return { results: [], fetching: false };
});
return;
}
setResultsState({ results, fetching: false });
// setResultsState({ results, fetching: false });
setResultsState((prev) => {
if (prev.results === results && !prev.fetching) return prev;
return { results, fetching: false };
});
trackEvent({
type: 'search_type_query',
@@ -142,14 +153,19 @@ export const SearchResults = React.forwardRef(function SearchResults(
});
}, 1000);
// return () => {
// cancelled = true;
// clearTimeout(timeout);
// };
return () => {
cancelled = true;
clearTimeout(timeout);
if (timeoutRef.current) {
clearTimeout(timeoutRef.current);
timeoutRef.current = null;
}
};
}
// }, [query, global, pointer, spaceId, revisionId, withAsk, trackEvent, getCtx]);
}, [query, global, pointer, spaceId, revisionId, withAsk, trackEvent]);
// Claire notes: it's not trackEvent
}, [query, global, pointer, spaceId, revisionId, withAsk, trackEvent, getCtx]);
const results: ResultType[] = React.useMemo(() => {
if (!withAsk) {