gsadmin/gitbook
1
0
Fork 0
mirror of https://github.com/GitbookIO/gitbook.git synced 2026-09-30 22:18:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent insights tracking failures from breaking MCP tool requests (#4346)

Browse Source
This commit is contained in:
Nolann B.
2026-06-27 09:31:20 +02:00
committed by GitHub
parent 2fa65e6949
commit b7c3b847e8
1 changed files with 52 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/gitbook/src/app/sites/dynamic/[mode]/[siteURL]/[siteData]/~gitbook/mcp/handler.ts
+52 -46
View File
@@ -12,6 +12,18 @@ import { createMcpHandler } from 'mcp-handler';
import type { NextRequest } from 'next/server';
import { z } from 'zod';
/**
* Fire-and-forget insights tracking for the MCP endpoint. A tracking failure (e.g. a 422 from the
* insights API) must never reject into the request lifecycle, or it surfaces as an MCP transport error.
*/
function trackMcpEvent(args: Parameters<typeof trackServerInsightsEvents>[0]) {
waitUntil(
trackServerInsightsEvents(args).catch((error) => {
console.error('Failed to track MCP insights event:', error);
})
);
}
export async function handleMcpRequest(
rawRequest: NextRequest,
params: RouteLayoutParams,
@@ -31,21 +43,19 @@ export async function handleMcpRequest(
requestURL.search = rawRequest.nextUrl.search;
const request = new Request(requestURL, rawRequest);
waitUntil(
trackServerInsightsEvents({
organizationId: context.organizationId,
siteId: context.site.id,
events: [
{
type: 'mcp_request',
location: {
displayContext: SiteInsightsDisplayContext.Server,
},
trackMcpEvent({
organizationId: context.organizationId,
siteId: context.site.id,
events: [
{
type: 'mcp_request',
location: {
displayContext: SiteInsightsDisplayContext.Server,
},
],
request,
})
);
},
],
request,
});
const mcpHandler = createMcpHandler(
(server) => {
@@ -65,22 +75,20 @@ export async function handleMcpRequest(
})
);
waitUntil(
trackServerInsightsEvents({
organizationId: context.organizationId,
siteId: site.id,
events: [
{
type: 'search_type_query',
query,
location: {
displayContext: SiteInsightsDisplayContext.Mcp,
},
trackMcpEvent({
organizationId: context.organizationId,
siteId: site.id,
events: [
{
type: 'search_type_query',
query,
location: {
displayContext: SiteInsightsDisplayContext.Mcp,
},
],
request,
})
);
},
],
request,
});
return {
content: results.flatMap((result) => {
@@ -186,24 +194,22 @@ export async function handleMcpRequest(
resolved.page
);
waitUntil(
trackServerInsightsEvents({
organizationId: context.organizationId,
siteId: site.id,
events: [
{
type: 'page_view',
location: {
displayContext: SiteInsightsDisplayContext.Mcp,
page: resolved.page.id,
space: match.siteSpace.space.id,
revision: match.siteSpace.space.revision,
},
trackMcpEvent({
organizationId: context.organizationId,
siteId: site.id,
events: [
{
type: 'page_view',
location: {
displayContext: SiteInsightsDisplayContext.Mcp,
page: resolved.page.id,
space: match.siteSpace.space.id,
revision: match.siteSpace.space.revision,
},
],
request,
})
);
},
],
request,
});
return { content: [{ type: 'text', text: markdown }] };
} catch (error) {