gsadmin/gitbook
1
0
Fork 0
mirror of https://github.com/GitbookIO/gitbook.git synced 2026-10-14 09:09:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't link page group breadcrumbs to their redirecting URL (RND-13140)

Browse Source
This commit is contained in:
Peter White
2026-10-14 10:42:44 +02:00
parent f7dc7faa65
commit 9f93c189eb
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/gitbook/src/components/PageBody/PageHeader.tsx
+14 -8
View File
@@ -222,10 +222,15 @@ export async function PageHeader(props: {
))}
{ancestors.map((breadcrumb, index) => {
const parentPages = ancestors[index - 1]?.pages ?? revision.pages;
const href = linker.toPathForPage({
pages: revision.pages,
page: breadcrumb,
});
// A group's own URL only redirects to its first page, so render it as a
// label like the table of contents and section groups do.
const href =
breadcrumb.type === 'group'
? undefined
: linker.toPathForPage({
pages: revision.pages,
page: breadcrumb,
});
return (
<li key={breadcrumb.id} className="inline">
<BreadcrumbItemDropdown
@@ -483,15 +488,16 @@ function getPageSiblings(
if (page.hidden && page.id !== activeId) {
continue;
}
// A group whose subtree has no document resolves to no page — the sidebar renders it as a
// non-clickable label, so don't offer it as a navigable sibling (its path would 404).
if (page.type === 'group' && page.id !== activeId && !resolveFirstDocument([page], [])) {
// A group's own URL redirects to its first document, so link straight to it. A group whose
// subtree has no document resolves to no page, so don't offer it (its path would 404).
const target = page.type === 'group' ? resolveFirstDocument([page], [])?.page : page;
if (!target) {
continue;
}
result.push({
id: page.id,
title: page.linkTitle || page.title,
href: context.linker.toPathForPage({ pages: context.revision.pages, page }),
href: context.linker.toPathForPage({ pages: context.revision.pages, page: target }),
emoji: page.emoji,
icon: page.icon,
isActive: page.id === activeId,