gsadmin/gitbook
1
0
Fork 0
mirror of https://github.com/GitbookIO/gitbook.git synced 2026-09-12 05:48:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix embed search suggested questions not opening the assistant (#4514)

Browse Source
This commit is contained in:
Peter White
2026-08-18 17:19:25 +02:00
committed by GitHub
parent 01c9b059c6
commit 9002f6598a
3 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/embed-search-suggestions.md
+5
View File
@@ -0,0 +1,5 @@
---
"gitbook": patch
---
Fix suggested question clicks in the embed search not opening the assistant.
packages/gitbook/src/components/Search/useSearch.tsx
+3 -3
View File
@@ -163,16 +163,16 @@ export function useSearchLink(): (
return {
href: `?${searchParams.toString()}`,
prefetch: false,
onClick: (event) => {
onClick: async (event) => {
event.preventDefault();
callback?.();
setSearchState((prev) => ({
await setSearchState((prev) => ({
...prev,
query: params.query !== undefined ? params.query : null,
ask: params.ask !== undefined ? params.ask : null,
scope: params.scope !== undefined ? params.scope : 'default',
open: params.open !== undefined ? params.open : false,
}));
callback?.();
},
};
},
packages/gitbook/src/components/Search/useSearchController.tsx
+3 -3
View File
@@ -271,7 +271,7 @@ export function useSearchController(
}, [abort, siteSpace.id]);
const askInAssistant = React.useCallback(
(assistantIndex = 0) => {
async (assistantIndex = 0) => {
const assistant = assistants[assistantIndex];
if (!assistant || !normalizedQuery) {
return;
@@ -282,13 +282,13 @@ export function useSearchController(
}
abort();
assistant.open(normalizedQuery);
setSearchState({
await setSearchState({
ask: normalizedQuery,
query: null,
scope: state?.scope ?? 'default',
open: assistant.mode === 'search',
});
assistant.open(normalizedQuery);
},
[abort, assistants, normalizedQuery, setSearchState, siteSpace.id, state?.scope]
);