Fix crash when rendering ogimage with invalid icon (#3348)

2026-10-03 12:10:34 +00:00 · 2025-06-17 20:25:21 +02:00
parent a3a944d7dd
commit 8f7c304d58
1 changed files with 6 additions and 8 deletions
@@ -160,14 +160,12 @@ export async function serveOGImage(baseContext: GitBookSiteContext, params: Page
            height: 48,
        };

-        if ('icon' in customization.favicon)
-            return (
-                <img
-                    {...(await fetchImage(customization.favicon.icon[theme], faviconSize))}
-                    {...faviconSize}
-                    alt="Icon"
-                />
-            );
+        if ('icon' in customization.favicon) {
+            const faviconImage = await fetchImage(customization.favicon.icon[theme], faviconSize);
+            if (faviconImage) {
+                return <img {...faviconImage} {...faviconSize} alt="Icon" />;
+            }
+        }

        return (
            <SiteDefaultIcon