Limit splitting plugin name for git+ssh

This commit is contained in:
Jasha Joachimsthal
2016-03-24 15:23:28 +01:00
parent e07719a86c
commit 7d21c815a5
2 changed files with 16 additions and 1 deletions
+1 -1
View File
@@ -20,7 +20,7 @@ function normalizePluginsList(plugins) {
plugins = _.map(plugins, function(plugin) {
if (plugin.name) return plugin;
var parts = plugin.split('@');
var parts = plugin.split('@', 1);
var name = parts[0];
var version = parts[1];
return {
+15
View File
@@ -81,6 +81,21 @@ describe('Plugins', function() {
})
.should.be.fulfilledWith(1);
});
it('should correctly install dependencies from GitHub via ssh', function() {
return mock.setupBook({
'book.json': {
plugins: ['ga@git@github.com:GitbookIO/plugin-ga.git#master']
}
})
.then(function(book) {
return book.prepareConfig()
.then(function() {
var plugins = new PluginsManager(book);
return plugins.install();
});
})
.should.be.fulfilledWith(1);
});
});
describe('Loading', function() {