wip formal algorithm

[RFC] Garbage Collector Elimination
2026-08-15 00:23:11 +00:00 · 2026-01-26 10:53:07 +01:00 · 2026-01-26 10:53:07 +01:00
178 changed files with 1937 additions and 2469 deletions
@@ -12,42 +12,32 @@ when:

 steps:
  - name: check formatting
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
-      - nix-build -j4 --attr flakePackages.fmt
-
-  - name: check typos
-    image: nixpkgs/nix:nixos-24.05
-    commands:
-      - nix-shell --attr ci --run typos
-
-  - name: check lints with clippy
-    image: nixpkgs/nix:nixos-24.05
-    commands:
-      - nix-build -j4 --attr flakePackages.clippy
+      - nix-shell --attr devShell --run "cargo fmt -- --check"

  - name: build
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-build -j4 --attr flakePackages.dev

  - name: unit + func tests (lmdb)
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-build -j4 --attr flakePackages.tests-lmdb

  - name: unit + func tests (sqlite)
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-build -j4 --attr flakePackages.tests-sqlite

  - name: unit + func tests (fjall)
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-build -j4 --attr flakePackages.tests-fjall

  - name: integration tests
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-build -j4 --attr flakePackages.dev
      - nix-shell --attr ci --run ./script/test-smoke.sh || (cat /tmp/garage.log; false)
@@ -11,7 +11,7 @@ depends_on:

 steps:
  - name: refresh-index
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    environment:
      AWS_ACCESS_KEY_ID:
        from_secret: garagehq_aws_access_key_id
@@ -22,7 +22,7 @@ steps:
      - nix-shell --attr ci --run "refresh_index"

  - name: multiarch-docker
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    environment:
      DOCKER_AUTH:
        from_secret: docker_auth
@@ -19,17 +19,17 @@ matrix:

 steps:
  - name: build
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-build --attr releasePackages.${ARCH} --argstr git_version ${CI_COMMIT_TAG:-$CI_COMMIT_SHA}

  - name: check is static binary
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-shell --attr ci --run "./script/not-dynamic.sh result/bin/garage"

  - name: integration tests
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-shell --attr ci --run ./script/test-smoke.sh || (cat /tmp/garage.log; false)
    when:
@@ -39,7 +39,7 @@ steps:
          ARCH: i386

  - name: upgrade tests from v1.0.0
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-shell --attr ci --run "./script/test-upgrade.sh v1.0.0 x86_64-unknown-linux-musl" || (cat /tmp/garage.log; false)
    when:
@@ -47,7 +47,7 @@ steps:
          ARCH: amd64

  - name: upgrade tests from v0.8.4
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    commands:
      - nix-shell --attr ci --run "./script/test-upgrade.sh v0.8.4 x86_64-unknown-linux-musl" || (cat /tmp/garage.log; false)
    when:
@@ -55,7 +55,7 @@ steps:
          ARCH: amd64

  - name: push static binary
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    environment:
      TARGET: "${TARGET}"
      AWS_ACCESS_KEY_ID:
@@ -66,7 +66,7 @@ steps:
      - nix-shell --attr ci --run "to_s3"

  - name: docker build and publish
-    image: nixpkgs/nix:nixos-24.05
+    image: nixpkgs/nix:nixos-22.05
    environment:
      DOCKER_PLATFORM: "linux/${ARCH}"
      CONTAINER_NAME: "dxflrs/${ARCH}_garage"
@@ -24,22 +24,22 @@ default-members = ["src/garage"]

 # Internal Garage crates
 format_table = { version = "0.1.1", path = "src/format-table" }
-garage_api_common = { version = "2.2.0", path = "src/api/common" }
-garage_api_admin = { version = "2.2.0", path = "src/api/admin" }
-garage_api_s3 = { version = "2.2.0", path = "src/api/s3" }
-garage_api_k2v = { version = "2.2.0", path = "src/api/k2v" }
-garage_block = { version = "2.2.0", path = "src/block" }
-garage_db = { version = "2.2.0", path = "src/db", default-features = false }
-garage_model = { version = "2.2.0", path = "src/model", default-features = false }
-garage_net = { version = "2.2.0", path = "src/net" }
-garage_rpc = { version = "2.2.0", path = "src/rpc" }
-garage_table = { version = "2.2.0", path = "src/table" }
-garage_util = { version = "2.2.0", path = "src/util" }
-garage_web = { version = "2.2.0", path = "src/web" }
+garage_api_common = { version = "2.1.0", path = "src/api/common" }
+garage_api_admin = { version = "2.1.0", path = "src/api/admin" }
+garage_api_s3 = { version = "2.1.0", path = "src/api/s3" }
+garage_api_k2v = { version = "2.1.0", path = "src/api/k2v" }
+garage_block = { version = "2.1.0", path = "src/block" }
+garage_db = { version = "2.1.0", path = "src/db", default-features = false }
+garage_model = { version = "2.1.0", path = "src/model", default-features = false }
+garage_net = { version = "2.1.0", path = "src/net" }
+garage_rpc = { version = "2.1.0", path = "src/rpc" }
+garage_table = { version = "2.1.0", path = "src/table" }
+garage_util = { version = "2.1.0", path = "src/util" }
+garage_web = { version = "2.1.0", path = "src/web" }
 k2v-client = { version = "0.0.4", path = "src/k2v-client" }

 # External crates from crates.io
-arc-swap = "1.1"
+arc-swap = "1.0"
 argon2 = "0.5"
 async-trait = "0.1.7"
 backtrace = "0.3"
@@ -95,7 +95,7 @@ fjall = "2.4"
 async-compression = { version = "0.4", features = ["tokio", "zstd"] }
 zstd = { version = "0.13", default-features = false }

-quick-xml = { version = "0.26", features = ["serialize"] }
+quick-xml = { version = "0.26", features = [ "serialize" ] }
 rmp-serde = "1.1.2"
 serde = { version = "1.0", default-features = false, features = ["derive", "rc"] }
 serde_bytes = "0.11"
@@ -115,7 +115,7 @@ httpdate = "1.0"
 http-range = "0.1"
 http-body-util = "0.1"
 hyper = { version = "1.0", default-features = false }
-hyper-util = { version = "0.1", features = ["full"] }
+hyper-util = { version = "0.1", features = [ "full" ] }
 multer = "3.0"
 percent-encoding = "2.2"
 roxmltree = "0.19"
@@ -123,11 +123,11 @@ url = "2.3"

 futures = "0.3"
 futures-util = "0.3"
-tokio = { version = "1.0", default-features = false, features = ["rt", "rt-multi-thread", "io-util", "net", "time", "macros", "sync", "signal", "fs"] }
+tokio = { version = "1.0", default-features = false, features = ["net", "rt", "rt-multi-thread", "io-util", "net", "time", "macros", "sync", "signal", "fs"] }
 tokio-util = { version = "0.7", features = ["compat", "io"] }
 tokio-stream = { version = "0.1", features = ["net"] }

-opentelemetry = { version = "0.17", features = ["rt-tokio", "metrics", "trace"] }
+opentelemetry = { version = "0.17", features = [ "rt-tokio", "metrics", "trace" ] }
 opentelemetry-prometheus = "0.10"
 opentelemetry-otlp = "0.10"
 opentelemetry-contrib = "0.9"
@@ -3,10 +3,10 @@ info:
  version: v0.8.0
  title: Garage Administration API v0+garage-v0.8.0
  description: |
-    Administrate your Garage cluster programmatically, including status, layout, keys, buckets, and maintenance tasks.
-
-    *Disclaimer: The API is not stable yet, hence its v0 tag. The API can change at any time, and changes can include breaking backward compatibility. Read the changelog and upgrade your scripts before upgrading. Additionally, this specification is very early stage and can contain bugs, especially on error return codes/types that are not tested yet. Do not expect a well finished and polished product!*
-paths:
+    Administrate your Garage cluster programatically, including status, layout, keys, buckets, and maintainance tasks.
+    
+    *Disclaimer: The API is not stable yet, hence its v0 tag. The API can change at any time, and changes can include breaking backward compatibility. Read the changelog and upgrade your scripts before upgrading. Additionnaly, this specification is very early stage and can contain bugs, especially on error return codes/types that are not tested yet. Do not expect a well finished and polished product!*
+paths: 
  /status:
    get:
      tags: 
@@ -3,10 +3,10 @@ info:
  version: v0.9.0
  title: Garage Administration API v0+garage-v0.9.0
  description: |
-    Administrate your Garage cluster programmatically, including status, layout, keys, buckets, and maintenance tasks.
-
-    *Disclaimer: The API is not stable yet, hence its v0 tag. The API can change at any time, and changes can include breaking backward compatibility. Read the changelog and upgrade your scripts before upgrading. Additionally, this specification is very early stage and can contain bugs, especially on error return codes/types that are not tested yet. Do not expect a well finished and polished product!*
-paths:
+    Administrate your Garage cluster programatically, including status, layout, keys, buckets, and maintainance tasks.
+    
+    *Disclaimer: The API is not stable yet, hence its v0 tag. The API can change at any time, and changes can include breaking backward compatibility. Read the changelog and upgrade your scripts before upgrading. Additionnaly, this specification is very early stage and can contain bugs, especially on error return codes/types that are not tested yet. Do not expect a well finished and polished product!*
+paths: 
  /health:
    get:
      tags:
@@ -440,7 +440,7 @@ paths:
              - "false"
          example: "true"
          required: false
-          description: "Whether or not the secret key should be returned in the response"
+          description: "Wether or not the secret key should be returned in the response"
      responses:
        '500':
          description: "The server can not handle your request. Check your connectivity with the rest of the cluster."
@@ -2,7 +2,7 @@
  "openapi": "3.1.0",
  "info": {
    "title": "Garage administration API",
-    "description": "Administrate your Garage cluster programmatically, including status, layout, keys, buckets, and maintenance tasks.\n\n*Disclaimer: This API may change in future Garage versions. Read the changelog and upgrade your scripts before upgrading. Additionally, this specification is early stage and can contain bugs, so be careful and please report any issues on our issue tracker.*",
+    "description": "Administrate your Garage cluster programatically, including status, layout, keys, buckets, and maintainance tasks.\n\n*Disclaimer: This API may change in future Garage versions. Read the changelog and upgrade your scripts before upgrading. Additionnaly, this specification is early stage and can contain bugs, so be careful and please report any issues on our issue tracker.*",
    "contact": {
      "name": "The Garage team",
      "url": "https://garagehq.deuxfleurs.fr/",
@@ -12,7 +12,7 @@
      "name": "AGPL-3.0",
      "identifier": "AGPL-3.0"
    },
-    "version": "v2.2.0"
+    "version": "v2.1.0"
  },
  "servers": [
    {
@@ -103,7 +103,7 @@
          "content": {
            "application/json": {
              "schema": {
-                "$ref": "#/components/schemas/BucketAliasEnum"
+                "$ref": "#/components/schemas/AddBucketAliasRequest"
              }
            }
          },
@@ -1409,7 +1409,7 @@
          "content": {
            "application/json": {
              "schema": {
-                "$ref": "#/components/schemas/BucketAliasEnum"
+                "$ref": "#/components/schemas/RemoveBucketAliasRequest"
              }
            }
          },
@@ -1722,6 +1722,24 @@
  },
  "components": {
    "schemas": {
+      "AddBucketAliasRequest": {
+        "allOf": [
+          {
+            "$ref": "#/components/schemas/BucketAliasEnum"
+          },
+          {
+            "type": "object",
+            "required": [
+              "bucketId"
+            ],
+            "properties": {
+              "bucketId": {
+                "type": "string"
+              }
+            }
+          }
+        ]
+      },
      "AddBucketAliasResponse": {
        "$ref": "#/components/schemas/GetBucketInfoResponse"
      },
@@ -1939,13 +1957,9 @@
          {
            "type": "object",
            "required": [
-              "bucketId",
              "globalAlias"
            ],
            "properties": {
-              "bucketId": {
-                "type": "string"
-              },
              "globalAlias": {
                "type": "string"
              }
@@ -1954,7 +1968,6 @@
          {
            "type": "object",
            "required": [
-              "bucketId",
              "localAlias",
              "accessKeyId"
            ],
@@ -1962,9 +1975,6 @@
              "accessKeyId": {
                "type": "string"
              },
-              "bucketId": {
-                "type": "string"
-              },
              "localAlias": {
                "type": "string"
              }
@@ -2394,7 +2404,7 @@
          },
          "websiteAccess": {
            "type": "boolean",
-            "description": "Whether website access is enabled for this bucket"
+            "description": "Whether website acces is enabled for this bucket"
          },
          "websiteConfig": {
            "oneOf": [
@@ -2441,7 +2451,7 @@
        "properties": {
          "connectedNodes": {
            "type": "integer",
-            "description": "the number of nodes this Garage node currently has an open connection to",
+            "description": "the nubmer of nodes this Garage node currently has an open connection to",
            "minimum": 0
          },
          "knownNodes": {
@@ -3902,46 +3912,6 @@
          }
        ]
      },
-      "NodeRoleChangeRequest": {
-        "oneOf": [
-          {
-            "type": "object",
-            "required": [
-              "id",
-              "remove"
-            ],
-            "properties": {
-              "id": {
-                "type": "string",
-                "description": "ID of the node for which this change applies"
-              },
-              "remove": {
-                "type": "boolean",
-                "description": "Set `remove` to `true` to remove the node from the layout"
-              }
-            }
-          },
-          {
-            "allOf": [
-              {
-                "$ref": "#/components/schemas/NodeAssignedRole"
-              },
-              {
-                "type": "object",
-                "required": [
-                  "id"
-                ],
-                "properties": {
-                  "id": {
-                    "type": "string",
-                    "description": "ID of the node for which this change applies"
-                  }
-                }
-              }
-            ]
-          }
-        ]
-      },
      "NodeUpdateTrackers": {
        "type": "object",
        "required": [
@@ -4003,6 +3973,24 @@
          }
        ]
      },
+      "RemoveBucketAliasRequest": {
+        "allOf": [
+          {
+            "$ref": "#/components/schemas/BucketAliasEnum"
+          },
+          {
+            "type": "object",
+            "required": [
+              "bucketId"
+            ],
+            "properties": {
+              "bucketId": {
+                "type": "string"
+              }
+            }
+          }
+        ]
+      },
      "RemoveBucketAliasResponse": {
        "$ref": "#/components/schemas/GetBucketInfoResponse"
      },
@@ -4192,7 +4180,7 @@
          "roles": {
            "type": "array",
            "items": {
-              "$ref": "#/components/schemas/NodeRoleChangeRequest"
+              "$ref": "#/components/schemas/NodeRoleChange"
            },
            "description": "New node roles to assign or remove in the cluster layout"
          }
@@ -51,4 +51,4 @@ We are currently building this SDK for [Python](@/documentation/build/python.md#

 More information:
  - [In the reference manual](@/documentation/reference-manual/admin-api.md)
-  - [Full specification](https://garagehq.deuxfleurs.fr/api/garage-admin-v0.html)
+  - [Full specifiction](https://garagehq.deuxfleurs.fr/api/garage-admin-v0.html)
@@ -5,13 +5,13 @@ weight = 99

 ## S3

-If you are developing a new application, you may want to use Garage to store your user's media.
+If you are developping a new application, you may want to use Garage to store your user's media.

 The S3 API that Garage uses is a standard REST API, so as long as you can make HTTP requests,
 you can query it. You can check the [S3 REST API Reference](https://docs.aws.amazon.com/AmazonS3/latest/API/API_Operations_Amazon_Simple_Storage_Service.html) from Amazon to learn more.

-Developing your own wrapper around the REST API is time consuming and complicated.
-Instead, there are some libraries already available.
+Developping your own wrapper around the REST API is time consuming and complicated.
+Instead, there are some libraries already avalaible.

 Some of them are maintained by Amazon, some by Minio, others by the community.

@@ -23,7 +23,7 @@ To configure S3-compatible software to interact with Garage,
 you will need the following parameters:

 - An **API endpoint**: this corresponds to the HTTP or HTTPS address
-  used to contact the Garage server. When running Garage locally this will usually
+  used to contact the Garage server. When runing Garage locally this will usually
  be `http://127.0.0.1:3900`. In a real-world setting, you would usually have a reverse-proxy
  that adds TLS support and makes your Garage server available under a public hostname
  such as `https://garage.example.com`.
@@ -12,9 +12,8 @@ In this section, we cover the following web applications:
 | [Mastodon](#mastodon)     | ✅       | Natively supported    |
 | [Matrix](#matrix)     | ✅       |  Tested with `synapse-s3-storage-provider`    |
 | [ejabberd](#ejabberd)     | ✅       |  `mod_s3_upload`    |
-| [Ente](#ente)     | ✅       |  Natively supported |
-| [Pixelfed](#pixelfed)     | ❓       |  Natively supported    |
-| [Pleroma](#pleroma)     | ✅        |  Natively supported    |
+| [Pixelfed](#pixelfed)     | ✅       |  Natively supported    |
+| [Pleroma](#pleroma)     | ❓       |  Not yet tested    |
 | [Lemmy](#lemmy)     | ✅        |  Supported with pict-rs    |
 | [Funkwhale](#funkwhale)     | ❓       | Not yet tested     |
 | [Misskey](#misskey)     | ❓       | Not yet tested     |
@@ -54,7 +53,7 @@ garage bucket allow nextcloud --read --write --key nextcloud-key

 Now edit your Nextcloud configuration file to enable object storage.
 On my installation, the config. file is located at the following path: `/var/www/nextcloud/config/config.php`.  
-We will add a new root key to the `$CONFIG` dictionary named `objectstore`:
+We will add a new root key to the `$CONFIG` dictionnary named `objectstore`:

 ```php
 <?php
@@ -413,7 +412,7 @@ mc mirror --newer-than "3h" ./public/system/ garage/mastodon-data

 ## Matrix

-Matrix is a chat communication protocol. Its main stable server implementation, [Synapse](https://matrix-org.github.io/synapse/latest/), provides a module to store media on a S3 backend. Additionally, a server independent media store supporting S3 has been developed by the community, it has been made possible thanks to how the matrix API has been designed and will work with implementations like Conduit, Dendrite, etc.
+Matrix is a chat communication protocol. Its main stable server implementation, [Synapse](https://matrix-org.github.io/synapse/latest/), provides a module to store media on a S3 backend. Additionally, a server independent media store supporting S3 has been developped by the community, it has been made possible thanks to how the matrix API has been designed and will work with implementations like Conduit, Dendrite, etc.

 ### synapse-s3-storage-provider (synapse only)

@@ -450,7 +449,7 @@ media_storage_providers:

 Note that uploaded media will also be stored locally and this behavior can not be deactivated, it is even required for
 some operations like resizing images.
-In fact, your local filesystem is considered as a cache but without any automated way to garbage collect it.
+In fact, your local filesysem is considered as a cache but without any automated way to garbage collect it.

 We can build our garbage collector with `s3_media_upload`, a tool provided with the module.
 If you installed the module with the command provided before, you should be able to bring it in your path:
@@ -568,186 +567,13 @@ The module can then be configured with:
 Other configuration options can be found in the
 [configuration YAML file](https://github.com/processone/ejabberd-contrib/blob/master/mod_s3_upload/conf/mod_s3_upload.yml).

-
-## Ente
-
-Ente is an alternative for Google Photos and Apple Photos. It [can be selfhosted](https://help.ente.io/self-hosting/) and is working fine with Garage as of May 2024.
-As a first step we need to create a bucket and a key for Ente:
-
-```bash
-garage bucket create ente
-garage key create ente-key
-# For the CORS setup to work, the key needs to be --owner as well, at least temporarily.
-garage bucket allow ente --read --write --owner --key ente-key
-```
-
-We also need to setup some CORS rules to allow the Ente frontend to access the bucket:
-
-```bash
-export CORS='{"CORSRules":[{"AllowedHeaders":["*"],"AllowedMethods":["GET", "PUT", "POST", "DELETE"],"AllowedOrigins":["*"], "ExposeHeaders":["ETag"]}]}'
-aws s3api put-bucket-cors --bucket ente --cors-configuration $CORS
-```
-
-Now we need to configure ente-server to use our bucket. This is explained [in the Ente S3 documentation](https://help.ente.io/self-hosting/guides/external-s3).
-Prepare a configuration file for ente's backend as `museum.yaml`:
-
-```yaml
-credentials-file: /credentials.yaml
-apps:
-  public-albums: https://albums.example.tld # If you want to use the share album feature
-    internal:
-hardcoded-ott:
-  local-domain-suffix: "@example.com" # Your domain
-  local-domain-value: 123456 # Custom One-Time Password since we are not sending mail by default
-key:
-  # WARNING -- You MUST CHANGE the values below
-  # Someone has made an image that can do it for you : https://github.com/EdyTheCow/ente-selfhost/blob/main/images/ente-server-tools/Dockerfile
-  # Simply build it yourself or run docker run --rm ghcr.io/edythecow/ente-server-tools go run tools/gen-random-keys/main.go
-  encryption: yvmG/RnzKrbCb9L3mgsmoxXr9H7i2Z4qlbT0mL3ln4w= # CHANGE THIS VALUE
-  hash: KXYiG07wC7GIgvCSdg+WmyWdXDAn6XKYJtp/wkEU7x573+byBRAYtpTP0wwvi8i/4l37uicX1dVTUzwH3sLZyw== # CHANGE THIS VALUE
-jwt:
-  secret: i2DecQmfGreG6q1vBj5tCokhlN41gcfS2cjOs9Po-u8= # CHANGE THIS VALUE
-```
-
-The full configuration file can be found [here](https://github.com/ente-io/ente/blob/main/server/configurations/local.yaml)
-Then prepare a credentials file as `credentials.yaml`
-
-```yaml
-db:
-    host: postgres
-    port: 5432
-    name: <ente_db_name>
-    user: <pguser>
-    password: <pgpass>
-
-s3:
-    # Override the primary and secondary hot storage. The commented out values
-    # are the defaults.
-    #
-    hot_storage:
-        primary: b2-eu-cen
-    #    secondary: wasabi-eu-central-2-v3
-
-    # If true, enable some workarounds to allow us to use a local minio instance
-    # for object storage.
-    #
-    # 1. Disable SSL.
-    # 2. Use "path" style S3 URLs (see `use_path_style_urls` below).
-    # 3. Directly download the file during replication instead of going via the
-    #    Cloudflare worker.
-    # 4. Do not specify storage classes when uploading objects (since minio does
-    #    not support them, specifically it doesn't support GLACIER).
-    are_local_buckets: true
-
-    # To use "path" style S3 URLs instead of DNS-based bucket access
-    # default to true if you set "are_local_buckets: true"
-    # use_path_style_urls: true
-
-    b2-eu-cen: # Don't change this key, it is hardcoded
-        key: <keyID> 
-        secret: <keySecret>
-        endpoint: garage:3900 # publicly accessible endpoint of your garage instance
-        region: garage
-        bucket: <yourbucketName>
-        use_path_style: true
-    # you can specify secondary locations, names are hardcoded as well
-    # wasabi-eu-central-2-v3:
-    # scw-eu-fr-v3:
-    
-    # and you can also specify a bucket to be used for embeddings, preview etc..
-    # default to the first bucket 
-    # derived-storage: wasabi-eu-central-2-derived
-```
-
-Finally you can run it with Docker : 
-
-```bash
-docker run -d --name ente-server --restart unless-stopped -v /path/to/museum.yaml:/museum.yaml -v /path/to/credentials.yaml:/credentials.yaml -p 8080:8080 ghcr.io/ente-io/ente-server
-```
-
-For more information on deployment you can check the [ente documentation](https://help.ente.io/self-hosting/)
-
 ## Pixelfed

 [Pixelfed Technical Documentation > Configuration](https://docs.pixelfed.org/technical-documentation/env.html#filesystem)

 ## Pleroma

-### Creating your bucket
-
-This is the usual Garage setup:
-
-```bash
-garage key new --name pleroma-key
-garage bucket create pleroma
-garage bucket allow pleroma --read --write --owner --key pleroma-key
-```
-
-We also need to expose these buckets publicly to serve their content to users:
-
-```bash
-garage bucket website --allow pleroma
-```
-
-Note the Key ID and Secret Key.
-
-### Configure Pleroma
-
-Update your Pleroma configuration like that in `/etc/pleroma/config.exs`.
-
-```
-config :pleroma, Pleroma.Upload,
-    uploader: Pleroma.Uploaders.S3,
-    base_url: "https://pleroma.garage.example.tld"
-
-config :ex_aws, :s3,
-    access_key_id: "GW...",
-    secret_access_key: "XXX",
-    region: "garage",
-    host: "api.garage.example.tld"
-```
-
-And restart Pleroma.
-
-You can found more information in [Pleroma Documentation > Pleroma.Uploaders.S3](https://docs-develop.pleroma.social/backend/configuration/cheatsheet/#pleromauploaderss3)
-
-### Migrating your data
-
-Pleroma have an internal migration tool that can encounter some fatal error
-
-```
-** (EXIT from #PID<0.98.0>) an exception was raised:
-    ** (File.Error) could not stream "/var/lib/pleroma/uploads/09/f8": illegal operation on a directory
-        (elixir 1.17.3) lib/file/stream.ex:100: anonymous fn/3 in Enumerable.File.Stream.reduce/3
-        (elixir 1.17.3) lib/stream.ex:1675: anonymous fn/5 in Stream.resource/3
-        (elixir 1.17.3) lib/stream.ex:1891: Enumerable.Stream.do_each/4
-        (elixir 1.17.3) lib/task/supervised.ex:370: Task.Supervised.stream_reduce/7
-        (elixir 1.17.3) lib/enum.ex:4423: Enum.map/2
-        (ex_aws_s3 2.5.8) lib/ex_aws/s3/upload.ex:141: ExAws.Operation.ExAws.S3.Upload.perform/2
-        (pleroma 2.10.0) lib/pleroma/uploaders/s3.ex:60: Pleroma.Uploaders.S3.put_file/1
-        (pleroma 2.10.0) lib/pleroma/uploaders/uploader.ex:49: Pleroma.Uploaders.Uploader.put_file/2
-```
-
-So, use [your best tool](https://garagehq.deuxfleurs.fr/documentation/connect/cli/) to sync `/var/lib/pleroma/uploads/` in your S3.
-
-Then, to avoid some non existent problem (just in case of), run this command
-
-```bash
-while true
-do
-    rm -vr $(./bin/pleroma_ctl uploads migrate_local S3 2>&1 | grep "could not stream" | awk -F '"' '{print $2}')
-    sleep 5
-done
-```
-
-If you have many files, stop this command sometime and the command bellow (interactive) to delete local
-file after upload. Then restart the loop.
-
-```bash
-./bin/pleroma_ctl uploads migrate_local S3 --delete
-```
-
-And *voilà*
+[Pleroma Documentation > Pleroma.Uploaders.S3](https://docs-develop.pleroma.social/backend/configuration/cheatsheet/#pleromauploaderss3)

 ## Lemmy

@@ -207,13 +207,3 @@ $ plakar at @garageS3 ls
 ```

 More information in Plakar documentation: https://www.plakar.io/docs/main/quickstart/
-
-## Synology HyperBackup
-
-HyperBackup can be configured to upload backups to garage using a custom S3 destination. However, the HyperBackup client hardcodes the `us-east-1` region that is a critical input to the v4 signature process. If garage is not set to `us-east-1`, HyperBackup will recognize available buckets, but fail during the final setup stage.
-
-In garage.toml:
-```toml
-[s3_api]
-s3_region = "us-east-1"
-```
@@ -41,7 +41,7 @@ Some commands:
 # list buckets
 mc ls garage/

-# list objects in a bucket
+# list objets in a bucket
 mc ls garage/my_files

 # copy from your filesystem to garage
@@ -149,15 +149,6 @@ rclone help
 This will tremendously accelerate operations such as `rclone sync` or `rclone ncdu` by reducing the number
 of ListObjects calls that are made.

-**Garage behind Cloudflare proxy:** when running Garage behind Cloudflare proxy, you might see `Response: error 403 Forbidden, Forbidden: Invalid signature` error in your garage logs or `AccessDenied: Forbidden: Invalid signature` error in rclone logs. Try adding `--s3-sign-accept-encoding=false` flag to your rclone command and see if the issue is resolved.
-
-```bash
-# this throws an error
-rclone lsd garage:
-
-# this should work
-rclone lsd --s3-sign-accept-encoding=false garage:
-```

 ## `s3cmd`

@@ -218,7 +209,7 @@ Within Cyberduck, a
 available within the `Preferences -> Profiles` section. This can enabled and
 then connections to Garage may be configured.

-### Instructions for the CLI
+### Instuctions for the CLI

 To configure duck (Cyberduck's CLI tool), start by creating its folder hierarchy:

@@ -323,3 +314,4 @@ ls
 ```

 And through the web interface at http://[::1]:8080/web/client
+
@@ -201,9 +201,11 @@ on the binary cache, the client will download the result from the cache instead

 ### Channels

-Channels additionally serve Nix definitions, ie. a `.nix` file referencing
+Channels additionnaly serve Nix definitions, ie. a `.nix` file referencing
 all the derivations you want to serve.

 ## Gitlab

 *External link:* [Gitlab Documentation > Object storage](https://docs.gitlab.com/ee/administration/object_storage.html)
+
+
@@ -13,7 +13,7 @@ have published Ansible roles.  We list them and compare them below.
 | **Runtime**                        | Systemd                                     | Docker                                                        | Systemd                         |
 | **Target OS**                      | Any Linux                                   | Any Linux                                                     | Any Linux                       |
 | **Architecture**                   | amd64, arm64, i686                          | amd64, arm64                                                  | arm64, arm, 386, amd64                            |
-| **Additional software**            | None                                        | Traefik                                                       | Nginx and Keepalived (optional) |
+| **Additional software**            | None                                        | Traefik                                                       | Ngnix and Keepalived (optional) |
 | **Automatic node connection**      | ❌                                          | ✅                                                            | ✅                              |
 | **Layout management**              | ❌                                          | ✅                                                            | ✅                              |
 | **Manage buckets & keys**          | ❌                                          | ✅ (basic)                                                    | ✅                              |
@@ -15,10 +15,9 @@ Alpine Linux repositories (available since v3.17):
 apk add garage
 ```

-The default configuration file is installed to `/etc/garage/garage.toml`. You can run
-Garage using: `rc-service garage start`.
-
-If you don't specify `rpc_secret`, it will be automatically replaced with a random string on the first start.
+The default configuration file is installed to `/etc/garage.toml`. You can run
+Garage using: `rc-service garage start`. If you don't specify `rpc_secret`, it
+will be automatically replaced with a random string on the first start.

 Please note that this package is built without Consul discovery, Kubernetes
 discovery, OpenTelemetry exporter, and K2V features (K2V will be enabled once
@@ -27,11 +26,7 @@ it's stable).

 ## Arch Linux

-Garage is available in the official repositories under [extra](https://archlinux.org/packages/extra/x86_64/garage).
-
-```bash
-pacman -S garage
-```
+Garage is available in the [AUR](https://aur.archlinux.org/packages/garage).

 ## FreeBSD

@@ -44,9 +39,3 @@ pkg install garage
 ```bash
 nix-shell -p garage
 ```
-
-## conda-forge
-
-```bash
-pixi global install garage
-```
@@ -33,7 +33,7 @@ by adding encryption at different levels.

 We would be very curious to know your needs and thougs about ideas such as
 encryption practices and things like key management, as we want Garage to be a
-serious base platform for the development of secure, encrypted applications.
+serious base platform for the developpment of secure, encrypted applications.
 Do not hesitate to come talk to us if you have any thoughts or questions on the
 subject.

@@ -59,7 +59,7 @@ For standard S3 API requests, Garage does not encrypt data at rest by itself.
 For the most generic at rest encryption of data, we recommend setting up your
 storage partitions on encrypted LUKS devices.

-If you are developing your own client software that makes use of S3 storage,
+If you are developping your own client software that makes use of S3 storage,
 we recommend implementing data encryption directly on the client side and never
 transmitting plaintext data to Garage. This makes it easy to use an external
 untrusted storage provider if necessary.
@@ -108,14 +108,14 @@ Protects against the following threats:

 - Stolen HDD

-Crucially, does not protect against malicious sysadmins or remote attackers that
+Crucially, does not protect againt malicious sysadmins or remote attackers that
 might gain access to your servers.

 Methods include full-disk encryption with tools such as LUKS.

 ## Encrypting data on the client side

-Protects against the following threats:
+Protects againt the following threats:

 - A honest-but-curious administrator
 - A malicious administrator that tries to corrupt your data
@@ -9,7 +9,7 @@ There are three methods to expose buckets as website:

 1. using the PutBucketWebsite S3 API call, which is allowed for access keys that have the owner permission bit set

-2. from the Garage CLI, by an administrator of the cluster
+2. from the Garage CLI, by an adminstrator of the cluster

 3. using the Garage administration API

@@ -20,12 +20,12 @@ sudo apt-get update
 sudo apt-get install build-essential
 ```

-## Building from source from the Forgejo repository
+## Building from source from the Gitea repository

 The primary location for Garage's source code is the
-[Forgejo repository](https://git.deuxfleurs.fr/Deuxfleurs/garage),
+[Gitea repository](https://git.deuxfleurs.fr/Deuxfleurs/garage),
 which contains all of the released versions as well as the code
-for the development of the next version.
+for the developpement of the next version.

 Clone the repository and enter it as follows:

@@ -41,7 +41,7 @@ git tag  				# List available tags
 git checkout v0.8.0		# Change v0.8.0 with the version you wish to build
 ```

-Otherwise you will be building a development build from the `main` branch
+Otherwise you will be building a developpement build from the `main` branch
 that includes all of the changes to be released in the next version.
 Be careful that such a build might be unstable or contain bugs,
 and could be incompatible with nodes that run stable versions of Garage.
@@ -85,14 +85,11 @@ The following feature flags are available in v0.8.0:
 | Feature flag | Enabled | Description |
 | ------------ | ------- | ----------- |
 | `bundled-libs` | *by default* | Use bundled version of sqlite3, zstd, lmdb and libsodium |
-| `consul-discovery` | optional | Enable automatic registration and discovery<br>of cluster nodes through the Consul API |
-| `fjall` | experimental | Enable using Fjall to store Garage's metadata |
-| `journald` | optional | Enable logging to systemd-journald with<br>`GARAGE_LOG_TO_JOURNALD=true` environment variable set |
+| `system-libs` | optional | Use system version of sqlite3, zstd, lmdb and libsodium<br>if available (exclusive with `bundled-libs`, build using<br>`cargo build --no-default-features --features system-libs`) |
 | `k2v` | optional | Enable the experimental K2V API (if used, all nodes on your<br>Garage cluster must have it enabled as well) |
 | `kubernetes-discovery` | optional | Enable automatic registration and discovery<br>of cluster nodes through the Kubernetes API |
-| `lmdb` | *by default* | Enable using LMDB to store Garage's metadata |
 | `metrics` | *by default* | Enable collection of metrics in Prometheus format on the admin API |
-| `sqlite` | *by default* | Enable using Sqlite3 to store Garage's metadata |
-| `syslog` | optional | Enable logging to Syslog with<br>`GARAGE_LOG_TO_SYSLOG=true` environment variable set |
-| `system-libs` | optional | Use system version of sqlite3, zstd, lmdb and libsodium<br>if available (exclusive with `bundled-libs`, build using<br>`cargo build --no-default-features --features system-libs`) |
 | `telemetry-otlp` | optional | Enable collection of execution traces using OpenTelemetry |
+| `syslog` | optional | Enable logging to Syslog |
+| `lmdb` | *by default* | Enable using LMDB to store Garage's metadata |
+| `sqlite` | *by default* | Enable using Sqlite3 to store Garage's metadata |
@@ -11,7 +11,7 @@ Firstly clone the repository:

 ```bash
 git clone https://git.deuxfleurs.fr/Deuxfleurs/garage
-cd garage/script/helm
+cd garage/scripts/helm
 ```

 Deploy with default options:
@@ -26,7 +26,7 @@ Or deploy with custom values:
 helm install --create-namespace --namespace garage garage ./garage -f values.override.yaml
 ```

-If you want to manage the CustomResourceDefinition used by garage for its `kubernetes_discovery` outside of the helm chart, add `garage.kubernetesSkipCrd: true` to your custom values and use the kustomization before deploying the helm chart:
+If you want to manage the CustomRessourceDefinition used by garage for its `kubernetes_discovery` outside of the helm chart, add `garage.kubernetesSkipCrd: true` to your custom values and use the kustomization before deploying the helm chart:

 ```bash
 kubectl apply -k ../k8s/crd
@@ -47,7 +47,7 @@ All possible configuration values can be found with:
 helm show values ./garage
 ```

-This is an example `values.override.yaml` for deploying in a microk8s cluster with a https s3 api ingress route:
+This is an example `values.overrride.yaml` for deploying in a microk8s cluster with a https s3 api ingress route:

 ```yaml
 garage:
@@ -96,14 +96,14 @@ to store 2 TB of data in total.
 ## Get a Docker image

 Our docker image is currently named `dxflrs/garage` and is stored on the [Docker Hub](https://hub.docker.com/r/dxflrs/garage/tags?page=1&ordering=last_updated).
-We encourage you to use a fixed tag (eg. `v2.2.0`) and not the `latest` tag.
-For this example, we will use the latest published version at the time of the writing which is `v2.2.0` but it's up to you
+We encourage you to use a fixed tag (eg. `v2.1.0`) and not the `latest` tag.
+For this example, we will use the latest published version at the time of the writing which is `v2.1.0` but it's up to you
 to check [the most recent versions on the Docker Hub](https://hub.docker.com/r/dxflrs/garage/tags?page=1&ordering=last_updated).

 For example:

 ```
-sudo docker pull dxflrs/garage:v2.2.0
+sudo docker pull dxflrs/garage:v2.1.0
 ```

 ## Deploying and configuring Garage
@@ -171,7 +171,7 @@ docker run \
  -v /etc/garage.toml:/etc/garage.toml \
  -v /var/lib/garage/meta:/var/lib/garage/meta \
  -v /var/lib/garage/data:/var/lib/garage/data \
-  dxflrs/garage:v2.2.0
+  dxflrs/garage:v2.1.0
 ```

 With this command line, Garage should be started automatically at each boot.
@@ -185,7 +185,7 @@ If you want to use `docker-compose`, you may use the following `docker-compose.y
 version: "3"
 services:
  garage:
-    image: dxflrs/garage:v2.2.0
+    image: dxflrs/garage:v2.1.0
    network_mode: "host"
    restart: unless-stopped
    volumes:
@@ -7,7 +7,7 @@ The main reason to add a reverse proxy in front of Garage is to provide TLS to y

 In production you will likely need your certificates signed by a certificate authority.
 The most automated way is to use a provider supporting the [ACME protocol](https://datatracker.ietf.org/doc/html/rfc8555) 
-such as [Let's Encrypt](https://letsencrypt.org/) or [ZeroSSL](https://zerossl.com/).
+such as [Let's Encrypt](https://letsencrypt.org/), [ZeroSSL](https://zerossl.com/) or [Buypass Go SSL](https://www.buypass.com/ssl/products/acme).

 If you are only testing Garage, you can generate a self-signed certificate to follow the documentation:

@@ -272,7 +272,7 @@ Add the following configuration section [to compress response](https://doc.traef

 ### Add caching response

-Traefik's caching middleware is only available on [enterprise version](https://doc.traefik.io/traefik-enterprise/middlewares/http-cache/), however the freely-available [Souin plugin](https://github.com/darkweak/souin#tr%C3%A6fik-container) can also do the job. (section to be completed)
+Traefik's caching middleware is only available on [entreprise version](https://doc.traefik.io/traefik-enterprise/middlewares/http-cache/), however the freely-available [Souin plugin](https://github.com/darkweak/souin#tr%C3%A6fik-container) can also do the job. (section to be completed)

 ### Complete example

@@ -38,7 +38,7 @@ WantedBy=multi-user.target
 id is dynamically allocated by systemd (set with `DynamicUser=true`). It cannot
 access (read or write) home folders (`/home`, `/root` and `/run/user`), the
 rest of the filesystem can only be read but not written, only the path seen as
-`/var/lib/garage` is writable as seen by the service. Additionally, the process
+`/var/lib/garage` is writable as seen by the service. Additionnaly, the process
 can not gain new privileges over time.

 For this to work correctly, your `garage.toml` must be set with
@@ -10,7 +10,7 @@ perspective.  It will allow you to understand if Garage is a good fit for
 you, how to better use it, how to contribute to it, what can Garage could
 and could not do, etc.

- **[Goals and use cases](@/documentation/design/goals.md):** This page explains why Garage was conceived and what practical use cases it targets.
+- **[Goals and use cases](@/documentation/design/goals.md):** This page explains why Garage was concieved and what practical use cases it targets.

 - **[Related work](@/documentation/design/related-work.md):** This pages presents the theoretical background on which Garage is built, and describes other software storage solutions and why they didn't work for us.

@@ -31,3 +31,5 @@ We love to talk and hear about Garage, that's why we keep a log here:
  - [(en, 2021-04-28) Distributed object storage is centralised](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/b1f60579a13d3c5eba7f74b1775c84639ea9b51a/doc/talks/2021-04-28_spirals-team/talk.pdf)

  - [(fr, 2020-12-02) Garage : jouer dans la cour des grands quand on est un hébergeur associatif](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/b1f60579a13d3c5eba7f74b1775c84639ea9b51a/doc/talks/2020-12-02_wide-team/talk.pdf)
+
+
@@ -15,14 +15,14 @@ The more a user request will require intra-cluster requests to complete, the mor
 This is especially true for sequential requests: requests that must wait the result of another request to be sent.
 We designed Garage without consensus algorithms (eg. Paxos or Raft) to minimize the number of sequential and parallel requests.

-This series of benchmarks quantifies the impact of this design choice.
+This serie of benchmarks quantifies the impact of this design choice.

 ### On a simple simulated network

 We start with a controlled environment, all the instances are running on the same (powerful enough) machine.

-To control the network latency, we simulate the network with [mknet](https://git.deuxfleurs.fr/trinity-1686a/mknet) (a tool we developed, based on `tc` and the linux network stack).
-To measure S3 endpoints latency, we use our own tool [s3lat](https://git.deuxfleurs.fr/quentin/s3lat/) to observe only the intra-cluster latency and not some contention on the nodes (CPU, RAM, disk I/O, network bandwidth, etc.).
+To control the network latency, we simulate the network with [mknet](https://git.deuxfleurs.fr/trinity-1686a/mknet) (a tool we developped, based on `tc` and the linux network stack).
+To mesure S3 endpoints latency, we use our own tool [s3lat](https://git.deuxfleurs.fr/quentin/s3lat/) to observe only the intra-cluster latency and not some contention on the nodes (CPU, RAM, disk I/O, network bandwidth, etc.).
 Compared to other benchmark tools, S3Lat sends only one (small) request at the same time and measures its latency.
 We selected 5 standard endpoints that are often in the critical path: ListBuckets, ListObjects, GetObject, PutObject and RemoveObject.

@@ -32,7 +32,7 @@ In this first benchmark, we consider 5 instances that are located in a different

 Compared to garage, minio latency drastically increases on 3 endpoints: GetObject, PutObject, RemoveObject.

-We suppose that these requests on minio make transactions over Raft, involving 4 sequential requests: 1) sending the message to the leader, 2) having the leader dispatch it to the other nodes, 3) waiting for the confirmation of followers and finally 4) committing it. With our current configuration, one Raft transaction will take around 400 ms. GetObject seems to correlate to 1 transaction while PutObject and RemoveObject seems to correlate to 2 or 3. Reviewing minio code would be required to confirm this hypothesis.
+We suppose that these requests on minio make transactions over Raft, involving 4 sequential requests: 1) sending the message to the leader, 2) having the leader dispatch it to the other nodes, 3) waiting for the confirmation of followers and finally 4) commiting it. With our current configuration, one Raft transaction will take around 400 ms. GetObject seems to correlate to 1 transaction while PutObject and RemoveObject seems to correlate to 2 or 3. Reviewing minio code would be required to confirm this hypothesis.

 Conversely, garage uses an architecture similar to DynamoDB and never require global cluster coordination to answer a request.
 Instead, garage can always contact the right node in charge of the requested data, and can answer in as low as one request in the case of GetObject and PutObject. We also observed that Garage latency, while often lower to minio, is more dispersed: garage is still in beta and has not received any performance optimization yet.
@@ -50,7 +50,7 @@ We plot a similar graph as before:

 This new graph is very similar to the one before, neither minio or garage seems to benefit from this new topology, but they also do not suffer from it.

-Considering garage, this is expected: nodes in the same DC are put in the same zone, and then data are spread on different zones for data resiliency and availability.
+Considering garage, this is expected: nodes in the same DC are put in the same zone, and then data are spread on different zones for data resiliency and availaibility.
 Then, in the default mode, requesting data requires to query at least 2 zones to be sure that we have the most up to date information.
 These requests will involve at least one inter-DC communication.
 In other words, we prioritize data availability and synchronization over raw performances.
@@ -94,7 +94,7 @@ delete a tombstone, the following condition has to be met:

 - All nodes responsible for storing this entry are aware of the existence of
  the tombstone, i.e. they cannot hold another version of the entry that is
-  superseded by the tombstone. This ensures that deleting the tombstone is
+  superseeded by the tombstone. This ensures that deleting the tombstone is
  safe and that no deleted value will come back in the system.

 Garage uses atomic database operations (such as compare-and-swap and
@@ -141,3 +141,4 @@ rebalance of data, this would have led to the disk utilization to explode
 during the rebalancing, only to shrink again after 24 hours. The 10-minute
 delay is a compromise that gives good security while not having this problem of
 disk space explosion on rebalance.
+
@@ -37,7 +37,7 @@ However, Amazon S3 source code is not open but alternatives were proposed.
 We identified Minio, Pithos, Swift and Ceph.
 Minio/Ceph enforces a total order, so properties similar to a (relaxed) filesystem.
 Swift and Pithos are probably the most similar to AWS S3 with their consistent hashing ring.
-However Pithos is not maintained anymore. More precisely the company that published Pithos version 1 has developed a second version 2 but has not open sourced it.
+However Pithos is not maintained anymore. More precisely the company that published Pithos version 1 has developped a second version 2 but has not open sourced it.
 Some tests conducted by the [ACIDES project](https://acides.org/) have shown that Openstack Swift consumes way more resources (CPU+RAM) that we can afford. Furthermore, people developing Swift have not designed their software for geo-distribution.

 There were many attempts in research too. I am only thinking to [LBFS](https://pdos.csail.mit.edu/papers/lbfs:sosp01/lbfs.pdf) that was used as a basis for Seafile. But none of them have been effectively implemented yet.
@@ -63,7 +63,7 @@ Due to its industry oriented design, Ceph is also far from being *Simple* to ope
 In a certain way, Ceph and MinIO are closer together than they are from Garage or OpenStack Swift.

 **[Pithos](https://github.com/exoscale/pithos):**
-Pithos has been abandoned and should probably not used yet, in the following we explain why we did not pick their design.
+Pithos has been abandonned and should probably not used yet, in the following we explain why we did not pick their design.
 Pithos was relying as a S3 proxy in front of Cassandra (and was working with Scylla DB too).
 From its designers' mouth, storing data in Cassandra has shown its limitations justifying the project abandonment.
 They built a closed-source version 2 that does not store blobs in the database (only metadata) but did not communicate further on it.
@@ -23,7 +23,7 @@ This logic is defined in `nix/build_index.nix`.
 For each commit, we first pass the code to a formatter (rustfmt) and a linter (clippy).
 Then we try to build it in debug mode and run both unit tests and our integration tests.

-Additionally, when releasing, our integration tests are run on the release build for amd64 and i686.
+Additionnaly, when releasing, our integration tests are run on the release build for amd64 and i686.

 ## Generated Artifacts

@@ -32,7 +32,7 @@ We generate the following binary artifacts for now:
  - **os**: linux
  - **format**: static binary, docker container

-Additionally we also build two web pages and one JSON document:
+Additionnaly we also build two web pages and one JSON document:
  - the documentation (this website)
  - [the release page](https://garagehq.deuxfleurs.fr/_releases.html)
  - [the release list in JSON format](https://garagehq.deuxfleurs.fr/_releases.json)
@@ -67,7 +67,7 @@ nix copy --to 's3://nix?endpoint=garage.deuxfleurs.fr&region=garage&secret-key=/
 The previous command will only send the built package and not its dependencies.
 In the case of our CI pipeline, we want to cache all intermediate build steps
 as well. This can be done using this quite involved command (here as an example
-for the `pkgs.amd64.release` package):
+for the `pkgs.amd64.relase` package):

 ```bash
 nix copy -j8 \
@@ -174,3 +174,5 @@ drone sign --save Deuxfleurs/garage
 ```

 Looking at the file, you will see that most of the commands are `nix-shell` and `nix-build` commands with various parameters.
+
+
@@ -242,7 +242,7 @@ dc3                 Tags   Partitions        Capacity   Usable capacity
  TOTAL                    256 (256 unique)  2.0 GB     1000.0 MB (50.0%)
 ```

-As we can see, the node that was moved to `dc3` (node4) is only used at 25% (approximately),
+As we can see, the node that was moved to `dc3` (node4) is only used at 25% (approximatively),
 whereas the node that was already in `dc3` (node3) is used at 75%.

 This can be explained by the following:
@@ -260,7 +260,7 @@ This can be explained by the following:
 data can be removed to be moved to node1.

 - Garage will move data in equal proportions from all possible sources, in this
-  case it means that it will transfer 25% of the entire data set from node3 to
+  case it means that it will tranfer 25% of the entire data set from node3 to
  node1 and another 25% from node4 to node1.

 This explains why node3 ends with 75% utilization (100% from before minus 25%
@@ -40,7 +40,7 @@ First of all, Garage divides the set of all possible block hashes
 in a fixed number of slices (currently 1024), and assigns
 to each slice a primary storage location among the specified data directories.
 The number of slices having their primary location in each data directory
-is proportional to the capacity specified in the config file.
+is proportionnal to the capacity specified in the config file.

 When Garage receives a block to write, it will always write it in the primary
 directory of the slice that contains its hash.
@@ -56,7 +56,7 @@ From a high level perspective, a major upgrade looks like this:
  10. Enable API access (reverse step 1)
  11. Monitor your cluster while load comes back, check that all your applications are happy with this new version

-### Major upgrades with minimal downtime
+### Major upgarades with minimal downtime

 There is only one operation that has to be coordinated cluster-wide: the switch of one version of the internal RPC protocol to the next.
 This means that an upgrade with very limited downtime can simply be performed from one major version to the next by restarting all nodes
@@ -132,7 +132,7 @@ docker run \
  -v /path/to/garage.toml:/etc/garage.toml \
  -v /path/to/garage/meta:/var/lib/garage/meta \
  -v /path/to/garage/data:/var/lib/garage/data \
-  dxflrs/garage:v2.2.0
+  dxflrs/garage:v2.1.0
 ```

 Under Linux, you can substitute `--network host` for `-p 3900:3900 -p 3901:3901 -p 3902:3902 -p 3903:3903`
@@ -25,7 +25,7 @@ db_engine = "lmdb"
 block_size = "1M"
 block_ram_buffer_max = "256MiB"
 block_max_concurrent_reads = 16
-block_max_concurrent_writes_per_request =10
+
 lmdb_map_size = "1T"

 compression_level = 1
@@ -51,20 +51,17 @@ allow_punycode = false

 [consul_discovery]
 api = "catalog"
-consul_http_addr = "https://127.0.0.1:8500"
-tls_skip_verify = false
+consul_http_addr = "http://127.0.0.1:8500"
 service_name = "garage-daemon"
-
 ca_cert = "/etc/consul/consul-ca.crt"
 client_cert = "/etc/consul/consul-client.crt"
 client_key = "/etc/consul/consul-key.crt"
-
 # for `agent` API mode, unset client_cert and client_key, and optionally enable `token`
 # token = "abcdef-01234-56789"
-
+tls_skip_verify = false
 tags = [ "dns-enabled" ]
 meta = { dns-acl = "allow trusted" }
-datacenters = ["dc1", "dc2", "dc3"]
+

 [kubernetes_discovery]
 namespace = "garage"
@@ -102,7 +99,6 @@ Top-level configuration options, in alphabetical order:
 [`allow_punycode`](#allow_punycode),
 [`allow_world_readable_secrets`](#allow_world_readable_secrets),
 [`block_max_concurrent_reads`](#block_max_concurrent_reads),
-[`block_max_concurrent_writes_per_request`](#block_max_concurrent_writes_per_request),
 [`block_ram_buffer_max`](#block_ram_buffer_max),
 [`block_size`](#block_size),
 [`bootstrap_peers`](#bootstrap_peers),
@@ -131,14 +127,12 @@ The `[consul_discovery]` section:
 [`client_cert`](#consul_client_cert_and_key),
 [`client_key`](#consul_client_cert_and_key),
 [`consul_http_addr`](#consul_http_addr),
-[`datacenters`](#consul_datacenters)
 [`meta`](#consul_tags_and_meta),
 [`service_name`](#consul_service_name),
 [`tags`](#consul_tags_and_meta),
 [`tls_skip_verify`](#consul_tls_skip_verify),
 [`token`](#consul_token).

-
 The `[kubernetes_discovery]` section:
 [`namespace`](#kube_namespace),
 [`service_name`](#kube_service_name),
@@ -372,7 +366,7 @@ Performance characteristics of the different DB engines are as follows:
    not recommended.

  - Keys in LMDB are limited to 511 bytes. This limit translates to limits on
-    object keys in S3 and sort keys in K2V that are limited to 479 bytes.
+    object keys in S3 and sort keys in K2V that are limted to 479 bytes.

 - **Sqlite:** Garage supports Sqlite as an alternative storage backend for
  metadata, which does not have the issues listed above for LMDB.  Sqlite is
@@ -396,7 +390,7 @@ garage convert-db -a <input db engine> -i <input db path> \
 ```

 Make sure to specify the full database path as presented in the table above
-(third column), and not just the path to the metadata directory.
+(third colummn), and not just the path to the metadata directory.

 #### `metadata_fsync` {#metadata_fsync}

@@ -438,7 +432,7 @@ This might reduce the risk that a data block is lost in rare
 situations such as simultaneous node losing power,
 at the cost of a moderate drop in write performance.

-Similarly to `metadata_fsync`, this is likely not necessary
+Similarly to `metatada_fsync`, this is likely not necessary
 if geographical replication is used.

 #### `metadata_auto_snapshot_interval` (since `v0.9.4`) {#metadata_auto_snapshot_interval}
@@ -554,20 +548,12 @@ awaits for one of the `block_max_concurrent_reads` slots to be available
 slot, it reads the entire block file to RAM and frees the slot as soon as the
 block file is finished reading. Only after the slot is released will the
 block's data start being transferred over the network.  If the request fails to
-acquire a reading slot within 15 seconds, it fails with a timeout error.
+acquire a reading slot wihtin 15 seconds, it fails with a timeout error.
 Timeout events can be monitored through the `block_read_semaphore_timeouts`
 metric in Prometheus: a non-zero number of such events indicates an I/O
 bottleneck on HDD read speed.


-#### `block_max_concurrent_writes_per_request` (since `v1.3.1` / `v2.2.0`) {#block_max_concurrent_writes_per_request}
-
-This parameter is designed to adapt to the concurrent write performance of 
-different storage media. Maximum number of parallel block writes per put request.
-Higher values may improve throughput but increase memory usage.
-
-Default value: 3. Recommended values: 10-30 for NVMe, 3-10 for spinning HDD.
-
 #### `lmdb_map_size` {#lmdb_map_size}

 This parameters can be used to set the map size used by LMDB,
@@ -617,11 +603,11 @@ storing the secret as the `GARAGE_RPC_SECRET_FILE` environment variable.

 #### `rpc_bind_addr` {#rpc_bind_addr}

-The address and port on which to bind for inter-cluster communications
-(referred to as RPC for remote procedure calls).
+The address and port on which to bind for inter-cluster communcations
+(reffered to as RPC for remote procedure calls).
 The port specified here should be the same one that other nodes will used to contact
 the node, even in the case of a NAT: the NAT should be configured to forward the external
-port number to the same internal port number. This means that if you have several nodes running
+port number to the same internal port nubmer. This means that if you have several nodes running
 behind a NAT, they should each use a different RPC port number.

 #### `rpc_bind_outgoing` (since `v0.9.2`) {#rpc_bind_outgoing}
@@ -740,18 +726,6 @@ node_prefix "" {
 }
 ```

-
-#### `datacenters` {#consul_datacenters}
-
-Optional list of datacenters that allow garage to do service discovery when Consul is configured in WAN federation.
-
-Example: `datacenters = ["dc1", "dc2", "dc3"]`
-
-In a WAN configuration, by default the Consul services API only responds with
-local LAN services.  When a list of datacenters is specified using this option,
-Garage will query the consul server API by datacenter directly, allowing for
-Garage to discover nodes across the Consul WAN.
-
 #### `tags` and `meta` {#consul_tags_and_meta}

 Additional list of tags and map of service meta to add during service registration.
@@ -784,14 +758,14 @@ manually.
 #### `api_bind_addr` {#s3_api_bind_addr}

 The IP and port on which to bind for accepting S3 API calls.
-This endpoint does not support TLS: a reverse proxy should be used to provide it.
+This endpoint does not suport TLS: a reverse proxy should be used to provide it.

 Alternatively, since `v0.8.5`, a path can be used to create a unix socket with 0222 mode.

 #### `s3_region` {#s3_region}

-Garage will accept S3 API calls that are targeted to the S3 region defined here.
-API calls targeted to other regions will fail with a AuthorizationHeaderMalformed error
+Garage will accept S3 API calls that are targetted to the S3 region defined here.
+API calls targetted to other regions will fail with a AuthorizationHeaderMalformed error
 message that redirects the client to the correct region.

 #### `root_domain` {#s3_root_domain}
@@ -799,7 +773,7 @@ message that redirects the client to the correct region.
 The optional suffix to access bucket using vhost-style in addition to path-style request.
 Note path-style requests are always enabled, whether or not vhost-style is configured.
 Configuring vhost-style S3 required a wildcard DNS entry, and possibly a wildcard TLS certificate,
-but might be required by software not supporting path-style requests.
+but might be required by softwares not supporting path-style requests.

 If `root_domain` is `s3.garage.eu`, a bucket called `my-bucket` can be interacted with
 using the hostname `my-bucket.s3.garage.eu`.
@@ -815,7 +789,7 @@ behaviour of this module.

 The IP and port on which to bind for accepting HTTP requests to buckets configured
 for website access.
-This endpoint does not support TLS: a reverse proxy should be used to provide it.
+This endpoint does not suport TLS: a reverse proxy should be used to provide it.

 Alternatively, since `v0.8.5`, a path can be used to create a unix socket with 0222 mode.

@@ -888,7 +862,7 @@ You can use any random string for this value. We recommend generating a random t

 If this is set to `true`, accessing the metrics endpoint will always require
 an access token. Valid tokens include the `metrics_token` if it is set,
-and admin API token defined dynamically in Garage which have
+and admin API token defined dynamicaly in Garage which have
 the `Metrics` endpoint in their scope.

 #### `trace_sink` {#admin_trace_sink}
@@ -46,7 +46,7 @@ to select the replication mode best suited to your use case (hint: in most cases

 ### Compression and deduplication

-All data stored in Garage is deduplicated, and optionally compressed using
+All data stored in Garage is deduplicated, and optionnally compressed using
 Zstd.  Objects uploaded to Garage are chunked in blocks of constant sizes (see
 [`block_size`](@/documentation/reference-manual/configuration.md#block_size)),
 and the hashes of individual blocks are used to dispatch them to storage nodes
@@ -84,13 +84,13 @@ exposing the same content under different domain names.

 Garage also supports bucket aliases which are local to a single user:
 this allows different users to have different buckets with the same name, thus avoiding naming collisions.
-This can be helpful for instance if you want to write an application that creates per-user buckets with always the same name.
+This can be helpfull for instance if you want to write an application that creates per-user buckets with always the same name.

 This feature is totally invisible to S3 clients and does not break compatibility with AWS.

 ### Cluster administration API

-Garage provides a fully-fledged REST API to administer your cluster programmatically.
+Garage provides a fully-fledged REST API to administer your cluster programatically.
 Functionality included in the admin API include: setting up and monitoring
 cluster nodes, managing access credentials, and managing storage buckets and bucket aliases.
 A full reference of the administration API is available [here](@/documentation/reference-manual/admin-api.md).
@@ -100,7 +100,7 @@ A full reference of the administration API is available [here](@/documentation/r
 Garage makes some internal metrics available in the Prometheus data format,
 which allows you to build interactive dashboards to visualize the load and internal state of your storage cluster.

-For developers and performance-savvy administrators,
+For developpers and performance-savvy administrators,
 Garage also supports exporting traces of what it does internally in OpenTelemetry format.
 This allows to monitor the time spent at various steps of the processing of requests,
 in order to detect potential performance bottlenecks.
@@ -19,7 +19,7 @@ The specification of the K2V API can be found
 [here](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/commit/f8be15c37db857e177d543de7be863692628d567/doc/drafts/k2v-spec.md).
 This document also includes a high-level overview of K2V's design.

-The K2V API uses AWSv4 signatures for authentication, same as the S3 API.
+The K2V API uses AWSv4 signatures for authentification, same as the S3 API.
 The AWS region used for signature calculation is always the same as the one
 defined for the S3 API in the config file.

@@ -55,3 +55,4 @@ cargo build --features cli --bin k2v-cli
 The CLI utility is self-documented, run `k2v-cli --help` to learn how to use
 it. There is also a short README.md in the `src/k2v-client` folder with some
 instructions.
+
@@ -27,7 +27,7 @@ Feel free to open a PR to suggest fixes this table. Minio is missing because the

 | Feature                      | Garage                           | [Openstack Swift](https://docs.openstack.org/swift/latest/s3_compat.html) | [Ceph Object Gateway](https://docs.ceph.com/en/latest/radosgw/s3/) | [Riak CS](https://docs.riak.com/riak/cs/2.1.1/references/apis/storage/s3/index.html) | [OpenIO](https://docs.openio.io/latest/source/arch-design/s3_compliancy.html) |
 |------------------------------|----------------------------------|-----------------|---------------|---------|-----|
-| [signature v2](https://docs.aws.amazon.com/AmazonS3/latest/API/Appendix-Sigv2.html) (deprecated) | ❌ Missing | ✅ |  ✅ | ✅ | ✅ |
+| [signature v2](https://docs.aws.amazon.com/general/latest/gr/signature-version-2.html) (deprecated) | ❌ Missing | ✅ |  ✅ | ✅ | ✅ |
 | [signature v4](https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-authenticating-requests.html) |  ✅ Implemented |  ✅ |  ✅ | ❌ | ✅ |
 | [URL path-style](https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access) (eg. `host.tld/bucket/key`) |  ✅ Implemented | ✅ |  ✅ | ❓| ✅ |
 | [URL vhost-style](https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#virtual-hosted-style-access) URL (eg. `bucket.host.tld/key`) |  ✅ Implemented | ❌| ✅| ✅ | ✅ |
@@ -45,7 +45,7 @@ we suppose that OpenIO supports presigned URLs.
 All endpoints that are missing on Garage will return a 501 Not Implemented.
 Some `x-amz-` headers are not implemented.

-### Core endpoints
+### Core endoints

 | Endpoint                     | Garage                           | [Openstack Swift](https://docs.openstack.org/swift/latest/s3_compat.html) | [Ceph Object Gateway](https://docs.ceph.com/en/latest/radosgw/s3/) | [Riak CS](https://docs.riak.com/riak/cs/2.1.1/references/apis/storage/s3/index.html) | [OpenIO](https://docs.openio.io/latest/source/arch-design/s3_compliancy.html) |
 |------------------------------|----------------------------------|-----------------|---------------|---------|-----|
@@ -135,12 +135,12 @@ If you need this feature, please [share your use case in our dedicated issue](ht
 **PutBucketLifecycleConfiguration:** The only actions supported are
 `AbortIncompleteMultipartUpload` and `Expiration` (without the
 `ExpiredObjectDeleteMarker` field).  All other operations are dependent on
-either bucket versioning or storage classes which Garage currently does not
+either bucket versionning or storage classes which Garage currently does not
 implement. The deprecated `Prefix` member directly in the the `Rule`
 structure/XML tag is not supported, specified prefixes must be inside the
 `Filter` structure/XML tag.

-**GetBucketVersioning:** Stub implementation which always returns "versioning not enabled", since Garage does not yet support bucket versioning.
+**GetBucketVersioning:** Stub implementation which always returns "versionning not enabled", since Garage does not yet support bucket versionning.

 ### Replication endpoints

@@ -155,7 +155,7 @@ Please open an issue if you have a use case for replication.
 *Note: Ceph documentation briefly says that Ceph supports
 [replication through the S3 API](https://docs.ceph.com/en/latest/radosgw/multisite-sync-policy/#s3-replication-api)
 but with some limitations.
-Additionally, replication endpoints are not documented in the S3 compatibility page so I don't know what kind of support we can expect.*
+Additionaly, replication endpoints are not documented in the S3 compatibility page so I don't know what kind of support we can expect.*

 ### Locking objects

@@ -197,7 +197,7 @@ Please open an issue if you have a use case.

 ### Vendor specific endpoints

-<details><summary>Display Amazon specific endpoints</summary>
+<details><summary>Display Amazon specifc endpoints</summary>


 | Endpoint                     | Garage                           | [Openstack Swift](https://docs.openstack.org/swift/latest/s3_compat.html) | [Ceph Object Gateway](https://docs.ceph.com/en/latest/radosgw/s3/) | [Riak CS](https://docs.riak.com/riak/cs/2.1.1/references/apis/storage/s3/index.html) | [OpenIO](https://docs.openio.io/latest/source/arch-design/s3_compliancy.html) |
@@ -234,3 +234,4 @@ Please open an issue if you have a use case.
 | [SelectObjectContent](https://docs.aws.amazon.com/AmazonS3/latest/API/API_SelectObjectContent.html) | ❌ Missing | ❌| ❌| ❌| ❌|

 </details>
+
@@ -3,7 +3,7 @@ title = "S3 compatibility target"
 weight = 5
 +++

-If there is a specific S3 functionality you have a need for, feel free to open
+If there is a specific S3 functionnality you have a need for, feel free to open
 a PR to put the corresponding endpoints higher in the list.  Please explain
 your motivations for doing so in the PR message.

@@ -68,7 +68,7 @@ Workflow for DELETE:
 1. Check write permission (LDAP)
 2. Get current version (or versions) in object table
 3. Do the deletion of those versions NOT IN A BACKGROUND JOB THIS TIME
-4. Return success to the user if we were able to delete blocks from the blocks table and entries from the object table
+4. Return succes to the user if we were able to delete blocks from the blocks table and entries from the object table

 To delete a version:

@@ -92,7 +92,7 @@ Known issue: if someone is reading from a version that we want to delete and the
 - file path = /meta/(first 3 hex digits of hash)/(rest of hash)
 - map block hash -> set of version UUIDs where it is referenced

-Useful metadata:
+Usefull metadata:

 - list of versions that reference this block in the Casandra table, so that we can do GC by checking in Cassandra that the lines still exist
 - list of other nodes that we know have acknowledged a write of this block, useful in the rebalancing algorithm
@@ -49,12 +49,12 @@ The ring construction that selects `n_token` random positions for each nodes giv
 is not well-balanced: the space between the tokens varies a lot, and some partitions are thus bigger than others.
 This problem was demonstrated in the original Dynamo DB paper.

-To solve this, we want to apply a better second method for partitioning our dataset:
+To solve this, we want to apply a better second method for partitionning our dataset:

 1. fix an initially large number of partitions (say 1024) with evenly-spaced delimiters, 

 2. attribute each partition randomly to a node, with a probability
-   proportional to its capacity (which `n_tokens` represented in the first
+   proportionnal to its capacity (which `n_tokens` represented in the first
   method)

 For now we continue using the multi-DC ring walking described above.
@@ -66,7 +66,7 @@ I have studied two ways to do the attribution of partitions to nodes, in a way t

 MagLev provided significantly better balancing, as it guarantees that the exact
 same number of partitions is attributed to all nodes that have the same
-capacity (and that this number is proportional to the node's capacity, except
+capacity (and that this number is proportionnal to the node's capacity, except
 for large values), however in both cases:

 - the distribution is still bad, because we use the naive multi-DC ring walking
@@ -19,7 +19,7 @@ The migration steps are as follows:
 2. Disable API and web access. Garage does not support disabling
   these endpoints but you can change the port number or stop your reverse
   proxy for instance.
-3. Check once again that your cluster is healthy. Run again `garage repair --all-nodes --yes tables` which is quick.
+3. Check once again that your cluster is healty. Run again `garage repair --all-nodes --yes tables` which is quick.
   Also check your queues are empty, run `garage stats` to query them.
 4. Turn off Garage v0.6
 5. Backup the metadata folder of all your nodes: `cd /var/lib/garage ; tar -acf meta-v0.6.tar.zst meta/`
@@ -28,11 +28,11 @@ We should try to test in least invasive ways, i.e. minimize the impact of the te
 - Not making `garage` a shared library (launch using `execve`, it's perfectly fine)

 Instead, we should focus on building a clean outer interface for the `garage` binary,
-for example loading configuration using environment variables instead of the configuration file if that's helpful for writing the tests.
+for example loading configuration using environnement variables instead of the configuration file if that's helpfull for writing the tests.

 There are two reasons for this:

- Keep the source code clean and focused
+- Keep the soure code clean and focused
 - Test something that is as close as possible as the true garage that will actually be running

 Reminder: rules of simplicity, concerning changes to Garage's source code.
@@ -71,3 +71,5 @@ Interesting blog posts on the blog of the Sled database:
 Misc:
  - [mutagen](https://github.com/llogiq/mutagen) - mutation testing is a way to assert our test quality by mutating the code and see if the mutation makes the tests fail
  - [fuzzing](https://rust-fuzz.github.io/book/) - cargo supports fuzzing, it could be a way to test our software reliability in presence of garbage data.
+  
+
@@ -176,7 +176,7 @@ Returns the cluster's current health in JSON format, with the following variable
  - degraded: Garage node is not connected to all storage nodes, but a quorum of write nodes is available for all partitions
  - unavailable: a quorum of write nodes is not available for some partitions
 - `knownNodes`: the number of nodes this Garage node has had a TCP connection to since the daemon started
- `connectedNodes`: the number of nodes this Garage node currently has an open connection to
+- `connectedNodes`: the nubmer of nodes this Garage node currently has an open connection to
 - `storageNodes`: the number of storage nodes currently registered in the cluster layout
 - `storageNodesOk`: the number of storage nodes to which a connection is currently open
 - `partitions`: the total number of partitions of the data (currently always 256)
@@ -379,7 +379,7 @@ Example response:
 ]
 ```

-#### GetKeyInfo `GET /v2/GetKeyInfo?id=<access key id>`
+#### GetKeyInfo `GET /v2/GetKeyInfo?id=<acces key id>`
 #### GetKeyInfo `GET /v2/GetKeyInfo?search=<pattern>`

 Returns information about the requested API access key.
@@ -388,7 +388,7 @@ If `id` is set, the key is looked up using its exact identifier (faster).
 If `search` is set, the key is looked up using its name or prefix
 of identifier (slower, all keys are enumerated to do this).

-Optionally, the query parameter `showSecretKey=true` can be set to reveal the
+Optionnally, the query parameter `showSecretKey=true` can be set to reveal the
 associated secret access key.

 Example response:
@@ -487,7 +487,7 @@ Request body format:

 This returns the key info in the same format as the result of GetKeyInfo.

-#### UpdateKey `POST /v2/UpdateKey?id=<access key id>`
+#### UpdateKey `POST /v2/UpdateKey?id=<acces key id>`

 Updates information about the specified API access key.

@@ -509,7 +509,7 @@ The possible flags in `allow` and `deny` are: `createBucket`.

 This returns the key info in the same format as the result of GetKeyInfo.

-#### DeleteKey `POST /v2/DeleteKey?id=<access key id>`
+#### DeleteKey `POST /v2/DeleteKey?id=<acces key id>`

 Deletes an API access key.

@@ -0,0 +1,142 @@
+# [RFC] Garbage Collector Elimination
+
+## Statement of problem and prior art
+
+Currently, Garage's garbage collector has a few identified issues.
+Namely, it can only be run if all nodes in a partition are currently online,
+it may not be correct in front of a rebalancing (this is partially mitigated by a 24h delay added to tombstone deletion),
+and it isn't resilient to a subset of nodes being restored from snapshots.
+It's not clear if it is possible to implement a garbage collection process that can eliminate tombstones, but also support
+a node rollback to a point in time where a key existed.
+
+This problematic, perhaps unsurprisingly, maps very well to the general abstraction of CRDTs for sets, where a whole partition
+would be a single CRDT. The semantic required in Garage demands reinsertion of deleted keys, which excludes the most simple
+forms of sets such as G-Sets and 2P-Sets. As the goal is to not handle garbage collection of tombstones, a standard ORSet
+is also unfitting. In fact it could be argued Garage already uses something akin to an ORSet with a garbage collector today.
+
+There exists CRDTs supporting this feature-set, one of which is an OptORSet[^1].
+It only needs a set-wide metadata proportional in the number of writers, and a per alive-key metadata proportional in the number
+of writers to that key (but no metadata for dead keys).
+These metadata are akin to DVVs[^2]. An element is considered new if its DVV comes causaly after the current DVV of the set.
+Correctness of this algorithm depends however on having causal delivery, which isn't given in Garage, neither in general nor in
+presence of snapshot restoration.
+
+## Proposal
+
+We devise a new kind of CRDT based on the core ideas of an OptORSet, but replacing each version inside its DVVs with a list of
+range of observed updates, which we name a Seen Vector (SV). Such metadata can in the worst case grow linearly with the number of
+insertion. In practice, assuming all elements are eventually known to every replica, the storage requirement of a SV is equivalent
+to that of a standard DVV. Under causal delivery, a SV degenerates into a standard DVV.
+
+To add an element to the set, a node increments its own version counter, and sends an update containing (element, replica, version).
+On receiving such an update, a node checks if it has already seen this particular (replica, version), and if so ignore it.
+If it hasn't seen that update, it saves the new element, and update its SV to include that new (replica, version).
+
+TODO: describe formaly the algorithm
+
+
+Algorithm 1, Seen Vector:
+```
+payload set S    -- S: set of triple (replica i, timestamp s, timestamp e)
+
+initial ∅
+query seen (replica i, timestamp c): boolean b
+  let b = (∃s <= c,e > c: (i,s,e) ∈ S)
+
+update increment ()
+  prepare ()
+    let r = myID()
+    let t = e|∀s,s', ∄e' > e: (r,s,e) ∈ S, (r,s',e') ∈ S    -- t is the maximum end bound for this replica
+  effect(r, t)
+    if ¬seen (r, t) then
+      if seen (r, t - 1) ∧ seen (r, t + 1) then
+        let R = {∃s: (r, s, t) ∈ S}
+        let R' = {∃e: (r, t + 1, e) ∈ S}
+        let M = S \ R
+        let M' = M \ R'
+        S := M' ∪ {(r, s, e)}
+      else if seen (r, t - 1)then
+        let R = {∃s: (r, s, t) ∈ S}
+        let M = S \ R
+        S := M ∪ {(r, s, t+1)}
+      else if seen (r, t + 1)then
+        let R = {∃e: (r, t + 1, e) ∈ S}
+        let M = S \ R
+        E := E ∪ {(r, t, e)}
+      else
+        E := E ∪ {(r, t, t+1)}
+
+merge (B)
+  # TODO this is correct, but largelly suboptimal. We should perform the increment.effect subroutine for all elements of B instead
+  S := S ∪ B.S
+```
+
+Algorithm 2, OptORSet with SV. This algorithm is largely copied and adapted from Figure 3 of [^1]
+```
+payload set E, SV sv  -- E: elements, set of triples (element e, timestamp c, replica i)
+                      -- sv: SeenVector of received triples
+
+initial ∅, ∅
+query contains (element e) : boolean b
+  let b = (∃c, i : (e, c, i) ∈ E)
+
+query elements () : set S
+  let S = {e|∃c, i : (e, c, i) ∈ E}
+
+update add (element e)
+  prepare (e)
+    let r = myID() -- r = source replica
+    let c = sv.increment.prepare().t
+  effect (e, c, r)
+    if ¬sv.seen(r, c) then
+    let O = {(e, c′, r) ∈ E|c′ < c}
+    sv.increment.effect(r, c)
+    E := E ∪ {(e, c, r)} \ O
+
+update remove (element e)
+  prepare (e) -- Collect all unique triples containing e
+    let R = {(e, c, i) ∈ E}
+  effect (R) -- Remove triples observed at source
+    pre causal delivery
+    E := E \ R
+
+merge (B)
+  let M = (E ∩ B.E)
+  let M ′ = {(e, c, i) ∈ E \ B.E| ¬B.sv.seen(i, c)}
+  let M ′′ = {(e, c, i) ∈ B.E \ E| ¬sv.seen(i, c)}
+  let U = M ∪ M ′ ∪ M ′′
+  let O = {(e, c, i) ∈ U |∃(e, c′, i) ∈ U : c < c′}
+  E := U \ O
+  sv := sv.merge(B.sv)
+```
+
+## Storage evaluation
+
+As stated, if all updates are received, the SV is similar in size to that of a standard DVV. It may be however that a node create and
+immediately delete an element, creating holes in its sequence from the point of view of other replicas. These holes could be filled
+through an interactive process where the replica observing holes asks the node to scan over the whole set, and for each version in these
+hole, reply if no element has that exact version number. Holes caused by existing elements should be eventually fixed by an anti-entropy
+process, so replying with these elements appears unnecessary.
+
+The per-element storage requirement is proportional to the number of replicas having modified that element, even under non steady-state.
+This happens because as we always exchange whole elements, we have causal delivery for individual keys.
+
+## Replica version rollback
+
+This scheme assumes the same node won't issue the same version twice, which isn't a given when a node might be rollback to a previous state.
+The author proposes that on initialization, a replica asks all other replicas for the highest version number they know for it.
+If all replicas reply with a number less than or equal to the current version, it is safe to reuse the currently known number.
+If some replicas reply with a number higher, the node increase its version to that number.
+If at least one replica doesn't reply, it can't make any assumption about its actual version number.
+The node then increment a generation number, which is made part of its replica id, starts a new sequence from zero.
+
+## Appendix: providing SV to the underlying elements
+
+Some more complexe elements may want to have access to a version id and the Seen Vector to perform their own internal merge operations.
+The author reckon this may help implementing S3 versioning, by giving a simple way for Objects to know if an ObjectVersion was yet
+unknown or is known and already deleted.
+
+## References
+ 	
+[^1]: An optimized conflict-free replicated set, https://doi.org/10.48550/arXiv.1210.3368
+[^2]: Dotted Version Vectors: Logical Clocks for Optimistic Replication, https://doi.org/10.48550/arXiv.1011.5808
@@ -35,7 +35,7 @@ Triples in K2V are constituted of three fields:
  partition key in which the client wants to read/delete lists of items

 - a sort key (`sk`), an utf8 string that defines the index of the triplet inside its
-  partition; triplets are uniquely identified by their partition key + sort key
+  partition; triplets are uniquely idendified by their partition key + sort key

 - a value (`v`), an opaque binary blob associated to the partition key + sort key;
  they are transmitted as binary when possible but in most case in the JSON API
@@ -74,7 +74,7 @@ are obsoleted by the new write.

 **Basic insertion.** To insert a new value `v4` with context `[(node1, t2), (node2, t3)]`, in a
 simple case where there was no insertion in-between reading the value
-mentioned above and writing `v4`, and supposing that node2 receives the
+mentionned above and writing `v4`, and supposing that node2 receives the
 InsertItem query:

 - `node2` generates a timestamp `t4` such that `t4 > t3`.
@@ -332,7 +332,7 @@ Inserts a single item. This request does not use JSON, the body is sent directly

 To supersede previous values, the HTTP header `X-Garage-Causality-Token` should
 be set to the causality token returned by a previous read on this key. This
-header can be omitted for the first writes to the key.
+header can be ommitted for the first writes to the key.

 Example query:

@@ -397,7 +397,7 @@ smallest partition key that exists.  It returns partition keys in increasing
 order, or decreasing order if `reverse` is set to `true`,
 and stops when either of the following conditions is met:

-1. if `end` is specified, the partition key `end` is reached or surpassed (if it
+1. if `end` is specfied, the partition key `end` is reached or surpassed (if it
   is reached exactly, it is not included in the result)

 2. if `limit` is specified, `limit` partition keys have been listed
@@ -491,7 +491,7 @@ the triplet is inserted for the first time, the causality token should be set to

 The value is expected to be a base64-encoded binary blob. The value `null` can
 also be used to delete the triplet while preserving causality information: this
-allows to know if a delete has happened concurrently with an insert, in which
+allows to know if a delete has happenned concurrently with an insert, in which
 case both are preserved and returned on reads (see below).

 Partition keys and sort keys are utf8 strings which are stored sorted by
@@ -540,7 +540,7 @@ JSON struct with the following fields:

 For each of the searches, triplets are listed and returned separately. The
 semantics of `prefix`, `start`, `end`, `limit` and `reverse` are the same as for ReadIndex. The
-additional parameter `singleItem` allows to get a single item, whose sort key
+additionnal parameter `singleItem` allows to get a single item, whose sort key
 is the one given in `start`. Parameters `conflictsOnly` and `tombstones`
 control additional filters on the items that are returned.

@@ -59,7 +59,7 @@ To link the effective storage capacity of the cluster to partition assignment, w
 \end{equation}
 This assumption is justified by the dispersion of the hashing function, when the number of partitions is small relative to the number of stored blocks.

-Every node $n$ will store some number $p_n$ of partitions (it is the number of partitions $p$ such that $n$ appears in the $\alpha_p$). Hence the partitions stored by $n$ (and hence all partitions by our assumption) have there size bounded by $c_n/p_n$. This remark leads us to define the optimal size that we will want to maximize:
+Every node $n$ wille store some number $p_n$ of partitions (it is the number of partitions $p$ such that $n$ appears in the $\alpha_p$). Hence the partitions stored by $n$ (and hence all partitions by our assumption) have there size bounded by $c_n/p_n$. This remark leads us to define the optimal size that we will want to maximize:

 \begin{equation}
 	\label{eq:optimal}
@@ -38,7 +38,7 @@ We would like to compute an assignment of nodes to partitions. We will impose so
 \end{equation}
 This assumption is justified by the dispersion of the hashing function, when the number of partitions is small relative to the number of stored large objects.

-Every node $n$ will store some number $k_n$ of partitions. Hence the partitions stored by $n$ (and hence all partitions by our assumption) have there size bounded by $c_n/k_n$. This remark leads us to define the optimal size that we will want to maximize:
+Every node $n$ wille store some number $k_n$ of partitions. Hence the partitions stored by $n$ (and hence all partitions by our assumption) have there size bounded by $c_n/k_n$. This remark leads us to define the optimal size that we will want to maximize:

 \begin{equation}
 	\label{eq:optimal}
@@ -62,7 +62,7 @@ For now, in the following, we ask the following redundancy constraint:

 \textbf{Mode 3:} every partition needs to be assignated to three nodes. We try to spread the three nodes over different zones as much as possible.

-\textbf{Warning:} This is a working document written incrementally. The last version of the algorithm is the \textbf{parametric assignment} described in the next section.
+\textbf{Warning:} This is a working document written incrementaly. The last version of the algorithm is the \textbf{parametric assignment} described in the next section.


 \section{Computation of a parametric assignment}
@@ -318,7 +318,7 @@ $$
 $$
 which is the universal upper bound on $s^*$. Hence any optimal utilization $(n_v)$ can be modified to another optimal utilization such that $n_v\ge \hat{n}_v$

-Because $z_0$ cannot store more than $N$ partition occurrences, in any assignment, at least $2N$ partitions must be assignated to the zones $Z\setminus\{z_0\}$. Let $C_0 = C-c_{z_0}$. Suppose that there exists a zone $z_1\neq z_0$ such that $c_{z_1}/C_0 \ge 1/2$. Then, with the same argument as for $z_0$, we can define
+Because $z_0$ cannot store more than $N$ partition occurences, in any assignment, at least $2N$ partitions must be assignated to the zones $Z\setminus\{z_0\}$. Let $C_0 = C-c_{z_0}$. Suppose that there exists a zone $z_1\neq z_0$ such that $c_{z_1}/C_0 \ge 1/2$. Then, with the same argument as for $z_0$, we can define 
 $$\hat{n}_v = \left\lfloor\frac{c_v}{c_{z_1}}N\right\rfloor$$
 for every $v\in z_1$.

@@ -351,7 +351,7 @@ Define $3N$ tokens $t_1,\ldots, t_{3N}\in V$ as follows:
 Then for $1\le i \le N$, define the triplet $T_i$ to be 
 $(t_i, t_{i+N}, t_{i+2N})$. Since the same nodes of a zone appear contiguously, the three nodes of a triplet must belong to three distinct zones.

-However simple, this solution to go from an utilization to an assignment has the drawback of not spreading the triplets: a node will tend to be associated to the same two other nodes for many partitions. Hence, during data transfer, it will tend to use only two link, instead of spreading the bandwidth use over many other links to other nodes. To achieve this goal, we will reframe the search of an assignment as a flow problem. and in the flow algorithm, we will introduce randomness in the order of exploration. This will be sufficient to obtain a good dispersion of the triplets.
+However simple, this solution to go from an utilization to an assignment has the drawback of not spreading the triplets: a node will tend to be associated to the same two other nodes for many partitions. Hence, during data transfer, it will tend to use only two link, instead of spreading the bandwith use over many other links to other nodes. To achieve this goal, we will reframe the search of an assignment as a flow problem. and in the flow algorithm, we will introduce randomness in the order of exploration. This will be sufficient to obtain a good dispersion of the triplets.

 \begin{figure}
 	\centering
@@ -436,7 +436,7 @@ T_3=(b,c,d').
 $$
 One can check that in this case, it is impossible to minimize both the number of zone and node changes.

-Because of the redundancy constraint, we cannot use a greedy algorithm to just replace nodes in the triplets to try to get the new utilization rate: this could lead to blocking situation where there is still a hole to fill in a triplet but no available node satisfies the zone separation constraint. To circumvent this issue, we propose an algorithm based on finding cycles in a graph encoding of the assignment. As in section \ref{sec:opt_assign}, we can explore the neighbours in a random order in the graph algorithms, to spread the triplets distribution.
+Because of the redundancy constraint, we cannot use a greedy algorithm to just replace nodes in the triplets to try to get the new utilization rate: this could lead to blocking situation where there is still a hole to fill in a triplet but no available node satisfies the zone separation constraint. To circumvent this issue, we propose an algorithm based on finding cycles in a graph encoding of the assignment. As in section \ref{sec:opt_assign}, we can explore the neigbours in a random order in the graph algorithms, to spread the triplets distribution.


 \subsubsection{Minimizing the zone discrepancy}
@@ -550,8 +550,8 @@ We give some considerations of worst case complexity for these algorithms. In th
 Algorithm \ref{alg:util} can be implemented with complexity $O(\#V^2)$. The complexity of the function call at line \ref{lin:subutil} is $O(\#V)$. The difference between the sum of the subutilizations and $3N$ is at most the sum of the rounding errors when computing the $\hat{n}_v$. Hence it is bounded by $\#V$ and the loop at line \ref{lin:loopsub} is iterated at most $\#V$ times. Finding the minimizing $v$ at line \ref{lin:findmin} takes $O(\#V)$ operations (naively, we could also use a heap).

 Algorithm \ref{alg:opt} can be implemented with complexity $O(N^3\times \#Z)$. The flow graph has $O(N+\#Z)$ vertices and $O(N\times \#Z)$ edges. Dinic's algorithm has complexity $O(\#\mathrm{Vertices}^2\#\mathrm{Edges})$ hence in our case it is $O(N^3\times \#Z)$.
-
-Algorithm \ref{alg:mini} can be implemented with complexity $O(N^3\# Z)$ under \eqref{hyp:A} and $O(N^3 \#Z \#V)$ under \eqref{hyp:B}.
+ 
+Algorithm \ref{alg:mini} can be implented with complexity $O(N^3\# Z)$ under \eqref{hyp:A} and $O(N^3 \#Z \#V)$ under \eqref{hyp:B}.
 The graph $G_T$ has $O(N)$ vertices and $O(N\times \#Z)$ edges under assumption \eqref{hyp:A} and respectively $O(N\times \#Z)$ vertices and $O(N\times \#V)$ edges under assumption \eqref{hyp:B}. The loop at line \ref{lin:repeat} is iterated at most $N$ times since the distance between $T$ and $T'$ decreases at every iteration. Bellman-Ford algorithm has complexity $O(\#\mathrm{Vertices}\#\mathrm{Edges})$, which in our case amounts to $O(N^2\# Z)$ under \eqref{hyp:A} and $O(N^2 \#Z \#V)$ under \eqref{hyp:B}.
 
 \begin{algorithm}
@@ -637,7 +637,7 @@ We try to maximize $s^*$ defined in \eqref{eq:optimal}. So we can compute the op

 \subsection{Computation of a candidate assignment}

-To compute a candidate assignment (that does not optimize zone spreading nor distance to a previous assignment yet), we can use the following flow problem.
+To compute a candidate assignment (that does not optimize zone spreading nor distance to a previous assignment yet), we can use the folowing flow problem.

 Define the oriented weighted graph $(X,E)$. The set of vertices $X$ contains the source $\mathbf{s}$, the sink $\mathbf{t}$, vertices 
 $\mathbf{x}_p, \mathbf{u}^+_p, \mathbf{u}^-_p$ for every partition $p$, vertices $\mathbf{y}_{p,z}$ for every partition $p$ and zone $z$, and vertices $\mathbf{z}_v$ for every node $v$. 
@@ -680,14 +680,14 @@ Given the flow $f$, let $G_f=(X',E_f)$ be the multi-graph where $X' = X\setminus
 \end{itemize}
 To summarize, arcs are oriented left to right if they correspond to a presence of flow in $f$, and right to left if they correspond to an absence of flow. They are positively weighted if we want them to stay at their current state, and negatively if we want them to switch. Let us compute the weight of such graph.

-\begin{multiline*}
+\begin{multline*}
 	w(G_f)  = \sum_{e\in E_f} w(e_f)  \\
 	= 
 	(\alpha - \beta -\gamma) N_1 + (\alpha +\beta - \gamma) N_2 + (\alpha+\beta+\gamma) N_3 
 	\\ + 
 	\#V\times N - 4 \sum_p 3-\#(T_p\cap T'_p) \\ 
 	=(\#V-12+\alpha-\beta-\gamma)\times N + 4Q_V + 2\beta N_2 + 2(\beta+\gamma) N_3 \\
-\end{multiline*}
+\end{multline*}

 As for the mode 3-strict, one can check that the difference of two such graphs corresponding to the same $(n_v)$ is always eulerian. Hence we can navigate in this class with the same greedy algorithm that discovers positive cycles and flips them.

@@ -12,17 +12,16 @@
      "original": {
        "owner": "ipetkov",
        "repo": "crane",
-        "rev": "6fe74265bbb6d016d663b1091f015e2976c4a527",
        "type": "github"
      }
    },
    "flake-compat": {
      "locked": {
-        "lastModified": 1761640442,
-        "narHash": "sha256-AtrEP6Jmdvrqiv4x2xa5mrtaIp3OEe8uBYCDZDS+hu8=",
+        "lastModified": 1717312683,
+        "narHash": "sha256-FrlieJH50AuvagamEvWMIE6D2OAnERuDboFDYAED/dE=",
        "owner": "nix-community",
        "repo": "flake-compat",
-        "rev": "4a56054d8ffc173222d09dad23adf4ba946c8884",
+        "rev": "38fd3954cf65ce6faf3d0d45cd26059e059f07ea",
        "type": "github"
      },
      "original": {
@@ -51,17 +50,17 @@
    },
    "nixpkgs": {
      "locked": {
-        "lastModified": 1763977559,
-        "narHash": "sha256-g4MKqsIRy5yJwEsI+fYODqLUnAqIY4kZai0nldAP6EM=",
+        "lastModified": 1747825515,
+        "narHash": "sha256-BWpMQymVI73QoKZdcVCxUCCK3GNvr/xa2Dc4DM1o2BE=",
        "owner": "NixOS",
        "repo": "nixpkgs",
-        "rev": "cfe2c7d5b5d3032862254e68c37a6576b633d632",
+        "rev": "cd2812de55cf87df88a9e09bf3be1ce63d50c1a6",
        "type": "github"
      },
      "original": {
        "owner": "NixOS",
        "repo": "nixpkgs",
-        "rev": "cfe2c7d5b5d3032862254e68c37a6576b633d632",
+        "rev": "cd2812de55cf87df88a9e09bf3be1ce63d50c1a6",
        "type": "github"
      }
    },
@@ -81,17 +80,17 @@
        ]
      },
      "locked": {
-        "lastModified": 1763952169,
-        "narHash": "sha256-+PeDBD8P+NKauH+w7eO/QWCIp8Cx4mCfWnh9sJmy9CM=",
+        "lastModified": 1738549608,
+        "narHash": "sha256-GdyT9QEUSx5k/n8kILuNy83vxxdyUfJ8jL5mMpQZWfw=",
        "owner": "oxalica",
        "repo": "rust-overlay",
-        "rev": "ab726555a9a72e6dc80649809147823a813fa95b",
+        "rev": "35c6f8c4352f995ecd53896200769f80a3e8f22d",
        "type": "github"
      },
      "original": {
        "owner": "oxalica",
        "repo": "rust-overlay",
-        "rev": "ab726555a9a72e6dc80649809147823a813fa95b",
+        "rev": "35c6f8c4352f995ecd53896200769f80a3e8f22d",
        "type": "github"
      }
    },
@@ -2,17 +2,16 @@
  description =
    "Garage, an S3-compatible distributed object store for self-hosted deployments";

-  # Nixpkgs 25.05 as of 2025-11-24
+  # Nixpkgs 25.05 as of 2025-05-22
  inputs.nixpkgs.url =
-    "github:NixOS/nixpkgs/cfe2c7d5b5d3032862254e68c37a6576b633d632";
+    "github:NixOS/nixpkgs/cd2812de55cf87df88a9e09bf3be1ce63d50c1a6";

-  # Rust overlay as of 2025-11-24
+  # Rust overlay as of 2025-02-03
  inputs.rust-overlay.url =
-  "github:oxalica/rust-overlay/ab726555a9a72e6dc80649809147823a813fa95b";
+  "github:oxalica/rust-overlay/35c6f8c4352f995ecd53896200769f80a3e8f22d";
  inputs.rust-overlay.inputs.nixpkgs.follows = "nixpkgs";

-  # Crane as of 2025-01-24
-  inputs.crane.url = "github:ipetkov/crane/6fe74265bbb6d016d663b1091f015e2976c4a527";
+  inputs.crane.url = "github:ipetkov/crane";

  inputs.flake-compat.url = "github:nix-community/flake-compat";
  inputs.flake-utils.url = "github:numtide/flake-utils";
@@ -31,10 +30,6 @@
          inherit system nixpkgs crane rust-overlay extraTestEnv;
          release = false;
        }).garage-test;
-        lints = (compile {
-          inherit system nixpkgs crane rust-overlay;
-          release = false;
-        });
      in
      {
        packages = {
@@ -61,13 +56,9 @@
          tests-fjall = testWith {
            GARAGE_TEST_INTEGRATION_DB_ENGINE = "fjall";
          };
-
-          # lints (fmt, clippy)
-          fmt = lints.garage-cargo-fmt;
-          clippy = lints.garage-cargo-clippy;
        };

-        # ---- development shell, for making native builds only ----
+        # ---- developpment shell, for making native builds only ----
        devShells =
          let
            targets = compile {
@@ -167,7 +167,7 @@ let
                 </ul></p>
                 <p> Sources:
                 <ul>
-                  <li><a href="https://git.deuxfleurs.fr/Deuxfleurs/garage/src/${r.type}/${x.version}">Forgejo</a></li>
+                  <li><a href="https://git.deuxfleurs.fr/Deuxfleurs/garage/src/${r.type}/${x.version}">gitea</a></li>
                  <li><a href="https://git.deuxfleurs.fr/Deuxfleurs/garage/archive/${x.version}.zip">.zip</a></li>
                  <li><a href="https://git.deuxfleurs.fr/Deuxfleurs/garage/archive/${x.version}.tar.gz">.tar.gz</a></li>
                 </ul></p>
@@ -48,7 +48,7 @@ let

  inherit (pkgs) lib stdenv;

-  toolchainFn = (p: p.rust-bin.stable."1.91.0".default.override {
+  toolchainFn = (p: p.rust-bin.stable."1.82.0".default.override {
    targets = lib.optionals (target != null) [ rustTarget ];
    extensions = [
      "rust-src"
@@ -190,15 +190,4 @@ in rec {
      pkgs.cacert
    ];
  } // extraTestEnv);
-
-  # ---- source code linting ----
-
-  garage-cargo-fmt = craneLib.cargoFmt (commonArgs // {
-    cargoExtraArgs = "";
-  });
-
-  garage-cargo-clippy = craneLib.cargoClippy (commonArgs // {
-    cargoArtifacts = garage-deps;
-    cargoClippyExtraArgs = "--all-targets -- -D warnings";
-  });
 }
@@ -2,8 +2,8 @@ apiVersion: v2
 name: garage
 description: S3-compatible object store for small self-hosted geo-distributed deployments
 type: application
-version: 0.9.2
-appVersion: "v2.2.0"
+version: 0.9.1
+appVersion: "v2.1.0"
 home: https://garagehq.deuxfleurs.fr/
 icon: https://garagehq.deuxfleurs.fr/images/garage-logo.svg

@@ -1,6 +1,6 @@
 # garage

-![Version: 0.9.2](https://img.shields.io/badge/Version-0.9.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.2.0](https://img.shields.io/badge/AppVersion-v2.2.0-informational?style=flat-square)
+![Version: 0.9.1](https://img.shields.io/badge/Version-0.9.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.1.0](https://img.shields.io/badge/AppVersion-v2.1.0-informational?style=flat-square)

 S3-compatible object store for small self-hosted geo-distributed deployments

@@ -29,7 +29,7 @@ S3-compatible object store for small self-hosted geo-distributed deployments
 | garage.dbEngine | string | `"lmdb"` | Can be changed for better performance on certain systems https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#db_engine |
 | garage.existingConfigMap | string | `""` | if not empty string, allow using an existing ConfigMap for the garage.toml, if set, ignores garage.toml |
 | garage.garageTomlString | string | `""` | String Template for the garage configuration if set, ignores above values. Values can be templated, see https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/ |
-| garage.kubernetesSkipCrd | bool | `false` | Set to true if you want to use k8s discovery but install the CRDs manually outside of the helm chart, for example if you operate at namespace level without cluster resources |
+| garage.kubernetesSkipCrd | bool | `false` | Set to true if you want to use k8s discovery but install the CRDs manually outside of the helm chart, for example if you operate at namespace level without cluster ressources |
 | garage.replicationFactor | string | `"3"` | Default to 3 replicas, see the replication_factor section at https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#replication_factor |
 | garage.consistencyMode | string | `"consistent"` | Default to read-after-write consistency, see the consistency_mode section at https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#consistency_mode |
 | garage.metadataAutoSnapshotInterval | string | `""` | If this value is set, Garage will automatically take a snapshot of the metadata DB file at a regular interval and save it in the metadata directory. https://garagehq.deuxfleurs.fr/documentation/reference-manual/configuration/#metadata_auto_snapshot_interval |
@@ -76,7 +76,7 @@ S3-compatible object store for small self-hosted geo-distributed deployments
 | persistence.enabled | bool | `true` |  |
 | persistence.meta.hostPath | string | `"/var/lib/garage/meta"` |  |
 | persistence.meta.size | string | `"100Mi"` |  |
-| podAnnotations | object | `{}` | additional pod annotations |
+| podAnnotations | object | `{}` | additonal pod annotations |
 | podSecurityContext.fsGroup | int | `1000` |  |
 | podSecurityContext.runAsGroup | int | `1000` |  |
 | podSecurityContext.runAsNonRoot | bool | `true` |  |
@@ -47,8 +47,8 @@ helm.sh/chart: {{ include "garage.chart" . }}
 app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
 {{- end }}
 app.kubernetes.io/managed-by: {{ .Release.Service }}
-{{- with .Values.commonLabels }}
-{{- toYaml . | nindent 0 }}
+{{ with .Values.commonLabels }}
+{{- toYaml . }}
 {{- end }}
 {{- end }}

@@ -13,7 +13,7 @@ data:

    db_engine = "{{ .Values.garage.dbEngine }}"

-    block_size = "{{ .Values.garage.blockSize }}"
+    block_size = {{ .Values.garage.blockSize }}

    replication_factor = {{ .Values.garage.replicationFactor }}
    consistency_mode = "{{ .Values.garage.consistencyMode }}"
@@ -28,11 +28,7 @@ data:
    # rpc_secret will be populated by the init container from a k8s secret object
    rpc_secret = "__RPC_SECRET_REPLACE__"

-    bootstrap_peers = [
-    {{- range $index, $peer := .Values.garage.bootstrapPeers }}
-    {{- if $index}}, {{ end }}{{ $peer | quote }}
-    {{ end }} 
-    ]
+    bootstrap_peers = {{ .Values.garage.bootstrapPeers }}

    {{- if .Values.garage.additionalTopLevelConfig }}
    {{ .Values.garage.additionalTopLevelConfig | nindent 4 }}
@@ -4,10 +4,6 @@ metadata:
  name: {{ include "garage.fullname" . }}
  labels:
    {{- include "garage.labels" . | nindent 4 }}
-  {{- with .Values.service.annotations }}
-  annotations:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
 spec:
  type: {{ .Values.service.type }}
  ports:
@@ -41,4 +37,4 @@ spec:
      name: metrics
  selector:
    {{- include "garage.selectorLabels" . | nindent 4 }}
-{{- end }}
+{{- end }}
@@ -44,7 +44,7 @@ garage:
  # -- This is not required if you use the integrated kubernetes discovery
  bootstrapPeers: []
  # -- Set to true if you want to use k8s discovery but install the CRDs manually outside
-  # of the helm chart, for example if you operate at namespace level without cluster resources
+  # of the helm chart, for example if you operate at namespace level without cluster ressources
  kubernetesSkipCrd: false
  s3:
    api:
@@ -120,7 +120,7 @@ serviceAccount:
  # If not set and create is true, a name is generated using the fullname template
  name: ""

-# -- additional pod annotations
+# -- additonal pod annotations
 podAnnotations: {}

 podSecurityContext:
@@ -144,8 +144,6 @@ service:
  # - NodePort (+ Ingress)
  # - LoadBalancer
  type: ClusterIP
-  # -- Annotations to add to the service
-  annotations: {}
  s3:
    api:
      port: 3900
@@ -209,7 +207,7 @@ ingress:
      #      - kubernetes.docker.internal

 resources: {}
-  # The following are indicative for a small-size deployment, for anything serious double them.
+  # The following are indicative for a small-size deployement, for anything serious double them.
  # limits:
  #   cpu: 100m
  #   memory: 1024Mi
@@ -127,7 +127,7 @@ They are due to the download being interrupted in the middle (^C during first la
 Add `:force?` to the `cached-wget!` call in `daemon.clj` to re-download the binary,
 or restar the VMs to clear temporary files.

-### In `jepsen.garage`: prefix weirdness
+### In `jepsen.garage`: prefix wierdness

 In `store/garage set1/20231019T163358.615+0200`:

@@ -146,12 +146,12 @@ and passing all values that were previously in the context (creds and prefix) as
 The reg2 test is our custom checker for CRDT read-after-write on individual object keys, acting as registers which can be updated.
 The test fails without the timestamp fix, which is expected as the clock scrambler will prevent nodes from having a correct ordering of objects.

-With the timestamp fix (`--patch tsfix1`), the happened-before relationship should at least be respected, meaning that when a PutObject call starts
+With the timestamp fix (`--patch tsfix1`), the happenned-before relationship should at least be respected, meaning that when a PutObject call starts
 after another PutObject call has ended, the second call should overwrite the value of the first call, and that value should not be
 readable by future GetObject calls.
 However, we observed inconsistencies even with the timestamp fix.

-The inconsistencies seemed to always happened after writing a nil value, which translates to a DeleteObject call
+The inconsistencies seemed to always happenned after writing a nil value, which translates to a DeleteObject call
 instead of a PutObject. By removing the possibility of writing nil values, therefore only doing
 PutObject calls, the issue disappears. There is therefore an issue to fix in DeleteObject.

@@ -2,7 +2,7 @@

 : '
 	This script tests whether uploaded parts can be skipped in a
-	CompleteMultipartUpload
+	CompleteMultipartUpoad

 	On Minio: yes, parts can be skipped

@@ -52,7 +52,7 @@

 	Conclusions:

-	- Skipping a part in a CompleteMultipartUpload call is OK
+	- Skipping a part in a CompleteMultipartUpoad call is OK
 	- The part is simply not included in the stored object
 	- Sequential part renumbering counts only non-skipped parts
 '
@@ -26,7 +26,7 @@ in
      s3cmd
      minio-client
      rclone
-      (python313.withPackages (ps: [ ps.boto3 ]))
+      (python312.withPackages (ps: [ ps.boto3 ]))

      socat
      psmisc
@@ -34,11 +34,8 @@ in
      openssl
      curl
      jq
-      typos
    ];
    shellHook = ''
-      export AWS_REQUEST_CHECKSUM_CALCULATION='when_required'
-
      function to_s3 {
        AWS_REQUEST_CHECKSUM_CALCULATION=WHEN_REQUIRED AWS_RESPONSE_CHECKSUM_VALIDATION=WHEN_REQUIRED \
        aws \
@@ -52,7 +49,7 @@ in
      function to_docker {
        executor  \
          --force \
-          --custom-platform="$(echo "''${DOCKER_PLATFORM}" | sed 's/i386/386/')" \
+          --customPlatform="$(echo "''${DOCKER_PLATFORM}" | sed 's/i386/386/')" \
          --destination "$(echo "''${CONTAINER_NAME}" | sed 's/i386/386/'):''${CONTAINER_TAG}" \
          --context dir://`pwd` \
          --verbosity=debug
@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_admin"
-version = "2.2.0"
+version = "2.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -46,5 +46,5 @@ opentelemetry-prometheus = { workspace = true, optional = true }
 prometheus = { workspace = true, optional = true }

 [features]
-metrics = ["opentelemetry-prometheus", "prometheus"]
-k2v = ["garage_model/k2v"]
+metrics = [ "opentelemetry-prometheus", "prometheus" ]
+k2v = [ "garage_model/k2v" ]
@@ -143,7 +143,7 @@ impl RequestHandler for UpdateAdminTokenRequest {
 		garage: &Arc<Garage>,
 		_admin: &Admin,
 	) -> Result<UpdateAdminTokenResponse, Error> {
-		let mut token = get_existing_admin_token(garage, &self.id).await?;
+		let mut token = get_existing_admin_token(&garage, &self.id).await?;

 		apply_token_updates(&mut token, self.body)?;

@@ -164,7 +164,7 @@ impl RequestHandler for DeleteAdminTokenRequest {
 		garage: &Arc<Garage>,
 		_admin: &Admin,
 	) -> Result<DeleteAdminTokenResponse, Error> {
-		let token = get_existing_admin_token(garage, &self.id).await?;
+		let token = get_existing_admin_token(&garage, &self.id).await?;

 		garage
 			.admin_token_table
@@ -224,7 +224,7 @@ impl RequestHandler for GetCurrentAdminTokenInfoRequest {
 		}

 		let (prefix, _) = self.admin_token.split_once('.').unwrap();
-		let token = get_existing_admin_token(garage, &prefix.to_string()).await?;
+		let token = get_existing_admin_token(&garage, &prefix.to_string()).await?;

 		Ok(GetCurrentAdminTokenInfoResponse(admin_token_info_results(
 			&token, now,
@@ -262,7 +262,7 @@ pub struct GetClusterHealthResponse {
 	pub status: String,
 	/// the number of nodes this Garage node has had a TCP connection to since the daemon started
 	pub known_nodes: usize,
-	/// the number of nodes this Garage node currently has an open connection to
+	/// the nubmer of nodes this Garage node currently has an open connection to
 	pub connected_nodes: usize,
 	/// the number of storage nodes currently registered in the cluster layout
 	pub storage_nodes: usize,
@@ -387,7 +387,7 @@ pub struct UpdateAdminTokenRequestBody {
 	/// `GetClusterStatus`, etc), or the special value `*` to allow all
 	/// admin endpoints. **WARNING:** Granting a scope of `CreateAdminToken` or
 	/// `UpdateAdminToken` trivially allows for privilege escalation, and is thus
-	/// functionally equivalent to granting a scope of `*`.
+	/// functionnally equivalent to granting a scope of `*`.
 	pub scope: Option<Vec<String>>,
 }

@@ -841,7 +841,7 @@ pub struct GetBucketInfoResponse {
 	pub created: DateTime<Utc>,
 	/// List of global aliases for this bucket
 	pub global_aliases: Vec<String>,
-	/// Whether website access is enabled for this bucket
+	/// Whether website acces is enabled for this bucket
 	pub website_access: bool,
 	#[serde(default)]
 	/// Website configuration for this bucket
@@ -64,7 +64,7 @@ impl EndpointHandler<AdminRpc> for AdminApiServer {
 		match message {
 			AdminRpc::Proxy(req) => {
 				info!("Proxied admin API request: {}", req.name());
-				let res = req.clone().handle(&self.garage, self).await;
+				let res = req.clone().handle(&self.garage, &self).await;
 				match res {
 					Ok(res) => Ok(AdminRpcResponse::ProxyApiOkResponse(res.tagged())),
 					Err(e) => Ok(AdminRpcResponse::ApiErrorResponse {
@@ -76,7 +76,7 @@ impl EndpointHandler<AdminRpc> for AdminApiServer {
 			}
 			AdminRpc::Internal(req) => {
 				info!("Internal admin API request: {}", req.name());
-				let res = req.clone().handle(&self.garage, self).await;
+				let res = req.clone().handle(&self.garage, &self).await;
 				match res {
 					Ok(res) => Ok(AdminRpcResponse::InternalApiOkResponse(res)),
 					Err(e) => Ok(AdminRpcResponse::ApiErrorResponse {
@@ -173,12 +173,12 @@ impl AdminApiServer {
 		}

 		match request {
-			AdminApiRequest::Options(req) => req.handle(&self.garage, self).await,
-			AdminApiRequest::CheckDomain(req) => req.handle(&self.garage, self).await,
-			AdminApiRequest::Health(req) => req.handle(&self.garage, self).await,
-			AdminApiRequest::Metrics(req) => req.handle(&self.garage, self).await,
+			AdminApiRequest::Options(req) => req.handle(&self.garage, &self).await,
+			AdminApiRequest::CheckDomain(req) => req.handle(&self.garage, &self).await,
+			AdminApiRequest::Health(req) => req.handle(&self.garage, &self).await,
+			AdminApiRequest::Metrics(req) => req.handle(&self.garage, &self).await,
 			req => {
-				let res = req.handle(&self.garage, self).await?;
+				let res = req.handle(&self.garage, &self).await?;
 				let mut res = json_ok_response(&res)?;
 				res.headers_mut()
 					.insert(ACCESS_CONTROL_ALLOW_ORIGIN, HeaderValue::from_static("*"));
@@ -29,7 +29,7 @@ impl RequestHandler for LocalListBlockErrorsRequest {
 		let errors = errors
 			.into_iter()
 			.map(|e| BlockError {
-				block_hash: hex::encode(e.hash),
+				block_hash: hex::encode(&e.hash),
 				refcount: e.refcount,
 				error_count: e.error_count,
 				last_try_secs_ago: now.saturating_sub(e.last_try) / 1000,
@@ -61,15 +61,15 @@ impl RequestHandler for LocalGetBlockInfoRequest {
 					VersionBacklink::MultipartUpload { upload_id } => {
 						if let Some(u) = garage.mpu_table.get(upload_id, &EmptyKey).await? {
 							BlockVersionBacklink::Upload {
-								upload_id: hex::encode(upload_id),
+								upload_id: hex::encode(&upload_id),
 								upload_deleted: u.deleted.get(),
 								upload_garbage_collected: false,
-								bucket_id: Some(hex::encode(u.bucket_id)),
+								bucket_id: Some(hex::encode(&u.bucket_id)),
 								key: Some(u.key.to_string()),
 							}
 						} else {
 							BlockVersionBacklink::Upload {
-								upload_id: hex::encode(upload_id),
+								upload_id: hex::encode(&upload_id),
 								upload_deleted: true,
 								upload_garbage_collected: true,
 								bucket_id: None,
@@ -78,12 +78,12 @@ impl RequestHandler for LocalGetBlockInfoRequest {
 						}
 					}
 					VersionBacklink::Object { bucket_id, key } => BlockVersionBacklink::Object {
-						bucket_id: hex::encode(bucket_id),
+						bucket_id: hex::encode(&bucket_id),
 						key: key.to_string(),
 					},
 				};
 				versions.push(BlockVersion {
-					version_id: hex::encode(br.version),
+					version_id: hex::encode(&br.version),
 					ref_deleted: br.deleted.get(),
 					version_deleted: v.deleted.get(),
 					garbage_collected: false,
@@ -91,7 +91,7 @@ impl RequestHandler for LocalGetBlockInfoRequest {
 				});
 			} else {
 				versions.push(BlockVersion {
-					version_id: hex::encode(br.version),
+					version_id: hex::encode(&br.version),
 					ref_deleted: br.deleted.get(),
 					version_deleted: true,
 					garbage_collected: true,
@@ -100,7 +100,7 @@ impl RequestHandler for LocalGetBlockInfoRequest {
 			}
 		}
 		Ok(LocalGetBlockInfoResponse {
-			block_hash: hex::encode(hash),
+			block_hash: hex::encode(&hash),
 			refcount,
 			versions,
 		})
@@ -215,7 +215,7 @@ fn find_block_hash_by_prefix(garage: &Arc<Garage>, prefix: &str) -> Result<Hash,
 	for item in iter {
 		let (k, _v) = item.map_err(GarageError::from)?;
 		let hash = Hash::try_from(&k[..32]).unwrap();
-		if hash.as_slice()[..prefix_bin.len()] != prefix_bin {
+		if &hash.as_slice()[..prefix_bin.len()] != prefix_bin {
 			break;
 		}
 		if hex::encode(hash.as_slice()).starts_with(prefix) {
@@ -183,7 +183,7 @@ impl RequestHandler for CreateBucketRequest {

 			let key = helper.key().get_existing_key(&la.access_key_id).await?;
 			let state = key.state.as_option().unwrap();
-			if state.local_aliases.get(&la.alias).is_some() {
+			if matches!(state.local_aliases.get(&la.alias), Some(_)) {
 				return Err(Error::bad_request("Local alias already exists"));
 			}
 		}
@@ -380,13 +380,13 @@ impl RequestHandler for InspectObjectRequest {
 						.map(|(vk, vb)| InspectObjectBlock {
 							part_number: vk.part_number,
 							offset: vk.offset,
-							hash: hex::encode(vb.hash),
+							hash: hex::encode(&vb.hash),
 							size: vb.size,
 						})
 						.collect::<Vec<_>>()
 				})
 				.unwrap_or_default();
-			let uuid = hex::encode(obj_ver.uuid);
+			let uuid = hex::encode(&obj_ver.uuid);
 			let timestamp = DateTime::from_timestamp_millis(obj_ver.timestamp as i64)
 				.expect("invalid timestamp in db");
 			match &obj_ver.state {
@@ -467,7 +467,7 @@ impl RequestHandler for InspectObjectRequest {
 		}

 		Ok(InspectObjectResponse {
-			bucket_id: hex::encode(object.bucket_id),
+			bucket_id: hex::encode(&object.bucket_id),
 			key: object.key,
 			versions,
 		})
@@ -26,7 +26,7 @@ pub enum Error {
 	NoSuchAdminToken(String),

 	/// The API access key does not exist
-	#[error("Access key not found: {0}")]
+	#[error("Access key not found: {00}")]
 	NoSuchAccessKey(String),

 	/// The requested block does not exist
@@ -91,7 +91,7 @@ impl RequestHandler for GetKeyInfoRequest {
 			}
 		};

-		key_info_results(garage, key, self.show_secret_key).await
+		Ok(key_info_results(garage, key, self.show_secret_key).await?)
 	}
 }

@@ -143,7 +143,7 @@ impl RequestHandler for GetClusterLayoutHistoryRequest {
 					.iter()
 					.map(|node| {
 						(
-							hex::encode(node),
+							hex::encode(&node),
 							NodeUpdateTrackers {
 								ack: layout.update_trackers.ack_map.get(node, min_stored),
 								sync: layout.update_trackers.sync_map.get(node, min_stored),
@@ -343,16 +343,14 @@ impl RequestHandler for ClusterLayoutSkipDeadNodesRequest {
 		for node in all_nodes.iter() {
 			// Update ACK tracker for dead nodes or for all nodes if --allow-missing-data
 			if self.allow_missing_data || !status.iter().any(|x| x.id == *node && x.is_up) {
-				let ack_changed = layout.update_trackers.ack_map.set_max(*node, self.version);
-				if ack_changed {
+				if layout.update_trackers.ack_map.set_max(*node, self.version) {
 					ack_updated.push(hex::encode(node));
 				}
 			}

 			// If --allow-missing-data, update SYNC tracker for all nodes.
 			if self.allow_missing_data {
-				let sync_changed = layout.update_trackers.sync_map.set_max(*node, self.version);
-				if sync_changed {
+				if layout.update_trackers.sync_map.set_max(*node, self.version) {
 					sync_updated.push(hex::encode(node));
 				}
 			}
@@ -382,9 +380,9 @@ impl From<layout::ZoneRedundancy> for ZoneRedundancy {
 	}
 }

-impl From<ZoneRedundancy> for layout::ZoneRedundancy {
-	fn from(val: ZoneRedundancy) -> Self {
-		match val {
+impl Into<layout::ZoneRedundancy> for ZoneRedundancy {
+	fn into(self) -> layout::ZoneRedundancy {
+		match self {
 			ZoneRedundancy::Maximum => layout::ZoneRedundancy::Maximum,
 			ZoneRedundancy::AtLeast(x) => layout::ZoneRedundancy::AtLeast(x),
 		}
@@ -399,10 +397,10 @@ impl From<layout::LayoutParameters> for LayoutParameters {
 	}
 }

-impl From<LayoutParameters> for layout::LayoutParameters {
-	fn from(val: LayoutParameters) -> Self {
+impl Into<layout::LayoutParameters> for LayoutParameters {
+	fn into(self) -> layout::LayoutParameters {
 		layout::LayoutParameters {
-			zone_redundancy: val.zone_redundancy.into(),
+			zone_redundancy: self.zone_redundancy.into(),
 		}
 	}
 }
@@ -1,8 +1,7 @@
 #![allow(dead_code)]
 #![allow(non_snake_case)]

-use serde::{Deserialize, Serialize};
-use utoipa::{Modify, OpenApi, ToSchema};
+use utoipa::{Modify, OpenApi};

 use crate::api::*;

@@ -19,7 +18,7 @@ use crate::api::*;
            (status = 200, description = "Garage daemon metrics exported in Prometheus format"),
        ),
 )]
-fn Metrics() {}
+fn Metrics() -> () {}

 #[utoipa::path(get,
    path = "/health",
@@ -36,7 +35,7 @@ as long as it is able to have a quorum of nodes for read and write operations.
            (status = 503, description = "This Garage daemon is not able to handle requests")
        ),
 )]
-fn Health() {}
+fn Health() -> () {}

 #[utoipa::path(get,
    path = "/check",
@@ -54,7 +53,7 @@ do not correspond to an actual website.
            (status = 400, description = "No static website bucket exists for this domain")
        ),
 )]
-fn CheckDomain() {}
+fn CheckDomain() -> () {}

 // **********************************************
 //      Cluster operations
@@ -78,7 +77,7 @@ Returns the cluster's current status, including:
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetClusterStatus() {}
+fn GetClusterStatus() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetClusterHealth",
@@ -88,7 +87,7 @@ fn GetClusterStatus() {}
            (status = 200, description = "Cluster health report", body = GetClusterHealthResponse),
        ),
 )]
-fn GetClusterHealth() {}
+fn GetClusterHealth() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetClusterStatistics",
@@ -103,7 +102,7 @@ Fetch global cluster statistics.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetClusterStatistics() {}
+fn GetClusterStatistics() -> () {}

 #[utoipa::path(post,
    path = "/v2/ConnectClusterNodes",
@@ -115,7 +114,7 @@ fn GetClusterStatistics() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ConnectClusterNodes() {}
+fn ConnectClusterNodes() -> () {}

 // **********************************************
 //      Admin API token operations
@@ -130,7 +129,7 @@ fn ConnectClusterNodes() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ListAdminTokens() {}
+fn ListAdminTokens() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetAdminTokenInfo",
@@ -145,7 +144,7 @@ You can search by specifying the exact token identifier (`id`) or by specifying
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetAdminTokenInfo() {}
+fn GetAdminTokenInfo() -> () {}

 #[utoipa::path(post,
    path = "/v2/CreateAdminToken",
@@ -157,7 +156,7 @@ fn GetAdminTokenInfo() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn CreateAdminToken() {}
+fn CreateAdminToken() -> () {}

 #[utoipa::path(post,
    path = "/v2/UpdateAdminToken",
@@ -172,7 +171,7 @@ Updates information about the specified admin API token.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn UpdateAdminToken() {}
+fn UpdateAdminToken() -> () {}

 #[utoipa::path(post,
    path = "/v2/DeleteAdminToken",
@@ -184,7 +183,7 @@ fn UpdateAdminToken() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn DeleteAdminToken() {}
+fn DeleteAdminToken() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetCurrentAdminTokenInfo",
@@ -197,7 +196,7 @@ Return information about the calling admin API token.
            (status = 500, description = "Internal server error")
    ),
 )]
-fn GetCurrentAdminTokenInfo() {}
+fn GetCurrentAdminTokenInfo() -> () {}

 // **********************************************
 //      Layout operations
@@ -219,7 +218,7 @@ Returns the cluster's current layout, including:
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetClusterLayout() {}
+fn GetClusterLayout() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetClusterLayoutHistory",
@@ -232,7 +231,7 @@ Returns the history of layouts in the cluster
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetClusterLayoutHistory() {}
+fn GetClusterLayoutHistory() -> () {}

 #[utoipa::path(post,
    path = "/v2/UpdateClusterLayout",
@@ -247,7 +246,7 @@ For example to declare 100GB, you must set `capacity: 100000000000`.
 Garage uses internally the International System of Units (SI), it assumes that 1kB = 1000 bytes, and displays storage as kB, MB, GB (and not KiB, MiB, GiB that assume 1KiB = 1024 bytes).
    ",
    request_body(
-        content=UpdateClusterLayoutRequestOpenapi,
+        content=UpdateClusterLayoutRequest,
        description="
 To add a new node to the layout or to change the configuration of an existing node, simply set the values you want (`zone`, `capacity`, and `tags`).
 To remove a node, simply pass the `remove: true` field.
@@ -261,46 +260,7 @@ Contrary to the CLI that may update only a subset of the fields capacity, zone a
            (status = 500, description = "Internal server error")
        ),
 )]
-fn UpdateClusterLayout() {}
-
-// Hack: we cannot use the UpdateClusterLayoutRequest from api.rs,
-// as it contains (via NodeRoleChange) an untagged enum flattenned into
-// a struct, which breaks the openapi generator.
-// See issue #1249.
-// Instead, we use a rewritten version of the NodeRoleChange struct where
-// the struct fields are distributed into the enum variants (this is an equivalent
-// representation, but this way we avoid having to rewrite all uses of the original
-// struct in the Garage codebase).
-#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
-#[schema(as = UpdateClusterLayoutRequest)]
-pub struct UpdateClusterLayoutRequestOpenapi {
-	/// New node roles to assign or remove in the cluster layout
-	#[serde(default)]
-	pub roles: Vec<NodeRoleChangeOpenapi>,
-	/// New layout computation parameters to use
-	#[serde(default)]
-	pub parameters: Option<LayoutParameters>,
-}
-
-#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
-#[schema(as = NodeRoleChangeRequest)]
-#[serde(untagged)]
-pub enum NodeRoleChangeOpenapi {
-	#[serde(rename_all = "camelCase")]
-	Remove {
-		/// ID of the node for which this change applies
-		id: String,
-		/// Set `remove` to `true` to remove the node from the layout
-		remove: bool,
-	},
-	#[serde(rename_all = "camelCase")]
-	Update {
-		/// ID of the node for which this change applies
-		id: String,
-		#[serde(flatten)]
-		role: NodeAssignedRole,
-	},
-}
+fn UpdateClusterLayout() -> () {}

 #[utoipa::path(post,
    path = "/v2/PreviewClusterLayoutChanges",
@@ -315,7 +275,7 @@ Computes a new layout taking into account the staged parameters, and returns it
            (status = 500, description = "Internal server error")
        ),
 )]
-fn PreviewClusterLayoutChanges() {}
+fn PreviewClusterLayoutChanges() -> () {}

 #[utoipa::path(post,
    path = "/v2/ApplyClusterLayout",
@@ -331,7 +291,7 @@ Applies to the cluster the layout changes currently registered as staged layout
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ApplyClusterLayout() {}
+fn ApplyClusterLayout() -> () {}

 #[utoipa::path(post,
    path = "/v2/RevertClusterLayout",
@@ -342,7 +302,7 @@ fn ApplyClusterLayout() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn RevertClusterLayout() {}
+fn RevertClusterLayout() -> () {}

 #[utoipa::path(post,
    path = "/v2/ClusterLayoutSkipDeadNodes",
@@ -354,7 +314,7 @@ fn RevertClusterLayout() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ClusterLayoutSkipDeadNodes() {}
+fn ClusterLayoutSkipDeadNodes() -> () {}

 // **********************************************
 //      Access key operations
@@ -369,7 +329,7 @@ fn ClusterLayoutSkipDeadNodes() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ListKeys() {}
+fn ListKeys() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetKeyInfo",
@@ -386,7 +346,7 @@ For confidentiality reasons, the secret key is not returned by default: you must
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetKeyInfo() {}
+fn GetKeyInfo() -> () {}

 #[utoipa::path(post,
    path = "/v2/CreateKey",
@@ -398,7 +358,7 @@ fn GetKeyInfo() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn CreateKey() {}
+fn CreateKey() -> () {}

 #[utoipa::path(post,
    path = "/v2/ImportKey",
@@ -414,7 +374,7 @@ Imports an existing API key. This feature must only be used for migrations and b
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ImportKey() {}
+fn ImportKey() -> () {}

 #[utoipa::path(post,
    path = "/v2/UpdateKey",
@@ -431,7 +391,7 @@ Updates information about the specified API access key.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn UpdateKey() {}
+fn UpdateKey() -> () {}

 #[utoipa::path(post,
    path = "/v2/DeleteKey",
@@ -443,7 +403,7 @@ fn UpdateKey() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn DeleteKey() {}
+fn DeleteKey() -> () {}

 // **********************************************
 //      Bucket operations
@@ -458,7 +418,7 @@ fn DeleteKey() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ListBuckets() {}
+fn ListBuckets() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetBucketInfo",
@@ -475,7 +435,7 @@ and its quotas (if any).
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetBucketInfo() {}
+fn GetBucketInfo() -> () {}

 #[utoipa::path(post,
    path = "/v2/CreateBucket",
@@ -490,7 +450,7 @@ Technically, you can also specify both `globalAlias` and `localAlias` and that w
            (status = 500, description = "Internal server error")
        ),
 )]
-fn CreateBucket() {}
+fn CreateBucket() -> () {}

 #[utoipa::path(post,
    path = "/v2/UpdateBucket",
@@ -516,7 +476,7 @@ to change only one of the two quotas.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn UpdateBucket() {}
+fn UpdateBucket() -> () {}

 #[utoipa::path(post,
    path = "/v2/DeleteBucket",
@@ -534,7 +494,7 @@ Deletes a storage bucket. A bucket cannot be deleted if it is not empty.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn DeleteBucket() {}
+fn DeleteBucket() -> () {}

 #[utoipa::path(post,
    path = "/v2/CleanupIncompleteUploads",
@@ -546,7 +506,7 @@ fn DeleteBucket() {}
            (status = 500, description = "Internal server error")
        ),
 )]
-fn CleanupIncompleteUploads() {}
+fn CleanupIncompleteUploads() -> () {}

 #[utoipa::path(get,
    path = "/v2/InspectObject",
@@ -568,7 +528,7 @@ upload is in progress and not yet finished.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn InspectObject() {}
+fn InspectObject() -> () {}

 // **********************************************
 //      Operations on permissions for keys on buckets
@@ -594,7 +554,7 @@ If you want to disallow read for the key, check the DenyBucketKey operation.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn AllowBucketKey() {}
+fn AllowBucketKey() -> () {}

 #[utoipa::path(post,
    path = "/v2/DenyBucketKey",
@@ -616,7 +576,7 @@ If you want the key to have the reading permission, check the AllowBucketKey ope
            (status = 500, description = "Internal server error")
        ),
 )]
-fn DenyBucketKey() {}
+fn DenyBucketKey() -> () {}

 // **********************************************
 //      Operations on bucket aliases
@@ -626,43 +586,25 @@ fn DenyBucketKey() {}
    path = "/v2/AddBucketAlias",
    tag = "Bucket alias",
    description = "Add an alias for the target bucket.  This can be either a global or a local alias, depending on which fields are specified.",
-    request_body = BucketAliasEnumOpenapi,
+    request_body = AddBucketAliasRequest,
 	responses(
            (status = 200, description = "Returns exhaustive information about the bucket", body = AddBucketAliasResponse),
            (status = 500, description = "Internal server error")
        ),
 )]
-fn AddBucketAlias() {}
+fn AddBucketAlias() -> () {}

 #[utoipa::path(post,
    path = "/v2/RemoveBucketAlias",
    tag = "Bucket alias",
    description = "Remove an alias for the target bucket.  This can be either a global or a local alias, depending on which fields are specified.",
-    request_body = BucketAliasEnumOpenapi,
+    request_body = RemoveBucketAliasRequest,
 	responses(
            (status = 200, description = "Returns exhaustive information about the bucket", body = RemoveBucketAliasResponse),
            (status = 500, description = "Internal server error")
        ),
 )]
-fn RemoveBucketAlias() {}
-
-// Hack for issue #1249 (see UpdateClusterLayout)
-#[derive(Debug, Clone, Serialize, Deserialize, ToSchema)]
-#[serde(untagged)]
-#[schema(as = BucketAliasEnum)]
-pub enum BucketAliasEnumOpenapi {
-	#[serde(rename_all = "camelCase")]
-	Global {
-		bucket_id: String,
-		global_alias: String,
-	},
-	#[serde(rename_all = "camelCase")]
-	Local {
-		bucket_id: String,
-		local_alias: String,
-		access_key_id: String,
-	},
-}
+fn RemoveBucketAlias() -> () {}

 // **********************************************
 //      Node operations
@@ -680,7 +622,7 @@ Return information about the Garage daemon running on one or several nodes.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetNodeInfo() {}
+fn GetNodeInfo() -> () {}

 #[utoipa::path(get,
    path = "/v2/GetNodeStatistics",
@@ -696,7 +638,7 @@ Fetch statistics for one or several Garage nodes.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetNodeStatistics() {}
+fn GetNodeStatistics() -> () {}

 #[utoipa::path(post,
    path = "/v2/CreateMetadataSnapshot",
@@ -710,7 +652,7 @@ Instruct one or several nodes to take a snapshot of their metadata databases.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn CreateMetadataSnapshot() {}
+fn CreateMetadataSnapshot() -> () {}

 #[utoipa::path(post,
    path = "/v2/LaunchRepairOperation",
@@ -725,7 +667,7 @@ Launch a repair operation on one or several cluster nodes.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn LaunchRepairOperation() {}
+fn LaunchRepairOperation() -> () {}

 // **********************************************
 //      Worker operations
@@ -744,7 +686,7 @@ List background workers currently running on one or several cluster nodes.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ListWorkers() {}
+fn ListWorkers() -> () {}

 #[utoipa::path(post,
    path = "/v2/GetWorkerInfo",
@@ -759,7 +701,7 @@ Get information about the specified background worker on one or several cluster
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetWorkerInfo() {}
+fn GetWorkerInfo() -> () {}

 #[utoipa::path(post,
    path = "/v2/GetWorkerVariable",
@@ -774,7 +716,7 @@ Fetch values of one or several worker variables, from one or several cluster nod
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetWorkerVariable() {}
+fn GetWorkerVariable() -> () {}

 #[utoipa::path(post,
    path = "/v2/SetWorkerVariable",
@@ -789,7 +731,7 @@ Set the value for a worker variable, on one or several cluster nodes.
            (status = 500, description = "Internal server error")
        ),
 )]
-fn SetWorkerVariable() {}
+fn SetWorkerVariable() -> () {}

 // **********************************************
 //      Block operations
@@ -807,7 +749,7 @@ List data blocks that are currently in an errored state on one or several Garage
            (status = 500, description = "Internal server error")
        ),
 )]
-fn ListBlockErrors() {}
+fn ListBlockErrors() -> () {}

 #[utoipa::path(post,
    path = "/v2/GetBlockInfo",
@@ -822,7 +764,7 @@ Get detailed information about a data block stored on a Garage node, including a
            (status = 500, description = "Internal server error")
        ),
 )]
-fn GetBlockInfo() {}
+fn GetBlockInfo() -> () {}

 #[utoipa::path(post,
    path = "/v2/RetryBlockResync",
@@ -837,7 +779,7 @@ Instruct Garage node(s) to retry the resynchronization of one or several missing
            (status = 500, description = "Internal server error")
        ),
 )]
-fn RetryBlockResync() {}
+fn RetryBlockResync() -> () {}

 #[utoipa::path(post,
    path = "/v2/PurgeBlocks",
@@ -854,7 +796,7 @@ This will remove all objects and in-progress multipart uploads that contain the
            (status = 500, description = "Internal server error")
        ),
 )]
-fn PurgeBlocks() {}
+fn PurgeBlocks() -> () {}

 // **********************************************
 // **********************************************
@@ -876,11 +818,11 @@ impl Modify for SecurityAddon {
 #[derive(OpenApi)]
 #[openapi(
    info(
-        version = "v2.2.0",
+        version = "v2.1.0",
        title = "Garage administration API",
-        description = "Administrate your Garage cluster programmatically, including status, layout, keys, buckets, and maintenance tasks.
+        description = "Administrate your Garage cluster programatically, including status, layout, keys, buckets, and maintainance tasks.

-*Disclaimer: This API may change in future Garage versions. Read the changelog and upgrade your scripts before upgrading. Additionally, this specification is early stage and can contain bugs, so be careful and please report any issues on our issue tracker.*",
+*Disclaimer: This API may change in future Garage versions. Read the changelog and upgrade your scripts before upgrading. Additionnaly, this specification is early stage and can contain bugs, so be careful and please report any issues on our issue tracker.*",
        contact(
            name = "The Garage team",
            email = "garagehq@deuxfleurs.fr",
@@ -345,7 +345,7 @@ impl BlockRcRepair {
 #[async_trait]
 impl Worker for BlockRcRepair {
 	fn name(&self) -> String {
-		"Block refcount repair worker".into()
+		format!("Block refcount repair worker")
 	}

 	fn status(&self) -> WorkerStatus {
@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_common"
-version = "2.2.0"
+version = "2.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -150,7 +150,7 @@ impl TryFrom<HelperError> for CommonError {
 pub fn pass_helper_error(err: HelperError) -> CommonError {
 	match CommonError::try_from(err) {
 		Ok(e) => e,
-		Err(e) => panic!("Helper error `{}` should hot have happened here", e),
+		Err(e) => panic!("Helper error `{}` should hot have happenned here", e),
 	}
 }

@@ -88,7 +88,7 @@ pub fn handle_options_api(
 	// the same name, its CORS rules won't be applied
 	// and will be shadowed by the rules of the globally
 	// existing bucket (but this is inevitable because
-	// OPTIONS calls are not authenticated).
+	// OPTIONS calls are not auhtenticated).
 	if let Some(bn) = bucket_name {
 		let helper = garage.bucket_helper();
 		let bucket_opt = helper.resolve_global_bucket_fast(&bn)?;
@@ -154,7 +154,7 @@ impl<A: ApiHandler> ApiServer<A> {
 		{
 			format!("{forwarded_for_ip_addr} (via {addr})")
 		} else {
-			addr
+			format!("{addr}")
 		};
 		// we only do this to log the access key, so we can discard any error
 		let key = self
@@ -191,7 +191,7 @@ macro_rules! router_match {
    }};
    (@@parse_param $query:expr, parse_default($default:expr), $param:ident) => {{
        // extract and parse optional query parameter
-        // using provided value as default if parameter is missing
+        // using provided value as default if paramter is missing
        $query.$param.take().map(|x| x
            .parse()
            .map_err(|_| Error::bad_request("Failed to parse query parameter")))
@@ -63,7 +63,6 @@ pub struct ExpectedChecksums {
 	pub extra: Option<ChecksumValue>,
 }

-#[derive(Default)]
 pub struct Checksummer {
 	pub crc32: Option<CrcDigest>,
 	pub crc32c: Option<CrcDigest>,
@@ -85,7 +84,14 @@ pub struct Checksums {

 impl Checksummer {
 	pub fn new() -> Self {
-		Default::default()
+		Self {
+			crc32: None,
+			crc32c: None,
+			crc64nvme: None,
+			md5: None,
+			sha1: None,
+			sha256: None,
+		}
 	}

 	pub fn init(expected: &ExpectedChecksums, add_md5: bool) -> Self {
@@ -122,7 +128,7 @@ impl Checksummer {
 		}
 	}

-	pub fn add_algorithm(mut self, algo: Option<ChecksumAlgorithm>) -> Self {
+	pub fn add(mut self, algo: Option<ChecksumAlgorithm>) -> Self {
 		match algo {
 			Some(ChecksumAlgorithm::Crc32) => {
 				self.crc32 = Some(new_crc32());
@@ -181,7 +187,7 @@ impl Checksums {
 	pub fn verify(&self, expected: &ExpectedChecksums) -> Result<(), Error> {
 		if let Some(expected_md5) = &expected.md5 {
 			match self.md5 {
-				Some(md5) if BASE64_STANDARD.encode(md5) == expected_md5.trim_matches('"') => (),
+				Some(md5) if BASE64_STANDARD.encode(&md5) == expected_md5.trim_matches('"') => (),
 				_ => {
 					return Err(Error::InvalidDigest(
 						"MD5 checksum verification failed (from content-md5)".into(),
@@ -306,7 +312,7 @@ pub fn extract_checksum_value(
 		ChecksumAlgorithm::Crc32 => {
 			let crc32 = headers
 				.get(X_AMZ_CHECKSUM_CRC32)
-				.and_then(|x| BASE64_STANDARD.decode(x).ok())
+				.and_then(|x| BASE64_STANDARD.decode(&x).ok())
 				.and_then(|x| x.try_into().ok())
 				.ok_or_bad_request("invalid x-amz-checksum-crc32 header")?;
 			Ok(ChecksumValue::Crc32(crc32))
@@ -314,7 +320,7 @@ pub fn extract_checksum_value(
 		ChecksumAlgorithm::Crc32c => {
 			let crc32c = headers
 				.get(X_AMZ_CHECKSUM_CRC32C)
-				.and_then(|x| BASE64_STANDARD.decode(x).ok())
+				.and_then(|x| BASE64_STANDARD.decode(&x).ok())
 				.and_then(|x| x.try_into().ok())
 				.ok_or_bad_request("invalid x-amz-checksum-crc32c header")?;
 			Ok(ChecksumValue::Crc32c(crc32c))
@@ -322,7 +328,7 @@ pub fn extract_checksum_value(
 		ChecksumAlgorithm::Crc64Nvme => {
 			let crc64nvme = headers
 				.get(X_AMZ_CHECKSUM_CRC64NVME)
-				.and_then(|x| BASE64_STANDARD.decode(x).ok())
+				.and_then(|x| BASE64_STANDARD.decode(&x).ok())
 				.and_then(|x| x.try_into().ok())
 				.ok_or_bad_request("invalid x-amz-checksum-crc64nvme header")?;
 			Ok(ChecksumValue::Crc64Nvme(crc64nvme))
@@ -330,7 +336,7 @@ pub fn extract_checksum_value(
 		ChecksumAlgorithm::Sha1 => {
 			let sha1 = headers
 				.get(X_AMZ_CHECKSUM_SHA1)
-				.and_then(|x| BASE64_STANDARD.decode(x).ok())
+				.and_then(|x| BASE64_STANDARD.decode(&x).ok())
 				.and_then(|x| x.try_into().ok())
 				.ok_or_bad_request("invalid x-amz-checksum-sha1 header")?;
 			Ok(ChecksumValue::Sha1(sha1))
@@ -338,7 +344,7 @@ pub fn extract_checksum_value(
 		ChecksumAlgorithm::Sha256 => {
 			let sha256 = headers
 				.get(X_AMZ_CHECKSUM_SHA256)
-				.and_then(|x| BASE64_STANDARD.decode(x).ok())
+				.and_then(|x| BASE64_STANDARD.decode(&x).ok())
 				.and_then(|x| x.try_into().ok())
 				.ok_or_bad_request("invalid x-amz-checksum-sha256 header")?;
 			Ok(ChecksumValue::Sha256(sha256))
@@ -352,19 +358,19 @@ pub fn add_checksum_response_headers(
 ) -> http::response::Builder {
 	match checksum {
 		Some(ChecksumValue::Crc32(crc32)) => {
-			resp = resp.header(X_AMZ_CHECKSUM_CRC32, BASE64_STANDARD.encode(crc32));
+			resp = resp.header(X_AMZ_CHECKSUM_CRC32, BASE64_STANDARD.encode(&crc32));
 		}
 		Some(ChecksumValue::Crc32c(crc32c)) => {
-			resp = resp.header(X_AMZ_CHECKSUM_CRC32C, BASE64_STANDARD.encode(crc32c));
+			resp = resp.header(X_AMZ_CHECKSUM_CRC32C, BASE64_STANDARD.encode(&crc32c));
 		}
 		Some(ChecksumValue::Crc64Nvme(crc64nvme)) => {
-			resp = resp.header(X_AMZ_CHECKSUM_CRC64NVME, BASE64_STANDARD.encode(crc64nvme));
+			resp = resp.header(X_AMZ_CHECKSUM_CRC64NVME, BASE64_STANDARD.encode(&crc64nvme));
 		}
 		Some(ChecksumValue::Sha1(sha1)) => {
-			resp = resp.header(X_AMZ_CHECKSUM_SHA1, BASE64_STANDARD.encode(sha1));
+			resp = resp.header(X_AMZ_CHECKSUM_SHA1, BASE64_STANDARD.encode(&sha1));
 		}
 		Some(ChecksumValue::Sha256(sha256)) => {
-			resp = resp.header(X_AMZ_CHECKSUM_SHA256, BASE64_STANDARD.encode(sha256));
+			resp = resp.header(X_AMZ_CHECKSUM_SHA256, BASE64_STANDARD.encode(&sha256));
 		}
 		None => (),
 	}
@@ -69,7 +69,7 @@ pub fn verify_request(
 	mut req: Request<IncomingBody>,
 	service: &'static str,
 ) -> Result<VerifiedRequest, Error> {
-	let checked_signature = payload::check_payload_signature(garage, &mut req, service)?;
+	let checked_signature = payload::check_payload_signature(&garage, &mut req, service)?;

 	let request = streaming::parse_streaming_body(
 		req,
@@ -105,7 +105,7 @@ fn check_standard_signature(
 	// Verify that all necessary request headers are included in signed_headers
 	// The following must be included for all signatures:
 	// - the Host header (mandatory)
-	// - all x-amz-* headers used in the request (except x-amz-content-sha256)
+	// - all x-amz-* headers used in the request
 	// AWS also indicates that the Content-Type header should be signed if
 	// it is used, but Minio client doesn't sign it so we don't check it for compatibility.
 	let signed_headers = split_signed_headers(&authorization)?;
@@ -152,7 +152,7 @@ fn check_presigned_signature(
 	// Verify that all necessary request headers are included in signed_headers
 	// For AWSv4 pre-signed URLs, the following must be included:
 	// - the Host header (mandatory)
-	// - all x-amz-* headers used in the request (except x-amz-content-sha256)
+	// - all x-amz-* headers used in the request
 	let signed_headers = split_signed_headers(&authorization)?;
 	verify_signed_headers(request.headers(), &signed_headers)?;

@@ -187,7 +187,7 @@ fn check_presigned_signature(
 	let headers_mut = request.headers_mut();
 	for (name, value) in query.iter() {
 		if let Some(existing) = headers_mut.get(name) {
-			if signed_headers.contains(name) && existing.as_bytes() != value.value.as_bytes() {
+			if signed_headers.contains(&name) && existing.as_bytes() != value.value.as_bytes() {
 				return Err(Error::bad_request(format!(
 					"Conflicting values for `{}` in query parameters and request headers",
 					name
@@ -269,24 +269,18 @@ fn verify_signed_headers(headers: &HeaderMap, signed_headers: &[HeaderName]) ->
 		return Err(Error::bad_request("Header `Host` should be signed"));
 	}
 	for (name, _) in headers.iter() {
-		// Enforce signature of some headers
-		if header_should_be_signed(name) && !signed_headers.contains(name) {
-			return Err(Error::bad_request(format!(
-				"Header `{}` should be signed",
-				name
-			)));
+		if name.as_str().starts_with("x-amz-") {
+			if !signed_headers.contains(name) {
+				return Err(Error::bad_request(format!(
+					"Header `{}` should be signed",
+					name
+				)));
+			}
 		}
 	}
 	Ok(())
 }

-// Indicates whether a header is required to be signed
-fn header_should_be_signed(name: &HeaderName) -> bool {
-	// Enforce signature of all x-amz-* headers, except x-amz-content-sh256
-	// because it is included in the canonical request in all cases
-	name.as_str().starts_with("x-amz-") && name != X_AMZ_CONTENT_SHA256
-}
-
 pub fn string_to_sign(datetime: &DateTime<Utc>, scope_string: &str, canonical_req: &str) -> String {
 	let mut hasher = Sha256::default();
 	hasher.update(canonical_req.as_bytes());
@@ -347,7 +341,7 @@ pub fn canonical_request(
 	let canonical_query_string = {
 		let mut items = Vec::with_capacity(query.len());
 		for (_, QueryValue { key, value }) in query.iter() {
-			items.push(uri_encode(key, true) + "=" + &uri_encode(value, true));
+			items.push(uri_encode(&key, true) + "=" + &uri_encode(&value, true));
 		}
 		items.sort();
 		items.join("&")
@@ -481,7 +475,8 @@ impl Authorization {

 		let date = headers
 			.get(X_AMZ_DATE)
-			.ok_or_bad_request("Missing X-Amz-Date field")?
+			.ok_or_bad_request("Missing X-Amz-Date field")
+			.map_err(Error::from)?
 			.to_str()?;
 		let date = parse_date(date)?;

@@ -60,7 +60,7 @@ pub fn parse_streaming_body(
 					request_trailer_checksum_algorithm(req.headers())?
 						.ok_or_bad_request("Missing x-amz-trailer header")?,
 				);
-				checksummer = checksummer.add_algorithm(algo);
+				checksummer = checksummer.add(algo);
 				algo
 			} else {
 				None
@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_k2v"
-version = "2.2.0"
+version = "2.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -14,9 +14,9 @@ path = "lib.rs"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

 [dependencies]
-garage_model = { workspace = true, features = ["k2v"] }
+garage_model = { workspace = true, features = [ "k2v" ] }
 garage_table.workspace = true
-garage_util = { workspace = true, features = ["k2v"] }
+garage_util = { workspace = true, features = [ "k2v" ] }
 garage_api_common.workspace = true

 base64.workspace = true
@@ -61,7 +61,7 @@ pub async fn handle_read_batch(
 		resps.push(resp?);
 	}

-	json_ok_response(&resps)
+	Ok(json_ok_response(&resps)?)
 }

 async fn handle_read_batch_query(
@@ -155,7 +155,7 @@ pub async fn handle_delete_batch(
 		resps.push(resp?);
 	}

-	json_ok_response(&resps)
+	Ok(json_ok_response(&resps)?)
 }

 async fn handle_delete_batch_query(
@@ -33,7 +33,7 @@ pub async fn handle_read_index(

 	let (partition_keys, more, next_start) = read_range(
 		&garage.k2v.counter_table.table,
-		bucket_id,
+		&bucket_id,
 		&prefix,
 		&start,
 		&end,
@@ -1,6 +1,6 @@
 [package]
 name = "garage_api_s3"
-version = "2.2.0"
+version = "2.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -57,23 +57,23 @@ pub fn handle_get_bucket_acl(ctx: ReqCtx) -> Result<Response<ResBody>, Error> {

 	if kp.allow_owner {
 		grants.push(s3_xml::Grant {
-			grantee: create_grantee(key_p, &api_key),
+			grantee: create_grantee(&key_p, &api_key),
 			permission: s3_xml::Value("FULL_CONTROL".to_string()),
 		});
 	} else {
 		if kp.allow_read {
 			grants.push(s3_xml::Grant {
-				grantee: create_grantee(key_p, &api_key),
+				grantee: create_grantee(&key_p, &api_key),
 				permission: s3_xml::Value("READ".to_string()),
 			});
 			grants.push(s3_xml::Grant {
-				grantee: create_grantee(key_p, &api_key),
+				grantee: create_grantee(&key_p, &api_key),
 				permission: s3_xml::Value("READ_ACP".to_string()),
 			});
 		}
 		if kp.allow_write {
 			grants.push(s3_xml::Grant {
-				grantee: create_grantee(key_p, &api_key),
+				grantee: create_grantee(&key_p, &api_key),
 				permission: s3_xml::Value("WRITE".to_string()),
 			});
 		}
@@ -148,18 +148,14 @@ pub async fn handle_copy(
 			&& (was_multipart || checksum_algorithm != source_checksum_algorithm));

 	let res = if !must_recopy {
-		let dest_info = DestInfo {
-			key: dest_key,
-			uuid: dest_uuid,
-			object_meta: dest_object_meta,
-			encryption: dest_encryption,
-		};
-
 		// In most cases, we can just copy the metadata and link blocks of the
 		// old object from the new object.
 		handle_copy_metaonly(
 			ctx,
-			dest_info,
+			dest_key,
+			dest_uuid,
+			dest_object_meta,
+			dest_encryption,
 			source_version,
 			source_version_data,
 			source_version_meta,
@@ -181,16 +177,12 @@ pub async fn handle_copy(
 			checksum_type: checksum_algorithm.map(|_| ChecksumType::FullObject),
 			..dest_object_meta
 		};
-
-		let dest_info = DestInfo {
-			key: dest_key,
-			uuid: dest_uuid,
-			object_meta: dest_object_meta,
-			encryption: dest_encryption,
-		};
 		handle_copy_reencrypt(
 			ctx,
-			dest_info,
+			dest_key,
+			dest_uuid,
+			dest_object_meta,
+			dest_encryption,
 			source_version,
 			source_version_data,
 			source_encryption,
@@ -217,16 +209,12 @@ pub async fn handle_copy(
 	Ok(resp.body(string_body(xml))?)
 }

-struct DestInfo<'a> {
-	key: &'a str,
-	uuid: Uuid,
-	object_meta: ObjectVersionMetaInner,
-	encryption: EncryptionParams,
-}
-
 async fn handle_copy_metaonly(
 	ctx: ReqCtx,
-	dest_info: DestInfo<'_>,
+	dest_key: &str,
+	dest_uuid: Uuid,
+	dest_object_meta: ObjectVersionMetaInner,
+	dest_encryption: EncryptionParams,
 	source_version: &ObjectVersion,
 	source_version_data: &ObjectVersionData,
 	source_version_meta: &ObjectVersionMeta,
@@ -241,13 +229,13 @@ async fn handle_copy_metaonly(
 	let new_timestamp = now_msec();

 	let new_meta = ObjectVersionMeta {
-		encryption: dest_info.encryption.encrypt_meta(dest_info.object_meta)?,
+		encryption: dest_encryption.encrypt_meta(dest_object_meta)?,
 		size: source_version_meta.size,
 		etag: source_version_meta.etag.clone(),
 	};

 	let res = SaveStreamResult {
-		version_uuid: dest_info.uuid,
+		version_uuid: dest_uuid,
 		version_timestamp: new_timestamp,
 		etag: new_meta.etag.clone(),
 	};
@@ -259,7 +247,7 @@ async fn handle_copy_metaonly(
 			// bytes is either plaintext before&after or encrypted with the
 			// same keys, so it's ok to just copy it as is
 			let dest_object_version = ObjectVersion {
-				uuid: dest_info.uuid,
+				uuid: dest_uuid,
 				timestamp: new_timestamp,
 				state: ObjectVersionState::Complete(ObjectVersionData::Inline(
 					new_meta,
@@ -268,7 +256,7 @@ async fn handle_copy_metaonly(
 			};
 			let dest_object = Object::new(
 				dest_bucket_id,
-				dest_info.key.to_string(),
+				dest_key.to_string(),
 				vec![dest_object_version],
 			);
 			garage.object_table.insert(&dest_object).await?;
@@ -286,7 +274,7 @@ async fn handle_copy_metaonly(
 			// This holds a reference to the object in the Version table
 			// so that it won't be deleted, e.g. by repair_versions.
 			let tmp_dest_object_version = ObjectVersion {
-				uuid: dest_info.uuid,
+				uuid: dest_uuid,
 				timestamp: new_timestamp,
 				state: ObjectVersionState::Uploading {
 					encryption: new_meta.encryption.clone(),
@@ -296,13 +284,11 @@ async fn handle_copy_metaonly(
 			};
 			let tmp_dest_object = Object::new(
 				dest_bucket_id,
-				dest_info.key.to_string(),
+				dest_key.to_string(),
 				vec![tmp_dest_object_version],
 			);
 			garage.object_table.insert(&tmp_dest_object).await?;

-			let dest_uuid = dest_info.uuid;
-
 			// Write version in the version table. Even with empty block list,
 			// this means that the BlockRef entries linked to this version cannot be
 			// marked as deleted (they are marked as deleted only if the Version
@@ -311,7 +297,7 @@ async fn handle_copy_metaonly(
 				dest_uuid,
 				VersionBacklink::Object {
 					bucket_id: dest_bucket_id,
-					key: dest_info.key.to_string(),
+					key: dest_key.to_string(),
 				},
 				false,
 			);
@@ -343,7 +329,7 @@ async fn handle_copy_metaonly(
 			// with the stuff before, the block's reference counts could be decremented before
 			// they are incremented again for the new version, leading to data being deleted.
 			let dest_object_version = ObjectVersion {
-				uuid: dest_info.uuid,
+				uuid: dest_uuid,
 				timestamp: new_timestamp,
 				state: ObjectVersionState::Complete(ObjectVersionData::FirstBlock(
 					new_meta,
@@ -352,7 +338,7 @@ async fn handle_copy_metaonly(
 			};
 			let dest_object = Object::new(
 				dest_bucket_id,
-				dest_info.key.to_string(),
+				dest_key.to_string(),
 				vec![dest_object_version],
 			);
 			garage.object_table.insert(&dest_object).await?;
@@ -364,7 +350,10 @@ async fn handle_copy_metaonly(

 async fn handle_copy_reencrypt(
 	ctx: ReqCtx,
-	dest_info: DestInfo<'_>,
+	dest_key: &str,
+	dest_uuid: Uuid,
+	dest_object_meta: ObjectVersionMetaInner,
+	dest_encryption: EncryptionParams,
 	source_version: &ObjectVersion,
 	source_version_data: &ObjectVersionData,
 	source_encryption: EncryptionParams,
@@ -382,11 +371,11 @@ async fn handle_copy_reencrypt(

 	save_stream(
 		&ctx,
-		dest_info.uuid,
-		dest_info.object_meta,
-		dest_info.encryption,
+		dest_uuid,
+		dest_object_meta,
+		dest_encryption,
 		source_stream.map_err(|e| Error::from(GarageError::from(e))),
-		&dest_info.key.to_string(),
+		&dest_key.to_string(),
 		checksum_mode,
 	)
 	.await
@@ -556,7 +545,7 @@ pub async fn handle_upload_part_copy(

 	// Now, actually copy the blocks
 	let mut checksummer = Checksummer::init(&Default::default(), !dest_encryption.is_encrypted())
-		.add_algorithm(dest_object_checksum_algorithm.map(|(algo, _)| algo));
+		.add(dest_object_checksum_algorithm.map(|(algo, _)| algo));

 	// First, create a stream that is able to read the source blocks
 	// and extract the subrange if necessary.
@@ -29,7 +29,7 @@ async fn handle_delete_internal(ctx: &ReqCtx, key: &str) -> Result<(Uuid, Uuid),
 		.iter()
 		.rev()
 		.find(|v| !matches!(&v.state, ObjectVersionState::Aborted))
-		.or_else(|| object.versions().iter().next_back());
+		.or_else(|| object.versions().iter().rev().next());
 	let deleted_version = match deleted_version {
 		Some(dv) => dv.uuid,
 		None => {
@@ -139,7 +139,11 @@ fn parse_delete_objects_xml(xml: &roxmltree::Document) -> Option<DeleteRequest>
 				key: key_str.to_string(),
 			});
 		} else if item.has_tag_name("Quiet") {
-			ret.quiet = item.text()? == "true";
+			if item.text()? == "true" {
+				ret.quiet = true;
+			} else {
+				ret.quiet = false;
+			}
 		} else {
 			return None;
 		}
@@ -94,7 +94,10 @@ impl EncryptionParams {
 		// data blocks are reused as-is. Since Garage v2, we are using
 		// object-specific encryption keys, so we know that if both source
 		// and destination are encrypted, it can't be with the same key.
-		matches!((a, b), (Self::Plaintext, Self::Plaintext))
+		match (a, b) {
+			(Self::Plaintext, Self::Plaintext) => true,
+			_ => false,
+		}
 	}

 	pub fn new_from_headers(
@@ -121,7 +124,7 @@ impl EncryptionParams {

 	pub fn add_response_headers(&self, resp: &mut http::response::Builder) {
 		if let Self::SseC { client_key_md5, .. } = self {
-			let md5 = BASE64_STANDARD.encode(client_key_md5);
+			let md5 = BASE64_STANDARD.encode(&client_key_md5);

 			resp.headers_mut().unwrap().insert(
 				X_AMZ_SERVER_SIDE_ENCRYPTION_CUSTOMER_ALGORITHM,
@@ -193,7 +196,7 @@ impl EncryptionParams {
 						None
 					},
 				};
-				let plaintext = enc.decrypt_blob(inner)?;
+				let plaintext = enc.decrypt_blob(&inner)?;
 				let inner = ObjectVersionMetaInner::decode(&plaintext)
 					.ok_or_internal_error("Could not decode encrypted metadata")?;
 				Ok((enc, Cow::Owned(inner)))
@@ -245,7 +248,7 @@ impl EncryptionParams {
 				// So we just put some random bytes.
 				let mut random = [0u8; 16];
 				OsRng.fill_bytes(&mut random);
-				hex::encode(random)
+				hex::encode(&random)
 			}
 		}
 	}
@@ -260,12 +263,12 @@ impl EncryptionParams {
 			Self::SseC {
 				object_key: Some(oek),
 				..
-			} => Some(Aes256Gcm::new(oek)),
+			} => Some(Aes256Gcm::new(&oek)),
 			Self::SseC {
 				client_key,
 				object_key: None,
 				..
-			} => Some(Aes256Gcm::new(client_key)),
+			} => Some(Aes256Gcm::new(&client_key)),
 			Self::Plaintext => None,
 		}
 	}
@@ -430,7 +433,7 @@ fn parse_request_headers(
 			let key_b64 =
 				key.ok_or_bad_request("Missing server-side-encryption-customer-key header")?;
 			let key_bytes: [u8; 32] = BASE64_STANDARD
-				.decode(key_b64)
+				.decode(&key_b64)
 				.ok_or_bad_request(
 					"Invalid server-side-encryption-customer-key header: invalid base64",
 				)?
@@ -442,7 +445,7 @@ fn parse_request_headers(

 			let md5_b64 =
 				md5.ok_or_bad_request("Missing server-side-encryption-customer-key-md5 header")?;
-			let md5_bytes = BASE64_STANDARD.decode(md5_b64).ok_or_bad_request(
+			let md5_bytes = BASE64_STANDARD.decode(&md5_b64).ok_or_bad_request(
 				"Invalid server-side-encryption-customer-key-md5 header: invalid bass64",
 			)?;

@@ -508,7 +511,6 @@ struct DecryptStream {
 	state: DecryptStreamState,
 }

-#[expect(clippy::large_enum_variant)]
 enum DecryptStreamState {
 	Starting,
 	Running(DecryptorLE31<Aes256Gcm>),
@@ -545,7 +547,7 @@ impl Stream for DecryptStream {
 			let nonce_size = StreamNonceSize::to_usize();
 			if let Some(nonce) = this.buf.take_exact(nonce_size) {
 				let nonce = Nonce::from_slice(nonce.as_ref());
-				*this.state = DecryptStreamState::Running(DecryptorLE31::new(this.key, nonce));
+				*this.state = DecryptStreamState::Running(DecryptorLE31::new(&this.key, nonce));
 				break;
 			}

@@ -585,7 +587,8 @@ impl Stream for DecryptStream {

 		if matches!(this.state, DecryptStreamState::Done) {
 			if !this.buf.is_empty() {
-				return Poll::Ready(Some(Err(std::io::Error::other(
+				return Poll::Ready(Some(Err(std::io::Error::new(
+					std::io::ErrorKind::Other,
 					"Decrypt: unexpected bytes after last encrypted chunk",
 				))));
 			}
@@ -619,7 +622,10 @@ impl Stream for DecryptStream {
 		match res {
 			Ok(bytes) if bytes.is_empty() => Poll::Ready(None),
 			Ok(bytes) => Poll::Ready(Some(Ok(bytes.into()))),
-			Err(_) => Poll::Ready(Some(Err(std::io::Error::other("Decryption failed")))),
+			Err(_) => Poll::Ready(Some(Err(std::io::Error::new(
+				std::io::ErrorKind::Other,
+				"Decryption failed",
+			)))),
 		}
 	}
 }
@@ -93,7 +93,7 @@ fn object_headers(

 /// Override headers according to specific query parameters, see
 /// section "Overriding response header values through the request" in
-/// <https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html>
+/// https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
 fn getobject_override_headers(
 	overrides: GetObjectOverrides,
 	resp: &mut http::response::Builder,
@@ -124,7 +124,7 @@ fn handle_http_precondition(
 ) -> Result<Option<Response<ResBody>>, Error> {
 	let precondition_headers = PreconditionHeaders::parse(req)?;

-	if let Some(status_code) = precondition_headers.check(version, &version_meta.etag)? {
+	if let Some(status_code) = precondition_headers.check(&version, &version_meta.etag)? {
 		Ok(Some(
 			Response::builder()
 				.status(status_code)
@@ -189,12 +189,12 @@ pub async fn handle_head_without_ctx(
 		OekDerivationInfo::for_object(&object, object_version),
 	)?;

-	let checksum_mode = checksum_mode(req);
+	let checksum_mode = checksum_mode(&req);

-	if let Some(part_number) = part_number {
+	if let Some(pn) = part_number {
 		match version_data {
 			ObjectVersionData::Inline(_, _) => {
-				if part_number != 1 {
+				if pn != 1 {
 					return Err(Error::InvalidPart);
 				}
 				let bytes_len = version_meta.size;
@@ -223,7 +223,7 @@ pub async fn handle_head_without_ctx(
 				check_version_not_deleted(&version)?;

 				let (part_offset, part_end) =
-					calculate_part_bounds(&version, part_number).ok_or(Error::InvalidPart)?;
+					calculate_part_bounds(&version, pn).ok_or(Error::InvalidPart)?;

 				Ok(object_headers(
 					object_version,
@@ -316,16 +316,7 @@ pub async fn handle_get_without_ctx(
 		OekDerivationInfo::for_object(&object, last_v),
 	)?;

-	let checksum_mode = checksum_mode(req);
-
-	let handle_get_info = HandleGetInfo {
-		garage,
-		version: last_v,
-		version_data: last_v_data,
-		version_meta: last_v_meta,
-		encryption: enc,
-		meta_inner: &headers,
-	};
+	let checksum_mode = checksum_mode(&req);

 	match (part_number, parse_range_header(req, last_v_meta.size)?) {
 		(Some(_), Some(_)) => Err(Error::bad_request(
@@ -333,7 +324,12 @@ pub async fn handle_get_without_ctx(
 		)),
 		(Some(pn), None) => {
 			handle_get_part(
-				handle_get_info,
+				garage,
+				last_v,
+				last_v_data,
+				last_v_meta,
+				enc,
+				&headers,
 				pn,
 				ChecksumMode {
 					// TODO: for multipart uploads, checksums of each part should be stored
@@ -346,7 +342,12 @@ pub async fn handle_get_without_ctx(
 		}
 		(None, Some(range)) => {
 			handle_get_range(
-				handle_get_info,
+				garage,
+				last_v,
+				last_v_data,
+				last_v_meta,
+				enc,
+				&headers,
 				range.start,
 				range.start + range.length,
 				ChecksumMode {
@@ -358,14 +359,26 @@ pub async fn handle_get_without_ctx(
 			)
 			.await
 		}
-		(None, None) => handle_get_full(handle_get_info, overrides, checksum_mode).await,
+		(None, None) => {
+			handle_get_full(
+				garage,
+				last_v,
+				last_v_data,
+				last_v_meta,
+				enc,
+				&headers,
+				overrides,
+				checksum_mode,
+			)
+			.await
+		}
 	}
 }

 pub(crate) fn check_version_not_deleted(version: &Version) -> Result<(), Error> {
 	if version.deleted.get() {
 		// the version was deleted between when the object_table was consulted
-		// and now, this could mean the object was deleted, or overridden.
+		// and now, this could mean the object was deleted, or overriden.
 		// Rather than say the key doesn't exist, return a transient error
 		// to signal the client to try again.
 		return Err(CommonError::InternalError(UtilError::Message(
@@ -377,37 +390,28 @@ pub(crate) fn check_version_not_deleted(version: &Version) -> Result<(), Error>
 	Ok(())
 }

-struct HandleGetInfo<'a> {
-	garage: Arc<Garage>,
-	version: &'a ObjectVersion,
-	version_data: &'a ObjectVersionData,
-	version_meta: &'a ObjectVersionMeta,
-	encryption: EncryptionParams,
-	meta_inner: &'a ObjectVersionMetaInner,
-}
-
 async fn handle_get_full(
-	info: HandleGetInfo<'_>,
+	garage: Arc<Garage>,
+	version: &ObjectVersion,
+	version_data: &ObjectVersionData,
+	version_meta: &ObjectVersionMeta,
+	encryption: EncryptionParams,
+	meta_inner: &ObjectVersionMetaInner,
 	overrides: GetObjectOverrides,
 	checksum_mode: ChecksumMode,
 ) -> Result<Response<ResBody>, Error> {
 	let mut resp_builder = object_headers(
-		info.version,
-		info.version_meta,
-		info.meta_inner,
-		info.encryption,
+		version,
+		version_meta,
+		&meta_inner,
+		encryption,
 		checksum_mode,
 	)
-	.header(CONTENT_LENGTH, format!("{}", info.version_meta.size))
+	.header(CONTENT_LENGTH, format!("{}", version_meta.size))
 	.status(StatusCode::OK);
 	getobject_override_headers(overrides, &mut resp_builder)?;

-	let stream = full_object_byte_stream(
-		info.garage,
-		info.version,
-		info.version_data,
-		info.encryption,
-	);
+	let stream = full_object_byte_stream(garage, version, version_data, encryption);

 	Ok(resp_builder.body(response_body_from_stream(stream))?)
 }
@@ -487,7 +491,12 @@ pub fn full_object_byte_stream(
 }

 async fn handle_get_range(
-	info: HandleGetInfo<'_>,
+	garage: Arc<Garage>,
+	version: &ObjectVersion,
+	version_data: &ObjectVersionData,
+	version_meta: &ObjectVersionMeta,
+	encryption: EncryptionParams,
+	meta_inner: &ObjectVersionMetaInner,
 	begin: u64,
 	end: u64,
 	checksum_mode: ChecksumMode,
@@ -495,24 +504,18 @@ async fn handle_get_range(
 	// Here we do not use getobject_override_headers because we don't
 	// want to add any overridden headers (those should not be added
 	// when returning PARTIAL_CONTENT)
-	let resp_builder = object_headers(
-		info.version,
-		info.version_meta,
-		info.meta_inner,
-		info.encryption,
-		checksum_mode,
-	)
-	.header(CONTENT_LENGTH, format!("{}", end - begin))
-	.header(
-		CONTENT_RANGE,
-		format!("bytes {}-{}/{}", begin, end - 1, info.version_meta.size),
-	)
-	.status(StatusCode::PARTIAL_CONTENT);
+	let resp_builder = object_headers(version, version_meta, meta_inner, encryption, checksum_mode)
+		.header(CONTENT_LENGTH, format!("{}", end - begin))
+		.header(
+			CONTENT_RANGE,
+			format!("bytes {}-{}/{}", begin, end - 1, version_meta.size),
+		)
+		.status(StatusCode::PARTIAL_CONTENT);

-	match &info.version_data {
+	match &version_data {
 		ObjectVersionData::DeleteMarker => unreachable!(),
 		ObjectVersionData::Inline(_meta, bytes) => {
-			let bytes = info.encryption.decrypt_blob(bytes)?;
+			let bytes = encryption.decrypt_blob(&bytes)?;
 			if end as usize <= bytes.len() {
 				let body = bytes_body(bytes[begin as usize..end as usize].to_vec().into());
 				Ok(resp_builder.body(body)?)
@@ -523,47 +526,46 @@ async fn handle_get_range(
 			}
 		}
 		ObjectVersionData::FirstBlock(_meta, _first_block_hash) => {
-			let version = info
-				.garage
+			let version = garage
 				.version_table
-				.get(&info.version.uuid, &EmptyKey)
+				.get(&version.uuid, &EmptyKey)
 				.await?
 				.ok_or(Error::NoSuchKey)?;
 			check_version_not_deleted(&version)?;
-			let body = body_from_blocks_range(
-				info.garage,
-				info.encryption,
-				version.blocks.items(),
-				begin,
-				end,
-			);
+			let body =
+				body_from_blocks_range(garage, encryption, version.blocks.items(), begin, end);
 			Ok(resp_builder.body(body)?)
 		}
 	}
 }

 async fn handle_get_part(
-	info: HandleGetInfo<'_>,
+	garage: Arc<Garage>,
+	object_version: &ObjectVersion,
+	version_data: &ObjectVersionData,
+	version_meta: &ObjectVersionMeta,
+	encryption: EncryptionParams,
+	meta_inner: &ObjectVersionMetaInner,
 	part_number: u64,
 	checksum_mode: ChecksumMode,
 ) -> Result<Response<ResBody>, Error> {
 	// Same as for get_range, no getobject_override_headers
 	let resp_builder = object_headers(
-		info.version,
-		info.version_meta,
-		info.meta_inner,
-		info.encryption,
+		object_version,
+		version_meta,
+		meta_inner,
+		encryption,
 		checksum_mode,
 	)
 	.status(StatusCode::PARTIAL_CONTENT);

-	match info.version_data {
+	match version_data {
 		ObjectVersionData::Inline(_, bytes) => {
 			if part_number != 1 {
 				return Err(Error::InvalidPart);
 			}
-			let bytes = info.encryption.decrypt_blob(bytes)?;
-			assert_eq!(bytes.len() as u64, info.version_meta.size);
+			let bytes = encryption.decrypt_blob(&bytes)?;
+			assert_eq!(bytes.len() as u64, version_meta.size);
 			Ok(resp_builder
 				.header(CONTENT_LENGTH, format!("{}", bytes.len()))
 				.header(
@@ -574,10 +576,9 @@ async fn handle_get_part(
 				.body(bytes_body(bytes.into_owned().into()))?)
 		}
 		ObjectVersionData::FirstBlock(_, _) => {
-			let version = info
-				.garage
+			let version = garage
 				.version_table
-				.get(&info.version.uuid, &EmptyKey)
+				.get(&object_version.uuid, &EmptyKey)
 				.await?
 				.ok_or(Error::NoSuchKey)?;

@@ -586,19 +587,14 @@ async fn handle_get_part(
 			let (begin, end) =
 				calculate_part_bounds(&version, part_number).ok_or(Error::InvalidPart)?;

-			let body = body_from_blocks_range(
-				info.garage,
-				info.encryption,
-				version.blocks.items(),
-				begin,
-				end,
-			);
+			let body =
+				body_from_blocks_range(garage, encryption, version.blocks.items(), begin, end);

 			Ok(resp_builder
 				.header(CONTENT_LENGTH, format!("{}", end - begin))
 				.header(
 					CONTENT_RANGE,
-					format!("bytes {}-{}/{}", begin, end - 1, info.version_meta.size),
+					format!("bytes {}-{}/{}", begin, end - 1, version_meta.size),
 				)
 				.header(X_AMZ_MP_PARTS_COUNT, format!("{}", version.n_parts()?))
 				.body(body)?)
@@ -712,7 +708,11 @@ fn body_from_blocks_range(
 									Some(None)
 								} else {
 									// The chunk has an intersection with the requested range
-									let start_in_chunk = begin.saturating_sub(*chunk_offset);
+									let start_in_chunk = if *chunk_offset > begin {
+										0
+									} else {
+										begin - *chunk_offset
+									};
 									let end_in_chunk = if *chunk_offset + chunk_len < end {
 										chunk_len
 									} else {
@@ -773,7 +773,10 @@ fn error_stream_item<E: std::fmt::Display>(e: E) -> ByteStream {
 }

 fn std_error_from_read_error<E: std::fmt::Display>(e: E) -> std::io::Error {
-	std::io::Error::other(format!("Error while reading object data: {}", e))
+	std::io::Error::new(
+		std::io::ErrorKind::Other,
+		format!("Error while reading object data: {}", e),
+	)
 }

 // ----
@@ -850,9 +853,7 @@ impl PreconditionHeaders {
 	}

 	fn check(&self, v: &ObjectVersion, etag: &str) -> Result<Option<StatusCode>, Error> {
-		// we store date with ms precision, but headers are precise to the second: truncate
-		// the timestamp to handle the same-second edge case
-		let v_date = UNIX_EPOCH + Duration::from_secs(v.timestamp / 1000);
+		let v_date = UNIX_EPOCH + Duration::from_millis(v.timestamp);

 		// Implemented from https://datatracker.ietf.org/doc/html/rfc7232#section-6

@@ -324,31 +324,31 @@ pub async fn handle_list_parts(
 					size: s3_xml::IntValue(part.size as i64),
 					checksum_crc32: match &checksum {
 						Some(ChecksumValue::Crc32(x)) => {
-							Some(s3_xml::Value(BASE64_STANDARD.encode(x)))
+							Some(s3_xml::Value(BASE64_STANDARD.encode(&x)))
 						}
 						_ => None,
 					},
 					checksum_crc32c: match &checksum {
 						Some(ChecksumValue::Crc32c(x)) => {
-							Some(s3_xml::Value(BASE64_STANDARD.encode(x)))
+							Some(s3_xml::Value(BASE64_STANDARD.encode(&x)))
 						}
 						_ => None,
 					},
 					checksum_crc64nvme: match &checksum {
 						Some(ChecksumValue::Crc64Nvme(x)) => {
-							Some(s3_xml::Value(BASE64_STANDARD.encode(x)))
+							Some(s3_xml::Value(BASE64_STANDARD.encode(&x)))
 						}
 						_ => None,
 					},
 					checksum_sha1: match &checksum {
 						Some(ChecksumValue::Sha1(x)) => {
-							Some(s3_xml::Value(BASE64_STANDARD.encode(x)))
+							Some(s3_xml::Value(BASE64_STANDARD.encode(&x)))
 						}
 						_ => None,
 					},
 					checksum_sha256: match &checksum {
 						Some(ChecksumValue::Sha256(x)) => {
-							Some(s3_xml::Value(BASE64_STANDARD.encode(x)))
+							Some(s3_xml::Value(BASE64_STANDARD.encode(&x)))
 						}
 						_ => None,
 					},
@@ -598,7 +598,7 @@ impl ListObjectsQuery {
 					Some("[") => Ok(RangeBegin::IncludingKey {
 						key: String::from_utf8(
 							BASE64_STANDARD
-								.decode(&token.as_bytes()[1..])
+								.decode(token[1..].as_bytes())
 								.ok_or_bad_request("Invalid continuation token")?,
 						)?,
 						fallback_key: None,
@@ -606,7 +606,7 @@ impl ListObjectsQuery {
 					Some("]") => Ok(RangeBegin::AfterKey {
 						key: String::from_utf8(
 							BASE64_STANDARD
-								.decode(&token.as_bytes()[1..])
+								.decode(token[1..].as_bytes())
 								.ok_or_bad_request("Invalid continuation token")?,
 						)?,
 					}),
@@ -725,7 +725,10 @@ impl<K: std::cmp::Ord, V> Accumulator<K, V> {
 		let object = objects.peek().expect("This iterator can not be empty as it is checked earlier in the code. This is a logic bug, please report it.");

 		// Check if this is a common prefix (requires a passed delimiter and its value in the key)
-		let pfx = common_prefix(object, query)?;
+		let pfx = match common_prefix(object, query) {
+			Some(p) => p,
+			None => return None,
+		};
 		assert!(pfx.starts_with(&query.prefix));

 		// Try to register this prefix
@@ -1014,12 +1017,12 @@ mod tests {

 		query.common.prefix = "a/".to_string();
 		assert_eq!(
-			common_prefix(objs.first().unwrap(), &query.common),
+			common_prefix(objs.get(0).unwrap(), &query.common),
 			Some("a/b/")
 		);

 		query.common.prefix = "a/b/".to_string();
-		assert_eq!(common_prefix(objs.first().unwrap(), &query.common), None);
+		assert_eq!(common_prefix(objs.get(0).unwrap(), &query.common), None);
 	}

 	#[test]
@@ -1040,7 +1043,7 @@ mod tests {

 	#[test]
 	fn test_extract_upload() {
-		let objs = [
+		let objs = vec![
 			Object::new(
 				bucket(),
 				"b".to_string(),
@@ -43,7 +43,7 @@ pub async fn handle_create_multipart_upload(
 		bucket_name,
 		..
 	} = &ctx;
-	let existing_object = garage.object_table.get(bucket_id, key).await?;
+	let existing_object = garage.object_table.get(&bucket_id, &key).await?;

 	let upload_id = gen_uuid();
 	let timestamp = next_timestamp(existing_object.as_ref());
@@ -57,12 +57,12 @@ pub async fn handle_create_multipart_upload(

 	// Determine whether object should be encrypted, and if so the key
 	let encryption = EncryptionParams::new_from_headers(
-		garage,
+		&garage,
 		req.headers(),
 		OekDerivationInfo {
 			bucket_id: *bucket_id,
 			version_id: upload_id,
-			object_key: key,
+			object_key: &key,
 		},
 	)?;
 	let object_encryption = encryption.encrypt_meta(meta)?;
@@ -157,8 +157,12 @@ pub async fn handle_put_part(
 		} => (encryption, checksum_algorithm),
 		_ => unreachable!(),
 	};
-	let (encryption, _) =
-		EncryptionParams::check_decrypt(garage, &req_head.headers, &object_encryption, oek_params)?;
+	let (encryption, _) = EncryptionParams::check_decrypt(
+		&garage,
+		&req_head.headers,
+		&object_encryption,
+		oek_params,
+	)?;

 	// Check object is valid and part can be accepted
 	let first_block = first_block.ok_or_bad_request("Empty body")?;
@@ -455,7 +459,7 @@ pub async fn handle_complete_multipart_upload(
 		None => object_encryption,
 		Some(_) => {
 			let (encryption, meta) = EncryptionParams::check_decrypt(
-				garage,
+				&garage,
 				&req_head.headers,
 				&object_encryption,
 				oek_params,
@@ -499,23 +503,23 @@ pub async fn handle_complete_multipart_upload(
 		key: s3_xml::Value(key),
 		etag: s3_xml::Value(format!("\"{}\"", etag)),
 		checksum_crc32: match &checksum_extra {
-			Some(ChecksumValue::Crc32(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(x))),
+			Some(ChecksumValue::Crc32(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(&x))),
 			_ => None,
 		},
 		checksum_crc32c: match &checksum_extra {
-			Some(ChecksumValue::Crc32c(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(x))),
+			Some(ChecksumValue::Crc32c(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(&x))),
 			_ => None,
 		},
 		checksum_crc64nvme: match &checksum_extra {
-			Some(ChecksumValue::Crc64Nvme(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(x))),
+			Some(ChecksumValue::Crc64Nvme(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(&x))),
 			_ => None,
 		},
 		checksum_sha1: match &checksum_extra {
-			Some(ChecksumValue::Sha1(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(x))),
+			Some(ChecksumValue::Sha1(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(&x))),
 			_ => None,
 		},
 		checksum_sha256: match &checksum_extra {
-			Some(ChecksumValue::Sha256(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(x))),
+			Some(ChecksumValue::Sha256(x)) => Some(s3_xml::Value(BASE64_STANDARD.encode(&x))),
 			_ => None,
 		},
 		checksum_type: match checksum_algorithm {
@@ -731,7 +735,7 @@ impl MultipartChecksummer {
 		part_len: u64,
 	) -> Result<(), Error> {
 		self.md5
-			.update(&hex::decode(etag).ok_or_message("invalid etag hex")?);
+			.update(&hex::decode(&etag).ok_or_message("invalid etag hex")?);
 		if let Some(extra) = &mut self.extra {
 			extra.update(checksum, part_len)?;
 		}
@@ -811,10 +815,10 @@ impl MultipartExtraChecksummer {
 				}
 			},
 			(Self::CompositeSha1(sha1), Some(ChecksumValue::Sha1(x))) => {
-				sha1.update(x);
+				sha1.update(&x);
 			}
 			(Self::CompositeSha256(sha256), Some(ChecksumValue::Sha256(x))) => {
-				sha256.update(x);
+				sha256.update(&x);
 			}
 			_ => {
 				return Err(Error::internal_error(format!(
@@ -138,26 +138,10 @@ pub async fn handle_post_object(

 	let mut conditions = decoded_policy.into_conditions()?;

-	// If there are conditions on the bucket name, check these against the actual bucket_name rather
-	// than the one in params, which is allowed to be absent.
-	if let Some(conds) = conditions.params.remove("bucket") {
-		for cond in conds {
-			let ok = match cond {
-				Operation::Equal(s) => s.as_str() == bucket_name,
-				Operation::StartsWith(s) => bucket_name.starts_with(&s),
-			};
-			if !ok {
-				return Err(Error::bad_request(
-					"Key 'bucket' has value not allowed in policy",
-				));
-			}
-		}
-	}
-
 	for (param_key, value) in params.iter() {
 		let param_key = param_key.as_str();
 		match param_key {
-			"policy" | "x-amz-signature" | "bucket" => (), // this is always accepted, as it's required to validate other fields
+			"policy" | "x-amz-signature" => (), // this is always accepted, as it's required to validate other fields
 			"content-type" => {
 				let conds = conditions.params.remove("content-type").ok_or_else(|| {
 					Error::bad_request(format!("Key '{}' is not allowed in policy", param_key))
@@ -505,15 +489,15 @@ mod tests {
 		let mut conditions = policy_2.into_conditions().unwrap();

 		assert_eq!(
-			conditions.params.remove("acl"),
+			conditions.params.remove(&"acl".to_string()),
 			Some(vec![Operation::Equal("public-read".into())])
 		);
 		assert_eq!(
-			conditions.params.remove("bucket"),
+			conditions.params.remove(&"bucket".to_string()),
 			Some(vec![Operation::Equal("johnsmith".into())])
 		);
 		assert_eq!(
-			conditions.params.remove("key"),
+			conditions.params.remove(&"key".to_string()),
 			Some(vec![Operation::StartsWith("user/eric/".into())])
 		);
 		assert!(conditions.params.is_empty());
@@ -536,7 +520,7 @@ mod tests {
 		let mut conditions = policy_2.into_conditions().unwrap();

 		assert_eq!(
-			conditions.params.remove("acl"),
+			conditions.params.remove(&"acl".to_string()),
 			Some(vec![Operation::Equal("public-read".into())])
 		);
 		assert_eq!(
@@ -544,7 +528,9 @@ mod tests {
 			vec![Operation::StartsWith("image/".into())]
 		);
 		assert_eq!(
-			conditions.params.remove("success_action_redirect"),
+			conditions
+				.params
+				.remove(&"success_action_redirect".to_string()),
 			Some(vec![Operation::StartsWith("".into())])
 		);
 		assert!(conditions.params.is_empty());
@@ -39,6 +39,8 @@ use crate::encryption::{EncryptionParams, OekDerivationInfo};
 use crate::error::*;
 use crate::website::X_AMZ_WEBSITE_REDIRECT_LOCATION;

+const PUT_BLOCKS_MAX_PARALLEL: usize = 3;
+
 pub(crate) struct SaveStreamResult {
 	pub(crate) version_uuid: Uuid,
 	pub(crate) version_timestamp: u64,
@@ -91,7 +93,7 @@ pub async fn handle_put(
 		OekDerivationInfo {
 			bucket_id: ctx.bucket_id,
 			version_id: version_uuid,
-			object_key: key,
+			object_key: &key,
 		},
 	)?;

@@ -158,7 +160,7 @@ pub(crate) async fn save_stream<S: Stream<Item = Result<Bytes, Error>> + Unpin>(
 	let mut checksummer = match &checksum_mode {
 		ChecksumMode::Verify(expected) => Checksummer::init(expected, !encryption.is_encrypted()),
 		ChecksumMode::Calculate(algo) => {
-			Checksummer::init(&Default::default(), !encryption.is_encrypted()).add_algorithm(*algo)
+			Checksummer::init(&Default::default(), !encryption.is_encrypted()).add(*algo)
 		}
 		ChecksumMode::VerifyFrom { .. } => {
 			// Checksums are calculated by the garage_api_common::signature module
@@ -505,7 +507,7 @@ pub(crate) async fn read_and_put_blocks<S: Stream<Item = Result<Bytes, Error>> +
 			};
 			let recv_next = async {
 				// If more than a maximum number of writes are in progress, don't add more for now
-				if currently_running >= ctx.garage.config.block_max_concurrent_writes_per_request {
+				if currently_running >= PUT_BLOCKS_MAX_PARALLEL {
 					futures::future::pending().await
 				} else {
 					block_rx3.recv().await
@@ -554,7 +556,6 @@ pub(crate) async fn read_and_put_blocks<S: Stream<Item = Result<Bytes, Error>> +
 	Ok((total_size, checksums, first_block_hash))
 }

-#[expect(clippy::too_many_arguments)]
 async fn put_block_and_meta(
 	ctx: &ReqCtx,
 	version: &Version,
@@ -669,7 +670,7 @@ pub(crate) fn extract_metadata_headers(
 	let mut ret = Vec::new();

 	// Preserve standard headers
-	let standard_header = [
+	let standard_header = vec![
 		hyper::header::CONTENT_TYPE,
 		hyper::header::CACHE_CONTROL,
 		hyper::header::CONTENT_DISPOSITION,
@@ -355,7 +355,7 @@ impl Endpoint {
 		if let Some(x_id) = query.x_id.take() {
 			if x_id != res.name() {
 				// I think AWS ignores the x-id parameter.
-				// Let's make this at least be a warning to help debugging.
+				// Let's make this at least be a warnin to help debugging.
 				warn!(
 					"x-id ({}) does not match parsed endpoint ({})",
 					x_id,
@@ -949,7 +949,7 @@ mod tests {
 			GET "/?uploads&delimiter=/&prefix=photos/2006/" => ListMultipartUploads
 			GET "/?uploads&delimiter=D&encoding-type=EncodingType&key-marker=KeyMarker&max-uploads=1&prefix=Prefix&upload-id-marker=UploadIdMarker" => ListMultipartUploads
 			GET "/" => ListObjects
-			GET "/?prefix=N&marker=Need&max-keys=40" => ListObjects
+			GET "/?prefix=N&marker=Ned&max-keys=40" => ListObjects
 			GET "/?delimiter=/" => ListObjects
 			GET "/?prefix=photos/2006/&delimiter=/" => ListObjects

@@ -1011,7 +1011,7 @@ mod tests {
 		// no bucket, won't work with the rest of the test suite
 		assert!(matches!(
 			parse("GET", "/", None, None).0,
-			Endpoint::ListBuckets
+			Endpoint::ListBuckets { .. }
 		));
 		assert!(matches!(
 			parse("GET", "/", None, None).0.authorization_type(),
@@ -213,7 +213,7 @@ impl WebsiteConfiguration {
 		}
 		if self.routing_rules.rules.len() > 1000 {
 			// we will do linear scans, best to avoid overly long configuration. The
-			// limit was chosen arbitrarily
+			// limit was choosen arbitrarily
 			return Err(Error::bad_request(
 				"Bad XML: RoutingRules can't have more than 1000 child elements",
 			));
@@ -225,7 +225,7 @@ impl WebsiteConfiguration {
 	pub fn into_garage_website_config(self) -> Result<WebsiteConfig, Error> {
 		if self.redirect_all_requests_to.is_some() {
 			Err(Error::NotImplemented(
-				"RedirectAllRequestsTo is not currently implemented in Garage, however its effect can be emulated using a single unconditional RoutingRule.".into(),
+				"RedirectAllRequestsTo is not currently implemented in Garage, however its effect can be emulated using a single inconditional RoutingRule.".into(),
 			))
 		} else {
 			Ok(WebsiteConfig {
@@ -251,7 +251,7 @@ impl WebsiteConfiguration {
 								hostname: rule.redirect.hostname.map(|h| h.0),
 								protocol: rule.redirect.protocol.map(|p| p.0),
 								// aws default to 301, which i find punitive in case of
-								// misconfiguration (can be permanently cached on the
+								// missconfiguration (can be permanently cached on the
 								// user agent)
 								http_redirect_code: rule
 									.redirect
@@ -1,6 +1,6 @@
 [package]
 name = "garage_block"
-version = "2.2.0"
+version = "2.1.0"
 authors = ["Alex Auvolat <alex@adnab.me>"]
 edition = "2018"
 license = "AGPL-3.0"
@@ -39,4 +39,4 @@ tokio.workspace = true
 tokio-util.workspace = true

 [features]
-system-libs = ["zstd/pkg-config"]
+system-libs = [ "zstd/pkg-config" ]
@@ -89,7 +89,7 @@ impl DataBlock {
 					return DataBlock::compressed(data_compressed.into());
 				}
 			}
-			DataBlock::plain(data)
+			DataBlock::plain(data.into())
 		})
 		.await
 		.unwrap()
@@ -262,7 +262,7 @@ impl DataLayout {
 	pub(crate) fn primary_block_dir(&self, hash: &Hash) -> PathBuf {
 		let ipart = self.partition_from(hash);
 		let idir = self.part_prim[ipart] as usize;
-		self.block_dir_from(hash, self.data_dirs[idir].path.clone())
+		self.block_dir_from(hash, &self.data_dirs[idir].path)
 	}

 	pub(crate) fn secondary_block_dirs<'a>(
@@ -272,7 +272,7 @@ impl DataLayout {
 		let ipart = self.partition_from(hash);
 		self.part_sec[ipart]
 			.iter()
-			.map(move |idir| self.block_dir_from(hash, self.data_dirs[*idir as usize].path.clone()))
+			.map(move |idir| self.block_dir_from(hash, &self.data_dirs[*idir as usize].path))
 	}

 	fn partition_from(&self, hash: &Hash) -> usize {
@@ -283,7 +283,8 @@ impl DataLayout {
 			% DRIVE_NPART
 	}

-	fn block_dir_from(&self, hash: &Hash, mut path: PathBuf) -> PathBuf {
+	fn block_dir_from(&self, hash: &Hash, dir: &PathBuf) -> PathBuf {
+		let mut path = dir.clone();
 		path.push(hex::encode(&hash.as_slice()[0..1]));
 		path.push(hex::encode(&hash.as_slice()[1..2]));
 		path
@@ -325,7 +326,7 @@ fn make_data_dirs(dirs: &DataDirEnum) -> Result<Vec<DataDir>, Error> {
 			let mut ok = false;
 			for dir in dirs.iter() {
 				let state = match &dir.capacity {
-					Some(cap) if !dir.read_only => {
+					Some(cap) if dir.read_only == false => {
 						let capacity = cap.parse::<bytesize::ByteSize>()
 							.ok_or_message("invalid capacity value")?.as_u64();
 						if capacity == 0 {
@@ -336,7 +337,7 @@ fn make_data_dirs(dirs: &DataDirEnum) -> Result<Vec<DataDir>, Error> {
 							capacity,
 						}
 					}
-					None if dir.read_only => {
+					None if dir.read_only == true => {
 						DataDirState::ReadOnly
 					}
 					_ => return Err(Error::Message(format!("data directories in data_dir should have a capacity value or be marked read_only, not the case for {}", dir.path.to_string_lossy()))),
@@ -358,7 +359,7 @@ fn make_data_dirs(dirs: &DataDirEnum) -> Result<Vec<DataDir>, Error> {
 }

 fn dir_not_empty(path: &PathBuf) -> Result<bool, Error> {
-	for entry in std::fs::read_dir(path)? {
+	for entry in std::fs::read_dir(&path)? {
 		let dir = entry?;
 		let ft = dir.file_type()?;
 		let name = dir.file_name().into_string().ok();
@@ -173,7 +173,7 @@ impl BlockManager {
 			data_fsync: config.data_fsync,
 			disable_scrub: config.disable_scrub,
 			compression_level: config.compression_level,
-			mutation_lock: [(); MUTEX_COUNT]
+			mutation_lock: vec![(); MUTEX_COUNT]
 				.iter()
 				.map(|_| Mutex::new(BlockManagerLocked()))
 				.collect::<Vec<_>>(),
@@ -344,7 +344,7 @@ impl BlockManager {
 	/// Returns the set of nodes that should store a copy of a given block.
 	/// These are the nodes assigned to the block's hash in the current
 	/// layout version only: since blocks are immutable, we don't need to
-	/// do complex logic when several layout versions are active at once,
+	/// do complex logic when several layour versions are active at once,
 	/// just move them directly to the new nodes.
 	pub(crate) fn storage_nodes_of(&self, hash: &Hash) -> Result<Vec<Uuid>, Error> {
 		let cluster_layout = self.system.cluster_layout();
@@ -569,10 +569,12 @@ impl BlockManager {
 		async {
 			match self.find_block(hash).await {
 				Some(p) => self.read_block_from(hash, &p).await,
-				None => Err(Error::Message(format!(
-					"block {:?} not found on node",
-					hash
-				))),
+				None => {
+					return Err(Error::Message(format!(
+						"block {:?} not found on node",
+						hash
+					)));
+				}
 			}
 		}
 		.bound_record_duration(&self.metrics.block_read_duration)
@@ -89,7 +89,7 @@ impl BlockRc {
 				.transaction(|tx| {
 					let mut cnt = 0;
 					for f in recalc_fns.iter() {
-						cnt += f(tx, hash)?;
+						cnt += f(&tx, hash)?;
 					}
 					let old_rc = RcEntry::parse_opt(tx.get(&self.rc_table, hash)?);
 					trace!(
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
trinity-1686a	d0fa38a769	wip formal algorithm	2026-01-26 10:53:07 +01:00
trinity-1686a	82ae78757f	[RFC] Garbage Collector Elimination	2026-01-26 10:53:07 +01:00