fb95a8819f
fix server panic caused by garage json-api Metrics ( fix #1132 )
2025-08-27 23:59:41 +02:00
47772eb525
Merge pull request 'fix: return consistent cors headers on api error' ( #1115 ) from Xstoudi/garage:fix/consistent-cors into main-v2
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1115
2025-08-27 16:19:36 +00:00
c1ed770e64
Merge pull request 'log access keys Garage v2' ( #1124 ) from 1686a/log-access-key-v2 into main-v2
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1124
2025-08-27 16:17:39 +00:00
d8058e7475
fix: method name duplicated after client sdk generation
2025-08-07 10:14:56 +00:00
385fbc606d
log user-defined admin api tokens
2025-08-03 15:50:36 +02:00
6f9d6919a9
log access keys
2025-08-03 15:31:51 +02:00
d975960be3
hide keys without any permissions from admin api
2025-08-02 17:28:14 +02:00
985ad68ade
fix: run cargo format
2025-07-31 22:52:27 +02:00
b7a853b01f
ignore checksums with empty/whitespace-only bodies
...
aws-sdk-cpp was observed to send request bodies like this via Lix:
```xml
<?xml version="1.0"?>
<CompleteMultipartUpload xmlns="http://s3.amazonaws.com/doc/2006-03-01/ ">
<Part>
<ETag>"8a5031bda169553d6a232e6c11068774"</ETag>
<ChecksumCRC32></ChecksumCRC32>
<PartNumber>1</PartNumber>
</Part>
<Part>
<ETag>"da977cc58b75bd17749c1ff460ba301a"</ETag>
<ChecksumCRC32></ChecksumCRC32>
<PartNumber>2</PartNumber>
</Part>
</CompleteMultipartUpload>
```
2025-07-31 11:15:33 -07:00
66faef9fb6
factor out repetitive else-if chain into macro
2025-07-30 18:44:51 -07:00
13f67b6cd8
log incorrect multipart completion body
2025-07-30 17:08:43 -07:00
0dabf9b22f
fix: return consistent cors headers on api error
2025-07-30 22:20:48 +02:00
e226fb413f
Merge pull request 'fix: return 204 on successful AbortMultipartUpload' ( #1095 ) from nikeee/garage:fix-abort-multipart-upload into main-v2
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1095
2025-07-11 17:12:32 +00:00
708a84f1d6
fix: return 204 on successful AbortMultipartUpload
...
Docs state that 204 should be returned on success:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_AbortMultipartUpload.html
```http
HTTP/1.1 204
x-amz-request-charged: RequestCharged
```
2025-07-11 16:19:51 +02:00
f8be15c37d
Merge pull request 'api: add instrospect endpoint' ( #1092 ) from Xstoudi/garage:feature/introspect-endpoint into main-v2
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1092
2025-07-11 11:20:12 +00:00
71aef8770e
fix: GetBucketCORS returns 404 if there are no policies
...
Similar issue @ ceph:
https://github.com/ceph/ceph/pull/27122/files
https://tracker.ceph.com/issues/38886
Implementation @ minio:
https://github.com/minio/minio/blob/de234b888c26cc191f3062a625af82640c966795/cmd/dummy-handlers.go#L196
2025-07-08 17:33:51 +02:00
b4f6ab963c
api: correct according to review
2025-07-04 21:36:34 +02:00
9a31b9c077
api: change endpoint name and allow it to be called even if not in current token scope
2025-07-03 21:59:23 +02:00
58a96dc687
api: correct openapi def
2025-07-03 21:59:22 +02:00
7bbb3ff9cf
api: add instrospect endpoint
...
Fixes #1091
2025-07-01 23:14:09 +02:00
9b6e45ca1f
fix(openapi): set parameters in query instead of path for get params
...
get request params are wrongfully outputted as "in path" instead of "in query", it fix this.
Fixes #1081
2025-06-19 22:31:44 +02:00
42baa29e50
openapi spec: add missing datatypes for path parameters
2025-06-14 17:25:37 +02:00
dc1a4ffd76
Merge branch 'main' into next-v2
2025-06-13 14:01:39 +02:00
a19d2f16e2
Merge pull request 'api: s3: implement get bucket acl' ( #1045 ) from ragazenta/garage:feat/dummy-acl into main
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1045
2025-05-30 16:25:04 +00:00
fc8fc60f6d
emit internal error when we detect race condition ( #1053 ) ( fix #1050 )
...
i went with a `500`/`InternalError`/`Please try again.` because that is something i've seen AWS S3 report while developing other software, and i'm not convinced all clients would understand a 409 conflict properly (GET don't usually conflict)
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1053
Co-authored-by: trinity-1686a <trinity@deuxfleurs.fr >
Co-committed-by: trinity-1686a <trinity@deuxfleurs.fr >
2025-05-30 16:24:12 +00:00
1b042e379e
api: s3: implement get bucket acl
2025-05-26 09:43:15 +07:00
ffbce0f689
speed up UploadPartCopy
...
(cherry picked from commit db54bf96c7
2025-05-23 20:36:32 +02:00
7ab1d176d4
Merge branch 'main' into next-v2
2025-05-23 16:33:07 +02:00
2ade8c86f6
more resilience to inconsistent alias states
2025-05-22 19:12:05 +02:00
b15d55ea9f
Merge pull request 'implement x-amz-checksum-type' ( #1025 ) from checksum-type into next-v2
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1025
2025-05-22 17:06:04 +00:00
c13af97b81
return ChecksumType in CompleteMultipartUpload result
2025-05-22 18:24:29 +02:00
d1d5c67ba7
fix test-smoke for CompleteMultipartUpload
2025-05-22 18:14:53 +02:00
cfd10480ee
CopyObject: fix checksumming choice logic
2025-05-22 17:07:10 +02:00
fbb40c4ea0
object_table: merge checksum_algorithm and checksum_type for Uploading state
2025-05-22 17:07:10 +02:00
e475c7f802
api: switch to crc_fast for checksumming and implement full-object mpu checksums
2025-05-22 17:03:54 +02:00
589a992af8
api: parse x-amz-checksum-type and validate combination with algo
2025-05-22 17:03:54 +02:00
768794daae
api: change ExpectedChecksums to not be a reference
2025-05-22 17:03:54 +02:00
abe0546ab0
model: store x-amz-checksum-type (full_object | composite)
2025-05-22 17:03:54 +02:00
be16bc7a05
Merge pull request 'Fix behavior of CopyObject wrt x-amz-website-redirect-location' ( #1037 ) from Armael/garage:copy-website-redirect into main
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1037
2025-05-22 13:57:28 +00:00
bfaa1ca6b7
Merge pull request 'api: lifecycle: 404 if missing lifecycle config' ( #1043 ) from ragazenta/garage:no-lifecycle-response into main
...
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/1043
2025-05-22 13:56:52 +00:00
ae3f7ee76c
api: lifecycle: 404 if missing lifecycle config
2025-05-22 19:33:54 +07:00
c6bc3f229b
Fix behavior of CopyObject wrt x-amz-website-redirect-location
2025-05-22 14:03:11 +02:00
bba9202f31
add test for punycode
2025-05-19 20:36:03 +02:00
a605a80806
support punnycode in api/web endpoint
2025-05-19 18:11:55 +02:00
539af12d21
allow punnycode in bucket name
2025-05-19 18:07:04 +02:00
db54bf96c7
speed up UploadPartCopy
2025-05-14 02:12:41 +02:00
e79b485aa8
fix panic in ListAdminTokens
2025-04-17 17:38:20 +02:00
d38d62f4d7
bump version to v2.0.0
2025-04-17 12:36:41 +02:00
5d338f0b8f
add never_expires to remove expiration dates of admin tokens and access keys
2025-04-17 11:44:09 +02:00
590c9bb4db
possibility to update access key expiration date
2025-04-17 11:30:58 +02:00
Alex Auvolat