gsadmin/garage
1
0
Fork 0
mirror of https://github.com/deuxfleurs-org/garage.git synced 2026-08-06 04:47:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

CopyObject: fix checksumming choice logic

Browse Source
This commit is contained in:
Alex Auvolat
2025-05-22 16:36:33 +02:00
parent fbb40c4ea0
commit cfd10480ee
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/api/s3/copy.rs
+4 -3
View File
@@ -78,7 +78,8 @@ pub async fn handle_copy(
},
)?;
let was_multipart = source_version_meta.etag.contains('-'); // HACK
let was_multipart = source_version_meta.etag.contains('-') // HACK
|| source_object_meta_inner.checksum_type == Some(ChecksumType::Composite);
// Extract source checksum info before source_object_meta_inner is consumed
let source_checksum = source_object_meta_inner.checksum;
@@ -131,8 +132,8 @@ pub async fn handle_copy(
// See: https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html
let must_recopy = !EncryptionParams::is_same(&source_encryption, &dest_encryption)
|| source_checksum_algorithm != checksum_algorithm
|| (was_multipart && checksum_algorithm.is_some());
|| (checksum_algorithm.is_some()
&& (was_multipart || checksum_algorithm != source_checksum_algorithm));
let res = if !must_recopy {
// In most cases, we can just copy the metadata and link blocks of the