gsadmin/garage-ui
1
0
Fork 0
mirror of https://github.com/Noooste/garage-ui.git synced 2026-08-08 21:03:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(frontend): optimize onOpenChange handling to prevent unnecessary re-renders

Browse Source
This commit is contained in:
Noooste
2026-08-04 01:25:49 +02:00
parent 5b04b3483b
commit b986e00eb3
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/ui/dialog.tsx
+7 -2
View File
@@ -67,6 +67,11 @@ const DialogContent = React.forwardRef<HTMLDivElement, React.HTMLAttributes<HTML
const { open, onOpenChange, size } = useDialog();
const containerRef = React.useRef<HTMLDivElement>(null);
const onOpenChangeRef = React.useRef(onOpenChange);
React.useEffect(() => {
onOpenChangeRef.current = onOpenChange;
});
React.useEffect(() => {
if (!open) return;
const previouslyFocused = document.activeElement as HTMLElement | null;
@@ -74,7 +79,7 @@ const DialogContent = React.forwardRef<HTMLDivElement, React.HTMLAttributes<HTML
const keyHandler = (e: KeyboardEvent) => {
if (e.key === 'Escape') {
e.stopPropagation();
onOpenChange(false);
onOpenChangeRef.current(false);
return;
}
if (e.key !== 'Tab' || !containerRef.current) return;
@@ -105,7 +110,7 @@ const DialogContent = React.forwardRef<HTMLDivElement, React.HTMLAttributes<HTML
document.removeEventListener('keydown', keyHandler);
previouslyFocused?.focus?.();
};
}, [open, onOpenChange]);
}, [open]);
if (!open) return null;