fix(volume-backups): preserve backup failure status

apps/dokploy/__test__/backups/volume-backup-restart.test.ts

@@ -28,6 +28,39 @@ describe("createRestartSafeBackupCommand", () => {
 		expect(outputLines(result.stdout)).toEqual(["stop", "backup", "start"]);
 	});
 
+	it("preserves the backup error status when the restart also fails", () => {
+		const result = runCommand(
+			createRestartSafeBackupCommand({
+				stopCommand: 'echo "stop"',
+				backupCommand: 'echo "backup"; exit 23',
+				startCommand: 'echo "start"; exit 17',
+				uploadCommand: 'echo "upload"',
+			}),
+		);
+
+		expect(result.status).toBe(23);
+		expect(outputLines(result.stdout)).toEqual([
+			"stop",
+			"backup",
+			"start",
+			"Service restart also failed with exit code 17",
+		]);
+	});
+
+	it("returns the restart error status when the backup succeeds", () => {
+		const result = runCommand(
+			createRestartSafeBackupCommand({
+				stopCommand: 'echo "stop"',
+				backupCommand: 'echo "backup"',
+				startCommand: 'echo "start"; exit 17',
+				uploadCommand: 'echo "upload"',
+			}),
+		);
+
+		expect(result.status).toBe(17);
+		expect(outputLines(result.stdout)).toEqual(["stop", "backup", "start"]);
+	});
+
 	it("uploads only after a successful backup and service restart", () => {
 		const result = runCommand(
 			createRestartSafeBackupCommand({

packages/server/src/utils/volume-backups/backup.ts

@@ -28,11 +28,21 @@ export const createRestartSafeBackupCommand = ({
 		${backupCommand}
 	)
 	DOKPLOY_VOLUME_BACKUP_STATUS=$?
+	(
+		set -e
+		${startCommand}
+	)
+	DOKPLOY_VOLUME_RESTART_STATUS=$?
 	set -e
-	${startCommand}
 	if [ "$DOKPLOY_VOLUME_BACKUP_STATUS" -ne 0 ]; then
+		if [ "$DOKPLOY_VOLUME_RESTART_STATUS" -ne 0 ]; then
+			echo "Service restart also failed with exit code $DOKPLOY_VOLUME_RESTART_STATUS"
+		fi
 		exit "$DOKPLOY_VOLUME_BACKUP_STATUS"
 	fi
+	if [ "$DOKPLOY_VOLUME_RESTART_STATUS" -ne 0 ]; then
+		exit "$DOKPLOY_VOLUME_RESTART_STATUS"
+	fi
 	${uploadCommand}
 `;