gsadmin/desktop-edge-win
1
0
Fork 0
mirror of https://github.com/openziti/desktop-edge-win.git synced 2026-10-12 15:58:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

UX Workflows for MFA with property band aids.

Browse Source
This commit is contained in:
Jeremy Tellier - ROG
2021-03-22 13:22:17 +01:00
parent 7bc9fe1b89
commit 40969f133f
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
DesktopEdge/MainWindow.xaml.cs
+8 -3
View File
@@ -92,6 +92,7 @@ namespace ZitiDesktopEdge {
await serviceClient.EnableMFA(this.IdentityMenu.Identity.Fingerprint);
} else {
// Clint - Disable MFA
ShowBlurb("MFA Disabled, limited service access", "");
}
@@ -114,10 +115,11 @@ namespace ZitiDesktopEdge {
} else if (mfa.Action == "auth_challenge") {
ShowBlurb("Setting Up auth_challenge", "");
} else if (mfa.Action == "auth_response") {
/// Clint - This needs to be called after the setup completes
/// ShowMFARecoveryCodes(this.IdentityMenu.Identity);
if (mfa.IsVerified) {
ShowMFARecoveryCodes(this.IdentityMenu.Identity);
if (this.IdentityMenu.Identity.Fingerprint==mfa.Fingerprint) {
/// Clint - Here too I am manually setting these to get the UIs right
this.IdentityMenu.Identity.IsMFAEnabled = true;
this.IdentityMenu.Identity.MFAInfo.IsAuthenticated = mfa.IsVerified;
this.IdentityMenu.UpdateView();
}
@@ -169,6 +171,7 @@ namespace ZitiDesktopEdge {
/// <param name="identity">The Ziti Identity to Authenticate</param>
public void ShowMFARecoveryCodes(ZitiIdentity identity) {
if (identity.MFAInfo!=null) {
// Clint - Rcovery Codes is always null so this never shows, can you add the call to get the recovery codes?
if (identity.MFAInfo.RecoveryCodes?.Length > 0) {
MFASetup.Opacity = 0;
MFASetup.Visibility = Visibility.Visible;
@@ -862,6 +865,8 @@ namespace ZitiDesktopEdge {
IdentityMenu.SetHeight(this.Height - 160);
MainMenu.IdentitiesButton.Visibility = Visibility.Visible;
foreach (var id in ids) {
/// Clint - This next line doesnt seem right, should that be filled from the service
if (id.Services.Count > 0) id.MFAInfo.IsAuthenticated = true;
IdentityItem idItem = new IdentityItem();
idItem.ToggleStatus.IsEnabled = id.IsEnabled;
@@ -1218,7 +1223,7 @@ namespace ZitiDesktopEdge {
if (_blurbUrl.Length>0) {
// So this simply execute a url but you could do like if (_blurbUrl=="DoSomethingNifty") CallNifyFunction();
if (_blurbUrl== this.RECOVER) {
// clint: can we know what identity to execute recovery against?
// Clint: can we know what identity to execute recovery against? - Here too this should call the regnerate codes function
} else {
Process.Start(new ProcessStartInfo(_blurbUrl) { UseShellExecute = true });
}
DesktopEdge/Views/Screens/MFAScreen.xaml.cs
+1 -2
View File
@@ -206,11 +206,10 @@ namespace ZitiDesktopEdge {
}
DataClient serviceClient = serviceClient = (DataClient)Application.Current.Properties["ServiceClient"];
DataClient serviceClient = (DataClient)Application.Current.Properties["ServiceClient"];
SvcResponse authResult = await serviceClient.AuthMFA(this._identity.Fingerprint, code);
if (authResult?.Code != 0) {
Logger.Error("AuthMFA failed. " + authResult.Message);
this.OnClose?.Invoke(false);
} else {
this.OnClose?.Invoke(true);
}