mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 22:21:30 +00:00
shankar0123
8b75e0311b
Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol
sub-module's go.mod, every Go file's import path (361 files), and a rebuild of
the checked-in f5-mock-icontrol binary so its embedded build-info reflects the
new module path. No behavior change.
Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A
(keep module path declared as github.com/shankar0123/certctl regardless of
repo URL) shipped on the day of the org transfer (2026-05-03) since we had no
external Go consumers; this commit closes that deferral.
Backward-compat: GitHub HTTP redirects continue to forward
github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL
level, but Go's module proxy uses the path declared in go.mod as the
canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...`
hit a "module path mismatch" error because go.mod said
github.com/shankar0123/certctl and the URL they fetched it from said
certctl-io/certctl. Post-fix, the canonical name and the URL agree, so
go get / go install / external Go consumers / Go-tooling integrations
work cleanly via either the new path (preferred) or the old path (which
redirects and Go follows the redirect for source fetch).
Anyone still importing the old path inside their own code keeps working
provided they update their go.mod's `require` line to match — the module
path declared in their consumer's go.sum / go.mod is the authoritative
import name, so a mass sed across their import statements is the migration
on the consumer side. No external consumers exist today.
Diff shape:
361 *.go files — import path replacement only
2 go.mod — module declaration replacement only
1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt
so embedded build-info reflects the new path (8618965 vs
8618933 bytes; 32-byte diff is the build-info change)
Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure
mechanical substitution.
Verification:
gofmt: 17 files needed re-alignment after sed (the new path is one char
shorter than the old, so column-aligned import groups drifted). Applied
`gofmt -w` to fix.
go mod tidy: clean exit on both modules.
go vet ./...: clean exit.
go build ./...: clean exit.
go test -short -count=1 on representative packages: all green
(internal/domain, internal/validation, internal/crypto, internal/crypto/signer,
cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...`
confirming the module path resolves correctly.
binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns
nothing; `strings | grep certctl-io/certctl` shows the new module path
embedded in build-info.
Files intentionally NOT touched in this commit:
README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io
URLs in commit 0729ee4 (the post-transfer URL refresh). This commit is
purely the Go-tooling layer.
Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account
namespace, not a Go import or GitHub repo URL. Stays.
This is a non-blocking, non-customer-impacting change. Operators pulling
container images, running `make verify`, hitting the API, or installing the
agent see no functional difference. Only Go-tooling consumers (none today)
are affected, and they're enabled — not broken — by this commit.
320 lines
9.2 KiB
Go
320 lines
9.2 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/certctl-io/certctl/internal/service"
|
|
)
|
|
|
|
// Add context import was already there — verify import is present above
|
|
|
|
// MockExportService is a mock implementation of ExportService interface.
|
|
type MockExportService struct {
|
|
ExportPEMFn func(ctx context.Context, certID string) (*service.ExportPEMResult, error)
|
|
ExportPKCS12Fn func(ctx context.Context, certID string, password string) ([]byte, error)
|
|
}
|
|
|
|
func (m *MockExportService) ExportPEM(ctx context.Context, certID string) (*service.ExportPEMResult, error) {
|
|
if m.ExportPEMFn != nil {
|
|
return m.ExportPEMFn(ctx, certID)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (m *MockExportService) ExportPKCS12(ctx context.Context, certID string, password string) ([]byte, error) {
|
|
if m.ExportPKCS12Fn != nil {
|
|
return m.ExportPKCS12Fn(ctx, certID, password)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func TestExportPEM_Success(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPEMFn: func(_ context.Context, certID string) (*service.ExportPEMResult, error) {
|
|
if certID != "mc-test-1" {
|
|
t.Errorf("expected certID mc-test-1, got %s", certID)
|
|
}
|
|
return &service.ExportPEMResult{
|
|
CertPEM: "-----BEGIN CERTIFICATE-----\nAAA\n-----END CERTIFICATE-----\n",
|
|
ChainPEM: "-----BEGIN CERTIFICATE-----\nBBB\n-----END CERTIFICATE-----\n",
|
|
FullPEM: "-----BEGIN CERTIFICATE-----\nAAA\n-----END CERTIFICATE-----\n-----BEGIN CERTIFICATE-----\nBBB\n-----END CERTIFICATE-----\n",
|
|
}, nil
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/certificates/mc-test-1/export/pem", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPEM(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d", w.Code)
|
|
}
|
|
if ct := w.Header().Get("Content-Type"); ct != "application/json" {
|
|
t.Errorf("expected application/json content type, got %s", ct)
|
|
}
|
|
|
|
var result service.ExportPEMResult
|
|
if err := json.NewDecoder(w.Body).Decode(&result); err != nil {
|
|
t.Fatalf("failed to decode response: %v", err)
|
|
}
|
|
if result.CertPEM == "" {
|
|
t.Error("expected non-empty CertPEM")
|
|
}
|
|
if result.ChainPEM == "" {
|
|
t.Error("expected non-empty ChainPEM")
|
|
}
|
|
if result.FullPEM == "" {
|
|
t.Error("expected non-empty FullPEM")
|
|
}
|
|
}
|
|
|
|
func TestExportPEM_Download(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPEMFn: func(_ context.Context, _ string) (*service.ExportPEMResult, error) {
|
|
return &service.ExportPEMResult{
|
|
CertPEM: "cert",
|
|
ChainPEM: "chain",
|
|
FullPEM: "full-pem-content",
|
|
}, nil
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/certificates/mc-test-1/export/pem?download=true", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPEM(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d", w.Code)
|
|
}
|
|
if ct := w.Header().Get("Content-Type"); ct != "application/x-pem-file" {
|
|
t.Errorf("expected application/x-pem-file, got %s", ct)
|
|
}
|
|
if cd := w.Header().Get("Content-Disposition"); cd != `attachment; filename="certificate.pem"` {
|
|
t.Errorf("expected Content-Disposition attachment, got %s", cd)
|
|
}
|
|
if w.Body.String() != "full-pem-content" {
|
|
t.Errorf("expected full-pem-content body, got %s", w.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestExportPEM_NotFound(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPEMFn: func(_ context.Context, _ string) (*service.ExportPEMResult, error) {
|
|
return nil, fmt.Errorf("certificate not found: %w", ErrMockNotFound)
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/certificates/nonexistent/export/pem", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPEM(w, req)
|
|
|
|
if w.Code != http.StatusNotFound {
|
|
t.Fatalf("expected 404, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExportPEM_ServiceError(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPEMFn: func(_ context.Context, _ string) (*service.ExportPEMResult, error) {
|
|
return nil, fmt.Errorf("internal error")
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/certificates/mc-test-1/export/pem", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPEM(w, req)
|
|
|
|
if w.Code != http.StatusInternalServerError {
|
|
t.Fatalf("expected 500, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExportPEM_MethodNotAllowed(t *testing.T) {
|
|
h := NewExportHandler(&MockExportService{})
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/certificates/mc-test-1/export/pem", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPEM(w, req)
|
|
|
|
if w.Code != http.StatusMethodNotAllowed {
|
|
t.Fatalf("expected 405, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExportPKCS12_Success(t *testing.T) {
|
|
pfxData := []byte{0x30, 0x82, 0x01, 0x00} // mock PKCS#12 data
|
|
mockSvc := &MockExportService{
|
|
ExportPKCS12Fn: func(_ context.Context, certID string, password string) ([]byte, error) {
|
|
if certID != "mc-test-1" {
|
|
t.Errorf("expected certID mc-test-1, got %s", certID)
|
|
}
|
|
if password != "mysecret" {
|
|
t.Errorf("expected password mysecret, got %s", password)
|
|
}
|
|
return pfxData, nil
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
body := strings.NewReader(`{"password":"mysecret"}`)
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/certificates/mc-test-1/export/pkcs12", body)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPKCS12(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d", w.Code)
|
|
}
|
|
if ct := w.Header().Get("Content-Type"); ct != "application/x-pkcs12" {
|
|
t.Errorf("expected application/x-pkcs12, got %s", ct)
|
|
}
|
|
if cd := w.Header().Get("Content-Disposition"); cd != `attachment; filename="certificate.p12"` {
|
|
t.Errorf("expected Content-Disposition attachment, got %s", cd)
|
|
}
|
|
if len(w.Body.Bytes()) != len(pfxData) {
|
|
t.Errorf("expected %d bytes, got %d", len(pfxData), len(w.Body.Bytes()))
|
|
}
|
|
}
|
|
|
|
func TestExportPKCS12_EmptyPassword(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPKCS12Fn: func(_ context.Context, _ string, password string) ([]byte, error) {
|
|
if password != "" {
|
|
t.Errorf("expected empty password, got %s", password)
|
|
}
|
|
return []byte{0x30}, nil
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
// Empty body — password defaults to ""
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/certificates/mc-test-1/export/pkcs12", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPKCS12(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExportPKCS12_NotFound(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPKCS12Fn: func(_ context.Context, _ string, _ string) ([]byte, error) {
|
|
return nil, fmt.Errorf("certificate not found: %w", ErrMockNotFound)
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/certificates/nonexistent/export/pkcs12", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPKCS12(w, req)
|
|
|
|
if w.Code != http.StatusNotFound {
|
|
t.Fatalf("expected 404, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExportPKCS12_ServiceError(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPKCS12Fn: func(_ context.Context, _ string, _ string) ([]byte, error) {
|
|
return nil, fmt.Errorf("encoding error")
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/certificates/mc-test-1/export/pkcs12", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPKCS12(w, req)
|
|
|
|
if w.Code != http.StatusInternalServerError {
|
|
t.Fatalf("expected 500, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExportPKCS12_MethodNotAllowed(t *testing.T) {
|
|
h := NewExportHandler(&MockExportService{})
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/certificates/mc-test-1/export/pkcs12", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPKCS12(w, req)
|
|
|
|
if w.Code != http.StatusMethodNotAllowed {
|
|
t.Fatalf("expected 405, got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExtractCertIDFromExportPath(t *testing.T) {
|
|
tests := []struct {
|
|
path string
|
|
expected string
|
|
}{
|
|
{"/api/v1/certificates/mc-test-1/export/pem", "mc-test-1"},
|
|
{"/api/v1/certificates/mc-api-prod/export/pkcs12", "mc-api-prod"},
|
|
{"/api/v1/certificates//export/pem", ""},
|
|
{"/api/v1/other/mc-test-1/export/pem", ""},
|
|
{"/api/v1/certificates/mc-test-1", ""},
|
|
{"", ""},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
got := extractCertIDFromExportPath(tt.path)
|
|
if got != tt.expected {
|
|
t.Errorf("extractCertIDFromExportPath(%q) = %q, want %q", tt.path, got, tt.expected)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestExportPKCS12_InvalidJSON(t *testing.T) {
|
|
mockSvc := &MockExportService{
|
|
ExportPKCS12Fn: func(_ context.Context, _ string, password string) ([]byte, error) {
|
|
// Invalid JSON is silently ignored, defaults to empty password
|
|
if password != "" {
|
|
t.Errorf("expected empty password (invalid JSON ignored), got %s", password)
|
|
}
|
|
return []byte{0x30}, nil
|
|
},
|
|
}
|
|
h := NewExportHandler(mockSvc)
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/certificates/mc-test-1/export/pkcs12", strings.NewReader(`{"invalid json`))
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPKCS12(w, req)
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200 (invalid JSON ignored), got %d", w.Code)
|
|
}
|
|
}
|
|
|
|
func TestExportPEM_MethodNotAllowedDelete(t *testing.T) {
|
|
h := NewExportHandler(&MockExportService{})
|
|
|
|
req := httptest.NewRequest(http.MethodDelete, "/api/v1/certificates/mc-test-1/export/pem", nil)
|
|
w := httptest.NewRecorder()
|
|
|
|
h.ExportPEM(w, req)
|
|
|
|
if w.Code != http.StatusMethodNotAllowed {
|
|
t.Fatalf("expected 405, got %d", w.Code)
|
|
}
|
|
}
|