mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 16:31:33 +00:00
a485e31f63
Sprint 2 unified-master-audit closure. Pre-fix four service List
endpoints (target, issuer, team, agent_group) called repoFoo.List(ctx)
to fetch the full table then sliced in memory:
rows, _ := s.repo.List(ctx)
total := int64(len(rows))
start := (page - 1) * perPage
end := start + perPage
return rows[start:end], total, nil
This page-sliced in memory pattern marshals every row per request —
fine on small fleets but unacceptable for multi-tenant or large-fleet
deploys. The agent_group case was worse — the service explicitly
ignored page/perPage and returned the entire slice.
Fix:
- New ListPaginated(ctx, limit, offset) method on each of the four
repositories. Postgres implementations push LIMIT + OFFSET into
the SQL plus a SELECT COUNT(*) for the total. Mirrors the cursor
pattern already in internal/repository/postgres/certificate.go.
- Each ListPaginated normalises limit≤0→50 and offset<0→0,
matching the service-layer defaults that already existed.
- Repository interfaces grow the new method so adapters stay
swappable.
- Service List methods now call repoFoo.ListPaginated(ctx, perPage,
(page-1)*perPage) directly — no more memory-slice.
- AgentGroupService.ListAgentGroups closes the Bundle E / Audit
L-020 'page/perPage unused' gap.
Test changes:
- sliceWindow generic helper in testutil_test.go mirrors the SQL
LIMIT/OFFSET semantics for in-memory mocks.
- Six mock implementers (lifecycle_test, testutil_test x2,
agent_group_test, team_test) gain ListPaginated methods.
- TestTeamService_List_SCALE002_PaginationPropagatesToRepo pins
the page=2, perPage=3 → 3 rows of 10 invariant.
Closes SCALE-002.
182 lines
4.9 KiB
Go
182 lines
4.9 KiB
Go
// Copyright 2026 certctl LLC. All rights reserved.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package service
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"log/slog"
|
|
"time"
|
|
|
|
"github.com/certctl-io/certctl/internal/domain"
|
|
"github.com/certctl-io/certctl/internal/repository"
|
|
)
|
|
|
|
// TeamService provides business logic for team management.
|
|
type TeamService struct {
|
|
teamRepo repository.TeamRepository
|
|
auditService *AuditService
|
|
}
|
|
|
|
// NewTeamService creates a new team service.
|
|
func NewTeamService(
|
|
teamRepo repository.TeamRepository,
|
|
auditService *AuditService,
|
|
) *TeamService {
|
|
return &TeamService{
|
|
teamRepo: teamRepo,
|
|
auditService: auditService,
|
|
}
|
|
}
|
|
|
|
// List returns a paginated list of teams.
|
|
//
|
|
// SCALE-002 closure (Sprint 2, 2026-05-16): pagination is pushed into
|
|
// the SQL layer via TeamRepository.ListPaginated.
|
|
func (s *TeamService) List(ctx context.Context, page, perPage int) ([]*domain.Team, int64, error) {
|
|
if page < 1 {
|
|
page = 1
|
|
}
|
|
if perPage < 1 {
|
|
perPage = 50
|
|
}
|
|
offset := (page - 1) * perPage
|
|
return s.teamRepo.ListPaginated(ctx, perPage, offset)
|
|
}
|
|
|
|
// Get retrieves a team by ID.
|
|
func (s *TeamService) Get(ctx context.Context, id string) (*domain.Team, error) {
|
|
team, err := s.teamRepo.Get(ctx, id)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to get team %s: %w", id, err)
|
|
}
|
|
return team, nil
|
|
}
|
|
|
|
// Create validates and stores a new team.
|
|
func (s *TeamService) Create(ctx context.Context, team *domain.Team, actor string) error {
|
|
if team.Name == "" {
|
|
return fmt.Errorf("team name is required")
|
|
}
|
|
|
|
if team.ID == "" {
|
|
team.ID = generateID("team")
|
|
}
|
|
now := time.Now()
|
|
if team.CreatedAt.IsZero() {
|
|
team.CreatedAt = now
|
|
}
|
|
if team.UpdatedAt.IsZero() {
|
|
team.UpdatedAt = now
|
|
}
|
|
if err := s.teamRepo.Create(ctx, team); err != nil {
|
|
return fmt.Errorf("failed to create team: %w", err)
|
|
}
|
|
|
|
if s.auditService != nil {
|
|
if auditErr := s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "create_team", "team", team.ID, nil); auditErr != nil {
|
|
slog.Error("failed to record audit event", "error", auditErr)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Update modifies an existing team.
|
|
func (s *TeamService) Update(ctx context.Context, id string, team *domain.Team, actor string) error {
|
|
if team.Name == "" {
|
|
return fmt.Errorf("team name is required")
|
|
}
|
|
|
|
team.ID = id
|
|
if err := s.teamRepo.Update(ctx, team); err != nil {
|
|
return fmt.Errorf("failed to update team %s: %w", id, err)
|
|
}
|
|
|
|
if s.auditService != nil {
|
|
if auditErr := s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "update_team", "team", id, nil); auditErr != nil {
|
|
slog.Error("failed to record audit event", "error", auditErr)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Delete removes a team.
|
|
func (s *TeamService) Delete(ctx context.Context, id string, actor string) error {
|
|
if err := s.teamRepo.Delete(ctx, id); err != nil {
|
|
return fmt.Errorf("failed to delete team %s: %w", id, err)
|
|
}
|
|
|
|
if s.auditService != nil {
|
|
if auditErr := s.auditService.RecordEvent(ctx, actor, domain.ActorTypeUser, "delete_team", "team", id, nil); auditErr != nil {
|
|
slog.Error("failed to record audit event", "error", auditErr)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ListTeams returns paginated teams (handler interface method).
|
|
func (s *TeamService) ListTeams(ctx context.Context, page, perPage int) ([]domain.Team, int64, error) {
|
|
// Bundle E / Audit L-020: page/perPage are unused; the underlying repo
|
|
// List() does not yet take pagination params. Marked explicitly so
|
|
// ineffassign sees no dead store and future maintainers see the
|
|
// vestigial params rather than a misleading default-applied clamp.
|
|
_ = page
|
|
_ = perPage
|
|
|
|
teams, err := s.teamRepo.List(ctx)
|
|
if err != nil {
|
|
return nil, 0, fmt.Errorf("failed to list teams: %w", err)
|
|
}
|
|
total := int64(len(teams))
|
|
|
|
var result []domain.Team
|
|
for _, t := range teams {
|
|
if t != nil {
|
|
result = append(result, *t)
|
|
}
|
|
}
|
|
|
|
return result, total, nil
|
|
}
|
|
|
|
// GetTeam returns a single team (handler interface method).
|
|
func (s *TeamService) GetTeam(ctx context.Context, id string) (*domain.Team, error) {
|
|
return s.teamRepo.Get(ctx, id)
|
|
}
|
|
|
|
// CreateTeam creates a new team (handler interface method).
|
|
func (s *TeamService) CreateTeam(ctx context.Context, team domain.Team) (*domain.Team, error) {
|
|
if team.ID == "" {
|
|
team.ID = generateID("team")
|
|
}
|
|
now := time.Now()
|
|
if team.CreatedAt.IsZero() {
|
|
team.CreatedAt = now
|
|
}
|
|
if team.UpdatedAt.IsZero() {
|
|
team.UpdatedAt = now
|
|
}
|
|
if err := s.teamRepo.Create(ctx, &team); err != nil {
|
|
return nil, fmt.Errorf("failed to create team: %w", err)
|
|
}
|
|
return &team, nil
|
|
}
|
|
|
|
// UpdateTeam modifies a team (handler interface method).
|
|
func (s *TeamService) UpdateTeam(ctx context.Context, id string, team domain.Team) (*domain.Team, error) {
|
|
team.ID = id
|
|
if err := s.teamRepo.Update(ctx, &team); err != nil {
|
|
return nil, fmt.Errorf("failed to update team: %w", err)
|
|
}
|
|
return &team, nil
|
|
}
|
|
|
|
// DeleteTeam removes a team (handler interface method).
|
|
func (s *TeamService) DeleteTeam(ctx context.Context, id string) error {
|
|
return s.teamRepo.Delete(ctx, id)
|
|
}
|