mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 16:11:29 +00:00
a485e31f63
Sprint 2 unified-master-audit closure. Pre-fix four service List
endpoints (target, issuer, team, agent_group) called repoFoo.List(ctx)
to fetch the full table then sliced in memory:
rows, _ := s.repo.List(ctx)
total := int64(len(rows))
start := (page - 1) * perPage
end := start + perPage
return rows[start:end], total, nil
This page-sliced in memory pattern marshals every row per request —
fine on small fleets but unacceptable for multi-tenant or large-fleet
deploys. The agent_group case was worse — the service explicitly
ignored page/perPage and returned the entire slice.
Fix:
- New ListPaginated(ctx, limit, offset) method on each of the four
repositories. Postgres implementations push LIMIT + OFFSET into
the SQL plus a SELECT COUNT(*) for the total. Mirrors the cursor
pattern already in internal/repository/postgres/certificate.go.
- Each ListPaginated normalises limit≤0→50 and offset<0→0,
matching the service-layer defaults that already existed.
- Repository interfaces grow the new method so adapters stay
swappable.
- Service List methods now call repoFoo.ListPaginated(ctx, perPage,
(page-1)*perPage) directly — no more memory-slice.
- AgentGroupService.ListAgentGroups closes the Bundle E / Audit
L-020 'page/perPage unused' gap.
Test changes:
- sliceWindow generic helper in testutil_test.go mirrors the SQL
LIMIT/OFFSET semantics for in-memory mocks.
- Six mock implementers (lifecycle_test, testutil_test x2,
agent_group_test, team_test) gain ListPaginated methods.
- TestTeamService_List_SCALE002_PaginationPropagatesToRepo pins
the page=2, perPage=3 → 3 rows of 10 invariant.
Closes SCALE-002.
178 lines
4.4 KiB
Go
178 lines
4.4 KiB
Go
// Copyright 2026 certctl LLC. All rights reserved.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package postgres
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"github.com/certctl-io/certctl/internal/repository"
|
|
|
|
"github.com/certctl-io/certctl/internal/domain"
|
|
"github.com/google/uuid"
|
|
)
|
|
|
|
// TeamRepository implements repository.TeamRepository
|
|
type TeamRepository struct {
|
|
db *sql.DB
|
|
}
|
|
|
|
// NewTeamRepository creates a new TeamRepository
|
|
func NewTeamRepository(db *sql.DB) *TeamRepository {
|
|
return &TeamRepository{db: db}
|
|
}
|
|
|
|
// List returns all teams
|
|
func (r *TeamRepository) List(ctx context.Context) ([]*domain.Team, error) {
|
|
rows, err := r.db.QueryContext(ctx, `
|
|
SELECT id, name, description, created_at, updated_at
|
|
FROM teams
|
|
ORDER BY created_at DESC
|
|
`)
|
|
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to query teams: %w", err)
|
|
}
|
|
defer rows.Close()
|
|
|
|
var teams []*domain.Team
|
|
for rows.Next() {
|
|
var team domain.Team
|
|
if err := rows.Scan(&team.ID, &team.Name, &team.Description,
|
|
&team.CreatedAt, &team.UpdatedAt); err != nil {
|
|
return nil, fmt.Errorf("failed to scan team: %w", err)
|
|
}
|
|
teams = append(teams, &team)
|
|
}
|
|
|
|
if err := rows.Err(); err != nil {
|
|
return nil, fmt.Errorf("error iterating team rows: %w", err)
|
|
}
|
|
|
|
return teams, nil
|
|
}
|
|
|
|
// ListPaginated returns a slice of teams bounded by limit/offset plus the
|
|
// total count. SCALE-002 closure (Sprint 2, 2026-05-16).
|
|
func (r *TeamRepository) ListPaginated(ctx context.Context, limit, offset int) ([]*domain.Team, int64, error) {
|
|
if limit <= 0 {
|
|
limit = 50
|
|
}
|
|
if offset < 0 {
|
|
offset = 0
|
|
}
|
|
var total int64
|
|
if err := r.db.QueryRowContext(ctx, `SELECT COUNT(*) FROM teams`).Scan(&total); err != nil {
|
|
return nil, 0, fmt.Errorf("failed to count teams: %w", err)
|
|
}
|
|
rows, err := r.db.QueryContext(ctx, `
|
|
SELECT id, name, description, created_at, updated_at
|
|
FROM teams
|
|
ORDER BY created_at DESC
|
|
LIMIT $1 OFFSET $2
|
|
`, limit, offset)
|
|
if err != nil {
|
|
return nil, 0, fmt.Errorf("failed to query teams: %w", err)
|
|
}
|
|
defer rows.Close()
|
|
var teams []*domain.Team
|
|
for rows.Next() {
|
|
var team domain.Team
|
|
if err := rows.Scan(&team.ID, &team.Name, &team.Description,
|
|
&team.CreatedAt, &team.UpdatedAt); err != nil {
|
|
return nil, 0, fmt.Errorf("failed to scan team: %w", err)
|
|
}
|
|
teams = append(teams, &team)
|
|
}
|
|
if err := rows.Err(); err != nil {
|
|
return nil, 0, fmt.Errorf("error iterating team rows: %w", err)
|
|
}
|
|
return teams, total, nil
|
|
}
|
|
|
|
// Get retrieves a team by ID
|
|
func (r *TeamRepository) Get(ctx context.Context, id string) (*domain.Team, error) {
|
|
var team domain.Team
|
|
err := r.db.QueryRowContext(ctx, `
|
|
SELECT id, name, description, created_at, updated_at
|
|
FROM teams
|
|
WHERE id = $1
|
|
`, id).Scan(&team.ID, &team.Name, &team.Description,
|
|
&team.CreatedAt, &team.UpdatedAt)
|
|
|
|
if err != nil {
|
|
if err == sql.ErrNoRows {
|
|
return nil, fmt.Errorf("team not found: %w", repository.ErrNotFound)
|
|
}
|
|
return nil, fmt.Errorf("failed to query team: %w", err)
|
|
}
|
|
|
|
return &team, nil
|
|
}
|
|
|
|
// Create stores a new team
|
|
func (r *TeamRepository) Create(ctx context.Context, team *domain.Team) error {
|
|
if team.ID == "" {
|
|
team.ID = uuid.New().String()
|
|
}
|
|
|
|
err := r.db.QueryRowContext(ctx, `
|
|
INSERT INTO teams (id, name, description, created_at, updated_at)
|
|
VALUES ($1, $2, $3, $4, $5)
|
|
RETURNING id
|
|
`, team.ID, team.Name, team.Description, team.CreatedAt, team.UpdatedAt).Scan(&team.ID)
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create team: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Update modifies an existing team
|
|
func (r *TeamRepository) Update(ctx context.Context, team *domain.Team) error {
|
|
result, err := r.db.ExecContext(ctx, `
|
|
UPDATE teams SET
|
|
name = $1,
|
|
description = $2,
|
|
updated_at = $3
|
|
WHERE id = $4
|
|
`, team.Name, team.Description, team.UpdatedAt, team.ID)
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("failed to update team: %w", err)
|
|
}
|
|
|
|
rows, err := result.RowsAffected()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get rows affected: %w", err)
|
|
}
|
|
|
|
if rows == 0 {
|
|
return fmt.Errorf("team not found: %w", repository.ErrNotFound)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Delete removes a team
|
|
func (r *TeamRepository) Delete(ctx context.Context, id string) error {
|
|
result, err := r.db.ExecContext(ctx, "DELETE FROM teams WHERE id = $1", id)
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("failed to delete team: %w", err)
|
|
}
|
|
|
|
rows, err := result.RowsAffected()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get rows affected: %w", err)
|
|
}
|
|
|
|
if rows == 0 {
|
|
return fmt.Errorf("team not found: %w", repository.ErrNotFound)
|
|
}
|
|
|
|
return nil
|
|
}
|