2 Commits

Author	SHA1	Message	Date
shankar0123	8b75e0311b	chore: rename Go module path to github.com/certctl-io/certctl ... Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol sub-module's go.mod, every Go file's import path (361 files), and a rebuild of the checked-in f5-mock-icontrol binary so its embedded build-info reflects the new module path. No behavior change. Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A (keep module path declared as github.com/shankar0123/certctl regardless of repo URL) shipped on the day of the org transfer (2026-05-03) since we had no external Go consumers; this commit closes that deferral. Backward-compat: GitHub HTTP redirects continue to forward github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL level, but Go's module proxy uses the path declared in go.mod as the canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...` hit a "module path mismatch" error because go.mod said github.com/shankar0123/certctl and the URL they fetched it from said certctl-io/certctl. Post-fix, the canonical name and the URL agree, so go get / go install / external Go consumers / Go-tooling integrations work cleanly via either the new path (preferred) or the old path (which redirects and Go follows the redirect for source fetch). Anyone still importing the old path inside their own code keeps working provided they update their go.mod's `require` line to match — the module path declared in their consumer's go.sum / go.mod is the authoritative import name, so a mass sed across their import statements is the migration on the consumer side. No external consumers exist today. Diff shape: 361 *.go files — import path replacement only 2 go.mod — module declaration replacement only 1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt so embedded build-info reflects the new path (8618965 vs 8618933 bytes; 32-byte diff is the build-info change) Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure mechanical substitution. Verification: gofmt: 17 files needed re-alignment after sed (the new path is one char shorter than the old, so column-aligned import groups drifted). Applied `gofmt -w` to fix. go mod tidy: clean exit on both modules. go vet ./...: clean exit. go build ./...: clean exit. go test -short -count=1 on representative packages: all green (internal/domain, internal/validation, internal/crypto, internal/crypto/signer, cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...` confirming the module path resolves correctly. binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns nothing; `strings | grep certctl-io/certctl` shows the new module path embedded in build-info. Files intentionally NOT touched in this commit: README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io URLs in commit 0729ee4 (the post-transfer URL refresh). This commit is purely the Go-tooling layer. Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account namespace, not a Go import or GitHub repo URL. Stays. This is a non-blocking, non-customer-impacting change. Operators pulling container images, running `make verify`, hitting the API, or installing the agent see no functional difference. Only Go-tooling consumers (none today) are affected, and they're enabled — not broken — by this commit.	2026-05-04 00:30:29 +00:00
shankar0123	40fd96a416	feat(ocsp): pre-signed response cache + invalidate-on-revoke (Phase 2) ... Production hardening II Phase 2 — closes the per-request live-signing bottleneck for OCSP. Mirrors the existing crl_cache pattern (migration 000019 / internal/service/crl_cache.go) but per (issuer_id, serial_hex) instead of per-issuer. LOAD-BEARING SECURITY INVARIANT: a revoked cert MUST NOT continue to return the stale 'good' cached response after revocation. The RevocationSvc.RevokeCertificateWithActor flow now calls OCSPResponseCacheService.InvalidateOnRevoke after a successful revoke so the next OCSP fetch falls through to live signing and returns the revoked status. Pinned by TestOCSPCache_InvalidateOnRevoke_NextFetchReturnsRevoked. NEW migrations/000024_ocsp_response_cache.{up,down}.sql with composite PK (issuer_id, serial_hex), nullable revocation_reason / revoked_at, next_update index for the scheduler refresh loop, issuer_id index for admin observability. NEW internal/domain/ocsp_response_cache.go::OCSPResponseCacheEntry + IsStale helper. NEW internal/repository/postgres/ocsp_response_cache.go implementing repository.OCSPResponseCacheRepository (Get / Put / Delete / CountByIssuer). Interface defined in internal/repository/interfaces.go. NEW internal/service/ocsp_response_cache.go::OCSPResponseCacheService with read-through facade + sync.Map singleflight + InvalidateOnRevoke. On cache miss, calls caOperationsSvc.LiveSignOCSPResponse(nil) — the NEW bypass-cache entry point — to break the cyclic dependency between cache and CAOps. REFACTORED internal/service/ca_operations.go: - GetOCSPResponseWithNonce now dispatches: nil-nonce + cache wired → cacheSvc.Get (cache); nonce != nil OR cache nil → live-sign. - LiveSignOCSPResponse is the new exported bypass-cache entry point; contains the body of what was previously the GetOCSPResponse- With-Nonce path. - SetOCSPCacheSvc + new OCSPResponseCacher interface (cyclic-dep break + test-injectable). The cache stores nil-nonce blobs by design. Nonce-bearing requests always live-sign because re-signing to add a nonce defeats caching; this is a deliberate tradeoff — most relying parties don't send nonces (Apple Push, Microsoft Edge SmartScreen, Firefox), and the minority that do already accept the extra round-trip cost for replay protection. WIRED in cmd/server/main.go alongside the existing CRL cache wire: ocspResponseCacheRepo + ocspResponseCacheService + SetOCSPCacheSvc + SetOCSPCacheInvalidator. Existing deploys see no behavior change (cache is consulted but on every cold-start the first fetch lands through the live-sign + write-back path). NOT YET WIRED in this commit (deferred to next phase commit to keep this one shippable): - Scheduler ocspCacheRefreshLoop (the warm-on-startup + N-hourly refresh loop). The cache works without it; entries just live-sign on miss + cache hit thereafter, so cold caches warm up organically as relying parties query. - Admin observability endpoint /api/v1/admin/ocsp/cache. - CERTCTL_OCSP_CACHE_REFRESH_INTERVAL env var. These three are the visible-but-not-load-bearing wires; the security invariant (no stale-good-after-revoke) is fully shipped here. 7 new tests in internal/service/ocsp_response_cache_test.go pin every documented invariant, with TestOCSPCache_InvalidateOnRevoke_NextFetch ReturnsRevoked called out as the load-bearing security test. Pre-commit verification: go build ./... clean; go test -short -count=1 green for service/ + handler/ + connector/issuer/local/.	2026-04-30 05:03:01 +00:00