mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 18:31:37 +00:00
8b75e0311b
Mechanical sed across the main go.mod's module declaration, the f5-mock-icontrol
sub-module's go.mod, every Go file's import path (361 files), and a rebuild of
the checked-in f5-mock-icontrol binary so its embedded build-info reflects the
new module path. No behavior change.
Choice B from cowork/transfer-certctl-to-org.md, executed 2026-05-04. Choice A
(keep module path declared as github.com/shankar0123/certctl regardless of
repo URL) shipped on the day of the org transfer (2026-05-03) since we had no
external Go consumers; this commit closes that deferral.
Backward-compat: GitHub HTTP redirects continue to forward
github.com/shankar0123/certctl → github.com/certctl-io/certctl at the URL
level, but Go's module proxy uses the path declared in go.mod as the
canonical name. Pre-fix, anyone trying `go get github.com/certctl-io/certctl/...`
hit a "module path mismatch" error because go.mod said
github.com/shankar0123/certctl and the URL they fetched it from said
certctl-io/certctl. Post-fix, the canonical name and the URL agree, so
go get / go install / external Go consumers / Go-tooling integrations
work cleanly via either the new path (preferred) or the old path (which
redirects and Go follows the redirect for source fetch).
Anyone still importing the old path inside their own code keeps working
provided they update their go.mod's `require` line to match — the module
path declared in their consumer's go.sum / go.mod is the authoritative
import name, so a mass sed across their import statements is the migration
on the consumer side. No external consumers exist today.
Diff shape:
361 *.go files — import path replacement only
2 go.mod — module declaration replacement only
1 binary — deploy/test/f5-mock-icontrol/f5-mock-icontrol rebuilt
so embedded build-info reflects the new path (8618965 vs
8618933 bytes; 32-byte diff is the build-info change)
Total: 364 files, 730 insertions / 730 deletions, net-zero size, pure
mechanical substitution.
Verification:
gofmt: 17 files needed re-alignment after sed (the new path is one char
shorter than the old, so column-aligned import groups drifted). Applied
`gofmt -w` to fix.
go mod tidy: clean exit on both modules.
go vet ./...: clean exit.
go build ./...: clean exit.
go test -short -count=1 on representative packages: all green
(internal/domain, internal/validation, internal/crypto, internal/crypto/signer,
cmd/agent). Test output now reads `ok github.com/certctl-io/certctl/...`
confirming the module path resolves correctly.
binary: f5-mock-icontrol rebuilt; `strings | grep shankar0123` returns
nothing; `strings | grep certctl-io/certctl` shows the new module path
embedded in build-info.
Files intentionally NOT touched in this commit:
README.md / CHANGELOG.md / docs/ / etc. — already swept to certctl-io
URLs in commit 0729ee4 (the post-transfer URL refresh). This commit is
purely the Go-tooling layer.
Scarf pixels (`shankar0123.docker.scarf.sh/...`) — Scarf-account
namespace, not a Go import or GitHub repo URL. Stays.
This is a non-blocking, non-customer-impacting change. Operators pulling
container images, running `make verify`, hitting the API, or installing the
agent see no functional difference. Only Go-tooling consumers (none today)
are affected, and they're enabled — not broken — by this commit.
134 lines
4.8 KiB
Go
134 lines
4.8 KiB
Go
package postgres
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/certctl-io/certctl/internal/domain"
|
|
"github.com/certctl-io/certctl/internal/repository"
|
|
)
|
|
|
|
// OCSPResponseCacheRepository implements repository.OCSPResponseCacheRepository
|
|
// using PostgreSQL.
|
|
//
|
|
// Schema: see migrations/000024_ocsp_response_cache.up.sql. The cache
|
|
// stores one row per (issuer_id, serial_hex) — the composite primary
|
|
// key collapses upserts to ON CONFLICT DO UPDATE. The response DER
|
|
// blob lives in BYTEA — typical sizes are a few hundred bytes for a
|
|
// single-cert response (one OCSP response wraps one cert; a request
|
|
// for cert+chain typically issues separate responses).
|
|
//
|
|
// Production hardening II Phase 2.
|
|
type OCSPResponseCacheRepository struct {
|
|
db *sql.DB
|
|
}
|
|
|
|
// NewOCSPResponseCacheRepository creates a new repository.
|
|
func NewOCSPResponseCacheRepository(db *sql.DB) *OCSPResponseCacheRepository {
|
|
return &OCSPResponseCacheRepository{db: db}
|
|
}
|
|
|
|
// Compile-time interface check.
|
|
var _ repository.OCSPResponseCacheRepository = (*OCSPResponseCacheRepository)(nil)
|
|
|
|
// Get returns the cached OCSP response for (issuer, serial). Returns
|
|
// (nil, nil) on miss so the caller can fall through to live signing
|
|
// + a write-back via Put (read-through pattern).
|
|
func (r *OCSPResponseCacheRepository) Get(ctx context.Context, issuerID, serialHex string) (*domain.OCSPResponseCacheEntry, error) {
|
|
const query = `
|
|
SELECT issuer_id, serial_hex, response_der, cert_status,
|
|
COALESCE(revocation_reason, 0), COALESCE(revoked_at, '0001-01-01 00:00:00 UTC'::timestamptz),
|
|
this_update, next_update, generated_at
|
|
FROM ocsp_response_cache
|
|
WHERE issuer_id = $1 AND serial_hex = $2`
|
|
var e domain.OCSPResponseCacheEntry
|
|
err := r.db.QueryRowContext(ctx, query, issuerID, serialHex).Scan(
|
|
&e.IssuerID, &e.SerialHex, &e.ResponseDER, &e.CertStatus,
|
|
&e.RevocationReason, &e.RevokedAt,
|
|
&e.ThisUpdate, &e.NextUpdate, &e.GeneratedAt,
|
|
)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, nil
|
|
}
|
|
if err != nil {
|
|
return nil, fmt.Errorf("OCSPResponseCacheRepository.Get: %w", err)
|
|
}
|
|
return &e, nil
|
|
}
|
|
|
|
// Put upserts the cache row for (issuer, serial). The composite PK
|
|
// collapses repeat-writes to ON CONFLICT DO UPDATE (matches the
|
|
// crl_cache pattern in 000019).
|
|
func (r *OCSPResponseCacheRepository) Put(ctx context.Context, e *domain.OCSPResponseCacheEntry) error {
|
|
const stmt = `
|
|
INSERT INTO ocsp_response_cache (
|
|
issuer_id, serial_hex, response_der, cert_status,
|
|
revocation_reason, revoked_at,
|
|
this_update, next_update, generated_at
|
|
) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9)
|
|
ON CONFLICT (issuer_id, serial_hex) DO UPDATE SET
|
|
response_der = EXCLUDED.response_der,
|
|
cert_status = EXCLUDED.cert_status,
|
|
revocation_reason = EXCLUDED.revocation_reason,
|
|
revoked_at = EXCLUDED.revoked_at,
|
|
this_update = EXCLUDED.this_update,
|
|
next_update = EXCLUDED.next_update,
|
|
generated_at = EXCLUDED.generated_at`
|
|
|
|
// Convert the domain's zero-time RevokedAt to nullable for the SQL
|
|
// row when CertStatus != "revoked" — the cert_status discriminator
|
|
// is the source of truth, but keeping the nullable columns nullable
|
|
// in storage is friendlier for ad-hoc queries.
|
|
var revokedAt interface{}
|
|
var revocationReason interface{}
|
|
if e.CertStatus == "revoked" {
|
|
revokedAt = e.RevokedAt
|
|
revocationReason = e.RevocationReason
|
|
}
|
|
|
|
_, err := r.db.ExecContext(ctx, stmt,
|
|
e.IssuerID, e.SerialHex, e.ResponseDER, e.CertStatus,
|
|
revocationReason, revokedAt,
|
|
e.ThisUpdate, e.NextUpdate, e.GeneratedAt)
|
|
if err != nil {
|
|
return fmt.Errorf("OCSPResponseCacheRepository.Put: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Delete removes a single (issuer, serial) entry. Used by
|
|
// InvalidateOnRevoke when the revocation service wants the cache to
|
|
// re-sign on the next request rather than carry stale data.
|
|
func (r *OCSPResponseCacheRepository) Delete(ctx context.Context, issuerID, serialHex string) error {
|
|
_, err := r.db.ExecContext(ctx,
|
|
`DELETE FROM ocsp_response_cache WHERE issuer_id = $1 AND serial_hex = $2`,
|
|
issuerID, serialHex)
|
|
if err != nil {
|
|
return fmt.Errorf("OCSPResponseCacheRepository.Delete: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// CountByIssuer returns the count of cached entries per issuer.
|
|
// Backs the admin observability endpoint at /api/v1/admin/ocsp/cache.
|
|
func (r *OCSPResponseCacheRepository) CountByIssuer(ctx context.Context) (map[string]int, error) {
|
|
rows, err := r.db.QueryContext(ctx,
|
|
`SELECT issuer_id, COUNT(*) FROM ocsp_response_cache GROUP BY issuer_id`)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("OCSPResponseCacheRepository.CountByIssuer: %w", err)
|
|
}
|
|
defer rows.Close()
|
|
out := map[string]int{}
|
|
for rows.Next() {
|
|
var issuerID string
|
|
var n int
|
|
if err := rows.Scan(&issuerID, &n); err != nil {
|
|
return nil, fmt.Errorf("scan: %w", err)
|
|
}
|
|
out[issuerID] = n
|
|
}
|
|
return out, rows.Err()
|
|
}
|