mirror of
https://github.com/shankar0123/certctl.git
synced 2026-06-07 22:11:38 +00:00
Bundle L follow-up: fix CI staticcheck QF1008 in jwe_failure_test.go
CI on the Bundle L merge (7b79234) failed at golangci-lint:
internal/connector/issuer/stepca/jwe_failure_test.go:105:16:
QF1008: could remove embedded field 'PublicKey' from selector
internal/connector/issuer/stepca/jwe_failure_test.go:106:16: same
internal/connector/issuer/stepca/jwe_failure_test.go:241:9: same
ecdsa.PrivateKey embeds PublicKey, so 'key.PublicKey.X' is
redundantly traversing the embedded field. The shorter 'key.X'
compiles to the same access via the embedded promotion.
Verified clean via 'staticcheck -checks all' (only pre-existing
ST1000 'no package comment' hits remain, predating this bundle).
Tests still PASS at 90.4% coverage; semantics unchanged.
This commit is contained in:
@@ -102,8 +102,8 @@ func aesKeyWrap(t *testing.T, kek, plaintext []byte) []byte {
|
||||
func buildJWE(t *testing.T, password string, key *ecdsa.PrivateKey, kid string) []byte {
|
||||
t.Helper()
|
||||
// 1. Build the JWK and serialize to JSON (this is the "plaintext" of the JWE)
|
||||
xBytes := key.PublicKey.X.Bytes()
|
||||
yBytes := key.PublicKey.Y.Bytes()
|
||||
xBytes := key.X.Bytes()
|
||||
yBytes := key.Y.Bytes()
|
||||
dBytes := key.D.Bytes()
|
||||
// Pad to fixed-size for P-256 (32 bytes)
|
||||
pad := func(b []byte, size int) []byte {
|
||||
@@ -238,10 +238,10 @@ func TestDecryptProvisionerKey_RoundTrip(t *testing.T) {
|
||||
if got.D.Cmp(key.D) != 0 {
|
||||
t.Errorf("private scalar D mismatch")
|
||||
}
|
||||
if got.PublicKey.X.Cmp(key.PublicKey.X) != 0 {
|
||||
if got.X.Cmp(key.X) != 0 {
|
||||
t.Errorf("public X mismatch")
|
||||
}
|
||||
if got.PublicKey.Y.Cmp(key.PublicKey.Y) != 0 {
|
||||
if got.Y.Cmp(key.Y) != 0 {
|
||||
t.Errorf("public Y mismatch")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user