gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-07 14:01:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bundle N.A/B-extended CI follow-up #2: 4th QF1002 hit at line 102 in TestDigicert_GetOrderStatus_PendingProcessingDeniedUnknown

Browse Source 
CI flagged one more QF1002 hit at digicert_failure_test.go:102:5
that I missed in the prior fix (only got the three at 32/51/70).
Same fix: 'switch { case r.URL.Path == "/user/me" }' →
'switch r.URL.Path { case "/user/me" }'.

The remaining switches in this file (lines 126, 149) mix
r.URL.Path == "x" with strings.Contains(r.URL.Path, "..."),
which can't be expressed as tagged switches — staticcheck
correctly does not flag those (same shape as the sectigo
switches that pass clean).

Verification: go test -short -count=1 ./internal/connector/issuer/
digicert/... PASS in 0.6s.

Bundle: N.AB-ci-fix-2
This commit is contained in:
shankar0123
2026-04-27 21:52:31 +00:00
parent 710ecca35d
commit 2024bb0f1a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/connector/issuer/digicert/digicert_failure_test.go
+2 -2
View File
@@ -99,8 +99,8 @@ func TestDigicert_GetOrderStatus_PendingProcessingDeniedUnknown(t *testing.T) {
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch {
case r.URL.Path == "/user/me":
switch r.URL.Path {
case "/user/me":
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`{"id":1}`))
default: