gsadmin/certctl
1
0
Fork 0
mirror of https://github.com/shankar0123/certctl.git synced 2026-06-12 09:28:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use context.Context instead of interface{} in VerificationService interface

Browse Source 
The handler's VerificationService interface used interface{} for the ctx
parameter, but the service implementation uses context.Context. This caused
a compile error: *service.VerificationService does not implement
handler.VerificationService.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Shankar
2026-03-27 21:13:48 -04:00
parent 16dcaf4970
commit 1198a70a33
3 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/handler/verification.go
+3 -2
View File
@@ -1,6 +1,7 @@
package handler package handler
import ( import (
"context"
"encoding/json" "encoding/json"
"fmt" "fmt"
"net/http" "net/http"
@@ -13,10 +14,10 @@ import (
// VerificationService defines the service interface for verification operations. // VerificationService defines the service interface for verification operations.
type VerificationService interface { type VerificationService interface {
// RecordVerificationResult records the outcome of TLS endpoint verification. // RecordVerificationResult records the outcome of TLS endpoint verification.
RecordVerificationResult(ctx interface{}, result *domain.VerificationResult) error RecordVerificationResult(ctx context.Context, result *domain.VerificationResult) error
// GetVerificationResult retrieves the verification status for a job. // GetVerificationResult retrieves the verification status for a job.
GetVerificationResult(ctx interface{}, jobID string) (*domain.VerificationResult, error) GetVerificationResult(ctx context.Context, jobID string) (*domain.VerificationResult, error)
} }
// VerificationHandler handles HTTP requests for certificate deployment verification. // VerificationHandler handles HTTP requests for certificate deployment verification.
internal/api/handler/verification_handler_test.go
+3 -2
View File
@@ -2,6 +2,7 @@ package handler
import ( import (
"bytes" "bytes"
"context"
"encoding/json" "encoding/json"
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
@@ -18,7 +19,7 @@ type mockVerificationService struct {
results map[string]*domain.VerificationResult results map[string]*domain.VerificationResult
} }
func (m *mockVerificationService) RecordVerificationResult(ctx interface{}, result *domain.VerificationResult) error { func (m *mockVerificationService) RecordVerificationResult(ctx context.Context, result *domain.VerificationResult) error {
if m.recordErr != nil { if m.recordErr != nil {
return m.recordErr return m.recordErr
} }
@@ -29,7 +30,7 @@ func (m *mockVerificationService) RecordVerificationResult(ctx interface{}, resu
return nil return nil
} }
func (m *mockVerificationService) GetVerificationResult(ctx interface{}, jobID string) (*domain.VerificationResult, error) { func (m *mockVerificationService) GetVerificationResult(ctx context.Context, jobID string) (*domain.VerificationResult, error) {
if m.getErr != nil { if m.getErr != nil {
return nil, m.getErr return nil, m.getErr
} }
internal/integration/lifecycle_test.go
+2 -2
View File
@@ -1214,10 +1214,10 @@ func (m *mockNetworkScanService) TriggerScan(ctx context.Context, targetID strin
// mockVerificationService implements handler.VerificationService for integration tests. // mockVerificationService implements handler.VerificationService for integration tests.
type mockVerificationService struct{} type mockVerificationService struct{}
func (m *mockVerificationService) RecordVerificationResult(ctx interface{}, result *domain.VerificationResult) error { func (m *mockVerificationService) RecordVerificationResult(ctx context.Context, result *domain.VerificationResult) error {
return nil return nil
} }
func (m *mockVerificationService) GetVerificationResult(ctx interface{}, jobID string) (*domain.VerificationResult, error) { func (m *mockVerificationService) GetVerificationResult(ctx context.Context, jobID string) (*domain.VerificationResult, error) {
return nil, fmt.Errorf("not found") return nil, fmt.Errorf("not found")
} }