From 1198a70a3391f3f1a9bd62affe7799c2be777926 Mon Sep 17 00:00:00 2001 From: Shankar Date: Fri, 27 Mar 2026 21:13:48 -0400 Subject: [PATCH] fix: use context.Context instead of interface{} in VerificationService interface The handler's VerificationService interface used interface{} for the ctx parameter, but the service implementation uses context.Context. This caused a compile error: *service.VerificationService does not implement handler.VerificationService. Co-Authored-By: Claude Opus 4.6 --- internal/api/handler/verification.go | 5 +++-- internal/api/handler/verification_handler_test.go | 5 +++-- internal/integration/lifecycle_test.go | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/internal/api/handler/verification.go b/internal/api/handler/verification.go index 1259e09..19127b0 100644 --- a/internal/api/handler/verification.go +++ b/internal/api/handler/verification.go @@ -1,6 +1,7 @@ package handler import ( + "context" "encoding/json" "fmt" "net/http" @@ -13,10 +14,10 @@ import ( // VerificationService defines the service interface for verification operations. type VerificationService interface { // RecordVerificationResult records the outcome of TLS endpoint verification. - RecordVerificationResult(ctx interface{}, result *domain.VerificationResult) error + RecordVerificationResult(ctx context.Context, result *domain.VerificationResult) error // GetVerificationResult retrieves the verification status for a job. - GetVerificationResult(ctx interface{}, jobID string) (*domain.VerificationResult, error) + GetVerificationResult(ctx context.Context, jobID string) (*domain.VerificationResult, error) } // VerificationHandler handles HTTP requests for certificate deployment verification. diff --git a/internal/api/handler/verification_handler_test.go b/internal/api/handler/verification_handler_test.go index 3fd4a97..10659c1 100644 --- a/internal/api/handler/verification_handler_test.go +++ b/internal/api/handler/verification_handler_test.go @@ -2,6 +2,7 @@ package handler import ( "bytes" + "context" "encoding/json" "net/http" "net/http/httptest" @@ -18,7 +19,7 @@ type mockVerificationService struct { results map[string]*domain.VerificationResult } -func (m *mockVerificationService) RecordVerificationResult(ctx interface{}, result *domain.VerificationResult) error { +func (m *mockVerificationService) RecordVerificationResult(ctx context.Context, result *domain.VerificationResult) error { if m.recordErr != nil { return m.recordErr } @@ -29,7 +30,7 @@ func (m *mockVerificationService) RecordVerificationResult(ctx interface{}, resu return nil } -func (m *mockVerificationService) GetVerificationResult(ctx interface{}, jobID string) (*domain.VerificationResult, error) { +func (m *mockVerificationService) GetVerificationResult(ctx context.Context, jobID string) (*domain.VerificationResult, error) { if m.getErr != nil { return nil, m.getErr } diff --git a/internal/integration/lifecycle_test.go b/internal/integration/lifecycle_test.go index 842dd55..2962197 100644 --- a/internal/integration/lifecycle_test.go +++ b/internal/integration/lifecycle_test.go @@ -1214,10 +1214,10 @@ func (m *mockNetworkScanService) TriggerScan(ctx context.Context, targetID strin // mockVerificationService implements handler.VerificationService for integration tests. type mockVerificationService struct{} -func (m *mockVerificationService) RecordVerificationResult(ctx interface{}, result *domain.VerificationResult) error { +func (m *mockVerificationService) RecordVerificationResult(ctx context.Context, result *domain.VerificationResult) error { return nil } -func (m *mockVerificationService) GetVerificationResult(ctx interface{}, jobID string) (*domain.VerificationResult, error) { +func (m *mockVerificationService) GetVerificationResult(ctx context.Context, jobID string) (*domain.VerificationResult, error) { return nil, fmt.Errorf("not found") }