Files
PSProxmoxVE/tests/PSProxmoxVE.Tests/Vms/VmAdvancedOps.Tests.ps1
T
goodolclint-claude[bot] 109dca657a refactor: make the offline Pester suite able to fail (#153) (#205)
Skip-IfMissing skipped a test whenever the cmdlet under test was absent
from the build, including the test asserting it exists. Every cmdlet
compiles into one assembly, so there is no partial-build case for it to
serve; all it did was hide a missing cmdlet. Delete the 37 copies and
every call site, and drop the residual conditional skips in the same
family (CmdExists probes, an attribute-presence skip in SdnCmdlets, a
lifecycle helper skipping on a cmdlet-name collision fixed long ago).

894 It blocks only reflected [Cmdlet] and [Parameter] attributes back at
the compiler: existence, CommandType -eq 'Cmdlet', Parameters.ContainsKey,
IsMandatory reflection, and per-file CmdletsToExport asserts for whichever
names an author remembered. Nothing reflected over the built assembly, so
a new cmdlet missing from the manifest shipped invisible. One data-driven
file replaces them: it diffs CmdletsToExport against the assembly's cmdlet
types in both directions and asserts the conventions reflection can see.

Behavioural tests are untouched: no-session errors, binding rejections,
ShouldProcess and -WhatIf, ConfirmImpact, ValidateSet and ValidateRange
values, parameter types, positions and pipeline binding.

The generated help covered 169 of 194 cmdlets. Regenerated with the repo's
own generate-help.ps1: 25 new markdown stubs, 13 existing docs picking up
parameters added in earlier waves, and a rebuilt MAML.

Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>
2026-09-03 00:54:02 +00:00

216 lines
7.5 KiB
PowerShell

#Requires -Module Pester
<#
.SYNOPSIS
Pester 5 tests for VM advanced operation cmdlets:
Copy-PveVm, Move-PveVm.
All tests are fully offline — no live Proxmox VE target is required.
#>
BeforeAll {
. $PSScriptRoot/../_TestHelper.ps1
}
# ---------------------------------------------------------------------------
# Copy-PveVm
# ---------------------------------------------------------------------------
Describe 'Copy-PveVm' {
Context 'Parameter metadata' {
BeforeAll {
$script:Cmd = Get-Command 'Copy-PveVm'
}
# --- SourceNode ---
It 'SourceNode should be of type String' {
$script:Cmd.Parameters['SourceNode'].ParameterType | Should -Be ([string])
}
# --- VmId ---
It 'VmId should be of type Int32' {
$script:Cmd.Parameters['VmId'].ParameterType | Should -Be ([int])
}
It 'VmId should accept pipeline input by property name' {
$acceptsByPropName = $script:Cmd.Parameters['VmId'].ParameterSets.Values |
Where-Object { $_.ValueFromPipelineByPropertyName }
$acceptsByPropName | Should -Not -BeNullOrEmpty
}
# --- NewVmId (optional) ---
It 'NewVmId should be of nullable Int32 type' {
$script:Cmd.Parameters['NewVmId'].ParameterType |
Should -Be ([System.Nullable[int]])
}
# --- NewName (optional) ---
It 'NewName should be of type String' {
$script:Cmd.Parameters['NewName'].ParameterType | Should -Be ([string])
}
# --- TargetNode (optional) ---
It 'TargetNode should be of type String' {
$script:Cmd.Parameters['TargetNode'].ParameterType | Should -Be ([string])
}
# --- Full (switch, optional) ---
It 'Should have Full switch parameter' {
$script:Cmd.Parameters.ContainsKey('Full') | Should -BeTrue
$script:Cmd.Parameters['Full'].ParameterType |
Should -Be ([System.Management.Automation.SwitchParameter])
}
# --- Storage (optional) ---
It 'Storage should be of type String' {
$script:Cmd.Parameters['Storage'].ParameterType | Should -Be ([string])
}
# --- Wait (switch, optional) ---
It 'Should have Wait switch parameter' {
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
$script:Cmd.Parameters['Wait'].ParameterType |
Should -Be ([System.Management.Automation.SwitchParameter])
}
# --- Session (inherited) ---
}
Context 'ShouldProcess support' {
It 'Should support ShouldProcess (WhatIf parameter exists)' {
$cmd = Get-Command 'Copy-PveVm'
$cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
}
It 'Should support Confirm parameter' {
$cmd = Get-Command 'Copy-PveVm'
$cmd.Parameters.ContainsKey('Confirm') | Should -BeTrue
}
It 'Should not throw with -WhatIf (no session required)' {
{ Copy-PveVm -SourceNode 'pve-node1' -VmId 100 -WhatIf -ErrorAction Stop } |
Should -Not -Throw
}
It 'Should not throw with -WhatIf and optional params' {
{ Copy-PveVm -SourceNode 'pve-node1' -VmId 100 -NewVmId 200 -NewName 'clone-test' -TargetNode 'pve-node2' -Full -WhatIf -ErrorAction Stop } |
Should -Not -Throw
}
}
Context 'Without active session' {
It 'Should throw when no session is active (without -WhatIf)' {
{ Copy-PveVm -SourceNode 'pve-node1' -VmId 100 -ErrorAction Stop } |
Should -Throw '*No active Proxmox VE session*'
}
It 'Should throw PveNotConnectedException type' {
try {
Copy-PveVm -SourceNode 'pve-node1' -VmId 100 -ErrorAction Stop
}
catch {
$_.Exception.GetType().Name | Should -Match 'PveNotConnectedException|CmdletInvocationException'
}
}
}
}
# ---------------------------------------------------------------------------
# Move-PveVm
# ---------------------------------------------------------------------------
Describe 'Move-PveVm' {
Context 'Parameter metadata' {
BeforeAll {
$script:Cmd = Get-Command 'Move-PveVm'
}
# --- Node ---
It 'Node should be of type String' {
$script:Cmd.Parameters['Node'].ParameterType | Should -Be ([string])
}
It 'Node should accept pipeline input by property name' {
$acceptsByPropName = $script:Cmd.Parameters['Node'].ParameterSets.Values |
Where-Object { $_.ValueFromPipelineByPropertyName }
$acceptsByPropName | Should -Not -BeNullOrEmpty
}
# --- VmId ---
It 'VmId should be of type Int32' {
$script:Cmd.Parameters['VmId'].ParameterType | Should -Be ([int])
}
It 'VmId should accept pipeline input by property name' {
$acceptsByPropName = $script:Cmd.Parameters['VmId'].ParameterSets.Values |
Where-Object { $_.ValueFromPipelineByPropertyName }
$acceptsByPropName | Should -Not -BeNullOrEmpty
}
# --- TargetNode ---
It 'TargetNode should be of type String' {
$script:Cmd.Parameters['TargetNode'].ParameterType | Should -Be ([string])
}
# --- Online (switch, optional) ---
It 'Should have Online switch parameter' {
$script:Cmd.Parameters.ContainsKey('Online') | Should -BeTrue
$script:Cmd.Parameters['Online'].ParameterType |
Should -Be ([System.Management.Automation.SwitchParameter])
}
# --- Wait (switch, optional) ---
It 'Should have Wait switch parameter' {
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
$script:Cmd.Parameters['Wait'].ParameterType |
Should -Be ([System.Management.Automation.SwitchParameter])
}
# --- Session (inherited) ---
}
Context 'ShouldProcess support' {
It 'Should support ShouldProcess (WhatIf parameter exists)' {
$cmd = Get-Command 'Move-PveVm'
$cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
}
It 'Should support Confirm parameter' {
$cmd = Get-Command 'Move-PveVm'
$cmd.Parameters.ContainsKey('Confirm') | Should -BeTrue
}
It 'Should not throw with -WhatIf (no session required)' {
{ Move-PveVm -Node 'pve-node1' -VmId 100 -TargetNode 'pve-node2' -WhatIf -ErrorAction Stop } |
Should -Not -Throw
}
It 'Should not throw with -WhatIf and -Online flag' {
{ Move-PveVm -Node 'pve-node1' -VmId 100 -TargetNode 'pve-node2' -Online -WhatIf -ErrorAction Stop } |
Should -Not -Throw
}
}
Context 'Without active session' {
It 'Should throw when no session is active (without -WhatIf)' {
{ Move-PveVm -Node 'pve-node1' -VmId 100 -TargetNode 'pve-node2' -ErrorAction Stop } |
Should -Throw '*No active Proxmox VE session*'
}
It 'Should throw PveNotConnectedException type' {
try {
Move-PveVm -Node 'pve-node1' -VmId 100 -TargetNode 'pve-node2' -ErrorAction Stop
}
catch {
$_.Exception.GetType().Name | Should -Match 'PveNotConnectedException|CmdletInvocationException'
}
}
}
}