Files
goodolclint-claude[bot] 109dca657a refactor: make the offline Pester suite able to fail (#153) (#205)
Skip-IfMissing skipped a test whenever the cmdlet under test was absent
from the build, including the test asserting it exists. Every cmdlet
compiles into one assembly, so there is no partial-build case for it to
serve; all it did was hide a missing cmdlet. Delete the 37 copies and
every call site, and drop the residual conditional skips in the same
family (CmdExists probes, an attribute-presence skip in SdnCmdlets, a
lifecycle helper skipping on a cmdlet-name collision fixed long ago).

894 It blocks only reflected [Cmdlet] and [Parameter] attributes back at
the compiler: existence, CommandType -eq 'Cmdlet', Parameters.ContainsKey,
IsMandatory reflection, and per-file CmdletsToExport asserts for whichever
names an author remembered. Nothing reflected over the built assembly, so
a new cmdlet missing from the manifest shipped invisible. One data-driven
file replaces them: it diffs CmdletsToExport against the assembly's cmdlet
types in both directions and asserts the conventions reflection can see.

Behavioural tests are untouched: no-session errors, binding rejections,
ShouldProcess and -WhatIf, ConfirmImpact, ValidateSet and ValidateRange
values, parameter types, positions and pipeline binding.

The generated help covered 169 of 194 cmdlets. Regenerated with the repo's
own generate-help.ps1: 25 new markdown stubs, 13 existing docs picking up
parameters added in earlier waves, and a rebuilt MAML.

Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>
2026-09-03 00:54:02 +00:00

99 lines
3.6 KiB
PowerShell

#Requires -Module Pester
<#
.SYNOPSIS
Pester 5 tests for Remove-PveVm.
All tests are fully offline — no live Proxmox VE target is required.
#>
BeforeAll {
. $PSScriptRoot/../_TestHelper.ps1
}
Describe 'Remove-PveVm' {
Context 'ShouldProcess / ConfirmImpact' {
BeforeAll {
$script:Cmd = Get-Command 'Remove-PveVm'
}
It 'Should support ShouldProcess (WhatIf present)' {
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
}
It 'Should support ShouldProcess (Confirm present)' {
$script:Cmd.Parameters.ContainsKey('Confirm') | Should -BeTrue
}
It 'Should declare ConfirmImpact High (verified via CmdletAttribute)' {
# Retrieve the CmdletAttribute from the underlying type to confirm ConfirmImpact.
$cmdletType = $script:Cmd.ImplementingType
$attr = $cmdletType.GetCustomAttributes(
[System.Management.Automation.CmdletAttribute], $false) |
Select-Object -First 1
$attr.ConfirmImpact | Should -Be ([System.Management.Automation.ConfirmImpact]::High)
}
It 'Should accept -WhatIf without throwing even when no session exists' {
{ Remove-PveVm -Node 'pve-node1' -VmId 100 -WhatIf -ErrorAction Stop } |
Should -Not -Throw
}
}
Context 'Required parameters' {
It 'VmId should be Mandatory' {
$vmidParam = (Get-Command 'Remove-PveVm').Parameters['VmId']
$isMandatory = $vmidParam.ParameterSets.Values | Where-Object { $_.IsMandatory }
$isMandatory | Should -Not -BeNullOrEmpty
}
}
Context 'Optional switch parameters' {
BeforeAll {
$script:Cmd = Get-Command 'Remove-PveVm'
}
It 'Should have Purge switch parameter' {
$script:Cmd.Parameters.ContainsKey('Purge') | Should -BeTrue
$script:Cmd.Parameters['Purge'].ParameterType |
Should -Be ([System.Management.Automation.SwitchParameter])
}
It 'Should have Force switch parameter' {
$script:Cmd.Parameters.ContainsKey('Force') | Should -BeTrue
$script:Cmd.Parameters['Force'].ParameterType |
Should -Be ([System.Management.Automation.SwitchParameter])
}
It 'Should have Wait switch parameter' {
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
$script:Cmd.Parameters['Wait'].ParameterType |
Should -Be ([System.Management.Automation.SwitchParameter])
}
}
Context 'Pipeline input support' {
BeforeAll {
$script:Cmd = Get-Command 'Remove-PveVm'
}
It 'Node should accept pipeline input by property name' {
$node = $script:Cmd.Parameters['Node']
$acceptsByPropName = $node.ParameterSets.Values |
Where-Object { $_.ValueFromPipelineByPropertyName }
$acceptsByPropName | Should -Not -BeNullOrEmpty
}
It 'VmId should accept pipeline input by property name' {
$vmid = $script:Cmd.Parameters['VmId']
$acceptsByPropName = $vmid.ParameterSets.Values |
Where-Object { $_.ValueFromPipelineByPropertyName }
$acceptsByPropName | Should -Not -BeNullOrEmpty
}
}
Context 'Without active session' {
It 'Should throw when no session is active (without -WhatIf)' {
{ Remove-PveVm -Node 'pve-node1' -VmId 100 -Confirm:$false -ErrorAction Stop } | Should -Throw '*No active Proxmox VE session*'
}
}
}