Files
Clint Branham d187b0de52 fix: resolve net48-only nullable warnings (CS8601, CS8602, CS8604)
- CS8601: Add null-forgiving operator on guarded dictionary assignments
  in cmdlets where IsNullOrEmpty check precedes the assignment
- CS8602: Add Assert.NotNull after JObject["data"] in xUnit model tests
  (JToken indexer returns nullable on net48)
- CS8604: Add null-forgiving on guarded arguments in NodeService,
  WaitPveTaskCmdlet, GetPveTemplateCmdlet, and auth test parameters

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 08:32:57 -05:00

111 lines
3.7 KiB
C#

using Xunit;
using Newtonsoft.Json.Linq;
using PSProxmoxVE.Core.Models.Vms;
namespace PSProxmoxVE.Core.Tests.Models
{
public class TaskModelTests
{
[Fact]
public void PveTask_Deserialize_Completed_HasCorrectUpid()
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("UPID:pve1:00001234:00ABCDEF:65F00000:qmstart:100:root@pam:", task.Upid);
}
[Fact]
public void PveTask_Deserialize_Completed_StatusIsStopped()
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("stopped", task.Status);
}
[Fact]
public void PveTask_Deserialize_Completed_ExitStatusIsOk()
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("OK", task.ExitStatus);
}
[Fact]
public void PveTask_Deserialize_Completed_IsSuccessful_IsTrue()
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.True(task.IsSuccessful);
}
[Fact]
public void PveTask_Deserialize_Running_HasCorrectUpid()
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("UPID:pve1:00001234:00ABCDEF:65F00000:qmstart:100:root@pam:", task.Upid);
}
[Fact]
public void PveTask_Deserialize_Running_StatusIsRunning()
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("running", task.Status);
}
[Fact]
public void PveTask_Deserialize_Running_ExitStatus_IsNull()
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Null(task.ExitStatus);
}
[Fact]
public void PveTask_Deserialize_Running_IsSuccessful_IsFalse()
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.False(task.IsSuccessful);
}
[Fact]
public void PveTask_IsSuccessful_RequiresBothStoppedAndOk()
{
// Stopped but with an error exit status should not be successful
var task = new PveTask
{
Upid = "UPID:pve1:000:000:000:qmstop:100:root@pam:",
Status = "stopped",
ExitStatus = "Error: some error occurred"
};
Assert.False(task.IsSuccessful);
}
}
}