gsadmin/PSProxmoxVE
1
0
Fork 0
mirror of https://github.com/GoodOlClint/PSProxmoxVE.git synced 2026-09-03 02:38:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct New-PveVm disk-options warning text

Browse Source 
Now that -ScsiHardware is part of HasDiskOptions(), the old "options were
ignored" wording was misleading: scsihw is written unconditionally as a
VM-level key and is never ignored. Reword to state that the per-disk
options are the ones dropped, and that -ScsiHardware (if specified) is
still applied. Accurate whether or not -ScsiHardware was passed.

Addresses PR #67 follow-up review.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Clint Branham
2026-05-22 14:25:21 -05:00
parent 80b70cdaf6
commit e959fbb9b8
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PSProxmoxVE/Cmdlets/Vms/NewPveVmCmdlet.cs
+4 -3
View File
@@ -242,9 +242,10 @@ namespace PSProxmoxVE.Cmdlets.Vms
if (!string.IsNullOrEmpty(DiskStorage) && diskSizeGib != null) if (!string.IsNullOrEmpty(DiskStorage) && diskSizeGib != null)
config[$"{diskBus}0"] = BuildDiskSpec(DiskStorage!, diskSizeGib); config[$"{diskBus}0"] = BuildDiskSpec(DiskStorage!, diskSizeGib);
else if (HasDiskOptions()) else if (HasDiskOptions())
WriteWarning("Disk IO options (-DiskBus/-DiskIoThread/-DiskAio/-DiskSsd/-DiskDiscard/-DiskCache) " WriteWarning("Disk options were specified but no disk is being created "
+ "were specified but no disk is being created (-DiskStorage and -DiskSize are both required). " + "(-DiskStorage and -DiskSize are both required). The per-disk options "
+ "The options were ignored."); + "(-DiskBus/-DiskIoThread/-DiskAio/-DiskSsd/-DiskDiscard/-DiskCache) were ignored; "
+ "-ScsiHardware, if specified, is still applied as the VM-level scsihw setting.");
if (!string.IsNullOrEmpty(Bridge)) if (!string.IsNullOrEmpty(Bridge))
{ {