From e959fbb9b82c3d24d964e55c4fb87bc99f03f043 Mon Sep 17 00:00:00 2001 From: Clint Branham Date: Fri, 22 May 2026 14:25:21 -0500 Subject: [PATCH] fix: correct New-PveVm disk-options warning text Now that -ScsiHardware is part of HasDiskOptions(), the old "options were ignored" wording was misleading: scsihw is written unconditionally as a VM-level key and is never ignored. Reword to state that the per-disk options are the ones dropped, and that -ScsiHardware (if specified) is still applied. Accurate whether or not -ScsiHardware was passed. Addresses PR #67 follow-up review. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/PSProxmoxVE/Cmdlets/Vms/NewPveVmCmdlet.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/PSProxmoxVE/Cmdlets/Vms/NewPveVmCmdlet.cs b/src/PSProxmoxVE/Cmdlets/Vms/NewPveVmCmdlet.cs index af0d5b3..ae48844 100644 --- a/src/PSProxmoxVE/Cmdlets/Vms/NewPveVmCmdlet.cs +++ b/src/PSProxmoxVE/Cmdlets/Vms/NewPveVmCmdlet.cs @@ -242,9 +242,10 @@ namespace PSProxmoxVE.Cmdlets.Vms if (!string.IsNullOrEmpty(DiskStorage) && diskSizeGib != null) config[$"{diskBus}0"] = BuildDiskSpec(DiskStorage!, diskSizeGib); else if (HasDiskOptions()) - WriteWarning("Disk IO options (-DiskBus/-DiskIoThread/-DiskAio/-DiskSsd/-DiskDiscard/-DiskCache) " - + "were specified but no disk is being created (-DiskStorage and -DiskSize are both required). " - + "The options were ignored."); + WriteWarning("Disk options were specified but no disk is being created " + + "(-DiskStorage and -DiskSize are both required). The per-disk options " + + "(-DiskBus/-DiskIoThread/-DiskAio/-DiskSsd/-DiskDiscard/-DiskCache) were ignored; " + + "-ScsiHardware, if specified, is still applied as the VM-level scsihw setting."); if (!string.IsNullOrEmpty(Bridge)) {