mirror of
https://github.com/Shik3i/KoalaSync.git
synced 2026-07-26 12:08:15 +00:00
fix(extension): drop unused roomPassword field from GET_STATUS response
Defense-in-depth: the field was always undefined in practice (no code path ever sets currentRoom.password — verified across the full git history), and no GET_STATUS caller in the codebase reads it. But if a future change ever populated currentRoom.password, any caller of GET_STATUS would receive it in cleartext. Threat surface today is narrow (externally_connectable is not set, no content script sends GET_STATUS, only the popup uses it), but the field has no reason to exist — removing it eliminates the future-leak vector for free. Backward compatible: no caller reads this field, so removing it is a no-op for every existing code path.
This commit is contained in:
@@ -1744,7 +1744,6 @@ async function handleAsyncMessage(message, sender, sendResponse) {
|
||||
serverUrl: currentServerUrl,
|
||||
version: chrome.runtime.getManifest().version,
|
||||
protocolVersion: PROTOCOL_VERSION,
|
||||
roomPassword: currentRoom ? currentRoom.password : null,
|
||||
ping: currentPingMs,
|
||||
controlMode,
|
||||
hostPeerId,
|
||||
|
||||
Reference in New Issue
Block a user