gsadmin/KoalaSync
1
0
Fork 0
mirror of https://github.com/Shik3i/KoalaSync.git synced 2026-08-17 06:47:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: replace Ko-Fi with Support links, drop uninstall token

Browse Source 
Switch the Ko-Fi support links to https://support.koalastuff.net across the
README badge, the extension footer (popup.html/template.html, label
"Support KoalaSync") and remove the now-unused KOFI_URL constant. Stop
generating/sending the anonymous uninstall token: initUninstallURL() now
registers the feedback URL without the `t` parameter or storage write.
CHANGELOG updated to match.

Also guard the client CMD_ACK path: only ACK a command sender that is still
a known peer in the room, so we don't emit ACKs to peers that already left
(which the server now drops as absent-peer ACKs anyway).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Timo
2026-06-19 16:26:54 +02:00
parent 027d2dbde5
commit 23d43741ce
4 changed files with 12 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extension/background.js
+9 -20
View File
@@ -19,24 +19,8 @@ async function initUninstallURL() {
if (UNINSTALL_URL && UNINSTALL_URL.trim() !== '') {
try {
if (typeof chrome === 'undefined' || !chrome.storage || !chrome.storage.local) {
console.warn("Storage API not available, skipping uninstall URL token generation");
return;
}
const data = await chrome.storage.local.get("koalaByeToken");
let token = data?.koalaByeToken;
if (!token) {
token = (typeof self.crypto !== 'undefined' && typeof self.crypto.randomUUID === 'function')
? self.crypto.randomUUID()
: Math.random().toString(36).substring(2, 15) + Math.random().toString(36).substring(2, 15);
await chrome.storage.local.set({ koalaByeToken: token });
}
const url = new URL(UNINSTALL_URL);
url.searchParams.set("browser", BROWSER_TYPE);
url.searchParams.set("t", token);
const runtimeAPI = typeof browser !== 'undefined' ? browser.runtime : chrome.runtime;
if (runtimeAPI && runtimeAPI.setUninstallURL) {
@@ -1751,11 +1735,16 @@ async function handleAsyncMessage(message, sender, sendResponse) {
sendResponse({ status: 'ok' });
} else if (message.type === 'CMD_ACK') {
const commandSenderId = message.commandSenderId;
if (commandSenderId && commandSenderId !== peerId) {
emit(EVENTS.EVENT_ACK, {
senderId: peerId,
// Only ACK if the command sender is still a known peer in our room.
// If we've already seen their PEER_STATUS 'left', skip the ACK — it would
// only be dropped server-side as an absent-peer ACK anyway.
const senderStillPresent = currentRoom && Array.isArray(currentRoom.peers) &&
currentRoom.peers.some(p => (typeof p === 'object' ? p.peerId : p) === commandSenderId);
if (commandSenderId && commandSenderId !== peerId && senderStillPresent) {
emit(EVENTS.EVENT_ACK, {
senderId: peerId,
targetId: commandSenderId,
actionTimestamp: message.actionTimestamp
actionTimestamp: message.actionTimestamp
});
}
sendResponse({ status: 'ok' });